From nobody Mon Feb 9 17:06:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) client-ip=209.85.128.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358180; cv=none; d=zohomail.com; s=zohoarc; b=gy49NsNrJWCUr4lSPYS8gCsg5kc4LTl37BNOcrkL6TLIjYzcHLQWjPt4yaTOgI3xAty8NNqcGSWKnqN4xXQ6l6c6ELSzZ48Kgz+vQF30183JDQQ/gOiruYu6aL3UdPyUhawqv5iVBzXCjkDbWVhJgGIeK5+a311mGVqi8F4lou8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358180; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qjpKL26xEX2wus4BrB9hPdKCF0pBgl5q4uFapoXPmT4=; b=Zkpg+VrJnV3jVO9pGnAu0rOEikYrVAX7D8i+TQHu1lQaBuiOKgRYaaSieCYHExGWrsxuAf06sh3v8JtSk+0gr7iiDXnt5iit+8lCIzcYaGYrYJ8nE+O7Vv3BzuLyk31Tu0qMJk+UKL3Y1Y3V4vuA+q1749FT2Rqtl7mM95xaknw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.zohomail.com with SMTPS id 1635358180626525.1093540249537; Wed, 27 Oct 2021 11:09:40 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id 82-20020a1c0055000000b0032ccc3ad5c1so5081162wma.2 for ; Wed, 27 Oct 2021 11:09:40 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id f1sm600161wrc.74.2021.10.27.11.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qjpKL26xEX2wus4BrB9hPdKCF0pBgl5q4uFapoXPmT4=; b=hRPT91B4WHhCN+zATmRW1DER+ovs7zLkwNYMbg++UsFslqY/8a/zIIrPv/iZ4HGfzd bKd+ePmmbTdGpJnWVzuBFisT9dLTg9YWJNqlFdhoLJC4A2s5GYgR6HwWgze3DfmXHpYu Qqcw92Xl1/vdN2d8ITXrZiyq479s8ELaQK6g490RW+oZjmM2TtzT5X6avplm86zrB16F 7nWTHsir3XxlKDdRgIaONZaA49cWK04dyg9wW3vBqgY8viQvyaGOSXNYTd1uMGiCf8aV zopQzmtqXQ+T1kydU0TJmX3Sjvg2PR9AU0E3DcA/iPKD9c2+zqMBHa2iUmTOPYAfkFKH rSLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qjpKL26xEX2wus4BrB9hPdKCF0pBgl5q4uFapoXPmT4=; b=Jqw0M644cWlEZSAzkPbVXbau4q+Ka0+skvGgJANlUTa8XvpOXl8gxBcEjarY4Zha/4 D30rjVg8Co+3n/S/O22YrYH+PjfhL4/gHQYHdbqJREVyBzWCJUYB0aZSxoq+MFXS+5vY 101ebwkxSiIi+92a5ugGab6B2sp0fSq4MK3WT/l2ntW10gouduLnzfpg6INkc6kpTDfS VM8Z+v4G4BbhFPaj7nok3IhsUIGgA2iIoiqFB2kfIko9YexGlcxVc/kD266ynbgJ0/Nu OPtYTtdd9lfXZpvtBO3lGucgY0NMdK3KurS4hziZgBtANp4/ZpVMGU0D/z2/vo8AMl/k VFGA== X-Gm-Message-State: AOAM5308gZAQs+M6Ij87Yutz6gkctevoF0jcn9Z9G9rSFgZuA1dAojIL xnK/dakyiAZVa6W7VsLN5ek= X-Google-Smtp-Source: ABdhPJxXN1vc0VIEWgUMcWL5Ftv7um1Q0YOJtZ9Q/2gc6Pt8u987f535Y6DoOd+aoqc1fVGyVm/8aw== X-Received: by 2002:a7b:cb82:: with SMTP id m2mr7218489wmi.11.1635358178897; Wed, 27 Oct 2021 11:09:38 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH v2 27/32] target/mips: Convert MSA MOVE.V opcode to decodetree Date: Wed, 27 Oct 2021 20:07:25 +0200 Message-Id: <20211027180730.1551932-28-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358182719100001 Convert the MOVE.V opcode (Vector Move) to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa.decode | 7 ++++++- target/mips/tcg/msa_translate.c | 19 ++++++++++++++----- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 7c309526444..cfa5fa5d688 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -21,6 +21,7 @@ &msa_ldst df wd ws sa &msa_bit df wd ws m &msa_elm_df df wd ws n +&msa_elm wd ws =20 %dfn_df 16:6 !function=3Dmsa_elm_df %dfn_n 16:6 !function=3Dmsa_elm_n @@ -32,6 +33,7 @@ @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz @elm_df ...... .... ...... ws:5 wd:5 ...... &msa_elm_df df= =3D%dfn_df n=3D%dfn_n +@elm ...... .......... ws:5 wd:5 ...... &msa_elm @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @@ -165,7 +167,10 @@ BNZ 010001 111 .. ..... ..............= .. @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df - COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + { + MOVE_V 011110 0010111110 ..... ..... 011001 @elm + COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + } COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df INSERT 011110 0100 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 2ed637f16da..0655b61801b 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -36,7 +36,6 @@ enum { /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, }; =20 static const char msaregnames[][6] =3D { @@ -510,6 +509,19 @@ TRANS_DF_iii_b(HADD_U, trans_msa_3r, gen_helper_ms= a_hadd_u); TRANS_DF_iii_b(HSUB_S, trans_msa_3r, gen_helper_msa_hsub_s); TRANS_DF_iii_b(HSUB_U, trans_msa_3r, gen_helper_msa_hsub_u); =20 +static bool trans_MOVE_V(DisasContext *ctx, arg_msa_elm *a) +{ + if (!check_msa_enabled(ctx)) { + return true; + } + + gen_helper_msa_move_v(cpu_env, + tcg_constant_i32(a->wd), + tcg_constant_i32(a->ws)); + + return true; +} + static void gen_msa_elm_3e(DisasContext *ctx) { #define MASK_MSA_ELM_DF3E(op) (MASK_MSA_MINOR(op) | (op & (0x3FF << 16))) @@ -528,9 +540,6 @@ static void gen_msa_elm_3e(DisasContext *ctx) gen_helper_msa_cfcmsa(telm, cpu_env, tsr); gen_store_gpr(telm, dest); break; - case OPC_MOVE_V: - gen_helper_msa_move_v(cpu_env, tdt, tsr); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -627,7 +636,7 @@ static void gen_msa_elm(DisasContext *ctx) uint8_t dfn =3D (ctx->opcode >> 16) & 0x3f; =20 if (dfn =3D=3D 0x3E) { - /* CTCMSA, CFCMSA, MOVE.V */ + /* CTCMSA, CFCMSA */ gen_msa_elm_3e(ctx); return; } else { --=20 2.31.1