From nobody Mon Feb 9 17:06:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) client-ip=209.85.128.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358171; cv=none; d=zohomail.com; s=zohoarc; b=BjHmKZphtwwmkM319H2ElMjXwnk5gOUv+K82pDrUPDGvu7hWQ0DIkHHRqIUDRTflbCMc8LOLvFxNsmYFfL+cFVusfGPqxYzPLZfEz5LGEShSNgODUToCTbBTuoiv3ti/5UpWpB8BeW/7Wqp93m+rMeEStIToNM4vwS7TU3xV6Xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358171; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fUU6kj3/MNVjhNoRDca0LWMfLXwMBccF/5RZxkxk4kk=; b=kREKNIwJ0OC/Ylzp9zK0O6aW1mpOKyBRcVZzaFysGzKDeEOn9rlpQnsNQmvAxCKkw71P4+QI3+dzP5icKb7199ZNEmAVuUJaZKh2Asg8d77pfnP/DF/EsW+URLIw9iOxNZsK6GZ+l/Ql9bY9/pgdMxIrgbsR37rutMebYt2uSTw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.zohomail.com with SMTPS id 1635358171388386.10962713695596; Wed, 27 Oct 2021 11:09:31 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id 82-20020a1c0055000000b0032ccc3ad5c1so5080835wma.2 for ; Wed, 27 Oct 2021 11:09:30 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id v6sm730285wrx.17.2021.10.27.11.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fUU6kj3/MNVjhNoRDca0LWMfLXwMBccF/5RZxkxk4kk=; b=oNkEM9Q2UIZhkCvlLcsy3RyqAekcrReCFBhBuOZ5OkLHLjwCZse78Rlph3292wFrlN 6AJXB60xrTvSWT65q8aSNgKGMZ6mCb0ZItIsO9ppeSqdfoS/tZk2YhUf5k2Z9CE7CVgg yFc8l5dDWIwAod0r0LH0nyFTdGqNCrkrK8LAV+iKy2+0Q0EhvhEy6ky1GLmKhb/8871O CKOp4jknRnolUdbJzCN6DMcXvIw4t+aQZqgPehpiMYBntp/qHRSZBftHQ1ET4Rb1LLXH qzY5FrUtqTZqxAlcqrSlNikavrZk25WdrnTPT1RIqnau/U2NQGRYJyUM0yOiLNuEmfsY Xu/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fUU6kj3/MNVjhNoRDca0LWMfLXwMBccF/5RZxkxk4kk=; b=8OZjA9OtHNG+x/caxwZWdwj6fHL0SOg8zjL4aExTK2uHRgHJi5wxsT1FpB/RxhbhFj 2ymMEC/fW6ejCD601zDvnVcC8/4C1tKoXCtx/ywdmLGUS+d/DLyHLRiIUzHzSv9pHK3T zC+l1QPblSXlxrdUHzqvb/HA0442lkvVSTxTy7K5PexvHan7BTWo0kQtJfsUUlr/kJGm KXcHe7BWpq4JPZcmoLEVJ5hS317kboGwnjfy84pUBYIl73Y415McCXfZfbTxIDroz7HD eMc1rz/79n9O/zjaIWc0RsoOxqxDZrl2ygyyyS4jpYyfSjziOHm7oypyB0N12zL8Hz+R fKWw== X-Gm-Message-State: AOAM533KGtPs6NbY9lWgy5ah2zvo1JoStsr1/r36LZXjmp0k02cqspNd 1zk4E4nBSq4JE8nitPE3Bis= X-Google-Smtp-Source: ABdhPJwwzGNydugCT6ZbTuqasrdst4dRYGcLgjy4ziD0MxzWgRWM3Var6QEEsPrah0Zt5s1HiMf47Q== X-Received: by 2002:a7b:cb99:: with SMTP id m25mr7337112wmi.87.1635358169707; Wed, 27 Oct 2021 11:09:29 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH v2 25/32] target/mips: Convert MSA COPY_U opcode to decodetree Date: Wed, 27 Oct 2021 20:07:23 +0200 Message-Id: <20211027180730.1551932-26-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358173328100001 Convert the COPY_U opcode (Element Copy to GPR Unsigned) to decodetree. Since the 'n' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- v2: Add NULL_IF_TARGET_MIPS32() macro, use array of 4 functions --- target/mips/tcg/msa.decode | 1 + target/mips/tcg/msa_translate.c | 66 ++++++++++++++++++++------------- 2 files changed, 41 insertions(+), 26 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index e701e507bfc..4e1d3caadc5 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -165,6 +165,7 @@ BNZ 010001 111 .. ..... ...............= . @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df + COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df =20 FCAF 011110 0000 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index fabc7f5538b..a2d7bbe912f 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -38,7 +38,6 @@ enum { OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_COPY_S_df =3D (0x2 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_COPY_U_df =3D (0x3 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_INSERT_df =3D (0x4 << 22) | (0x00 << 16) | OPC_MSA_ELM, }; =20 @@ -565,6 +564,46 @@ TRANS_MSA(SLDI, trans_msa_elm_df, gen_helper_msa_s= ldi_df); TRANS_MSA(SPLATI, trans_msa_elm_df, gen_helper_msa_splati_df); TRANS_MSA(INSVE, trans_msa_elm_df, gen_helper_msa_insve_df); =20 +static bool trans_msa_elm_d64(DisasContext *ctx, arg_msa_elm_df *a, + gen_helper_piii * const gen_msa[4]) +{ + if (a->df < 0 || !gen_msa[a->df]) { + return false; + } + + if (check_msa_enabled(ctx)) { + return true; + } + + if (a->wd =3D=3D 0) { + /* Treat as NOP. */ + return true; + } + + gen_msa[a->df](cpu_env, + tcg_constant_i32(a->wd), + tcg_constant_i32(a->ws), + tcg_constant_i32(a->n)); + + return true; +} + +#if defined(TARGET_MIPS64) +#define NULL_IF_TARGET_MIPS32(function) function +#else +#define NULL_IF_TARGET_MIPS32(function) NULL +#endif + +static bool trans_COPY_U(DisasContext *ctx, arg_msa_elm_df *a) +{ + static gen_helper_piii * const gen_msa_copy_u[4] =3D { + gen_helper_msa_copy_u_b, gen_helper_msa_copy_u_h, + NULL_IF_TARGET_MIPS32(gen_helper_msa_copy_u_w), NULL + }; + + return trans_msa_elm_d64(ctx, a, gen_msa_copy_u); +} + static void gen_msa_elm_df(DisasContext *ctx, uint32_t df, uint32_t n) { #define MASK_MSA_ELM(op) (MASK_MSA_MINOR(op) | (op & (0xf << 22))) @@ -577,7 +616,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t = df, uint32_t n) =20 switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_COPY_S_df: - case OPC_COPY_U_df: case OPC_INSERT_df: #if !defined(TARGET_MIPS64) /* Double format valid only for MIPS64 */ @@ -585,11 +623,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t= df, uint32_t n) gen_reserved_instruction(ctx); break; } - if ((MASK_MSA_ELM(ctx->opcode) =3D=3D OPC_COPY_U_df) && - (df =3D=3D DF_WORD)) { - gen_reserved_instruction(ctx); - break; - } #endif switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_COPY_S_df: @@ -608,25 +641,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t= df, uint32_t n) case DF_DOUBLE: gen_helper_msa_copy_s_d(cpu_env, twd, tws, tn); break; -#endif - default: - assert(0); - } - } - break; - case OPC_COPY_U_df: - if (likely(wd !=3D 0)) { - switch (df) { - case DF_BYTE: - gen_helper_msa_copy_u_b(cpu_env, twd, tws, tn); - break; - case DF_HALF: - gen_helper_msa_copy_u_h(cpu_env, twd, tws, tn); - break; -#if defined(TARGET_MIPS64) - case DF_WORD: - gen_helper_msa_copy_u_w(cpu_env, twd, tws, tn); - break; #endif default: assert(0); --=20 2.31.1