From nobody Mon Feb 9 17:59:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) client-ip=209.85.221.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358157; cv=none; d=zohomail.com; s=zohoarc; b=igfPNJKe2Ow3xiwmq4d32lfD6qolUwyL+0R4BRX5YvYtNG2p8WDhgezdAKolFunjM6fXURWLTaFlcO4zOaiPWefBgRKVZpxUAVtg0ikKtY9vjjPIbSTul4+bJEt6AI/h2vs3w5mn5VdpkTdc9Hfh4J5THZRyh6IiWUxS07BoC24= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358157; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0YfANERaUxvrc0pkdwp3e+fS48avmmg1M4DJ+bBsIRQ=; b=hPwMIuH2qXLryjGb49wNuK4O0UVbef7tdMxdhQVqTmzB+qD8tInh0+jbq+4zoQ+LYWucm4foBt9VFsYab2kQUWWXV6t8w9W/fo3wkB5I+KOFRlectSxCi2IYLI+JOzJi3xuIdO8Xh+n8jD0wZ2dx5P7vdrskFkZ9r3laySY5DWA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.zohomail.com with SMTPS id 163535815723919.550544069577768; Wed, 27 Oct 2021 11:09:17 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id k7so5549241wrd.13 for ; Wed, 27 Oct 2021 11:09:16 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id b15sm429413wmj.22.2021.10.27.11.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0YfANERaUxvrc0pkdwp3e+fS48avmmg1M4DJ+bBsIRQ=; b=hplJ14QUYfCwT4QFSGFzzHORn+XcPkLpWBlWn/FRBbR78z8+2ITFebNy9YilcsFfuV jEg7C/HSQ7OOXNQJH8YE69iEuyPy8PoCi+9RKZJwNQ7wmRibNbo0DlJBETa6Nq6x94AA BQoMXX2R8VRM1rVjrb2QCTtYNq5SFSQOsOJq7tDB38Qz7SkKi5YNwA4gHUA9B4kZdR4b SZGLdLPmWABPzx6JdXdwFBTjbWYL9/iaKO/ADLYX7WLCTOVSgKB7Ij4gyBtgOvqfeWV+ 9BWzNb/EOV0FRgXDXJLVi6M7gZHZqEfJ93jW6rW4aoF6aFl3ezNhSOGQZCuY6I+G9UDP aBwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0YfANERaUxvrc0pkdwp3e+fS48avmmg1M4DJ+bBsIRQ=; b=t19sH4c1DKb2vTpw1L5be2tzm51GCcWuPrQtB8VVoqXZ813Kz+oTp7Kzyh5Xk+rcH5 KA785sD/PThwl8HXC6bWpUHEVGAjf5JHsSojsocD30dDed0Zrq3OH15Qyk208bvgHMDv poqAoifKPaLI2fMpvKeGns5Z/SH8SxwrL8nJcRbYQyCRGRP56lnqhSOgg1gqqVZAe+/6 W6yBiI7t3QA2ZxfHbpDDEpvC3E2yOM8MJuqjtUe/evol/LS8aSA9BAG3o8oFh8ibxH4v 2viDe2VfmOziatHdxPSnAjF5bZNw1uiyk2LdHvJPYz8LF8B7PM6xwbRoat7lNp5GdPlV VxdQ== X-Gm-Message-State: AOAM533d6ABNZpjSXBVIydRvT08MNNtBCq35ohaVUa1Q8MIYlV1spUpw rXeMyY5GmdFqKuJUGZfUpME= X-Google-Smtp-Source: ABdhPJyLlImq6zg/g6k52d2HyQQRcVk3Yms8pFTYV33phtGDGanFMmE4gl/JNOtnfpQHTy4JGwUD1g== X-Received: by 2002:adf:dc0e:: with SMTP id t14mr43762902wri.277.1635358155499; Wed, 27 Oct 2021 11:09:15 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH v2 22/32] target/mips: Convert MSA 3R instruction format to decodetree (part 3/4) Date: Wed, 27 Oct 2021 20:07:20 +0200 Message-Id: <20211027180730.1551932-23-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358159332100001 Convert BINSL (Vector Bit Insert Left) and BINSR (Vector Bit Insert Right) opcodes to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa.decode | 3 +++ target/mips/tcg/msa_translate.c | 40 +++++---------------------------- 2 files changed, 9 insertions(+), 34 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index f6471b92fc7..19458f180f5 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -87,6 +87,9 @@ BNZ 010001 111 .. ..... ................ = @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + BINSL 011110 110.. ..... ..... ..... 001101 @3r + BINSR 011110 111.. ..... ..... ..... 001101 @3r + DOTP_S 011110 000.. ..... ..... ..... 010011 @3r DOTP_U 011110 001.. ..... ..... ..... 010011 @3r DPADD_S 011110 010.. ..... ..... ..... 010011 @3r diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 5cc704c9ace..a5a5cc4bcac 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -81,12 +81,10 @@ enum { OPC_ASUB_U_df =3D (0x5 << 23) | OPC_MSA_3R_11, OPC_DIV_U_df =3D (0x5 << 23) | OPC_MSA_3R_12, OPC_ILVR_df =3D (0x5 << 23) | OPC_MSA_3R_14, - OPC_BINSL_df =3D (0x6 << 23) | OPC_MSA_3R_0D, OPC_MAX_A_df =3D (0x6 << 23) | OPC_MSA_3R_0E, OPC_AVER_S_df =3D (0x6 << 23) | OPC_MSA_3R_10, OPC_MOD_S_df =3D (0x6 << 23) | OPC_MSA_3R_12, OPC_ILVEV_df =3D (0x6 << 23) | OPC_MSA_3R_14, - OPC_BINSR_df =3D (0x7 << 23) | OPC_MSA_3R_0D, OPC_MIN_A_df =3D (0x7 << 23) | OPC_MSA_3R_0E, OPC_AVER_U_df =3D (0x7 << 23) | OPC_MSA_3R_10, OPC_MOD_U_df =3D (0x7 << 23) | OPC_MSA_3R_12, @@ -247,6 +245,9 @@ typedef void gen_helper_piiii(TCGv_ptr, TCGv_i32, TCGv_= i32, TCGv_i32, TCGv_i32); #define TRANS_DF_ii(NAME, trans_func, gen_func) \ TRANS_DF_x(ii, NAME, trans_func, gen_func) =20 +#define TRANS_DF_iii(NAME, trans_func, gen_func) \ + TRANS_DF_x(iii, NAME, trans_func, gen_func) + #define TRANS_DF_iii_b(NAME, trans_func, gen_func) \ static gen_helper_piii * const NAME##_tab[4] =3D { \ gen_func##_h, gen_func##_w, gen_func##_d \ @@ -482,6 +483,9 @@ static bool trans_msa_3r(DisasContext *ctx, arg_msa_r *= a, return true; } =20 +TRANS_DF_iii(BINSL, trans_msa_3r, gen_helper_msa_binsl); +TRANS_DF_iii(BINSR, trans_msa_3r, gen_helper_msa_binsr); + TRANS_DF_iii_b(DOTP_S, trans_msa_3r, gen_helper_msa_dotp_s); TRANS_DF_iii_b(DOTP_U, trans_msa_3r, gen_helper_msa_dotp_u); TRANS_DF_iii_b(DPADD_S, trans_msa_3r, gen_helper_msa_dpadd_s); @@ -512,38 +516,6 @@ static void gen_msa_3r(DisasContext *ctx) TCGv_i32 twt =3D tcg_const_i32(wt); =20 switch (MASK_MSA_3R(ctx->opcode)) { - case OPC_BINSL_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_binsl_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_binsl_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_binsl_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_binsl_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_BINSR_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_binsr_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_binsr_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_binsr_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_binsr_d(cpu_env, twd, tws, twt); - break; - } - break; case OPC_BCLR_df: switch (df) { case DF_BYTE: --=20 2.31.1