From nobody Tue Feb 10 01:34:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358148; cv=none; d=zohomail.com; s=zohoarc; b=Vd34joQ0EgSqC6cZ5+2w8GlptjwG1t9yGNEkj4Z+GOYoTl/KnLJRzAh7HLwLNMFgIzUl3pRd29He/aDvege7rcIWuEQDx6Cgo9tDqLt+fdckyILlIy6qCLxRK9YJvwTVyfZEvMr2lyG6G1GA6EY+HpvDVm3j37RSD07wYpaknHc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358148; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zj4x/v5Ps4y6ZPFdUiEBaIWOnBZnxVVtjnU+CwSUqwc=; b=fj0Vsod2nNVUZiyhtkW/L6ciIP0hbJN81g0CJIAOyB0Xj6/5ppXDy2dFTG7wCKDhDhiDiK6feWvcFvGafXPXiADy3fsMBzusrWCqXIoRZYAianFQw5Fcvvkl7QyF26qLOJK8FMS4YYbfmCOEZbWrV1q8CwjLEidOZTakG0VGIUA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1635358148030699.3073591153413; Wed, 27 Oct 2021 11:09:08 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id j35-20020a05600c1c2300b0032caeca81b7so3361230wms.0 for ; Wed, 27 Oct 2021 11:09:07 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id q18sm4210119wmc.7.2021.10.27.11.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zj4x/v5Ps4y6ZPFdUiEBaIWOnBZnxVVtjnU+CwSUqwc=; b=Tuoj2ha/YM8RyMqCtBaE/2g+ukb0kkBKldDuq+bxxEeE78Mr7f5qTnjQdPCmy0pSdj hFSQ7lxfXmaA7wqVT0iJMiXrUtjPCLWaC/ViZLRes2I9EKh87pZmSTn9MuDrS0xRIX+c aB+pJbbrPHK56fTnEAECL7l8vU57P9jNv5283B1Sd6013rGdInFLknsY06QIDfOlfLbV qF2U2Y0NXR9xax37jiw7SpBOEx04Rf5rKP5imJZ+WcH5ZUlscE6RJDS8JokeWs4ZT1YX SBW49A1dLYqgYqDcIi/76LhZGiRV/y/RuM4a0tTaJ2cQOzHhokaJijDbZ1eYWHcsAkZ6 7Krw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zj4x/v5Ps4y6ZPFdUiEBaIWOnBZnxVVtjnU+CwSUqwc=; b=g1EplTqeowJLD0u1ToZOz4gCj9m1mkYOV6/GIYEHTghG7C62Y9+xi8gXb/pxB76xcV xUgyRPUtP5fSTfAX1fnI82l3jzn6xQa6pcjAAHjosNsSWaC9yoKhguMoVGVCsXGHC/7a iW8867DYm3ohRmgFjhgEX5BjsmpOVt7sNZJDTT4ToVuYcs7cqXyQ/k/W8ToimJXtVEzl 9+M1bMcEcQIBNl8TecL97px4f0XXaZmnJjQY1h+8UzlQBc5lmBye9kodSjLBT6OjoQr6 mbqZ51cy27dB5PsL2dd1KHk0P/BkD2cgudi5D2OXIQRX+uhEjhCBbSDpkyCb6l1o5hYS Y/PA== X-Gm-Message-State: AOAM533leiS3RCE/Y8vPiGC987mfVLI1moJFP6BZmeE4jK2t7EXm056z wfMUzZL0zwUNFb7NZziAza0= X-Google-Smtp-Source: ABdhPJxZQxQnYQXFa48N/IGFMnBgLesKNPyqO453FRaoRVx0gAR8xcMiHvusBS2QEFdKTjLRnLYcvQ== X-Received: by 2002:a7b:c444:: with SMTP id l4mr7127025wmi.115.1635358146218; Wed, 27 Oct 2021 11:09:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH v2 20/32] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4) Date: Wed, 27 Oct 2021 20:07:18 +0200 Message-Id: <20211027180730.1551932-21-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358149674100001 Convert 3-register operations to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa.decode | 6 ++++++ target/mips/tcg/msa_translate.c | 29 +++++++++++++++++------------ 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index f88ae234cca..7201b821ae0 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -31,6 +31,7 @@ @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 +@3r ...... ... df:2 wt:5 ws:5 wd:5 ...... &msa_r @3rf ...... .... df:1 wt:5 ws:5 wd:5 ...... &msa_r @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_i5 @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_i5 @@ -86,6 +87,11 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + SLD 011110 000 .. ..... ..... ..... 010100 @3r + SPLAT 011110 001 .. ..... ..... ..... 010100 @3r + + VSHF 011110 000 .. ..... ..... ..... 010101 @3r + FCAF 011110 0000 . ..... ..... ..... 011010 @3rf FCUN 011110 0001 . ..... ..... ..... 011010 @3rf FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index f635b49c13c..c7ca629d684 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -48,15 +48,12 @@ enum { OPC_SUBS_S_df =3D (0x0 << 23) | OPC_MSA_3R_11, OPC_MULV_df =3D (0x0 << 23) | OPC_MSA_3R_12, OPC_DOTP_S_df =3D (0x0 << 23) | OPC_MSA_3R_13, - OPC_SLD_df =3D (0x0 << 23) | OPC_MSA_3R_14, - OPC_VSHF_df =3D (0x0 << 23) | OPC_MSA_3R_15, OPC_SRA_df =3D (0x1 << 23) | OPC_MSA_3R_0D, OPC_SUBV_df =3D (0x1 << 23) | OPC_MSA_3R_0E, OPC_ADDS_A_df =3D (0x1 << 23) | OPC_MSA_3R_10, OPC_SUBS_U_df =3D (0x1 << 23) | OPC_MSA_3R_11, OPC_MADDV_df =3D (0x1 << 23) | OPC_MSA_3R_12, OPC_DOTP_U_df =3D (0x1 << 23) | OPC_MSA_3R_13, - OPC_SPLAT_df =3D (0x1 << 23) | OPC_MSA_3R_14, OPC_SRAR_df =3D (0x1 << 23) | OPC_MSA_3R_15, OPC_SRL_df =3D (0x2 << 23) | OPC_MSA_3R_0D, OPC_MAX_S_df =3D (0x2 << 23) | OPC_MSA_3R_0E, @@ -457,6 +454,23 @@ TRANS_MSA(SAT_U, trans_msa_bit, gen_helper_msa_sat_= u_df); TRANS_MSA(SRARI, trans_msa_bit, gen_helper_msa_srari_df); TRANS_MSA(SRLRI, trans_msa_bit, gen_helper_msa_srlri_df); =20 +static bool trans_msa_3r_df(DisasContext *ctx, arg_msa_r *a, + gen_helper_piiii *gen_msa_3r_df) +{ + gen_msa_3r_df(cpu_env, + tcg_constant_i32(a->df), + tcg_constant_i32(a->wd), + tcg_constant_i32(a->ws), + tcg_constant_i32(a->wt)); + + return true; +} + +TRANS_MSA(SLD, trans_msa_3r_df, gen_helper_msa_sld_df); +TRANS_MSA(SPLAT, trans_msa_3r_df, gen_helper_msa_splat_df); + +TRANS_MSA(VSHF, trans_msa_3r_df, gen_helper_msa_vshf_df); + static void gen_msa_3r(DisasContext *ctx) { #define MASK_MSA_3R(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) @@ -1207,12 +1221,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SLD_df: - gen_helper_msa_sld_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_VSHF_df: - gen_helper_msa_vshf_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBV_df: switch (df) { case DF_BYTE: @@ -1245,9 +1253,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SPLAT_df: - gen_helper_msa_splat_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBSUS_U_df: switch (df) { case DF_BYTE: --=20 2.31.1