From nobody Mon Feb 9 17:59:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) client-ip=209.85.128.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358124; cv=none; d=zohomail.com; s=zohoarc; b=WgzWTEcBfIUBv6uvfxmVC9y2P98uW7TPbXcVZOuHYCwvM1dGYPE0k8aJxLbGq+FaN8ZSMWHJpxcQ46AUWgxUrP0dVeAgT8E8L2LEkgNr9D7enxRVMpfLLh9hgJli+8+Ucuf3qSZn09llHO6ABmfLPQXQldY8o6Hlo/TZso/G18k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358124; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uElesMQVD3bhC5YLVgJyV44WXCUQXJKdsCqdLpq2BLU=; b=iE4XLR9vgETWK2q7ssZP49+VKGqxUKeR4bYr77xGKfAeB5VregeppE1kcK8V/VzUgcIM5gRlPk3cHJmCSih3sAtE4QapeB2coqiW90YVcjj8Lhzkdvce+B2z6JCsJRGhnPaV8tBGUpig+4VjFc/MTU9gDm3u+/enFkksuKbufYs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.zohomail.com with SMTPS id 163535812477939.37407538192838; Wed, 27 Oct 2021 11:08:44 -0700 (PDT) Received: by mail-wm1-f43.google.com with SMTP id 67-20020a1c1946000000b0030d4c90fa87so3066206wmz.2 for ; Wed, 27 Oct 2021 11:08:44 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id m15sm464521wmq.0.2021.10.27.11.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uElesMQVD3bhC5YLVgJyV44WXCUQXJKdsCqdLpq2BLU=; b=J0MpoAikh5rvNDZHV0HGkZilK0pvl1bFLGllKdTo5Vk68rNVMdPQYcgLXwgMuT7+qg ePTLQ3urSCPz/N7t6R3RQo8Bx/BXBEmfcs0Xvkk/pQFCNIv5ewOHxaSuPiU//Ri5FMzs Co4NjfbcEqPuEDuWDcpfMMctXhW05KmKuRw74ynULfNz0uk4t1cjULiT/nAQsQgxT+sQ vST/4I77gRyxZxK4YMR141PtQgvry4tEs0qwiHGwhGut/1K3ZoSHwwldCkpkq6eeNk6W v66pTcL13PTUgNgW/Srf/sPQfdeNZ59gpELAOWDcMoDAEM4jBztQDW6vS3pAEEpJvdoN zuEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=uElesMQVD3bhC5YLVgJyV44WXCUQXJKdsCqdLpq2BLU=; b=qpIxpcOjTcYd1GWbSgKN0vEd64q2xRpwlnazIwM/Hfo/OBvSIMUNr+isVGHmok+0Gr AQz2/HIa2kXOzANU2mOQ2RXuOoqvx8rxQVrytokAijQ8Jf24bsbIk2l93tbRTS9ao1/l cWVHoiEl+xy+VwxfdnhvocxGGHMMXeye15zQzhAjjqJQESNxiEOO17YRGyVipjiRLFtF YoDuUIEvn0p52U3AzwBXjDkA1ZtkPzNGc9Q4cAIfR2CxUTG622TWWUPP1XiO0gZ5xFc2 W7QlDwfFGr0aTUYNaHnNEM+zVKogv0Yp8LtLEhuoE0Ayx4cnk/sWv8sJkFbqOHoA0CsF NzvQ== X-Gm-Message-State: AOAM533p8bCc/MsndMUITltt5ctL5XNYg/igtx4UPhLpNoO/KHdNL3kd Bl+waAqJLvZUyep31uTekv0= X-Google-Smtp-Source: ABdhPJwW2tf7mkUfwFAo4dzTVytcSzg4X7u9qqxIgFiqBvC2gIlxpSnceIJ6WWNdx+u4778pzj1pXQ== X-Received: by 2002:a1c:a984:: with SMTP id s126mr7281196wme.156.1635358123092; Wed, 27 Oct 2021 11:08:43 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH v2 15/32] target/mips: Convert MSA FILL opcode to decodetree Date: Wed, 27 Oct 2021 20:07:13 +0200 Message-Id: <20211027180730.1551932-16-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358126944100003 Convert the FILL opcode (Vector Fill from GPR) to decodetree. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- v2: - check TARGET_LONG_BITS !=3D 64 before check_msa_access() - !check_msa_access returns true - Use tcg_constant_i32() --- target/mips/tcg/msa.decode | 2 ++ target/mips/tcg/msa_translate.c | 32 ++++++++++++++++++++------------ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 395a2cbafeb..030ffa9321b 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -28,6 +28,7 @@ @ldst ...... sa:s10 ws:5 wd:5 .... df:2 &msa_ldst @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_i5 @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_i5 @@ -83,6 +84,7 @@ BNZ 010001 111 .. ..... ................ = @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + FILL 011110 11000000 .. ..... ..... 011110 @2r FCLASS 011110 110010000 . ..... ..... 011110 @2rf FTRUNC_S 011110 110010001 . ..... ..... 011110 @2rf FTRUNC_U 011110 110010010 . ..... ..... 011110 @2rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index a61ba9a4db8..004eb0b7700 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -56,7 +56,6 @@ enum { OPC_MSA_2R =3D (0x18 << 21) | OPC_MSA_VEC, =20 /* 2R instruction df(bits 17..16) =3D _b, _h, _w, _d */ - OPC_FILL_df =3D (0x00 << 18) | OPC_MSA_2R, OPC_PCNT_df =3D (0x01 << 18) | OPC_MSA_2R, OPC_NLOC_df =3D (0x02 << 18) | OPC_MSA_2R, OPC_NLZC_df =3D (0x03 << 18) | OPC_MSA_2R, @@ -1843,17 +1842,6 @@ static void gen_msa_2r(DisasContext *ctx) TCGv_i32 tws =3D tcg_const_i32(ws); =20 switch (MASK_MSA_2R(ctx->opcode)) { - case OPC_FILL_df: -#if !defined(TARGET_MIPS64) - /* Double format valid only for MIPS64 */ - if (df =3D=3D DF_DOUBLE) { - gen_reserved_instruction(ctx); - break; - } -#endif - gen_helper_msa_fill_df(cpu_env, tcg_constant_i32(df), - twd, tws); /* trs */ - break; case OPC_NLOC_df: switch (df) { case DF_BYTE: @@ -1912,6 +1900,26 @@ static void gen_msa_2r(DisasContext *ctx) tcg_temp_free_i32(tws); } =20 +static bool trans_FILL(DisasContext *ctx, arg_msa_r *a) +{ + if (TARGET_LONG_BITS !=3D 64 && a->df =3D=3D DF_DOUBLE) { + /* Double format valid only for MIPS64 */ + gen_reserved_instruction(ctx); + return true; + } + + if (!check_msa_enabled(ctx)) { + return true; + } + + gen_helper_msa_fill_df(cpu_env, + tcg_constant_i32(a->df), + tcg_constant_i32(a->wd), + tcg_constant_i32(a->ws)); + + return true; +} + static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a, gen_helper_piii *gen_msa_2rf) { --=20 2.31.1