From nobody Tue Feb 10 04:17:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358106; cv=none; d=zohomail.com; s=zohoarc; b=j37goPQmQOyfirvV8aL4rkZqqstRV7JXfSK4GTfaJVknDkeW+7qztUsqMa+wN8poryiwV3Ku1RvMmy7Vr1+TAL53AV+QJKrKfuWsNqW/cvr7gBHtVJjQelLeYQNEAPNJzMenSvdhJUFI9XCrcnIH9zrzXuD7UA5YSBrKqYfDrsw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358106; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2rXLHxxRogsnp6IIzjRu1XhVnNOs7SF+xybpEobk/Vg=; b=eRHnypdosZ6d+WabIkIKSKFuddjpBxxCI0VL7l1/488//QM453myf3eLySLIxfF79QiGiojrueQfuHfFeroD8TIf5bbM/mt39W8SSvpKhL6gwOBOugUI+G9dsh2X+SabCYrLCBlIuvHTPgZhH8Ue2G+Vx8nIf+2N2nBWx9a89LM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 163535810601271.33693342604931; Wed, 27 Oct 2021 11:08:26 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id d10so5658422wrb.1 for ; Wed, 27 Oct 2021 11:08:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id s13sm4247815wmc.47.2021.10.27.11.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2rXLHxxRogsnp6IIzjRu1XhVnNOs7SF+xybpEobk/Vg=; b=ANMfmBJjxO88sfWrzq26iILIEFCYf+PB4PQhEMWufk8kK7xxuY5XuVIsMvySiMr5DP qunmFA5CimbCuNmBr1QAKUnpboV6QhKSoHatUIaGu95qwPEy6bXc2REH8NWyNu5AjfVh Iqir2HApiuXxf2Tas3K+DXqEatlaZ5oJ9rhoK69eXDjapWGfOHq8stHjyg32LzvWPD3T DdN74hZm7LU+P2VMH7c5d0KGvGgsnwlLn02Uo1AG2hYU4BBp5WlQis0PUKOKl5KybCmI lyK5ET4DhY2+uhnQMfDFaeTNH4WOZokHHrGkSwM1Ig/3alf6jjLIn6B4YUjzC+iJ/21c QyyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2rXLHxxRogsnp6IIzjRu1XhVnNOs7SF+xybpEobk/Vg=; b=7oOe79YfN+57m4kjx2ESOSWH5HxnBYs1FdoJmRubXwwoYWHZ8yfjjr7MIXKGn9feex M4AKO31NuJpCs0wt+CVBcp6k5fZrycLpud4iIyIhIeWN2kgIrPIyB/PNdWbdCX93VVGt NLSDPo7XRZRiuoPhMbuq/2IFDeurZv2lkBP5PGlJ0Pu6+cxQK53anqJWZTEzGSXIeQEb 2g/nHPis9UuCBcaqAkmUIQOuAjUMqoqFEEmC41zxNjBjkU99B9GJP6QfvRZB9/uzFh5t n5V+g08wei8mhFxIwV0Uyism9VtwPu6fZyetcEsXZhBW6AVi2KnjidJkDIhnslBaFNKp GcXg== X-Gm-Message-State: AOAM533WCyOnqlERczhu5X3UPiKHA5zc0A2LhC+zyIwMl/fcOsMEGjWP 0KfjQuV6V4SYZx0BDx2EWWY= X-Google-Smtp-Source: ABdhPJwxW5HT+WILrrZeCiXws1C71+50tuKZ4zd+jNCFYjkrNghFsm6vXUyN+z89R1y82SwZt5dutw== X-Received: by 2002:a5d:63cd:: with SMTP id c13mr40450230wrw.224.1635358104325; Wed, 27 Oct 2021 11:08:24 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang , Richard Henderson Subject: [PATCH v2 11/32] target/mips: Convert MSA SHF opcode to decodetree Date: Wed, 27 Oct 2021 20:07:09 +0200 Message-Id: <20211027180730.1551932-12-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358108069100001 Convert the SHF opcode (Immediate Set Shuffle Elements) to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: - add &msa_i8 format - !check_msa_enabled -> return true - TCG timm is constant --- target/mips/tcg/msa.decode | 4 ++++ target/mips/tcg/msa_translate.c | 37 ++++++++++++++++++--------------- 2 files changed, 24 insertions(+), 17 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index c4699b9d4b7..7a4d7549258 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -16,6 +16,7 @@ &msa_bz df wt sa &msa_ldi df wd sa &msa_i5 df wd ws sa +&msa_i8 df wd ws sa &msa_bit df wd ws m =20 %dfm_df 16:7 !function=3Dmsa_bit_df @@ -26,6 +27,7 @@ @bz ...... ... df:2 wt:5 sa:16 &msa_bz @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_i5 @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_i5 +@i8_df ...... df:2 sa:s8 ws:5 wd:5 ...... &msa_i8 @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldi @bit ...... ... ....... ws:5 wd:5 ...... &msa_bit df=3D= %dfm_df m=3D%dfm_m =20 @@ -38,6 +40,8 @@ BZ 010001 110 .. ..... ................ = @bz BNZ 010001 111 .. ..... ................ @bz =20 { + SHF 011110 .. ........ ..... ..... 000010 @i8_df + ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 SUBVI 011110 001 .. ..... ..... ..... 000110 @u5 MAXI_S 011110 010 .. ..... ..... ..... 000110 @s5 diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 175254c1e47..76c40dc7126 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -60,13 +60,10 @@ enum { /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, OPC_BMNZI_B =3D (0x0 << 24) | OPC_MSA_I8_01, - OPC_SHF_B =3D (0x0 << 24) | OPC_MSA_I8_02, OPC_ORI_B =3D (0x1 << 24) | OPC_MSA_I8_00, OPC_BMZI_B =3D (0x1 << 24) | OPC_MSA_I8_01, - OPC_SHF_H =3D (0x1 << 24) | OPC_MSA_I8_02, OPC_NORI_B =3D (0x2 << 24) | OPC_MSA_I8_00, OPC_BSELI_B =3D (0x2 << 24) | OPC_MSA_I8_01, - OPC_SHF_W =3D (0x2 << 24) | OPC_MSA_I8_02, OPC_XORI_B =3D (0x3 << 24) | OPC_MSA_I8_00, =20 /* VEC/2R/2RF instruction */ @@ -477,20 +474,6 @@ static void gen_msa_i8(DisasContext *ctx) case OPC_BSELI_B: gen_helper_msa_bseli_b(cpu_env, twd, tws, ti8); break; - case OPC_SHF_B: - case OPC_SHF_H: - case OPC_SHF_W: - { - uint8_t df =3D (ctx->opcode >> 24) & 0x3; - if (df =3D=3D DF_DOUBLE) { - gen_reserved_instruction(ctx); - } else { - TCGv_i32 tdf =3D tcg_const_i32(df); - gen_helper_msa_shf_df(cpu_env, tdf, twd, tws, ti8); - tcg_temp_free_i32(tdf); - } - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -502,6 +485,26 @@ static void gen_msa_i8(DisasContext *ctx) tcg_temp_free_i32(ti8); } =20 +static bool trans_SHF(DisasContext *ctx, arg_msa_i8 *a) +{ + if (a->df =3D=3D DF_DOUBLE) { + gen_reserved_instruction(ctx); + return true; + } + + if (!check_msa_enabled(ctx)) { + return true; + } + + gen_helper_msa_shf_df(cpu_env, + tcg_constant_i32(a->df), + tcg_constant_i32(a->wd), + tcg_constant_i32(a->ws), + tcg_constant_i32(a->sa)); + + return true; +} + static bool trans_msa_i5(DisasContext *ctx, arg_msa_i5 *a, gen_helper_piiii *gen_msa_i5) { --=20 2.31.1