From nobody Tue Feb 10 11:34:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635310581; cv=none; d=zohomail.com; s=zohoarc; b=YlsSr2NwdZLIwUoyFSJuwoIVJdZH0a6ObTCZ+4Ec6MYwn5k17NPwiWi0VaDoljNmo1N/rncGVh6S9CRyPIZtXOPGVy/VFCteg9P2k4II6M4eoSmkcVIwmp96zAjwVUiz4Tt6MJ93Ivn8xe06L1FT6Qtiw7GiNej0ELlaTenuKGc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635310581; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Xgqwxzvm1yoHh/fzT0KNAI1LNIKM1+1SON195Vhqr/o=; b=l2e7L1RrZx5GdcCw8Hn5R8eZii2eFH+Cs+A1XStqo0HZ1QGE9mEeCvME1RYA2ndoWQLLaTx4WzjdKcLuqM1yjFM0OflRpaEM+TYl76s6hdSBAIV5+ubpnp5VTmx6hAmmCylHtVubopaGMR39H3RaV60ESgOKSswnEemIR+KAE3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1635310581662222.91776286303275; Tue, 26 Oct 2021 21:56:21 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id z11-20020a1c7e0b000000b0030db7b70b6bso5134508wmc.1 for ; Tue, 26 Oct 2021 21:56:21 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id d3sm21667468wrb.36.2021.10.26.21.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 21:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xgqwxzvm1yoHh/fzT0KNAI1LNIKM1+1SON195Vhqr/o=; b=UIt/DChPhUSIG3lPRxfquQIOiN8e1V2Th5+2iNdfQj7m3mYpVBQQqAYP2M2LCr6BYY gRMA8o/+e/70yDg4rCkYg2bzYmTHrZdG5Zx2vddBTSa1urIsbPiz2F5TnaTTfTeps4MH rT6/QuqxOUbBgunO03a5iIVxNwtji6BQLsZt0VxB6ynhdHcRB+PERGTA/qFCC0Gckqof Bkgrc76D82hMdY43vpI5nsOTyrIExwSidVj1P7uk8Qga2Y4prQ+bBtRJ5RmNNu7K5jMv Y6GqrLu+ecKgF0UTmKHqY7zK41kYULWr6Gu4IK9BrnTP1aSVF4jIiPHPWWZEar9Bx64f w/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Xgqwxzvm1yoHh/fzT0KNAI1LNIKM1+1SON195Vhqr/o=; b=tb+Vnezq22t+FVS8bp1BAXsGxcCVzqI3IUw0bQ4Cpv++TLiApKFNk3g6eqrt7eW0m9 RIEuOakDlFlYC9LVVNgfDQjZMzHerMWSzOhy0hMvrJ/Pi/ms618zx6XR4ibdPU3TE1yz w7kLWWiRPcy0rg5TeLYQZuxud1bgoYhFAeGlsNWceJa/rwdxW0V5y41HT1+mDLmIhtAF bXSzbKYUYBDDV+Li2oXBlQtzP91CihjJJ9UniIaN0aXAIkZw+X0gh6AbQ11req+/osrH c0np7qcT0fIfdoNXcjTAY7jxcuVQlQHVsk/rAdQTu7TBX5prIrMgq7PyAKZjooMP6d46 fVjw== X-Gm-Message-State: AOAM533MvMtJ5hx+op5PBzkwLduQGiicgFOPLsEZVrYbkMhzJ5JSW7tM mQCTaAzHuM0aGa0VJzvuj5uWWPNjmtE= X-Google-Smtp-Source: ABdhPJxvYP8nzccWn/Pb7Y8T8dSn8DgzFW7W6toZ5ataKUxFc4MRnJFYsTuz4UfH6l0cDcuYBNtgug== X-Received: by 2002:a7b:c927:: with SMTP id h7mr3288597wml.68.1635310579926; Tue, 26 Oct 2021 21:56:19 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 2/4] target/arm: Introduce store_cpu_field_constant() helper Date: Wed, 27 Oct 2021 06:56:05 +0200 Message-Id: <20211027045607.1261526-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027045607.1261526-1-f4bug@amsat.org> References: <20211027045607.1261526-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635310583270100001 Similarly to the store_cpu_field() helper which takes a TCG temporary, store its value to the CPUState, introduce the store_cpu_field_constant() helper which store a constant to CPUState (without using any TCG temporary). Update the single store_cpu_offset() user in do_coproc_insn(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate-a32.h | 11 ++++++++--- target/arm/translate.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a32.h b/target/arm/translate-a32.h index 88f15df60e8..2e708ca3dbc 100644 --- a/target/arm/translate-a32.h +++ b/target/arm/translate-a32.h @@ -61,14 +61,19 @@ static inline TCGv_i32 load_cpu_offset(int offset) =20 #define load_cpu_field(name) load_cpu_offset(offsetof(CPUARMState, name)) =20 -static inline void store_cpu_offset(TCGv_i32 var, int offset) +static inline void store_cpu_offset(TCGv_i32 var, int offset, bool is_temp) { tcg_gen_st_i32(var, cpu_env, offset); - tcg_temp_free_i32(var); + if (is_temp) { + tcg_temp_free_i32(var); + } } =20 #define store_cpu_field(var, name) \ - store_cpu_offset(var, offsetof(CPUARMState, name)) + store_cpu_offset(var, offsetof(CPUARMState, name), true) + +#define store_cpu_field_constant(val, name) \ + store_cpu_offset(tcg_constant_i32(val), offsetof(CPUARMState, name), f= alse) =20 /* Create a new temporary and set it to the value of a CPU register. */ static inline TCGv_i32 load_reg(DisasContext *s, int reg) diff --git a/target/arm/translate.c b/target/arm/translate.c index 083a6d6ed77..5061e55f2c0 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -4855,7 +4855,7 @@ static void do_coproc_insn(DisasContext *s, int cpnum= , int is64, tcg_temp_free_i32(tmp); } else { TCGv_i32 tmp =3D load_reg(s, rt); - store_cpu_offset(tmp, ri->fieldoffset); + store_cpu_offset(tmp, ri->fieldoffset, true); } } } --=20 2.31.1