From nobody Tue Feb 10 10:42:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635310576; cv=none; d=zohomail.com; s=zohoarc; b=Q6H1cysyFYmkgxNecIh4a4PPKrSQtyf8TMm1UwDD/7Q4qHGXeKNmwoO1gI+1++nKXEafJWNY04RtnfT0wCG00iy1MIHxIlzMALQ6qtPW94OfyI7RGM9LV5re0Ly2CNcHJpU6euP6Fml9CpN3kJUIIS+SZpnbtiUWYttnH4lSNZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635310576; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=GAz9cmKnvUBNgShT35f7+r4cQgwrRv1I/U2YJHW4GFPSpeyRtS0kinBq9HenQPQ33bVur3xhUpoNpWIGfwY6RQUqGBJCY3GzpLvSpuWFEWVKUKKs/V1PW6AD/pmamDd+zp+AHnCJ/GJcewLAl/KKSMu+sE4k0jN8Q3WMRwAHldQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 1635310576554216.70857875412514; Tue, 26 Oct 2021 21:56:16 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id o4-20020a1c7504000000b0032cab7473caso2171092wmc.1 for ; Tue, 26 Oct 2021 21:56:15 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id h14sm2429034wmq.34.2021.10.26.21.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 21:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=EEs301cbturZRJCI1X6xYwruY/+L+oGeqviC8Aw0CJp4Mf+BV06OKL+1DzQpHXy9zn O0y7xp0mU2y1qpn7LaATDY/OwJLlxHL5GMzVT4h6VQzjtb9ayUAlyi0g3uhahWliCGe1 Osg2fRJ3eiXdDXpsecnsY2FbBoMFcfeorh2s+F2HflHTB49YnY7siJqXKrFCgPwamBs0 nB9LUIh3s7Lzs8eBXnYsHzW60dWCz7GP770HUH/POBtAz+flawV/kjNQNOHsl2MZ3jaA mTKInCqBstpod1GvMOB/A8zHJ/RYZNhDo9tvTBu+83FOf0J6Gpd/pr59ZCRSvCvM4Wx/ OsMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=k8JlTcBJ5tbuQianfT+GjK+LsVkfTV7SClfXj2hnAJtvesqoXurGGrdRz2jtrYtDB6 dHpberqLxA9g5k2hmN/JkHAVD1fsuoPX2MIHoSO0i9Ivj7xMS/FKJ7Jpb5n1Gc9MFoK+ dpm89mlVXleJsH84cabhFz14BgVHbDFeTFKgoite4FvOPoIPHCT0i9yNweoukqpXZgBe JozeiUUHBkx0UqPafclRhXw7zQgR1T2leAn/GUyBIsT+cubT8X+wTKWFR2jQecaSdBYs Acr73E1P1PbcxwCFokdku5t0pb0KsDJyOSQrm9p87ohMPvPVGKwlZfIETBmLgzPQsTT3 YwbA== X-Gm-Message-State: AOAM533k+zYq3y4/r0FBzkqxkHNSEilhvK+jGNti/nyLP92JaOL7enQH NHuTgAtEB0gnDuiuTVjRbtQ= X-Google-Smtp-Source: ABdhPJy9wMzOXO9yGkkrDUEXhuBkTyjZan5iG4FNsfmDNA/t99vZ/w1aIl1Y/jrNfbBxgqzUH0pU+A== X-Received: by 2002:a05:600c:ac2:: with SMTP id c2mr3303175wmr.118.1635310574725; Tue, 26 Oct 2021 21:56:14 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-arm@nongnu.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/4] target/arm: Use tcg_constant_i32() in op_smlad() Date: Wed, 27 Oct 2021 06:56:04 +0200 Message-Id: <20211027045607.1261526-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027045607.1261526-1-f4bug@amsat.org> References: <20211027045607.1261526-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635310577170100001 Avoid using a TCG temporary for a read-only constant. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index d6af5b1b039..083a6d6ed77 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7849,10 +7849,9 @@ static bool op_smlad(DisasContext *s, arg_rrrr *a, b= ool m_swap, bool sub) t3 =3D tcg_temp_new_i32(); tcg_gen_sari_i32(t3, t1, 31); qf =3D load_cpu_field(QF); - one =3D tcg_const_i32(1); + one =3D tcg_constant_i32(1); tcg_gen_movcond_i32(TCG_COND_NE, qf, t2, t3, one, qf); store_cpu_field(qf, QF); - tcg_temp_free_i32(one); tcg_temp_free_i32(t3); tcg_temp_free_i32(t2); } --=20 2.31.1