From nobody Sat Feb 7 09:03:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635264555225592.3658871717876; Tue, 26 Oct 2021 09:09:15 -0700 (PDT) Received: from localhost ([::1]:60048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfP0j-0001vT-Ru for importer@patchew.org; Tue, 26 Oct 2021 12:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOzG-0007d9-Mh for qemu-devel@nongnu.org; Tue, 26 Oct 2021 12:07:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOzE-00043U-IY for qemu-devel@nongnu.org; Tue, 26 Oct 2021 12:07:42 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-vi1Fy0NAPwGDlr7JdiwCHw-1; Tue, 26 Oct 2021 12:07:38 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0309362FB; Tue, 26 Oct 2021 16:07:37 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id B43F3E2CB; Tue, 26 Oct 2021 16:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CeJpYCXg7EA6G8snVr6W6qAUpTz5okwf/oso6QY/UA4=; b=VV//XC1qs4pso/x1DJLXWuNcN/TNbEC+M+0w3v3RfVXuIt4VbmrTfegV5gjT1uKzFfLPT2 fGBJ7x5jAPXEen8DEgN30b8RZwV2W9y+wEPHC/KLJEi/jVhm0myg0D9k3JK7aw6jrboImQ AFav86IngMeGsBiZEMEzwKm2M2KsLvE= X-MC-Unique: vi1Fy0NAPwGDlr7JdiwCHw-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v2 1/3] machine: Use host_memory_backend_is_mapped() in machine_consume_memdev() Date: Tue, 26 Oct 2021 18:06:47 +0200 Message-Id: <20211026160649.47545-2-david@redhat.com> In-Reply-To: <20211026160649.47545-1-david@redhat.com> References: <20211026160649.47545-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , David Hildenbrand , Richard Henderson , Peter Xu , Igor Mammedov , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1635264557393100001 Content-Type: text/plain; charset="utf-8" memory_region_is_mapped() is the wrong check, we actually want to check whether the backend is already marked mapped. For example, memory regions mapped via an alias, such as NVDIMMs, currently don't make memory_region_is_mapped() return "true". As the machine is initialized before any memory devices (and thereby before NVDIMMs are initialized), this isn't a fix but merely a cleanup. Reviewed-by: Richard Henderson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/core/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index b8d95eec32..a1db865939 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1260,7 +1260,7 @@ MemoryRegion *machine_consume_memdev(MachineState *ma= chine, { MemoryRegion *ret =3D host_memory_backend_get_memory(backend); =20 - if (memory_region_is_mapped(ret)) { + if (host_memory_backend_is_mapped(backend)) { error_report("memory backend %s can't be used multiple times.", object_get_canonical_path_component(OBJECT(backend))); exit(EXIT_FAILURE); --=20 2.31.1 From nobody Sat Feb 7 09:03:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635264695705313.69245173325305; Tue, 26 Oct 2021 09:11:35 -0700 (PDT) Received: from localhost ([::1]:37426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfP30-0005gn-Kd for importer@patchew.org; Tue, 26 Oct 2021 12:11:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOzL-0007jG-Of for qemu-devel@nongnu.org; Tue, 26 Oct 2021 12:07:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOzK-00044N-2H for qemu-devel@nongnu.org; Tue, 26 Oct 2021 12:07:47 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-sZHwZIsOPLmkrhh5dO8h6A-1; Tue, 26 Oct 2021 12:07:42 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AC5810168C3; Tue, 26 Oct 2021 16:07:41 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECDB51972D; Tue, 26 Oct 2021 16:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zjLtlBcGj/IRcnBpCfCpWEDqyxtDvZR4R/M/lfHENw4=; b=dQjeLUigQYLV6a0LO7nG+kor+6taqSdazBaD6hq839C9hSfi4sXfLwcCq6P1WvBr8rY4rc XkTICwFrPxBN07oNwDUi8N9KzKzPFE1CwRHckqvRqeYFrrX/zdYHqAruDxF0pSPjlpL4+i MzZV+9wwTJnBx3jv3Y6QHQLOOg0mUTo= X-MC-Unique: sZHwZIsOPLmkrhh5dO8h6A-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v2 2/3] memory: Make memory_region_is_mapped() succeed when mapped via an alias Date: Tue, 26 Oct 2021 18:06:48 +0200 Message-Id: <20211026160649.47545-3-david@redhat.com> In-Reply-To: <20211026160649.47545-1-david@redhat.com> References: <20211026160649.47545-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , David Hildenbrand , Richard Henderson , Peter Xu , Igor Mammedov , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1635264696248100001 Content-Type: text/plain; charset="utf-8" memory_region_is_mapped() currently does not return "true" when a memory region is mapped via an alias. Assuming we have: alias (A0) -> alias (A1) -> region (R0) Mapping A0 would currently only make memory_region_is_mapped() succeed on A0, but not on A1 and R0. Let's fix that by adding a "mapped_via_alias" counter to memory regions and updating it accordingly when an alias gets (un)mapped. I am not aware of actual issues, this is rather a cleanup to make it consistent. Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/exec/memory.h | 1 + softmmu/memory.c | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index a185b6dcb8..35382d9870 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -707,6 +707,7 @@ struct MemoryRegion { const MemoryRegionOps *ops; void *opaque; MemoryRegion *container; + int mapped_via_alias; /* Mapped via an alias, container might be NULL = */ Int128 size; hwaddr addr; void (*destructor)(MemoryRegion *mr); diff --git a/softmmu/memory.c b/softmmu/memory.c index e5826faa0c..17ca896c38 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -2524,8 +2524,13 @@ static void memory_region_add_subregion_common(Memor= yRegion *mr, hwaddr offset, MemoryRegion *subregion) { + MemoryRegion *alias; + assert(!subregion->container); subregion->container =3D mr; + for (alias =3D subregion->alias; alias; alias =3D alias->alias) { + alias->mapped_via_alias++; + } subregion->addr =3D offset; memory_region_update_container_subregions(subregion); } @@ -2550,9 +2555,14 @@ void memory_region_add_subregion_overlap(MemoryRegio= n *mr, void memory_region_del_subregion(MemoryRegion *mr, MemoryRegion *subregion) { + MemoryRegion *alias; + memory_region_transaction_begin(); assert(subregion->container =3D=3D mr); subregion->container =3D NULL; + for (alias =3D subregion->alias; alias; alias =3D alias->alias) { + alias->mapped_via_alias--; + } QTAILQ_REMOVE(&mr->subregions, subregion, subregions_link); memory_region_unref(subregion); memory_region_update_pending |=3D mr->enabled && subregion->enabled; @@ -2649,7 +2659,7 @@ static FlatRange *flatview_lookup(FlatView *view, Add= rRange addr) =20 bool memory_region_is_mapped(MemoryRegion *mr) { - return mr->container ? true : false; + return !!mr->container || mr->mapped_via_alias; } =20 /* Same as memory_region_find, but it does not add a reference to the --=20 2.31.1 From nobody Sat Feb 7 09:03:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635264820794314.23891687200467; Tue, 26 Oct 2021 09:13:40 -0700 (PDT) Received: from localhost ([::1]:41238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfP51-0008JR-NJ for importer@patchew.org; Tue, 26 Oct 2021 12:13:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOzQ-0007nI-Tj for qemu-devel@nongnu.org; Tue, 26 Oct 2021 12:07:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOzP-00045T-GN for qemu-devel@nongnu.org; Tue, 26 Oct 2021 12:07:52 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-NzvdDdX-Mly4Li1LNbVGRg-1; Tue, 26 Oct 2021 12:07:47 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 836C4362F8; Tue, 26 Oct 2021 16:07:46 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.192.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5417916A35; Tue, 26 Oct 2021 16:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NUxClgXVzXxQ9wiBVvGBoiHLiTm7ErAfHpHd5AdOaCI=; b=Bvk/ZweZjobdEzBDCMkqtdegd1xw/HaAuXyNZOzKKTlE8GjKoO6yGPrh67HtHBHeFECT1W DfC+NF8GbyB2PJWeeSrc+j9npazH/2k3Eurt6ogmw3xUnG2uTSWAUVP20XqT8svqWklHP6 pUjmzuflCm7vZTY2ybVsm/M6hewFSzE= X-MC-Unique: NzvdDdX-Mly4Li1LNbVGRg-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v2 3/3] memory: Update description of memory_region_is_mapped() Date: Tue, 26 Oct 2021 18:06:49 +0200 Message-Id: <20211026160649.47545-4-david@redhat.com> In-Reply-To: <20211026160649.47545-1-david@redhat.com> References: <20211026160649.47545-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , David Hildenbrand , Richard Henderson , Peter Xu , Igor Mammedov , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1635264823026100001 Content-Type: text/plain; charset="utf-8" Let's update the documentation, making it clearer what the semantics of memory_region_is_mapped() actually are. Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/exec/memory.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 35382d9870..bab9349b60 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -2266,7 +2266,8 @@ bool memory_region_present(MemoryRegion *container, h= waddr addr); =20 /** * memory_region_is_mapped: returns true if #MemoryRegion is mapped - * into any address space. + * into another memory region, which does not necessarily imply that it is + * mapped into an address space. * * @mr: a #MemoryRegion which should be checked if it's mapped */ --=20 2.31.1