From nobody Tue Feb 10 06:27:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635092198; cv=none; d=zohomail.com; s=zohoarc; b=eFDZPwexJkuUH5eubGevYlo/KbQAOXnpY0ZZkOF3mm/lHrKwZ6nL/NP6aWC5BV8MFA6f9Q7TrrC7r/r9wULlVbj4HgOd7BR2NGiskrpoAJqKLMQCP9ULzxwo+6wNjzLPq2OK22wbW9oeMQdfPPCdwApnPRPHdYFEOLT399xKtwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635092198; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yP7BLA1h8Q3wRULGuTTgt/69jEjbxHvrn1EyN0eEB+I=; b=AKBLbMsuNeGBiwbusyIHyq4k7SFExsnT9nCLJI4SZ+AFwVFxUKDgf+pi0xZruIQJoHWTkjopH/3Rod5BADbU2zNrkufD4uc7YWockRPAwb3UR3qdiUOovASxsVRN8fke+vJYF+bgobgbsyTwfBrMwScKYlxs42iJOiHI7cAXHcY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635092198670450.73483122304015; Sun, 24 Oct 2021 09:16:38 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id v17so6788357wrv.9 for ; Sun, 24 Oct 2021 09:16:38 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id f7sm12480783wmg.14.2021.10.24.09.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 09:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yP7BLA1h8Q3wRULGuTTgt/69jEjbxHvrn1EyN0eEB+I=; b=dIA/5dim4KbVkNv/T2pO2U2DYRwyozGNUfCOlH60rUK/P1FPH1MKseAMdrGjS6BKNk /QTvxfdDqFaCbxhy8dfcAfpCZTlz0GLFIEHt0LMxnNFL+fQ8aQbxDcE0gyY04Q3Mx1Mf JzStKyVn8+v/wiymBG4Y74vVHQ23rZIowbI45IVQsSOs3pMhFv5pfHJPHljgaUzpKe1E +PJ8HMk/uEU7FaH6+Z8OMddKdWeMhSn02tQOksj32kYeeNPOgudAHLFMYfGrfQupokZr VeYI38qRESxpPkcdpXtZZjjFVEuZieuni1QO+UOzfZWo0PF2nGeIw/Ebi84avAqMjo9V h8OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yP7BLA1h8Q3wRULGuTTgt/69jEjbxHvrn1EyN0eEB+I=; b=oMkWCCqtBPg1vGOCerzX6+pB+BPDXPCqf36H3QiaxZamRrNhF+oh28mg+4vTVcdUdF 401UNFmnGglhRJwVlmTPJ/4ps+fe43k7rtiuVRHZkpLmH4LXpbSvDeVI6OP4C4Dp932f Rtycz0h+vQ9ItreW+kg+5mk2M6aKWsMvf8oXnDaYZ/s9ce9WVWyhMpidDb+oiAHQPblt Bd2lZnS6Af0YQI2At1JkmYkRqUvdF/5BmNXkaQ2xGi74NcV/7ceoPbf4AMpteWNV4mre BU8PtUZ0YAsGAH2QSwaqLWCdrZjDKVM3Bb2k+ZjygNbZPCiotFR/twQGH/QTEkBrKxMu dAEg== X-Gm-Message-State: AOAM530nop4MpSCU1LSOgd7yzPg89nxuvb39Fp73pvoLcfVE0+vZvBUP MxUfyUQBqgpmKGg/4IufWQ8= X-Google-Smtp-Source: ABdhPJz3TSloNAOizdj6p2h4ZptplFg+2Y5RYo/atRMwpFoQz0uBVfmXh3JhI1nJ92Tl5Csh4H/l2Q== X-Received: by 2002:a5d:6741:: with SMTP id l1mr16441144wrw.2.1635092196962; Sun, 24 Oct 2021 09:16:36 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, David Gibson , Peter Maydell , qemu-ppc@nongnu.org, Richard Henderson , Greg Kurz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/4] target/ppc: Use tcg_constant_tl() in gen_op_cmp() Date: Sun, 24 Oct 2021 18:16:18 +0200 Message-Id: <20211024161619.325903-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211024161619.325903-1-f4bug@amsat.org> References: <20211024161619.325903-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635092200885100001 Avoid using a TCG temporary by moving the compared values to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Reviewed-by: Richard Henderson --- target/ppc/translate.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 518337bcb7f..507f6699f47 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -1430,23 +1430,20 @@ static opc_handler_t invalid_handler =3D { static inline void gen_op_cmp(TCGv arg0, TCGv arg1, int s, int crf) { TCGv t0 =3D tcg_temp_new(); - TCGv t1 =3D tcg_temp_new(); TCGv_i32 t =3D tcg_temp_new_i32(); =20 - tcg_gen_movi_tl(t0, CRF_EQ); - tcg_gen_movi_tl(t1, CRF_LT); tcg_gen_movcond_tl((s ? TCG_COND_LT : TCG_COND_LTU), - t0, arg0, arg1, t1, t0); - tcg_gen_movi_tl(t1, CRF_GT); + t0, arg0, arg1, + tcg_constant_tl(CRF_LT), tcg_constant_tl(CRF_EQ)); tcg_gen_movcond_tl((s ? TCG_COND_GT : TCG_COND_GTU), - t0, arg0, arg1, t1, t0); + t0, arg0, arg1, + tcg_constant_tl(CRF_GT), t0); =20 tcg_gen_trunc_tl_i32(t, t0); tcg_gen_trunc_tl_i32(cpu_crf[crf], cpu_so); tcg_gen_or_i32(cpu_crf[crf], cpu_crf[crf], t); =20 tcg_temp_free(t0); - tcg_temp_free(t1); tcg_temp_free_i32(t); } =20 --=20 2.31.1