From nobody Sat May 18 10:07:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635092189; cv=none; d=zohomail.com; s=zohoarc; b=X/Y/F3dzZm2XEKu1iOt3MKDRCu0nHZRykckJ9tB/XkS1E68zWeVHfDBobbjio6jypHWgbUuu3mpI2Fj7bpk/Xv4VT9blF9ltzNMe9ieIjNSra9OP0+5xqtX/86ziozjmy+V0eXG4XtAtKvUdWbIB83NbhxAHMOoXFc5/2d8O+OM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635092189; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9VeXic0fs8CIZcPeph0iPU6CO4mvSNbwetSuj8mQ6Wc=; b=jcTsfnjrIeTs2CFd6jKmkQA9PmiSRW0Dbtk1AJr3xSrCTERBrFaEY7KW5SC9D8TbvmRw7BBA18uySxdFYAESU4Iu+aH9uUg+pCR33nggjsSw0PMAGvG06AoKrUlnvxvMfrlxrR9bN585e/2N3m7N667BHRpCi6KzrILR51x99Mo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.zohomail.com with SMTPS id 1635092189301256.8706177654768; Sun, 24 Oct 2021 09:16:29 -0700 (PDT) Received: by mail-wm1-f54.google.com with SMTP id b133-20020a1c808b000000b0032ca4d18aebso6508393wmd.2 for ; Sun, 24 Oct 2021 09:16:28 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id m2sm5472303wrb.58.2021.10.24.09.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 09:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9VeXic0fs8CIZcPeph0iPU6CO4mvSNbwetSuj8mQ6Wc=; b=JjPgRwFXXmRAQMRY1Xw/f8qgythrTAU7QWpeVE++uzfedbXv08PaokKHaK5FNG3xcQ 7xrVa7Kisr6yBhgW2xtoPJPfM8CRylMm2/a0CP9wc+AJbYiLpudTuIwTMDOwYz4KRGX6 DUUXM3MPCC7wmVvUdHnSjGXHvP7rxQxr9OmMBEe3wUrzRlXDPhgKvYXxvUKJpS5qUlue 8Utk62ToamYemtWx0YB+5s3kKxNRDN1ZjiYp4jQbLh6zJdx4GC5kaxGe8o+1OG5RfvOK H5lxdlTfFF1xBu1u6Ca3ecOKfQXFFWfWgUHf4v3IdRSQ6RtqD6eeYGoW0g6+TuApkxud qP4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9VeXic0fs8CIZcPeph0iPU6CO4mvSNbwetSuj8mQ6Wc=; b=b1z6oFEHyiqhFW8kwRdOLTgG0eus70ItflXEcL5J+lcrMYnQ0uTyS0tPLSrKTUuHwZ g6f2Zr0CBeu35EG+/6IJi4xhs7MZ+nqnI6ZSX/nQa6/+yOOYZWcVcRp4QvPF0yfZ4hbb 6YxXcwZYAIUP/8cfRWst+c9albbJieD0VKtWYgilsE2p3EdStPdcfHnZo6Unv+oWC8CA E5Kai1xfp5ICXk0cWixiCKXn8iZZqM+GKu1tC8tlL3BaIlV5MKaCfdzzFuz1pTHbvCNj MXOJbVW2lldjghnhixtbz7jvS6PobFxWMk1daq8vo6DXTRy05wHnH3RctY/jCsZZJewg d/1Q== X-Gm-Message-State: AOAM532dC7a+0hw2aS9Nm65DVPTr770J8CX/SlE22FnGvGO2C3H66wWP jovcV/xdiWHfya7ItKAWuYo= X-Google-Smtp-Source: ABdhPJxggDeHVcUvoLpUfU0aPKXNusGRWwmur8bsuWSIUmhTv3/qUciUFh+8NHhmhZoRiod4TZ0lsQ== X-Received: by 2002:a1c:9ac7:: with SMTP id c190mr18390509wme.2.1635092187627; Sun, 24 Oct 2021 09:16:27 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, David Gibson , Peter Maydell , qemu-ppc@nongnu.org, Richard Henderson , Greg Kurz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/4] target/alpha: Use tcg_constant_i64() in gen_call_pal() Date: Sun, 24 Oct 2021 18:16:16 +0200 Message-Id: <20211024161619.325903-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211024161619.325903-1-f4bug@amsat.org> References: <20211024161619.325903-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635092190358100001 Avoid using a TCG temporary by moving the flag and exception address to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/alpha/translate.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index a4c3f43e720..326d4216aad 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -1191,20 +1191,17 @@ static DisasJumpType gen_call_pal(DisasContext *ctx= , int palcode) return gen_excp(ctx, EXCP_CALL_PAL, palcode); #else { - TCGv tmp =3D tcg_temp_new(); uint64_t exc_addr =3D ctx->base.pc_next; uint64_t entry =3D ctx->palbr; =20 if (ctx->tbflags & ENV_FLAG_PAL_MODE) { exc_addr |=3D 1; } else { - tcg_gen_movi_i64(tmp, 1); - st_flag_byte(tmp, ENV_FLAG_PAL_SHIFT); + st_flag_byte(tcg_constant_i64(1), ENV_FLAG_PAL_SHIFT); } =20 - tcg_gen_movi_i64(tmp, exc_addr); - tcg_gen_st_i64(tmp, cpu_env, offsetof(CPUAlphaState, exc_addr)); - tcg_temp_free(tmp); + tcg_gen_st_i64(tcg_constant_i64(exc_addr), + cpu_env, offsetof(CPUAlphaState, exc_addr)); =20 entry +=3D (palcode & 0x80 ? 0x2000 + (palcode - 0x80) * 64 --=20 2.31.1 From nobody Sat May 18 10:07:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635092194; cv=none; d=zohomail.com; s=zohoarc; b=Jq6R9bOjzX2+oax4fm9rsxBT6g7huMJeu9fgJUN7K8OnPe5i7k7x97J0PO+YKjV3ztR9S8HXmuRBL1JggiOdO7/UQMe3np/KUVpP0fh8wo9GK+eOp6WPHAkuf5EdCn/zCn4Yh2OoND5KzId3gQhetYYSrJR/n1FSERnIAjH2pKk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635092194; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O1BoBsNweUhtwI2foBYUrbLKkFOSUy9/c6YZdEqMFi0=; b=VsJsu3fodqxYL0MNSle3q5WZbLxvAr/veApanwUEuINgOHz8osSHzuwiMaWLvnNAOsA2PzlaiZEy/IveXw0K/7PAXBhYThOvHO27ogw6GMe0zanZyY+hK96JdqFUW/Rpx6AcU0qMREk/o58SLyk9aa9dxlCZmD3G9VqEsUWVz4o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1635092194022970.8295547348237; Sun, 24 Oct 2021 09:16:34 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id v17so6788136wrv.9 for ; Sun, 24 Oct 2021 09:16:33 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id f1sm9622312wrc.74.2021.10.24.09.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 09:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O1BoBsNweUhtwI2foBYUrbLKkFOSUy9/c6YZdEqMFi0=; b=HLQx7+s9mS3U6Bvl98KXWFqJTLGr74GgiZKciOnQAmb+7/uxFgWCeOWZJOQWj20UTD rrelJvkwbTj+AOn3i3N/4PXLTSaxya3mvTUw5RyLCItuA10wIb6CK8L+tHqBmnCB1wnE zi1yZK8hKDKr95gquXeScTAUH4Q8BWTARbZOo490iLLuGEE+q+RYmHcLkF8tLg8KVu1p GBGDyKclBqHNVXD3fS9MyCho5J1y7oK5Zyqgrf2GXtXKeiH85HNP8JvAQFCGXq0zvXAy U+SgY66j0ED8DDQCvcpwucXi1XNKDTUvxc/LbVYVp3SkaIU4PJL4pzPKqL1aAE8bEX3w gKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=O1BoBsNweUhtwI2foBYUrbLKkFOSUy9/c6YZdEqMFi0=; b=z6ViZokVT9XzI+nUh4j7DWX+M/ro3E4Q+ydR4Na8soGqK8Dhcio4Ed6Hj18jbnd9U7 F+iMhXPEol5QQkp8C7FcqA9YrdNtzPrwWkGfSYAz/q6qRlRC0aEAQk0+7SoSBY8+gMbn /u6kwXqicBxjUgP02WRULie5jjF52T5L3zg7wjTb1nX2f3IlBlUXO4CZRBK/o1cUFBpR 37HCDQlKaCk0g4xw7G5XMutWODehGhRoHXPZ8HXrFAs5vMJW3vkgyV82bfO/BA1NoHuI JT74ttxaQk+Eh6OAdp5nvjf+ZUrFe1psJZcDFhbAVPk6MOM8qjNWlX65P+PaIto4EYur +iEg== X-Gm-Message-State: AOAM5327iukYiIM/BJZg4IC1+npDezbXo82X1slbgFQBqhubDZorXG1x YaSX5RNXv2x8OH8VVbbzL6r+EEu2U8s= X-Google-Smtp-Source: ABdhPJxDj8PiGq/HRzQ54R5Igr4+2Sa/DnlyjQeYFGs1T8sysTiV5+BpXZ3vC5+mwD/8GqpoZiLyAA== X-Received: by 2002:a5d:6941:: with SMTP id r1mr4573781wrw.373.1635092192305; Sun, 24 Oct 2021 09:16:32 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, David Gibson , Peter Maydell , qemu-ppc@nongnu.org, Richard Henderson , Greg Kurz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/4] target/arm: Use tcg_constant_i64() in do_sat_addsub_64() Date: Sun, 24 Oct 2021 18:16:17 +0200 Message-Id: <20211024161619.325903-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211024161619.325903-1-f4bug@amsat.org> References: <20211024161619.325903-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635092194456100001 The immediate value used for comparison is constant and read-only. Move it to the constant pool. This frees a TCG temporary for unsigned saturation opcodes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/translate-sve.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index bc91a641711..76b5fe9f313 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -1943,20 +1943,20 @@ static void do_sat_addsub_32(TCGv_i64 reg, TCGv_i64= val, bool u, bool d) static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64 val, bool u, bool d) { TCGv_i64 t0 =3D tcg_temp_new_i64(); - TCGv_i64 t1 =3D tcg_temp_new_i64(); TCGv_i64 t2; =20 if (u) { if (d) { tcg_gen_sub_i64(t0, reg, val); - tcg_gen_movi_i64(t1, 0); - tcg_gen_movcond_i64(TCG_COND_LTU, reg, reg, val, t1, t0); + t2 =3D tcg_constant_i64(0); + tcg_gen_movcond_i64(TCG_COND_LTU, reg, reg, val, t2, t0); } else { tcg_gen_add_i64(t0, reg, val); - tcg_gen_movi_i64(t1, -1); - tcg_gen_movcond_i64(TCG_COND_LTU, reg, t0, reg, t1, t0); + t2 =3D tcg_constant_i64(-1); + tcg_gen_movcond_i64(TCG_COND_LTU, reg, t0, reg, t2, t0); } } else { + TCGv_i64 t1 =3D tcg_temp_new_i64(); if (d) { /* Detect signed overflow for subtraction. */ tcg_gen_xor_i64(t0, reg, val); @@ -1966,7 +1966,7 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64 v= al, bool u, bool d) =20 /* Bound the result. */ tcg_gen_movi_i64(reg, INT64_MIN); - t2 =3D tcg_const_i64(0); + t2 =3D tcg_constant_i64(0); tcg_gen_movcond_i64(TCG_COND_LT, reg, t0, t2, reg, t1); } else { /* Detect signed overflow for addition. */ @@ -1977,13 +1977,12 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64= val, bool u, bool d) =20 /* Bound the result. */ tcg_gen_movi_i64(t1, INT64_MAX); - t2 =3D tcg_const_i64(0); + t2 =3D tcg_constant_i64(0); tcg_gen_movcond_i64(TCG_COND_LT, reg, t0, t2, t1, reg); } - tcg_temp_free_i64(t2); + tcg_temp_free_i64(t1); } tcg_temp_free_i64(t0); - tcg_temp_free_i64(t1); } =20 /* Similarly with a vector and a scalar operand. */ --=20 2.31.1 From nobody Sat May 18 10:07:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635092198; cv=none; d=zohomail.com; s=zohoarc; b=eFDZPwexJkuUH5eubGevYlo/KbQAOXnpY0ZZkOF3mm/lHrKwZ6nL/NP6aWC5BV8MFA6f9Q7TrrC7r/r9wULlVbj4HgOd7BR2NGiskrpoAJqKLMQCP9ULzxwo+6wNjzLPq2OK22wbW9oeMQdfPPCdwApnPRPHdYFEOLT399xKtwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635092198; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yP7BLA1h8Q3wRULGuTTgt/69jEjbxHvrn1EyN0eEB+I=; b=AKBLbMsuNeGBiwbusyIHyq4k7SFExsnT9nCLJI4SZ+AFwVFxUKDgf+pi0xZruIQJoHWTkjopH/3Rod5BADbU2zNrkufD4uc7YWockRPAwb3UR3qdiUOovASxsVRN8fke+vJYF+bgobgbsyTwfBrMwScKYlxs42iJOiHI7cAXHcY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635092198670450.73483122304015; Sun, 24 Oct 2021 09:16:38 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id v17so6788357wrv.9 for ; Sun, 24 Oct 2021 09:16:38 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id f7sm12480783wmg.14.2021.10.24.09.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 09:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yP7BLA1h8Q3wRULGuTTgt/69jEjbxHvrn1EyN0eEB+I=; b=dIA/5dim4KbVkNv/T2pO2U2DYRwyozGNUfCOlH60rUK/P1FPH1MKseAMdrGjS6BKNk /QTvxfdDqFaCbxhy8dfcAfpCZTlz0GLFIEHt0LMxnNFL+fQ8aQbxDcE0gyY04Q3Mx1Mf JzStKyVn8+v/wiymBG4Y74vVHQ23rZIowbI45IVQsSOs3pMhFv5pfHJPHljgaUzpKe1E +PJ8HMk/uEU7FaH6+Z8OMddKdWeMhSn02tQOksj32kYeeNPOgudAHLFMYfGrfQupokZr VeYI38qRESxpPkcdpXtZZjjFVEuZieuni1QO+UOzfZWo0PF2nGeIw/Ebi84avAqMjo9V h8OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yP7BLA1h8Q3wRULGuTTgt/69jEjbxHvrn1EyN0eEB+I=; b=oMkWCCqtBPg1vGOCerzX6+pB+BPDXPCqf36H3QiaxZamRrNhF+oh28mg+4vTVcdUdF 401UNFmnGglhRJwVlmTPJ/4ps+fe43k7rtiuVRHZkpLmH4LXpbSvDeVI6OP4C4Dp932f Rtycz0h+vQ9ItreW+kg+5mk2M6aKWsMvf8oXnDaYZ/s9ce9WVWyhMpidDb+oiAHQPblt Bd2lZnS6Af0YQI2At1JkmYkRqUvdF/5BmNXkaQ2xGi74NcV/7ceoPbf4AMpteWNV4mre BU8PtUZ0YAsGAH2QSwaqLWCdrZjDKVM3Bb2k+ZjygNbZPCiotFR/twQGH/QTEkBrKxMu dAEg== X-Gm-Message-State: AOAM530nop4MpSCU1LSOgd7yzPg89nxuvb39Fp73pvoLcfVE0+vZvBUP MxUfyUQBqgpmKGg/4IufWQ8= X-Google-Smtp-Source: ABdhPJz3TSloNAOizdj6p2h4ZptplFg+2Y5RYo/atRMwpFoQz0uBVfmXh3JhI1nJ92Tl5Csh4H/l2Q== X-Received: by 2002:a5d:6741:: with SMTP id l1mr16441144wrw.2.1635092196962; Sun, 24 Oct 2021 09:16:36 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, David Gibson , Peter Maydell , qemu-ppc@nongnu.org, Richard Henderson , Greg Kurz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/4] target/ppc: Use tcg_constant_tl() in gen_op_cmp() Date: Sun, 24 Oct 2021 18:16:18 +0200 Message-Id: <20211024161619.325903-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211024161619.325903-1-f4bug@amsat.org> References: <20211024161619.325903-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635092200885100001 Avoid using a TCG temporary by moving the compared values to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Reviewed-by: Richard Henderson --- target/ppc/translate.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 518337bcb7f..507f6699f47 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -1430,23 +1430,20 @@ static opc_handler_t invalid_handler =3D { static inline void gen_op_cmp(TCGv arg0, TCGv arg1, int s, int crf) { TCGv t0 =3D tcg_temp_new(); - TCGv t1 =3D tcg_temp_new(); TCGv_i32 t =3D tcg_temp_new_i32(); =20 - tcg_gen_movi_tl(t0, CRF_EQ); - tcg_gen_movi_tl(t1, CRF_LT); tcg_gen_movcond_tl((s ? TCG_COND_LT : TCG_COND_LTU), - t0, arg0, arg1, t1, t0); - tcg_gen_movi_tl(t1, CRF_GT); + t0, arg0, arg1, + tcg_constant_tl(CRF_LT), tcg_constant_tl(CRF_EQ)); tcg_gen_movcond_tl((s ? TCG_COND_GT : TCG_COND_GTU), - t0, arg0, arg1, t1, t0); + t0, arg0, arg1, + tcg_constant_tl(CRF_GT), t0); =20 tcg_gen_trunc_tl_i32(t, t0); tcg_gen_trunc_tl_i32(cpu_crf[crf], cpu_so); tcg_gen_or_i32(cpu_crf[crf], cpu_crf[crf], t); =20 tcg_temp_free(t0); - tcg_temp_free(t1); tcg_temp_free_i32(t); } =20 --=20 2.31.1 From nobody Sat May 18 10:07:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635092203; cv=none; d=zohomail.com; s=zohoarc; b=gSfwxsd5RV8QOkof9a74JmIri1GDF0+h43cVF/twd8ZCMRhzC+vlbhtYvWH4tKITqMTyXYqAF4zyvoR6IoAP48LRSHuOrL/mDaUGpjbrdvrTnG0ixZo3IZuT7JsK2U4KQCr4zfaOdXO2y1b4JAlUQhZ7N4BD2WFNCsAc+n059mw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635092203; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+eCufxrSs/JG/dcQv3XIP+vKdVUBYPST3YpjCTe8HCs=; b=Hs7MqfgUigKfJQHNCP1dSBUG/cSE/cG6sBfgmhQI16BwYnSn/Y0XGdWuoPpAk0kTJjXVbi0wgWx2nkh0jA6H4JaqlplM9QyPVX/KBN5UwkEM/X25j2/Mo+TgjhrxJmYRb2RoUA7RPCrFQc6AvmxrFNSW1WEnbIUUlGtfVbhNkZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1635092203423829.9333322892079; Sun, 24 Oct 2021 09:16:43 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id k7so3447035wrd.13 for ; Sun, 24 Oct 2021 09:16:42 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id f7sm12480929wmg.14.2021.10.24.09.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Oct 2021 09:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+eCufxrSs/JG/dcQv3XIP+vKdVUBYPST3YpjCTe8HCs=; b=epGvdkQeWhmvp0rdLyNV1/H5Iwe7YgjE/OBdHIdA+L1cWsSYUhDLDbh1886G+TDf4a 0nioy9xlwZD6hnk+7iqodm49DC25+lFfXpioEWhd9pdn/NWIqQ3gWiwA8ScUJ/pmpz9c LGxiyKcvOLbEh3WCUsktPox9bwKVuA/c+pVaFLFyDEmMV40iEH+EOVXo9BtJuZnUnVwW 1jzLdIXkGQfT3HqveeV6j/1eh3PFQZ7HGi3NPVDD1Iehjgglyiqy7p898uGZYn5jQyIQ q/YQuEQuhAjm1j6OfU/v3hCA0R0q0Z+UY/xU1QWdBrIkL/SCeVHVhb84DynumjtVKOAt /C1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+eCufxrSs/JG/dcQv3XIP+vKdVUBYPST3YpjCTe8HCs=; b=3U/CmcPqP2oqKcYniCfwlD0QyfR/S0d4ZISBukEzx0In43Pv1h8GsPDrZXHru4BRG6 Uq+b+jTHyf81G7KNASUOwmM7l/jd2BHrtpgVz4JKw8pgIVUnsz2/00G/ufEZ7mfz5BGe /hZmP5P0b2b3UvIwb3xNxbpKiV54TVFK3snLgvxAljzLwnHBXymDCJhQStdxO1ZTYOzH ibYUohAJ1w095xOlCsmK7VPitmTfelZ5Yd92/roW9CwpbcGu7AnGehbFaYUZTYRvq8Lh plvz3nkNKhnEJToTcj4J1Tfq0noUTsFfc/tk2tmgHFvX10tzLa3ihZPkTF44FukBPM4p YQWg== X-Gm-Message-State: AOAM5300GEMu8xDdRb7xu0Nw0wpERtRm96mntxyaTlKvzjzXRRUCofsv OYWjFB8LXVpqDFV7N5ki61g= X-Google-Smtp-Source: ABdhPJw7BuPEkbeYOFICkoPQqsO98cxpBRMN5M/gpOPDOwFPxHFZMko2Apof4OlJ42mrRGR4gWdJUQ== X-Received: by 2002:adf:80cd:: with SMTP id 71mr16052364wrl.429.1635092201670; Sun, 24 Oct 2021 09:16:41 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, David Gibson , Peter Maydell , qemu-ppc@nongnu.org, Richard Henderson , Greg Kurz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/4] target/ppc: Use tcg_constant_i32() in gen_ld/st() Date: Sun, 24 Oct 2021 18:16:19 +0200 Message-Id: <20211024161619.325903-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211024161619.325903-1-f4bug@amsat.org> References: <20211024161619.325903-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635092205281100001 Avoid using a TCG temporary by moving the MemOp index to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/ppc/translate.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 507f6699f47..9a4ae61a39d 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -3347,15 +3347,14 @@ static void gen_lq(DisasContext *ctx) =20 if (tb_cflags(ctx->base.tb) & CF_PARALLEL) { if (HAVE_ATOMIC128) { - TCGv_i32 oi =3D tcg_temp_new_i32(); + TCGv_i32 oi; if (ctx->le_mode) { - tcg_gen_movi_i32(oi, make_memop_idx(MO_LEQ, ctx->mem_idx)); + oi =3D tcg_constant_i32(make_memop_idx(MO_LEQ, ctx->mem_id= x)); gen_helper_lq_le_parallel(lo, cpu_env, EA, oi); } else { - tcg_gen_movi_i32(oi, make_memop_idx(MO_BEQ, ctx->mem_idx)); + oi =3D tcg_constant_i32(make_memop_idx(MO_BEQ, ctx->mem_id= x)); gen_helper_lq_be_parallel(lo, cpu_env, EA, oi); } - tcg_temp_free_i32(oi); tcg_gen_ld_i64(hi, cpu_env, offsetof(CPUPPCState, retxh)); } else { /* Restart with exclusive lock. */ @@ -3458,17 +3457,16 @@ static void gen_std(DisasContext *ctx) =20 if (tb_cflags(ctx->base.tb) & CF_PARALLEL) { if (HAVE_ATOMIC128) { - TCGv_i32 oi =3D tcg_temp_new_i32(); + TCGv_i32 oi; if (ctx->le_mode) { - tcg_gen_movi_i32(oi, make_memop_idx(MO_LE | MO_128, - ctx->mem_idx)); + oi =3D tcg_constant_i32(make_memop_idx(MO_LE | MO_128, + ctx->mem_idx)); gen_helper_stq_le_parallel(cpu_env, EA, lo, hi, oi); } else { - tcg_gen_movi_i32(oi, make_memop_idx(MO_BE | MO_128, - ctx->mem_idx)); + oi =3D tcg_constant_i32(make_memop_idx(MO_BE | MO_128, + ctx->mem_idx)); gen_helper_stq_be_parallel(cpu_env, EA, lo, hi, oi); } - tcg_temp_free_i32(oi); } else { /* Restart with exclusive lock. */ gen_helper_exit_atomic(cpu_env); @@ -4065,17 +4063,16 @@ static void gen_lqarx(DisasContext *ctx) =20 if (tb_cflags(ctx->base.tb) & CF_PARALLEL) { if (HAVE_ATOMIC128) { - TCGv_i32 oi =3D tcg_temp_new_i32(); + TCGv_i32 oi; if (ctx->le_mode) { - tcg_gen_movi_i32(oi, make_memop_idx(MO_LE | MO_128 | MO_AL= IGN, - ctx->mem_idx)); + oi =3D tcg_constant_i32(make_memop_idx(MO_LE | MO_128 | MO= _ALIGN, + ctx->mem_idx)); gen_helper_lq_le_parallel(lo, cpu_env, EA, oi); } else { - tcg_gen_movi_i32(oi, make_memop_idx(MO_BE | MO_128 | MO_AL= IGN, - ctx->mem_idx)); + oi =3D tcg_constant_i32(make_memop_idx(MO_BE | MO_128 | MO= _ALIGN, + ctx->mem_idx)); gen_helper_lq_be_parallel(lo, cpu_env, EA, oi); } - tcg_temp_free_i32(oi); tcg_gen_ld_i64(hi, cpu_env, offsetof(CPUPPCState, retxh)); } else { /* Restart with exclusive lock. */ --=20 2.31.1