From nobody Fri Dec 19 19:14:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025711; cv=none; d=zohomail.com; s=zohoarc; b=aYHE4/yGC4srYmC0eptOeHNYTnomG1/MAYzgzXKw2TEEIX3Y8VeOmnUofu6TiEllWSSizXyDU8IrDDvBhCq+74cKoz/AfC+OlIDVU9JhDICEtXBI+WaBO+QJDVWTkpIaqOsqiQ1KpIAdm/glsASJunol0ZZCViS3yEv4OX9VQEA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025711; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qpC85BtT3RgnbykCXVzDyO1CuhDm3xChbP8VfA4crRw=; b=fm5MdJferPLRcftIrZO90KCXbN4BC/N2zjvBuP908OJmC5FL1JVtmPqpsKvkhajPTIgzczIhYyOaDtaLeHhRb5kbD/VWp3hqrRkovVRL1R+DJd0CRx9xReI1x+/uhbANwjIJe7OxLBJn8vuF79KBLrUVbEw5X/CLsGrOrfgmpIM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635025711601886.1611714452592; Sat, 23 Oct 2021 14:48:31 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id u18so1391029wrg.5 for ; Sat, 23 Oct 2021 14:48:31 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id o10sm12996960wmq.46.2021.10.23.14.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qpC85BtT3RgnbykCXVzDyO1CuhDm3xChbP8VfA4crRw=; b=HOGkbCqehWu0/fWcBYvuPsDx0nzee8arZGA1+R3W7hRZs70OFMuJmaG61va9C0hitT 9hRCZckvDEGkgDkwSMxs79pJQ5v95Iu9M9kSoSGIx1sZ6eHhS1NehFJtGav1eFwd2SEn GN7yjNwCeI1Pf588p2H/7j+w+DL9Roc+Xz9VRUy2AzYa9Ts2yOIl4mwb1WbVVs8xjhCK znTj4Psjk3WWeWUBeWpEUQ6t7hwaJiRfPyplVrFHLBjFObAPIoApo+2KdXzCGZRtXALz tG4+qxICGNwOfawEF3xheMyfJcZU0FkLIiGHDchEG8JeL/T3c63s9UPRQM91/MpKSwvd N69g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qpC85BtT3RgnbykCXVzDyO1CuhDm3xChbP8VfA4crRw=; b=PBYrH61VWoPuRIf56cVgK6ZKEE3s92zhIqIuyhcyDniWyMF8MiBLyTb4lVR11wsSXx +vzo8F5VH9FFVsK/buGWMLRIri3iebSbeI3PicdN1qdHrOVm/x+ehImuKE83vQnJs2WP CiDsOs4HkahyvnjbeAkrCJNYDhS78nRcbHULJowVYAKCcghw5tTXmaOtin9BuuQ39jqh CmzkY5lO9gNGEgUhWUBZmVl9B3Jg1sxpj72ctL+Xq3ZrfSxrYX7EYevtD9KHixhFh8vd kw5jCrUbn4+fXeq7dTiJwk8kth8kOKeYRtkHMY6GmJio630FJ3M/jCNVyJrOHxytytjV fPYA== X-Gm-Message-State: AOAM533zYJSmu0OLx9C3ogx9MUCuovpDdstjp5LIz0J964V30MFjQUI+ MYic2eFJ7YGUkTCfgUhvpI0= X-Google-Smtp-Source: ABdhPJxG3BQNeXCzCm6iEuG7LbOJOHJ7uaI1f+fA4opBvNGvuA8GJ78yeyoZ5JGoMI1szs2KrMExew== X-Received: by 2002:adf:fd8a:: with SMTP id d10mr10407145wrr.213.1635025709911; Sat, 23 Oct 2021 14:48:29 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 05/33] target/mips: Have check_msa_access() return a boolean Date: Sat, 23 Oct 2021 23:47:35 +0200 Message-Id: <20211023214803.522078-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025712088100001 Have check_msa_access() return a boolean value so we can return early if MSA is not enabled. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa_translate.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 3ef912da6b8..9e0a08fe335 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -293,19 +293,19 @@ void msa_translate_init(void) } } =20 -static inline int check_msa_access(DisasContext *ctx) +static inline bool check_msa_access(DisasContext *ctx) { if (unlikely((ctx->hflags & MIPS_HFLAG_FPU) && !(ctx->hflags & MIPS_HFLAG_F64))) { gen_reserved_instruction(ctx); - return 0; + return false; } =20 if (unlikely(!(ctx->hflags & MIPS_HFLAG_MSA))) { generate_exception_end(ctx, EXCP_MSADIS); - return 0; + return false; } - return 1; + return true; } =20 static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, @@ -354,7 +354,9 @@ static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, in= t s16, TCGCond cond) { TCGv_i64 t0; =20 - check_msa_access(ctx); + if (!check_msa_access(ctx)) { + return false; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -386,7 +388,9 @@ static bool trans_BNZ_V(DisasContext *ctx, arg_msa_bz *= a) =20 static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool i= f_not) { - check_msa_access(ctx); + if (!check_msa_access(ctx)) { + return false; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -2158,7 +2162,9 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) { uint32_t opcode =3D ctx->opcode; =20 - check_msa_access(ctx); + if (!check_msa_access(ctx)) { + return false; + } =20 switch (MASK_MSA_MINOR(opcode)) { case OPC_MSA_I8_00: --=20 2.31.1