From nobody Fri Dec 19 18:42:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025850; cv=none; d=zohomail.com; s=zohoarc; b=C2hVGc1Q428rr1DDdPZGwEmBBzN1xTxugUfZWpAoxayhHlhu1cnLeCm0SrBN30nnmqwlRVETQEvhzqeW+UDSE5qXHoLSfhXoNEstP8JVIs8NLhq20sNCmGkuyhmf7/ivKWDT5Aw5b7RwThs9WLwlHrqqVU7YnSFlFhp5ZkuiBsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025850; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QX0MqgtzyZKOctor19fJypxbHtnwnz4pOB3v/AvZpLk=; b=jUCeYiS9i4VaFhB+jZOVaXgUSc8UON3r/xTgUG9zcr5+qgjfOwJZQVfLTunxqhrQDZy1WxRYy8Y7Ub4/YDcx1t742N9Qzi88vUbtCJhumNIxvpGc8k1gZWJXtnhwlwEhnWygIw6Ll2EJAK6kj+a3BC22d1RoOhv8MS7GFW5A3K8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1635025850643980.6595516245902; Sat, 23 Oct 2021 14:50:50 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id k7so184630wrd.13 for ; Sat, 23 Oct 2021 14:50:49 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id c17sm11722128wmk.23.2021.10.23.14.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QX0MqgtzyZKOctor19fJypxbHtnwnz4pOB3v/AvZpLk=; b=a9WAet9wlHs/m6yUXVfaEv9ZQHmNcINmLCfX2FwCy+oPlBiSWkaVSCIt7dk1NeuD1W LcQW7WIOKgE+4/y8RYJOad9vONB0qjptd8eeDTppAOg7vPlct4et5G17sUNuCoWx97d6 4TxmHr9RYMe1RT0RY6GaaOW+I/lr3r+ixb4kqZEBG3Wl0i/YxYwrNDk/Dp/EsrwojsAD 31O4DoHWixW6QvQOIA5xTocWei7y6IxYpdZhjI0DGn56cJPMUOWccj8UhabsfzxOo05Q VeNTgpfUu5m71rIxZVFVRa+uIuH6lwXSd8gSQ55OJrPZ5jmBdTVu3RKaxtvDPBa95Okl TSPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QX0MqgtzyZKOctor19fJypxbHtnwnz4pOB3v/AvZpLk=; b=rOXsf67ejLfJAawO9Il94ZCjaXkyPhTro/9Fjk6D7W9TIOedYmUpb1pZepnJ7G3dsg j9IJQTJt+A4HXER4t8IdQ4D4w7cLcOyMA9HqrfhN/hDaEjLyQAEyASiQ11zvhLqdfvUc vK1qp9tZbGyPyx/mrcdc3rF9RqGjYXRLH4wZhZ5dASwUpv7KiOnLa9wc3qVqCi0L499+ kj+910zAFoCcjD13benGtzvHosW/FJX5wZkFOfFf/jUvXMIfMYISaPByZBzVJQX7nwAb EBWsfjQ8/22ynAAcIe7XLYM2tKhyek64VFNP3uqGJ70OMOzYQfbqWk6FNpHu2lk9soio YdWQ== X-Gm-Message-State: AOAM532e+Wu73zSQvjBvengAZUC9TWQpIqOzyyYL5SWJPcTCOLM5HYcf 2v7XdUA4Yyke650+jyaYb+w= X-Google-Smtp-Source: ABdhPJzwzbWy4hC6N9VL4jOhne6J1b8w6nWQ24GmtOpZ6a8lxON6prJKBAxJBSU/vKsUHrl36LVyDA== X-Received: by 2002:a05:6000:128f:: with SMTP id f15mr10517415wrx.143.1635025848768; Sat, 23 Oct 2021 14:50:48 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 33/33] target/mips: Adjust style in msa_translate_init() Date: Sat, 23 Oct 2021 23:48:03 +0200 Message-Id: <20211023214803.522078-34-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025851614100001 While the first 'off' variable assignment is unused, it helps to better understand the code logic. Move the assignation where it would have been used so it is easier to compare the MSA registers based on FPU ones versus the MSA specific registers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 5d8cad378e6..d196cad196b 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -80,13 +80,15 @@ void msa_translate_init(void) int i; =20 for (i =3D 0; i < 32; i++) { - int off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]); + int off; =20 /* * The MSA vector registers are mapped on the * scalar floating-point unit (FPU) registers. */ + off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]); msa_wr_d[i * 2] =3D fpu_f64[i]; + off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[1]); msa_wr_d[i * 2 + 1] =3D tcg_global_mem_new_i64(cpu_env, off, msaregnames[i * 2 + 1= ]); --=20 2.31.1