From nobody Fri Dec 19 17:34:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025830; cv=none; d=zohomail.com; s=zohoarc; b=jDvym6xC9FdV7QZcX9n+8SfodQlzKk9ENIZFG8ZIT1uNd3nRZkPW9nfw/eqBFVPDxkbvL+CQoumDh5UYTZwrZbu+IlW4zVsGbIay1YUfpT90u9TIADcw6mqlIPFv0in8A9Q5PjiYvN/lxlZbDkyuT5Qg+rKGsqx7FYXy2UzAdnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025830; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HfZ6rYii68KhWE0NxYMgEJrFZqSlTNn66/qs8YyNLIU=; b=OND0+NfcMHHzRvYT5+lTJs8dw7z8oeubKPIlVU+XpurYynJfKDt6G+eESoa1TKa3oZqIbXR2kVFliY+L+C0GKTloT3wlkPfOSA7oI2HcnV5GMHQjcUfCnCW5XI3rCi5R+/04Bdot2Kpr+usppaDHFuhiR6oX8jzI/fkOyLhdQyM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1635025830974252.5829362072809; Sat, 23 Oct 2021 14:50:30 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id d10so721034wrb.1 for ; Sat, 23 Oct 2021 14:50:30 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id z6sm15392203wmp.1.2021.10.23.14.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HfZ6rYii68KhWE0NxYMgEJrFZqSlTNn66/qs8YyNLIU=; b=b5P2lOaZ7D/lCmlqVKbwkOKW7tKR2tt8DVqF5l9iVps6Bat/Ho1oHlEJhaDC/7/dS1 MlkZNBXEZwNb7caPWXKS+Ag0EkuuCYuw0EzxXBvrtuQA5dJdKzDEmjdFmvr7IKnfL34s dWJ2JmomnAQkrMkkfDj/p5ND5pOCOJ66sTdghF2/nKBasOSA6WjkI6GUNmhJeaQGqON1 8Y54pjhhwroegEZlnaXFXnnNP1reC8Dn4fSF0vMWZsHdDUroL8a2WZlcugoJjR1JaB4u YZlvJvShnLLhdIbSo9d3ERKnFaEWFV/Hu9hkpJ/DM4O7iYkjgJvw8YY36fBfGLsV0zDk /pnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HfZ6rYii68KhWE0NxYMgEJrFZqSlTNn66/qs8YyNLIU=; b=J5QtORMjsngldK+1Yal0VNxLm22O9d46ArIR3T4QTJ0TM6v7D4ul59bYNgJS0fjaFg BqD0zY+NDpDQfDthqhAATnGLHgoi5kteJCcePWX2+wWyInfNCuTIvC7DF2UnThp56xi/ MYjce7jLtquoprYpIjqWdnafCea3a40gzLfa+oO4diDHCylVpZIYBNg6ZAJyBCMnJMQQ O5TknDzo3llMDmSpBkIX1s3Cefwe+9uoCWUPbBOzFW8Oq9TmPIETNYnTV5QLajII3B2g m5Y5Wyoho3btkNZx5x2qSChvhgULBuanCMPAX9F5QI1lVNjX/22FfeDThzyR41nke+8a Udfg== X-Gm-Message-State: AOAM530nMwFuIYiR0zStwZEeCjhoT9l0qQfe6Vgln7v9vdlwWTyOqXx1 HNTy0SVEjn9Gw1rV4HR32Kc= X-Google-Smtp-Source: ABdhPJzHl+dSkHrDEutBsmvOsxRXFXrwBYpTfYv81up4a8FN18pxemoVORvrAM67GePLoSo/MzzUQw== X-Received: by 2002:a05:6000:186a:: with SMTP id d10mr10855818wri.279.1635025829325; Sat, 23 Oct 2021 14:50:29 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 29/33] target/mips: Convert MSA MOVE.V opcode to decodetree Date: Sat, 23 Oct 2021 23:47:59 +0200 Message-Id: <20211023214803.522078-30-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025833063100001 Convert the MOVE.V opcode (Vector Move) to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 6 +++++- target/mips/tcg/msa_translate.c | 26 +++++++++++++++++++++----- 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index dc5e561b9dc..1bde1983de3 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -23,6 +23,7 @@ @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz @elm_df ...... .... df:6 ws:5 wd:5 ...... &msa_elm +@elm ...... .......... ws:5 wd:5 ...... &msa_elm df=3D0 @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @@ -156,7 +157,10 @@ BNZ 010001 111 .. ..... ..............= .. @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df - COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + { + MOVE_V 011110 0010111110 ..... ..... 011001 @elm + COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + } COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df INSERT 011110 0100 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index ff5dbd99f84..b03cde964e0 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -31,7 +31,6 @@ enum { /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, }; =20 static const char msaregnames[][6] =3D { @@ -533,6 +532,26 @@ TRANS_DF_B(HADD_U, trans_msa_3r, gen_helper_ms= a_hadd_u); TRANS_DF_B(HSUB_S, trans_msa_3r, gen_helper_msa_hsub_s); TRANS_DF_B(HSUB_U, trans_msa_3r, gen_helper_msa_hsub_u); =20 +static bool trans_MOVE_V(DisasContext *ctx, arg_msa_elm *a) +{ + TCGv_i32 tsr; + TCGv_i32 tdt; + + if (!check_msa_access(ctx)) { + return false; + } + + tsr =3D tcg_const_i32(a->ws); + tdt =3D tcg_const_i32(a->wd); + + gen_helper_msa_move_v(cpu_env, tdt, tsr); + + tcg_temp_free_i32(tdt); + tcg_temp_free_i32(tsr); + + return true; +} + static void gen_msa_elm_3e(DisasContext *ctx) { #define MASK_MSA_ELM_DF3E(op) (MASK_MSA_MINOR(op) | (op & (0x3FF << 16))) @@ -551,9 +570,6 @@ static void gen_msa_elm_3e(DisasContext *ctx) gen_helper_msa_cfcmsa(telm, cpu_env, tsr); gen_store_gpr(telm, dest); break; - case OPC_MOVE_V: - gen_helper_msa_move_v(cpu_env, tdt, tsr); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -665,7 +681,7 @@ static void gen_msa_elm(DisasContext *ctx) uint8_t dfn =3D (ctx->opcode >> 16) & 0x3f; =20 if (dfn =3D=3D 0x3E) { - /* CTCMSA, CFCMSA, MOVE.V */ + /* CTCMSA, CFCMSA */ gen_msa_elm_3e(ctx); return; } --=20 2.31.1