From nobody Fri Dec 19 16:01:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) client-ip=209.85.221.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025697; cv=none; d=zohomail.com; s=zohoarc; b=Yf9PAo7rErdbjPuv4vvIdweex4j6WtBCrCDScrk9vMIyDEbBWXWuqqoX9ThAaB7HyAd421WR0gzl5Bd2mli7ixC+myHHesJrRNjmsh+GoImEc9yC/Wc+Wxrj0ylpb40rE2Xh+MSWVRjVXSKmKwph+QoZz+jo9WNVCHr2YZ0tPT8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025697; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DuHGHpNNVCydVgJy4KB8F/VCb65x/TwAzNHkrfOZkls=; b=TMIkR0d5NV+qRbmORlM+bp2qA2L/LevUpmrcEK/vg5wjpa/uFcX36fjkpoHvP60nL4t479Z0rFoS5LFbtniopNQI/RqaySZif9XNoQspHLCiAo9CeKiQqjZVqJ9UwmrRf/iu0hrGsErEyu6XSzjBF9y0vdHQRtIU3PjwSzAyScc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.zohomail.com with SMTPS id 1635025697113176.06940184266944; Sat, 23 Oct 2021 14:48:17 -0700 (PDT) Received: by mail-wr1-f48.google.com with SMTP id a16so3564309wrh.12 for ; Sat, 23 Oct 2021 14:48:16 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id z1sm12185003wre.21.2021.10.23.14.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DuHGHpNNVCydVgJy4KB8F/VCb65x/TwAzNHkrfOZkls=; b=qJK+EWorxXcr67O/Yrmp9AqJt2OD364+gHBfaQy1TiijIwUNS4UXc5iqPP7FbpAxaJ nO4k7RjD5+93Oc5VPmJ5RztMLkpPexihTOjGOA12mF+Kpj67q5U0jPa5areyINfGUM+I WCVxky5h45frhZOklZPkkHymJOX+R14t5EnzBtdjpRQrZiha4qukLmDXNMfKtPPNfah7 FAvxVaus2iGkdE4gcN1GiVmufvnzJEa5F+w9n/tLcdxw1Ygx8Oixgj3lzTUow3Cf/Llb DOPDUEDPAQeDrH88Qwjll+OvJU5bBRcOSJ6cwkOhVFR+lqey0Say6D+OnpemCVoBJ0wk Iapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DuHGHpNNVCydVgJy4KB8F/VCb65x/TwAzNHkrfOZkls=; b=izueUAqdosjRu0DMA2LfnhHP2mNDMNCY2iBgG86DRREZMgj8w2V/Ab5Ya183PJ0ci2 rta/TApmQEWlhlWakZtU/a4KTK3Z7dXibKwngI5R/Ax6u9oQTikJZn2woqfP0P6r/Gbc QCS3z5y+vN/nR8GlZ4aV9wupSQ6k58fZ8qj0eyVzh2Uu91zLkxaXuamJgJ7APyOdBzN/ IUvx5eYJpLv9scDw3yac9Qp/OBZsFrha4Z3ep9nufkuZzCRZe63C8OYNCOVK30/BDN1i vWJwn9ITEsapmAUBiotm2WUt800h1ZxrovH+As3qhkaWUfxQP5hBEw1q9NT0OIfDhXH/ K3ig== X-Gm-Message-State: AOAM531YbEJEPHdi+w/4ebXDTqWqIvkBTyehfmSrTkTImTkg+0kVg9v2 UQfbo4/7CTA65a2XBVkKknU= X-Google-Smtp-Source: ABdhPJyixjrvcxo3EjdSUE9JLX+Xpfr1KhQbk2J28z3fjsaXC+0HND8I/LcW73a5KwH3XZccoN57AA== X-Received: by 2002:adf:ed84:: with SMTP id c4mr10572634wro.316.1635025695433; Sat, 23 Oct 2021 14:48:15 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 02/33] target/mips: Fix MSA MADDV.B opcode Date: Sat, 23 Oct 2021 23:47:32 +0200 Message-Id: <20211023214803.522078-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025697927100001 The result of the 'Vector Multiply and Add' opcode is incorrect with Byte vectors. Probably due to a copy/paste error, commit 7a7a162adde mistakenly used the $wt (target register) instead of $wd (destination register) as first operand. Fix that. Cc: Aleksandar Rikalo Fixes: 7a7a162adde ("target/mips: msa: Split helpers for MADDV.") Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa_helper.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index e40c1b70575..d978909527f 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -3231,22 +3231,22 @@ void helper_msa_maddv_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 - pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwt->b[0], pws->b[0], pwt->b[0]= ); - pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwt->b[1], pws->b[1], pwt->b[1]= ); - pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwt->b[2], pws->b[2], pwt->b[2]= ); - pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwt->b[3], pws->b[3], pwt->b[3]= ); - pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwt->b[4], pws->b[4], pwt->b[4]= ); - pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwt->b[5], pws->b[5], pwt->b[5]= ); - pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwt->b[6], pws->b[6], pwt->b[6]= ); - pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwt->b[7], pws->b[7], pwt->b[7]= ); - pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwt->b[8], pws->b[8], pwt->b[8]= ); - pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwt->b[9], pws->b[9], pwt->b[9]= ); - pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwt->b[10], pws->b[10], pwt->b[10= ]); - pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwt->b[11], pws->b[11], pwt->b[11= ]); - pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwt->b[12], pws->b[12], pwt->b[12= ]); - pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwt->b[13], pws->b[13], pwt->b[13= ]); - pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwt->b[14], pws->b[14], pwt->b[14= ]); - pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwt->b[15], pws->b[15], pwt->b[15= ]); + pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwd->b[0], pws->b[0], pwt->b[0]= ); + pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwd->b[1], pws->b[1], pwt->b[1]= ); + pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwd->b[2], pws->b[2], pwt->b[2]= ); + pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwd->b[3], pws->b[3], pwt->b[3]= ); + pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwd->b[4], pws->b[4], pwt->b[4]= ); + pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwd->b[5], pws->b[5], pwt->b[5]= ); + pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwd->b[6], pws->b[6], pwt->b[6]= ); + pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwd->b[7], pws->b[7], pwt->b[7]= ); + pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwd->b[8], pws->b[8], pwt->b[8]= ); + pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwd->b[9], pws->b[9], pwt->b[9]= ); + pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwd->b[10], pws->b[10], pwt->b[10= ]); + pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwd->b[11], pws->b[11], pwt->b[11= ]); + pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwd->b[12], pws->b[12], pwt->b[12= ]); + pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwd->b[13], pws->b[13], pwt->b[13= ]); + pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwd->b[14], pws->b[14], pwt->b[14= ]); + pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwd->b[15], pws->b[15], pwt->b[15= ]); } =20 void helper_msa_maddv_h(CPUMIPSState *env, --=20 2.31.1