From nobody Tue Feb 10 16:43:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025821; cv=none; d=zohomail.com; s=zohoarc; b=d0nUjAYeadbxhKLSCQvCRDdFOX5Cma8hxJtzorTTjFKwclP6AsMUO2C95Q72RN2lxOLFqGAjFY94HPo921BUbVRqJaKDKF9eP6EJRcp6iX5OKPxXXtSjdgWHBAOygYTpfl7w3NS1VQbiRicdddoakq64wC0xZlRn+nE1eCoN8W0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025821; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qDHiAkaJ1MayXxmzfFfuU1YwcKAXMhm8sLiXLX0b59w=; b=Yv34TQTsRfw4Ekqo16jC8NZCThrlPH/SHQPhZsH/HY72EfxAy269Jr7CjC3eCebv/j4DWk9y8j5UGrrvveBYM5I3vcxydlHRbwvTQJDQcx5p3gWvps878BpX7SsxeYmtS6LcpUvZhPspVq6kC9bXs+ttNgSih/58vTOMmp4noic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 1635025821671841.5771161028892; Sat, 23 Oct 2021 14:50:21 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id v17so3526243wrv.9 for ; Sat, 23 Oct 2021 14:50:21 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id 126sm6044486wmz.28.2021.10.23.14.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qDHiAkaJ1MayXxmzfFfuU1YwcKAXMhm8sLiXLX0b59w=; b=bZ1e+UBcAC7eng1B6TS6tCPYnCQzm929hgRmbOTFfnYHC5Bzjr2De+A+AsgGjgTbCL PBFuOjfFSl5Yq8oVSaWE9Sy5mLMm3GzXaSyK3G2a8D3O/7nchDI0ZJN1uNDqv9L6MK8U ZmWjZaj6vZQp+rjPtrE1umpFGqEOaUQRhKvPGf9JitidOSYh+5DEAlJeeALlDlM4XcES SqMlffCu5LTJ7IaXlHiO0wHW564phjTBhKz+YxWFVPLK7oLYvM6c/z9uk7Nc319nXO7H Y8W6am6+FCvVJRji75uVhdRW2B/agbFIV8sFquz7Mq7fHrabUQOHmVUtebHOrey0eQxg +Odg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qDHiAkaJ1MayXxmzfFfuU1YwcKAXMhm8sLiXLX0b59w=; b=AUmiCxeEwUm8t3nceRkWFwMNThe7rg5GfmHm37TYQIZdyPDYU7o97LBS8/ksCz9GGk oZjgZO9FC5QXaI82hIF1AjBizlJj6UmAkaZlYVX2c5dNGxUPV6Qd0RkS+ajXndDO3HXu xLCQ2Mc8PbfF3u21hthRtXVHCnaEx47GkB0qDWrPOLB7GiMXqd+DwZ9w+M4+vHWTxVQ4 iD18jStZe0ee9utla5a1uAjxZbmRLFOmLIFhZSVJLBC28lAWn/f02f+WeQNBzmx9MsaJ 72pKnBtCemifq6PJXp9UHxImFpCDPc6HC7iVJohVKAKFqnHSnHxc5hLJ7/ktcsV5h4iW MEVA== X-Gm-Message-State: AOAM531MulbCp339OWJR7osEx9blHQyD0kSJl2c/f1HzKfIhprvzE9Dl gRRWEaoVzprtJyLIeDxcQDI= X-Google-Smtp-Source: ABdhPJxpj/9uEE2b9gny23sMxoBmadNo7ZQmtnzETbtQw53X6Fiad7p/JRLZd0HOTPQ58gtAk6RNYg== X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr8046579wri.359.1635025819944; Sat, 23 Oct 2021 14:50:19 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 27/33] target/mips: Convert MSA COPY_U opcode to decodetree Date: Sat, 23 Oct 2021 23:47:57 +0200 Message-Id: <20211023214803.522078-28-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025822858100001 Convert the COPY_U opcode (Element Copy to GPR Unsigned) to decodetree. Since the 'n' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa.decode | 1 + target/mips/tcg/msa_translate.c | 90 +++++++++++++++++++++++---------- 2 files changed, 65 insertions(+), 26 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 0f1674cd318..80a06d12746 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -156,6 +156,7 @@ BNZ 010001 111 .. ..... ...............= . @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df + COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df =20 FCAF 011110 0000 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 95dcd4b5b06..e033b365fdd 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -33,7 +33,6 @@ enum { OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_COPY_S_df =3D (0x2 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_COPY_U_df =3D (0x3 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_INSERT_df =3D (0x4 << 22) | (0x00 << 16) | OPC_MSA_ELM, }; =20 @@ -139,6 +138,11 @@ static inline bool check_msa_access(DisasContext *ctx) TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ NULL, gen_func##_h, gen_func##_w, gen_func##_d) =20 +#define TRANS_DF_W64(NAME, trans_func, gen_func) \ + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ + DF_HALF, DF_WORD, \ + gen_func##_b, gen_func##_h, gen_func##_w, NULL) + static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, TCGCond cond) { @@ -591,6 +595,65 @@ TRANS_MSA(SLDI, trans_msa_elm_df, gen_helper_msa_s= ldi_df); TRANS_MSA(SPLATI, trans_msa_elm_df, gen_helper_msa_splati_df); TRANS_MSA(INSVE, trans_msa_elm_df, gen_helper_msa_insve_df); =20 +static bool trans_msa_elm_d64(DisasContext *ctx, arg_msa_elm *a, + enum CPUMIPSMSADataFormat df_max32, + enum CPUMIPSMSADataFormat df_max64, + void (*gen_msa_elm_b)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_elm_h)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_elm_w)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_elm_d)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32)) +{ + TCGv_i32 twd; + TCGv_i32 tws; + TCGv_i32 tn; + uint32_t df, n; + + if (!df_extract(df_elm, a->df, &df, &n)) { + gen_reserved_instruction(ctx); + return true; + } + + if (df > (TARGET_LONG_BITS =3D=3D 64 ? df_max64 : df_max32)) { + gen_reserved_instruction(ctx); + return true; + } + + if (a->wd =3D=3D 0) { + /* Treat as NOP. */ + return true; + } + + twd =3D tcg_const_i32(a->wd); + tws =3D tcg_const_i32(a->ws); + tn =3D tcg_constant_i32(n); + + switch (a->df) { + case DF_BYTE: + gen_msa_elm_b(cpu_env, twd, tws, tn); + break; + case DF_HALF: + gen_msa_elm_h(cpu_env, twd, tws, tn); + break; + case DF_WORD: + gen_msa_elm_w(cpu_env, twd, tws, tn); + break; + case DF_DOUBLE: + g_assert_not_reached(); + break; + } + + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twd); + + return true; +} + +TRANS_DF_W64(COPY_U, trans_msa_elm_d64, gen_helper_msa_copy_u); + static void gen_msa_elm_df(DisasContext *ctx, uint32_t df, uint32_t n) { #define MASK_MSA_ELM(op) (MASK_MSA_MINOR(op) | (op & (0xf << 22))) @@ -603,7 +666,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t = df, uint32_t n) =20 switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_COPY_S_df: - case OPC_COPY_U_df: case OPC_INSERT_df: #if !defined(TARGET_MIPS64) /* Double format valid only for MIPS64 */ @@ -611,11 +673,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t= df, uint32_t n) gen_reserved_instruction(ctx); break; } - if ((MASK_MSA_ELM(ctx->opcode) =3D=3D OPC_COPY_U_df) && - (df =3D=3D DF_WORD)) { - gen_reserved_instruction(ctx); - break; - } #endif switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_COPY_S_df: @@ -634,25 +691,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t= df, uint32_t n) case DF_DOUBLE: gen_helper_msa_copy_s_d(cpu_env, twd, tws, tn); break; -#endif - default: - assert(0); - } - } - break; - case OPC_COPY_U_df: - if (likely(wd !=3D 0)) { - switch (df) { - case DF_BYTE: - gen_helper_msa_copy_u_b(cpu_env, twd, tws, tn); - break; - case DF_HALF: - gen_helper_msa_copy_u_h(cpu_env, twd, tws, tn); - break; -#if defined(TARGET_MIPS64) - case DF_WORD: - gen_helper_msa_copy_u_w(cpu_env, twd, tws, tn); - break; #endif default: assert(0); --=20 2.31.1