From nobody Fri Dec 19 17:34:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025793; cv=none; d=zohomail.com; s=zohoarc; b=AX3hV4FfvB0vcbQg9M9q6YTT/c/TWwi31Ho4rILYMkB/UAisP3lTm9kzFdK0AVMSQrjwkQSxBNlKktHReatkvcvXpkAUqpV61Eb+QJaDPBDSTJKgf6TOfFMs8ctW22dn0CYnPZVicx955UwHjjLGYPQghBO/kb7/31rto1QoT/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025793; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4W4U2ZakVa+VyW3piwFf7vBo1nL6bSIlarNPs7+y7Kw=; b=HzzlCTpozvs8xL3n9Pc60cNYXlFQiNbrXQztHI00pWYwUVBFNxTMC6l71mF1hi38jFYEa9bMsgkJFMOVPGJ2gPHEnbAj9j83cNq07cJGgajQ1R+1+yZ0cWd2CYoIfplrdlV2sHexy5VeJqti1NUGgmIs3C08ltfMVoZ1166usbI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635025793950528.2526845337019; Sat, 23 Oct 2021 14:49:53 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id a16so3568814wrh.12 for ; Sat, 23 Oct 2021 14:49:53 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id s9sm14187283wmj.39.2021.10.23.14.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4W4U2ZakVa+VyW3piwFf7vBo1nL6bSIlarNPs7+y7Kw=; b=VuyV8XslVDeoeSNIxNvKcUvNzL38hEGa91GbyPHVxCIGrJEPGaLzQCZGRJiStd7i/1 ZUehFvm1SEB8BxT8JYVDJkoxfTpZCOWulWQ9WUfkR6QSKAEdy/HtcgEI7rEdPcMugMUC kDIODr/A0FiJKNwenwfvqBk/1xD0MlEAv9zElkqgw4QWw/oj81QFE8uWlltCp/ZrMVC5 3PRTD/zC5zPs1wh23Qb34VKIrmW4cLkZcUqcWd+vt4enHpkfDsRQF2sXwTfYzGZGluu2 AN3Pf4iSp0dRnozzSOx+GNwhP4++ZYkbNB0Fq1qblsPfhPU/j7By9N1ZFCCdE1UPWO0v vUJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4W4U2ZakVa+VyW3piwFf7vBo1nL6bSIlarNPs7+y7Kw=; b=pOF8sFV/2tHX+3LERJwaRh/1g7uciazbYu1GLS43Cx/TfHAaFfVywuLUoVy7YxpQ2G RNUeOxfxq+OlU3ywJVCGVjfGeBlRKd21RCgP5NAqyY15J/kAcFVkdEZqVuaJE3r3JajL 6goHaw7eFDmSkCRpRucu4Qb468gL8WjmIs7oW/UmtoCL5behzmbt872B2HLPo/koP/4y ir751Zu0x60B6Rfs3XT0ytK5kHaqO+hJKxXtfOYqacZ7NNnmeLC94t7QtC1NrCn+fS8k kWzeM9pahYm9SlcQX9n4NF/zAGBFCSookEWT80sM5m1b0a/r8MWnOURnGvpt9d5+sgnV cJXw== X-Gm-Message-State: AOAM532pcvYpc27kRam8i+kHVHqPS+hUzKeR/9ZULTK5JJ35oP9Oq3jE 5kb/XiWHlRH7VRYRfVrNA1Q= X-Google-Smtp-Source: ABdhPJxZbFht8X8DalrfGadgjecRpedjlIg3ms6TTyc3GOpSUBcc5+g6x2PNTXpoA+wW6OEiVxR3ug== X-Received: by 2002:adf:a30c:: with SMTP id c12mr10719166wrb.366.1635025792193; Sat, 23 Oct 2021 14:49:52 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4) Date: Sat, 23 Oct 2021 23:47:52 +0200 Message-Id: <20211023214803.522078-23-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025796122100001 Convert 3-register operations to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 6 ++++++ target/mips/tcg/msa_translate.c | 35 ++++++++++++++++++++++----------- 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 28b7a71d930..ca0fd568560 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -24,6 +24,7 @@ @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 +@3r ...... ... df:2 wt:5 ws:5 wd:5 ...... &msa_r @3rf ...... .... df:1 wt:5 ws:5 wd:5 ...... &msa_r @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @@ -79,6 +80,11 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + SLD 011110 000 .. ..... ..... ..... 010100 @3r + SPLAT 011110 001 .. ..... ..... ..... 010100 @3r + + VSHF 011110 000 .. ..... ..... ..... 010101 @3r + FCAF 011110 0000 . ..... ..... ..... 011010 @3rf FCUN 011110 0001 . ..... ..... ..... 011010 @3rf FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 4543b7abdfb..0c7055c68bd 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -45,15 +45,12 @@ enum { OPC_SUBS_S_df =3D (0x0 << 23) | OPC_MSA_3R_11, OPC_MULV_df =3D (0x0 << 23) | OPC_MSA_3R_12, OPC_DOTP_S_df =3D (0x0 << 23) | OPC_MSA_3R_13, - OPC_SLD_df =3D (0x0 << 23) | OPC_MSA_3R_14, - OPC_VSHF_df =3D (0x0 << 23) | OPC_MSA_3R_15, OPC_SRA_df =3D (0x1 << 23) | OPC_MSA_3R_0D, OPC_SUBV_df =3D (0x1 << 23) | OPC_MSA_3R_0E, OPC_ADDS_A_df =3D (0x1 << 23) | OPC_MSA_3R_10, OPC_SUBS_U_df =3D (0x1 << 23) | OPC_MSA_3R_11, OPC_MADDV_df =3D (0x1 << 23) | OPC_MSA_3R_12, OPC_DOTP_U_df =3D (0x1 << 23) | OPC_MSA_3R_13, - OPC_SPLAT_df =3D (0x1 << 23) | OPC_MSA_3R_14, OPC_SRAR_df =3D (0x1 << 23) | OPC_MSA_3R_15, OPC_SRL_df =3D (0x2 << 23) | OPC_MSA_3R_0D, OPC_MAX_S_df =3D (0x2 << 23) | OPC_MSA_3R_0E, @@ -469,6 +466,29 @@ TRANS_MSA(SAT_U, trans_msa_bit, gen_helper_msa_sat_= u_df); TRANS_MSA(SRARI, trans_msa_bit, gen_helper_msa_srari_df); TRANS_MSA(SRLRI, trans_msa_bit, gen_helper_msa_srlri_df); =20 +static bool trans_msa_3r_df(DisasContext *ctx, arg_msa_r *a, + void (*gen_msa_3r_df)(TCGv_ptr, TCGv_i32, TCGv= _i32, + TCGv_i32, TCGv_i32)) +{ + TCGv_i32 tdf =3D tcg_constant_i32(a->df); + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); + TCGv_i32 twt =3D tcg_const_i32(a->wt); + + gen_msa_3r_df(cpu_env, tdf, twd, tws, twt); + + tcg_temp_free_i32(twd); + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twt); + + return true; +} + +TRANS_MSA(SLD, trans_msa_3r_df, gen_helper_msa_sld_df); +TRANS_MSA(SPLAT, trans_msa_3r_df, gen_helper_msa_splat_df); + +TRANS_MSA(VSHF, trans_msa_3r_df, gen_helper_msa_vshf_df); + static void gen_msa_3r(DisasContext *ctx) { #define MASK_MSA_3R(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) @@ -1219,12 +1239,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SLD_df: - gen_helper_msa_sld_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_VSHF_df: - gen_helper_msa_vshf_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBV_df: switch (df) { case DF_BYTE: @@ -1257,9 +1271,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SPLAT_df: - gen_helper_msa_splat_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBSUS_U_df: switch (df) { case DF_BYTE: --=20 2.31.1