From nobody Fri Dec 19 16:01:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025692; cv=none; d=zohomail.com; s=zohoarc; b=A9MvzYP8tAdJtNKDDywTKZtfqpifXMnz7mGd0bwP+FkOt8cnXMZ9tbZLFiVaSbnFccaxSSD8BDLHSd+ROSILNI/aqRZ5l9IDEGvEgB4+C09y5Xi0sirPvwM5hDmghJ9sQ4lNfqQVSW/qyRY+oqpWCA3fGmU1PVMmIeVgP17u3yE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025692; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=Y/9QtnpeEdEauKN9vBweQYShDHV4KfWyqIAa+8urRtgdGN1dIlgC73WfRxo5Psf/AMIAnwTVzbL3qndsddNicBXJEwvAcIT+X4xYQe3XU0oTfdToEIImVu4N0jUvuhylE6PFhFWWTkKdhN1xnNaHCh1vP0tSlJ5RGwhmR6NMCIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635025692418948.4207496883971; Sat, 23 Oct 2021 14:48:12 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id a16so3564124wrh.12 for ; Sat, 23 Oct 2021 14:48:11 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id s3sm11606358wrm.40.2021.10.23.14.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=g7j/ChCc/LcNFTfAhTouMvq95VT2Z/oE6cC6dPh783oLS+sQ+3v1F3jaD8QfE3rQMm u29yIy9D3i/gjj+wHBs8p2pzW4P5OrC6SAKJ+RrqXwIVGpUtM5hm/0MLCsZq9flxwBjY OCZ0+9gq4k72YJvXQ1D0azTYoGQ4erYCzBdgInpIWOcCT+120gikrDyKidALpJjTpAD3 rXqLpvIo5XT1O7+AgwUpPZT7ETORlgBDgDQA7TeFqT4WT/IIxv+xHmuHpN3ROSOGONTg ilOj6l4E+Jtm19F5YbKO3aNJKTWz/oRHSy1jI1JlaxvK5WoCoMSgoBFT/Ifn+6OdRcoC YzsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=Lw5sKp2yYyqWcIryP2k952W+mtxOe7EAuPBrmbvGCqK0olq+2FQWGefyd1YKn7evYu 4qwJjReRsLwJi1gNlJsPLTUO5d9QVPWGZ+KGIFvs3CalEHR3tg3pyeEM/QC9hWLPk22N reb7/H9MEGormJUrMcmTHvJTkBAuqcFohZwG1VRUI0H15+ycKf4J91EHXwiIeeqL1GgC khiw7cnmNQm7ESaYt8qQAjx+KKTXbN3f/Nm1XR7sNr+9eHk5ABGoCZ6QuwDAG6lL2heb QctXB5ToB6YO0/sABgawTyrRRUPKJ1nffs/DARk8M3CEr0VgFoVyTTLs1mHJnpevHLwY 8Agw== X-Gm-Message-State: AOAM533TfPaIH9L7wNYaZRzPDFGCPpE6YgtSIdgaHLtGcMg9XpAujd2v 3YQL9/JOyhroZ87Xakxz3GE= X-Google-Smtp-Source: ABdhPJygghYsMFNf79bfBq1NQEW0qB01qocNzzfDru+dan/hTivChMGkQG8+JCaUi1zsneKjy+UnGA== X-Received: by 2002:a5d:5229:: with SMTP id i9mr10653560wra.114.1635025690715; Sat, 23 Oct 2021 14:48:10 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 01/33] tests/tcg: Fix some targets default cross compiler path Date: Sat, 23 Oct 2021 23:47:31 +0200 Message-Id: <20211023214803.522078-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025693697100001 We do not want a shell command substitution, but a parameter substitution (with assignment). Replace $() -> ${}, otherwise the expanded command return an empty string and the $cross_cc variable is not set. Fixes: 634ef789f8e ("tests/tcg: add more default compilers to configure.sh") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- tests/tcg/configure.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 1f985ccfc0c..b8574165fa6 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -46,7 +46,7 @@ fi : ${cross_cc_aarch64=3D"aarch64-linux-gnu-gcc"} : ${cross_cc_aarch64_be=3D"$cross_cc_aarch64"} : ${cross_cc_cflags_aarch64_be=3D"-mbig-endian"} -: $(cross_cc_alpha=3D"alpha-linux-gnu-gcc") +: ${cross_cc_alpha=3D"alpha-linux-gnu-gcc"} : ${cross_cc_arm=3D"arm-linux-gnueabihf-gcc"} : ${cross_cc_cflags_armeb=3D"-mbig-endian"} : ${cross_cc_hexagon=3D"hexagon-unknown-linux-musl-clang"} @@ -55,17 +55,17 @@ fi : ${cross_cc_i386=3D"i686-linux-gnu-gcc"} : ${cross_cc_cflags_i386=3D"-m32"} : ${cross_cc_m68k=3D"m68k-linux-gnu-gcc"} -: $(cross_cc_mips64el=3D"mips64el-linux-gnuabi64-gcc") -: $(cross_cc_mips64=3D"mips64-linux-gnuabi64-gcc") -: $(cross_cc_mipsel=3D"mipsel-linux-gnu-gcc") -: $(cross_cc_mips=3D"mips-linux-gnu-gcc") +: ${cross_cc_mips64el=3D"mips64el-linux-gnuabi64-gcc"} +: ${cross_cc_mips64=3D"mips64-linux-gnuabi64-gcc"} +: ${cross_cc_mipsel=3D"mipsel-linux-gnu-gcc"} +: ${cross_cc_mips=3D"mips-linux-gnu-gcc"} : ${cross_cc_ppc=3D"powerpc-linux-gnu-gcc"} : ${cross_cc_cflags_ppc=3D"-m32"} : ${cross_cc_ppc64=3D"powerpc64-linux-gnu-gcc"} : ${cross_cc_ppc64le=3D"powerpc64le-linux-gnu-gcc"} -: $(cross_cc_riscv64=3D"riscv64-linux-gnu-gcc") +: ${cross_cc_riscv64=3D"riscv64-linux-gnu-gcc"} : ${cross_cc_s390x=3D"s390x-linux-gnu-gcc"} -: $(cross_cc_sh4=3D"sh4-linux-gnu-gcc") +: ${cross_cc_sh4=3D"sh4-linux-gnu-gcc"} : ${cross_cc_cflags_sparc=3D"-m32 -mv8plus -mcpu=3Dultrasparc"} : ${cross_cc_sparc64=3D"sparc64-linux-gnu-gcc"} : ${cross_cc_cflags_sparc64=3D"-m64 -mcpu=3Dultrasparc"} --=20 2.31.1