From nobody Fri Dec 19 17:42:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025750; cv=none; d=zohomail.com; s=zohoarc; b=eeyB2QIeAtinOr+A5zIRG9465P1mATFVA6eVm2K+90w1BXnGow8UTuD4xMEJIUj5gAdoxkdQuawXoJJyjPJdYfjo6JT/5O+LyftbXnQzQlmAe6n4/NoARvE4YDtejoIhqgtdyupr62wdUgpxDarGKdNctoGHN7PIwSmBOPJw5hM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025750; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Mg99jYEYPFU2NQRL9WBrBN9xN6wlefBcRoYkXCdFQxc=; b=bupvgta9WPm9QqGpeGFFInzB0C/ynYqQuu0PWrnks6P4pIlQgzyYgovSh0MfhRzmuAz560WXaahr4W+4RqQW0W0WNFFgZX+hmO+ruBAtdxJGyQZoFc3ilfom2dkoJ8GGp5nvOOaZoYndd8S2oi26k56vQ/CblTwfbpHLNRkqf68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1635025750217182.1288282305568; Sat, 23 Oct 2021 14:49:10 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id e12so4785405wra.4 for ; Sat, 23 Oct 2021 14:49:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id i11sm5151354wmg.46.2021.10.23.14.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mg99jYEYPFU2NQRL9WBrBN9xN6wlefBcRoYkXCdFQxc=; b=QXb3Vks6GSLMXMelnDNSuZ2HBCFxm1tlsQo0MyXmWfw9uweWrt9BvAQEAD9PPFMz4j VRX8yVFCypgQ6ijZnRoBdwSjS6aD+/gG4OTgFQRLGA79hezp0TXfWXNS/Qq3TZQ3J88T mdlw0Fls+WGgYs36hOXMZ2MjRCQovWzOxlwiQPsFtgR9QyxbxonVysYKrJi61BJxcwlO 2v2B9TWMXH7etPPfA9DcU55Ww9QgSwmE4bT/RwT3LedzEX3MLYjO1xSO6ISOB/z0jhAb YhlTccR/ypgccYLLr+lxoPZOHyc7YZGsg2mpjfkbLdirvtrHz7TZen/vhMgirB0P4azh hD9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Mg99jYEYPFU2NQRL9WBrBN9xN6wlefBcRoYkXCdFQxc=; b=TZ9TPMu92cgYOD5JsBrsL5RKMXPjqrpWprdYa7T3YRh5QD6SVGy4VXoJVAheRHN6y4 gNaqmGgHcmOEGHUIsT7mba/2FfLzQxx4FaeOTpK8jlwqT+q28V5S9bMcAkzdDL3whl0q Z7h4NKUoyoJJlNLR3imKzT+26xoN74uh/lY04ZAmH6khRzn20mp+vIy2SBqlDgd5dFHq Lx4EdTxfxMaKjwOz1j084RCvDeUJRi0woKRtHM3mFHnMBsg0ANB0hDy0Oyug284fSamq TGx/MpDFTLSVBlLSUWFVZ8WHherpcgyIMnrJGWjC1+3FAc1IkeeXaKzNXv5lNaNgEQYA GTtg== X-Gm-Message-State: AOAM530AovmgBb84dn3dcPrnDXoa/CisA+1yYtUCqcJuYfe4lnKh5uPv +W3+v4k8jmg0OqQ+UrhK468= X-Google-Smtp-Source: ABdhPJzEVebXzGTA7nALnW601D90ykUbN7bh5yARJPoSJYrAPl0t5jnjWc+mDdWvtErSMst3ecy5zg== X-Received: by 2002:a5d:5915:: with SMTP id v21mr10649362wrd.270.1635025748535; Sat, 23 Oct 2021 14:49:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree Date: Sat, 23 Oct 2021 23:47:43 +0200 Message-Id: <20211023214803.522078-14-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025751071100001 Convert the SHF opcode (Immediate Set Shuffle Elements) to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 3 +++ target/mips/tcg/msa_translate.c | 47 +++++++++++++++++++++------------ 2 files changed, 33 insertions(+), 17 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 91d71ff560c..6347468a709 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -22,6 +22,7 @@ @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 +@i8_df ...... df:2 sa:s8 ws:5 wd:5 ...... &msa_ldst @bit ...... ... df:7 ws:5 wd:5 ...... &msa_ldst sa= =3D0 =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa @@ -33,6 +34,8 @@ BZ 010001 110 .. ..... ................ = @bz BNZ 010001 111 .. ..... ................ @bz =20 { + SHF 011110 .. ........ ..... ..... 000010 @i8_df + ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 SUBVI 011110 001 .. ..... ..... ..... 000110 @u5 MAXI_S 011110 010 .. ..... ..... ..... 000110 @s5 diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 10bbe25172a..7cb078bfe92 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -57,13 +57,10 @@ enum { /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, OPC_BMNZI_B =3D (0x0 << 24) | OPC_MSA_I8_01, - OPC_SHF_B =3D (0x0 << 24) | OPC_MSA_I8_02, OPC_ORI_B =3D (0x1 << 24) | OPC_MSA_I8_00, OPC_BMZI_B =3D (0x1 << 24) | OPC_MSA_I8_01, - OPC_SHF_H =3D (0x1 << 24) | OPC_MSA_I8_02, OPC_NORI_B =3D (0x2 << 24) | OPC_MSA_I8_00, OPC_BSELI_B =3D (0x2 << 24) | OPC_MSA_I8_01, - OPC_SHF_W =3D (0x2 << 24) | OPC_MSA_I8_02, OPC_XORI_B =3D (0x3 << 24) | OPC_MSA_I8_00, =20 /* VEC/2R/2RF instruction */ @@ -454,20 +451,6 @@ static void gen_msa_i8(DisasContext *ctx) case OPC_BSELI_B: gen_helper_msa_bseli_b(cpu_env, twd, tws, ti8); break; - case OPC_SHF_B: - case OPC_SHF_H: - case OPC_SHF_W: - { - uint8_t df =3D (ctx->opcode >> 24) & 0x3; - if (df =3D=3D DF_DOUBLE) { - gen_reserved_instruction(ctx); - } else { - TCGv_i32 tdf =3D tcg_const_i32(df); - gen_helper_msa_shf_df(cpu_env, tdf, twd, tws, ti8); - tcg_temp_free_i32(tdf); - } - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -479,6 +462,36 @@ static void gen_msa_i8(DisasContext *ctx) tcg_temp_free_i32(ti8); } =20 +static bool trans_SHF(DisasContext *ctx, arg_msa_ldst *a) +{ + TCGv_i32 tdf; + TCGv_i32 twd; + TCGv_i32 tws; + TCGv_i32 timm; + + if (a->df =3D=3D DF_DOUBLE) { + gen_reserved_instruction(ctx); + return true; + } + + if (!check_msa_access(ctx)) { + return false; + } + + tdf =3D tcg_constant_i32(a->df); + twd =3D tcg_const_i32(a->wd); + tws =3D tcg_const_i32(a->ws); + timm =3D tcg_const_i32(a->sa); + + gen_helper_msa_shf_df(cpu_env, tdf, twd, tws, timm); + + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twd); + tcg_temp_free_i32(timm); + + return true; +} + static bool trans_msa_i5(DisasContext *ctx, arg_msa_ldst *a, void (*gen_msa_i5)(TCGv_ptr, TCGv_i32, TCGv_i32, TCGv_i32, TCGv_i32)) --=20 2.31.1