From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025692; cv=none; d=zohomail.com; s=zohoarc; b=A9MvzYP8tAdJtNKDDywTKZtfqpifXMnz7mGd0bwP+FkOt8cnXMZ9tbZLFiVaSbnFccaxSSD8BDLHSd+ROSILNI/aqRZ5l9IDEGvEgB4+C09y5Xi0sirPvwM5hDmghJ9sQ4lNfqQVSW/qyRY+oqpWCA3fGmU1PVMmIeVgP17u3yE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025692; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=Y/9QtnpeEdEauKN9vBweQYShDHV4KfWyqIAa+8urRtgdGN1dIlgC73WfRxo5Psf/AMIAnwTVzbL3qndsddNicBXJEwvAcIT+X4xYQe3XU0oTfdToEIImVu4N0jUvuhylE6PFhFWWTkKdhN1xnNaHCh1vP0tSlJ5RGwhmR6NMCIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635025692418948.4207496883971; Sat, 23 Oct 2021 14:48:12 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id a16so3564124wrh.12 for ; Sat, 23 Oct 2021 14:48:11 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id s3sm11606358wrm.40.2021.10.23.14.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=g7j/ChCc/LcNFTfAhTouMvq95VT2Z/oE6cC6dPh783oLS+sQ+3v1F3jaD8QfE3rQMm u29yIy9D3i/gjj+wHBs8p2pzW4P5OrC6SAKJ+RrqXwIVGpUtM5hm/0MLCsZq9flxwBjY OCZ0+9gq4k72YJvXQ1D0azTYoGQ4erYCzBdgInpIWOcCT+120gikrDyKidALpJjTpAD3 rXqLpvIo5XT1O7+AgwUpPZT7ETORlgBDgDQA7TeFqT4WT/IIxv+xHmuHpN3ROSOGONTg ilOj6l4E+Jtm19F5YbKO3aNJKTWz/oRHSy1jI1JlaxvK5WoCoMSgoBFT/Ifn+6OdRcoC YzsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=Lw5sKp2yYyqWcIryP2k952W+mtxOe7EAuPBrmbvGCqK0olq+2FQWGefyd1YKn7evYu 4qwJjReRsLwJi1gNlJsPLTUO5d9QVPWGZ+KGIFvs3CalEHR3tg3pyeEM/QC9hWLPk22N reb7/H9MEGormJUrMcmTHvJTkBAuqcFohZwG1VRUI0H15+ycKf4J91EHXwiIeeqL1GgC khiw7cnmNQm7ESaYt8qQAjx+KKTXbN3f/Nm1XR7sNr+9eHk5ABGoCZ6QuwDAG6lL2heb QctXB5ToB6YO0/sABgawTyrRRUPKJ1nffs/DARk8M3CEr0VgFoVyTTLs1mHJnpevHLwY 8Agw== X-Gm-Message-State: AOAM533TfPaIH9L7wNYaZRzPDFGCPpE6YgtSIdgaHLtGcMg9XpAujd2v 3YQL9/JOyhroZ87Xakxz3GE= X-Google-Smtp-Source: ABdhPJygghYsMFNf79bfBq1NQEW0qB01qocNzzfDru+dan/hTivChMGkQG8+JCaUi1zsneKjy+UnGA== X-Received: by 2002:a5d:5229:: with SMTP id i9mr10653560wra.114.1635025690715; Sat, 23 Oct 2021 14:48:10 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 01/33] tests/tcg: Fix some targets default cross compiler path Date: Sat, 23 Oct 2021 23:47:31 +0200 Message-Id: <20211023214803.522078-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025693697100001 We do not want a shell command substitution, but a parameter substitution (with assignment). Replace $() -> ${}, otherwise the expanded command return an empty string and the $cross_cc variable is not set. Fixes: 634ef789f8e ("tests/tcg: add more default compilers to configure.sh") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- tests/tcg/configure.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 1f985ccfc0c..b8574165fa6 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -46,7 +46,7 @@ fi : ${cross_cc_aarch64=3D"aarch64-linux-gnu-gcc"} : ${cross_cc_aarch64_be=3D"$cross_cc_aarch64"} : ${cross_cc_cflags_aarch64_be=3D"-mbig-endian"} -: $(cross_cc_alpha=3D"alpha-linux-gnu-gcc") +: ${cross_cc_alpha=3D"alpha-linux-gnu-gcc"} : ${cross_cc_arm=3D"arm-linux-gnueabihf-gcc"} : ${cross_cc_cflags_armeb=3D"-mbig-endian"} : ${cross_cc_hexagon=3D"hexagon-unknown-linux-musl-clang"} @@ -55,17 +55,17 @@ fi : ${cross_cc_i386=3D"i686-linux-gnu-gcc"} : ${cross_cc_cflags_i386=3D"-m32"} : ${cross_cc_m68k=3D"m68k-linux-gnu-gcc"} -: $(cross_cc_mips64el=3D"mips64el-linux-gnuabi64-gcc") -: $(cross_cc_mips64=3D"mips64-linux-gnuabi64-gcc") -: $(cross_cc_mipsel=3D"mipsel-linux-gnu-gcc") -: $(cross_cc_mips=3D"mips-linux-gnu-gcc") +: ${cross_cc_mips64el=3D"mips64el-linux-gnuabi64-gcc"} +: ${cross_cc_mips64=3D"mips64-linux-gnuabi64-gcc"} +: ${cross_cc_mipsel=3D"mipsel-linux-gnu-gcc"} +: ${cross_cc_mips=3D"mips-linux-gnu-gcc"} : ${cross_cc_ppc=3D"powerpc-linux-gnu-gcc"} : ${cross_cc_cflags_ppc=3D"-m32"} : ${cross_cc_ppc64=3D"powerpc64-linux-gnu-gcc"} : ${cross_cc_ppc64le=3D"powerpc64le-linux-gnu-gcc"} -: $(cross_cc_riscv64=3D"riscv64-linux-gnu-gcc") +: ${cross_cc_riscv64=3D"riscv64-linux-gnu-gcc"} : ${cross_cc_s390x=3D"s390x-linux-gnu-gcc"} -: $(cross_cc_sh4=3D"sh4-linux-gnu-gcc") +: ${cross_cc_sh4=3D"sh4-linux-gnu-gcc"} : ${cross_cc_cflags_sparc=3D"-m32 -mv8plus -mcpu=3Dultrasparc"} : ${cross_cc_sparc64=3D"sparc64-linux-gnu-gcc"} : ${cross_cc_cflags_sparc64=3D"-m64 -mcpu=3Dultrasparc"} --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) client-ip=209.85.221.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025697; cv=none; d=zohomail.com; s=zohoarc; b=Yf9PAo7rErdbjPuv4vvIdweex4j6WtBCrCDScrk9vMIyDEbBWXWuqqoX9ThAaB7HyAd421WR0gzl5Bd2mli7ixC+myHHesJrRNjmsh+GoImEc9yC/Wc+Wxrj0ylpb40rE2Xh+MSWVRjVXSKmKwph+QoZz+jo9WNVCHr2YZ0tPT8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025697; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DuHGHpNNVCydVgJy4KB8F/VCb65x/TwAzNHkrfOZkls=; b=TMIkR0d5NV+qRbmORlM+bp2qA2L/LevUpmrcEK/vg5wjpa/uFcX36fjkpoHvP60nL4t479Z0rFoS5LFbtniopNQI/RqaySZif9XNoQspHLCiAo9CeKiQqjZVqJ9UwmrRf/iu0hrGsErEyu6XSzjBF9y0vdHQRtIU3PjwSzAyScc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.zohomail.com with SMTPS id 1635025697113176.06940184266944; Sat, 23 Oct 2021 14:48:17 -0700 (PDT) Received: by mail-wr1-f48.google.com with SMTP id a16so3564309wrh.12 for ; Sat, 23 Oct 2021 14:48:16 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id z1sm12185003wre.21.2021.10.23.14.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DuHGHpNNVCydVgJy4KB8F/VCb65x/TwAzNHkrfOZkls=; b=qJK+EWorxXcr67O/Yrmp9AqJt2OD364+gHBfaQy1TiijIwUNS4UXc5iqPP7FbpAxaJ nO4k7RjD5+93Oc5VPmJ5RztMLkpPexihTOjGOA12mF+Kpj67q5U0jPa5areyINfGUM+I WCVxky5h45frhZOklZPkkHymJOX+R14t5EnzBtdjpRQrZiha4qukLmDXNMfKtPPNfah7 FAvxVaus2iGkdE4gcN1GiVmufvnzJEa5F+w9n/tLcdxw1Ygx8Oixgj3lzTUow3Cf/Llb DOPDUEDPAQeDrH88Qwjll+OvJU5bBRcOSJ6cwkOhVFR+lqey0Say6D+OnpemCVoBJ0wk Iapg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DuHGHpNNVCydVgJy4KB8F/VCb65x/TwAzNHkrfOZkls=; b=izueUAqdosjRu0DMA2LfnhHP2mNDMNCY2iBgG86DRREZMgj8w2V/Ab5Ya183PJ0ci2 rta/TApmQEWlhlWakZtU/a4KTK3Z7dXibKwngI5R/Ax6u9oQTikJZn2woqfP0P6r/Gbc QCS3z5y+vN/nR8GlZ4aV9wupSQ6k58fZ8qj0eyVzh2Uu91zLkxaXuamJgJ7APyOdBzN/ IUvx5eYJpLv9scDw3yac9Qp/OBZsFrha4Z3ep9nufkuZzCRZe63C8OYNCOVK30/BDN1i vWJwn9ITEsapmAUBiotm2WUt800h1ZxrovH+As3qhkaWUfxQP5hBEw1q9NT0OIfDhXH/ K3ig== X-Gm-Message-State: AOAM531YbEJEPHdi+w/4ebXDTqWqIvkBTyehfmSrTkTImTkg+0kVg9v2 UQfbo4/7CTA65a2XBVkKknU= X-Google-Smtp-Source: ABdhPJyixjrvcxo3EjdSUE9JLX+Xpfr1KhQbk2J28z3fjsaXC+0HND8I/LcW73a5KwH3XZccoN57AA== X-Received: by 2002:adf:ed84:: with SMTP id c4mr10572634wro.316.1635025695433; Sat, 23 Oct 2021 14:48:15 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 02/33] target/mips: Fix MSA MADDV.B opcode Date: Sat, 23 Oct 2021 23:47:32 +0200 Message-Id: <20211023214803.522078-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025697927100001 The result of the 'Vector Multiply and Add' opcode is incorrect with Byte vectors. Probably due to a copy/paste error, commit 7a7a162adde mistakenly used the $wt (target register) instead of $wd (destination register) as first operand. Fix that. Cc: Aleksandar Rikalo Fixes: 7a7a162adde ("target/mips: msa: Split helpers for MADDV.") Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa_helper.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index e40c1b70575..d978909527f 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -3231,22 +3231,22 @@ void helper_msa_maddv_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 - pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwt->b[0], pws->b[0], pwt->b[0]= ); - pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwt->b[1], pws->b[1], pwt->b[1]= ); - pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwt->b[2], pws->b[2], pwt->b[2]= ); - pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwt->b[3], pws->b[3], pwt->b[3]= ); - pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwt->b[4], pws->b[4], pwt->b[4]= ); - pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwt->b[5], pws->b[5], pwt->b[5]= ); - pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwt->b[6], pws->b[6], pwt->b[6]= ); - pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwt->b[7], pws->b[7], pwt->b[7]= ); - pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwt->b[8], pws->b[8], pwt->b[8]= ); - pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwt->b[9], pws->b[9], pwt->b[9]= ); - pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwt->b[10], pws->b[10], pwt->b[10= ]); - pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwt->b[11], pws->b[11], pwt->b[11= ]); - pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwt->b[12], pws->b[12], pwt->b[12= ]); - pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwt->b[13], pws->b[13], pwt->b[13= ]); - pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwt->b[14], pws->b[14], pwt->b[14= ]); - pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwt->b[15], pws->b[15], pwt->b[15= ]); + pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwd->b[0], pws->b[0], pwt->b[0]= ); + pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwd->b[1], pws->b[1], pwt->b[1]= ); + pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwd->b[2], pws->b[2], pwt->b[2]= ); + pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwd->b[3], pws->b[3], pwt->b[3]= ); + pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwd->b[4], pws->b[4], pwt->b[4]= ); + pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwd->b[5], pws->b[5], pwt->b[5]= ); + pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwd->b[6], pws->b[6], pwt->b[6]= ); + pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwd->b[7], pws->b[7], pwt->b[7]= ); + pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwd->b[8], pws->b[8], pwt->b[8]= ); + pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwd->b[9], pws->b[9], pwt->b[9]= ); + pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwd->b[10], pws->b[10], pwt->b[10= ]); + pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwd->b[11], pws->b[11], pwt->b[11= ]); + pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwd->b[12], pws->b[12], pwt->b[12= ]); + pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwd->b[13], pws->b[13], pwt->b[13= ]); + pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwd->b[14], pws->b[14], pwt->b[14= ]); + pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwd->b[15], pws->b[15], pwt->b[15= ]); } =20 void helper_msa_maddv_h(CPUMIPSState *env, --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) client-ip=209.85.221.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025701; cv=none; d=zohomail.com; s=zohoarc; b=KA1cXbEumP8Fpgeqedqb4qopBBzNsyAHc9Te/lDJ3iFHTYkvNIhoTYmdysa3IvGSRftcDsk5pwHPIN88mLeYsjJOoCjwhb98ogBtyXNjuaCKQPTcpoOt8bmeFaUlfjpmEgzxnrShDZprkNxEgmUQDITzedSnCM9kRr2W0XVAf8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025701; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ESYS0poMleep1azLgDHGVOnLpU3H0aYnUxu4xqbADAE=; b=cowsweaaOF/JOtOgL1DK/vF95nzelnlTixmtIU+URBFyI42F+pOfvhdHUKZUkoQ2WPhSF41I9vNo5163IIsneyMXpsc6uxAGhRsPr/spVEK3VwM1OO7aIWW/BBkGgP/Dx/NAAN6DKcfiw96ZzYcHO1JNrlBdfDXOG0l7hp3CZ0A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.zohomail.com with SMTPS id 1635025701879432.3535779540334; Sat, 23 Oct 2021 14:48:21 -0700 (PDT) Received: by mail-wr1-f49.google.com with SMTP id m22so1501269wrb.0 for ; Sat, 23 Oct 2021 14:48:21 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id i24sm12149284wml.26.2021.10.23.14.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ESYS0poMleep1azLgDHGVOnLpU3H0aYnUxu4xqbADAE=; b=eeRGTvYiLVUQBQwaBsv1nwKirk4JApCJTeOI0Vy9NkMURsFjlup8/ddm/qTId6g89u PBtFAx17IpO9VOSvOVQcLulTx+zmKaA6Kf4H1JwKd3S0MQxu/NxXLJK28B6CgEqeKfov DuQqmuaiMx99iAZbd2eG/i5L94z1yvvltvJBVCMOTyleCl6LDCBBPlDECyenE5LpRf5t Sw2ZW0iSaQayWSdnxIesFfMO82EE7qS9qQyyRnLhbh/xdTiNC0Wws+aumZx8i/n0/asV EHifblfNJRf0DYl3IRY45gifdoBn+1bIUa9Jsxq2tNNBzPhuqv6a9qhcgYKZph4/5e2C WCTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ESYS0poMleep1azLgDHGVOnLpU3H0aYnUxu4xqbADAE=; b=a6mCDij6hqtYtIEdClmwHYAPBPVwG/gsnDWLLixWWIL/6xHCY3u3KRNhPlirq777lt a6lxa3h496eZHeX4MBIcYVodhscMnCNlvvHBi3gvvrR1Zwy4rv4KWhozdOE8A6KrbS2m wGnFBQ4P2Ioo77gmt5SrcSs+YaKhhCMTeT1y64BrPj5vHW3E0sC/qDErtnlKnMcJVaiv aKOxy4o7Stnba28AZD+tAXc9IK5TM0gVFH30hJVwsaqYuAS7tIjMghxBKV22lE0ynKRr WnL1QO7+qqcoHv7eMaix2nXRz+sxrJRnKjhSOAQ+GqJq5Ukx4cheT7lIgIORrzsX+ilF Yjaw== X-Gm-Message-State: AOAM533a9OlP2MFRQLsd19ygLlxJ+LKrydeo1dtVDJmYDcnHWgLqa6zF YLtkwUTZrfVvypJr9RIAjmI= X-Google-Smtp-Source: ABdhPJxMLb0bk8X7vnDJil1qbPe8qpNDynHZc/eUU65lvlfe8OPIFZ0v2mKSv1cWr12YTZGS/ykpZg== X-Received: by 2002:a5d:514c:: with SMTP id u12mr103304wrt.144.1635025700209; Sat, 23 Oct 2021 14:48:20 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 03/33] target/mips: Fix MSA MSUBV.B opcode Date: Sat, 23 Oct 2021 23:47:33 +0200 Message-Id: <20211023214803.522078-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025704085100001 The result of the 'Vector Multiply and Subtract' opcode is incorrect with Byte vectors. Probably due to a copy/paste error, commit 5f148a02327 mistakenly used the $wt (target register) instead of $wd (destination register) as first operand. Fix that. Cc: Aleksandar Rikalo Fixes: 5f148a02327 ("target/mips: msa: Split helpers for MSUBV.") Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa_helper.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index d978909527f..5667b1f0a15 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -3303,22 +3303,22 @@ void helper_msa_msubv_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 - pwd->b[0] =3D msa_msubv_df(DF_BYTE, pwt->b[0], pws->b[0], pwt->b[0]= ); - pwd->b[1] =3D msa_msubv_df(DF_BYTE, pwt->b[1], pws->b[1], pwt->b[1]= ); - pwd->b[2] =3D msa_msubv_df(DF_BYTE, pwt->b[2], pws->b[2], pwt->b[2]= ); - pwd->b[3] =3D msa_msubv_df(DF_BYTE, pwt->b[3], pws->b[3], pwt->b[3]= ); - pwd->b[4] =3D msa_msubv_df(DF_BYTE, pwt->b[4], pws->b[4], pwt->b[4]= ); - pwd->b[5] =3D msa_msubv_df(DF_BYTE, pwt->b[5], pws->b[5], pwt->b[5]= ); - pwd->b[6] =3D msa_msubv_df(DF_BYTE, pwt->b[6], pws->b[6], pwt->b[6]= ); - pwd->b[7] =3D msa_msubv_df(DF_BYTE, pwt->b[7], pws->b[7], pwt->b[7]= ); - pwd->b[8] =3D msa_msubv_df(DF_BYTE, pwt->b[8], pws->b[8], pwt->b[8]= ); - pwd->b[9] =3D msa_msubv_df(DF_BYTE, pwt->b[9], pws->b[9], pwt->b[9]= ); - pwd->b[10] =3D msa_msubv_df(DF_BYTE, pwt->b[10], pws->b[10], pwt->b[10= ]); - pwd->b[11] =3D msa_msubv_df(DF_BYTE, pwt->b[11], pws->b[11], pwt->b[11= ]); - pwd->b[12] =3D msa_msubv_df(DF_BYTE, pwt->b[12], pws->b[12], pwt->b[12= ]); - pwd->b[13] =3D msa_msubv_df(DF_BYTE, pwt->b[13], pws->b[13], pwt->b[13= ]); - pwd->b[14] =3D msa_msubv_df(DF_BYTE, pwt->b[14], pws->b[14], pwt->b[14= ]); - pwd->b[15] =3D msa_msubv_df(DF_BYTE, pwt->b[15], pws->b[15], pwt->b[15= ]); + pwd->b[0] =3D msa_msubv_df(DF_BYTE, pwd->b[0], pws->b[0], pwt->b[0]= ); + pwd->b[1] =3D msa_msubv_df(DF_BYTE, pwd->b[1], pws->b[1], pwt->b[1]= ); + pwd->b[2] =3D msa_msubv_df(DF_BYTE, pwd->b[2], pws->b[2], pwt->b[2]= ); + pwd->b[3] =3D msa_msubv_df(DF_BYTE, pwd->b[3], pws->b[3], pwt->b[3]= ); + pwd->b[4] =3D msa_msubv_df(DF_BYTE, pwd->b[4], pws->b[4], pwt->b[4]= ); + pwd->b[5] =3D msa_msubv_df(DF_BYTE, pwd->b[5], pws->b[5], pwt->b[5]= ); + pwd->b[6] =3D msa_msubv_df(DF_BYTE, pwd->b[6], pws->b[6], pwt->b[6]= ); + pwd->b[7] =3D msa_msubv_df(DF_BYTE, pwd->b[7], pws->b[7], pwt->b[7]= ); + pwd->b[8] =3D msa_msubv_df(DF_BYTE, pwd->b[8], pws->b[8], pwt->b[8]= ); + pwd->b[9] =3D msa_msubv_df(DF_BYTE, pwd->b[9], pws->b[9], pwt->b[9]= ); + pwd->b[10] =3D msa_msubv_df(DF_BYTE, pwd->b[10], pws->b[10], pwt->b[10= ]); + pwd->b[11] =3D msa_msubv_df(DF_BYTE, pwd->b[11], pws->b[11], pwt->b[11= ]); + pwd->b[12] =3D msa_msubv_df(DF_BYTE, pwd->b[12], pws->b[12], pwt->b[12= ]); + pwd->b[13] =3D msa_msubv_df(DF_BYTE, pwd->b[13], pws->b[13], pwt->b[13= ]); + pwd->b[14] =3D msa_msubv_df(DF_BYTE, pwd->b[14], pws->b[14], pwt->b[14= ]); + pwd->b[15] =3D msa_msubv_df(DF_BYTE, pwd->b[15], pws->b[15], pwt->b[15= ]); } =20 void helper_msa_msubv_h(CPUMIPSState *env, --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025706; cv=none; d=zohomail.com; s=zohoarc; b=mOj6xQloY3p1D3BCQR3NIRvl2ELxTaTiVIjELedQh+gugBQ79yIWzfiTT0X9sLN6dUUoS7uxXWF9FHGuZqISZzOpaPtipmUPEDIDGMKzsullY47nwKA1XrdxmL49GW4mAd6/sfPDy/+8bN6jDyChbJKobpCZbs5ZSrB0L2RQGis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025706; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PaHjQTT6bAAmhFELO4JrHHj9/5ukp2x4qgAluVj1msY=; b=OhQVA9DUTbI0pTlztqaSCRadwzWV5xvVdYsKdi6GTxZGKRtZ+xnaS2t2ZqrKB45CnPyH9vF7tjciskBoOOTDRNib5OwL3FdoWV6e2bxjsJVFb5ihLGcO72ve41sk9zQTOgYjIvD0qx0XwjguiIP2ocX3hkD9KSW58OAVOXfCo+g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1635025706549191.30553790064027; Sat, 23 Oct 2021 14:48:26 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id d3so628717wrh.8 for ; Sat, 23 Oct 2021 14:48:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id t11sm11509355wrz.65.2021.10.23.14.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PaHjQTT6bAAmhFELO4JrHHj9/5ukp2x4qgAluVj1msY=; b=d4tusU++8M3s+/L4hYgW+Wvj0NdENZG8iFierInblO1toh8ASjvilhBlQJBzMZ7X/5 zFYIPkgohr+8EzKynY5qh7/Tm3viFwCmnpfjjh36G5KvrklTZrlZ1eihBEHToFReJ/4I yxGbTxmgx0BduxONuYLtyry08EeON/0Qh+Un2cRrEnR8bwmU/S8159tt25XUVbZ3X0eY 4aM++ShpIvdYt2R1GkMI8imX4BiblSXL3lpt/tqMQV2zYzGjHXLTykwKmxj9FgvSvNJW TkD5cGxr31DvXnzOpm3ctJRy814kVsqD9rp5CPizWN/jf73gtZzbCQkMbcOtnK626fe+ JIcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=PaHjQTT6bAAmhFELO4JrHHj9/5ukp2x4qgAluVj1msY=; b=GAiMGWEpfstlhdlXWZQDen5X/ssnfcX9VVGhObwpRHA7NUS1LvFbfx5qHqgf2AIUPS eGsLhDLTmGnqxuc8pVbUQ310Q8H70SGaVJnpEamIdKUXHsSaeTda/WY9sCdp6HWmJ8bH ybUnNbsOm2168VF2tKtXtUImV8pn5RvpVU7xnjOpGgd9tXi6L8DnWve6SczKoig0Tvo7 P7NchLuaHfTdZWp+Nk+Bj/76vad9W8XSvxYrxmLmTvBFGPXhL38pr+Y/HEjulI60YMPI ccEkOAaCZlkM+tSd9s2m7QdU6l6Gf85V+kVMolK0IUknuwLSaFrb4dosdfE3WIqjBQ6U ztYQ== X-Gm-Message-State: AOAM531Udr7k+9mPdGIJn/Bk+4o4TgZaazNIOPhLgaxZqSjaghwLVhIU myzn6lOS6haZkfTYiFJI2Rw= X-Google-Smtp-Source: ABdhPJzAOpPyHnayxM4LueypYP5M9j4k1tmYItr/BpO44Aq+o2h13h72UOOsdLWrfo02i06BheHWrA== X-Received: by 2002:adf:a30c:: with SMTP id c12mr10711111wrb.366.1635025704829; Sat, 23 Oct 2021 14:48:24 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 04/33] tests/tcg/mips: Run MSA opcodes tests on user-mode emulation Date: Sat, 23 Oct 2021 23:47:34 +0200 Message-Id: <20211023214803.522078-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025708053100001 The following commits added various user-mode tests for various MSA instructions: - 0fdd986a6c8 ("Add tests for MSA integer add instructions") - 1be82d89011 ("Add tests for MSA integer average instructions") - 1d336c87a3c ("Add tests for MSA bit set instructions") - 1e6bea794c8 ("Add tests for MSA integer max/min instructions") - 2a367db039f ("Add tests for MSA pack instructions") - 3d9569b8550 ("Add tests for MSA move instructions") - 4b302ce90db ("Add tests for MSA integer multiply instructions") - 520e210c0aa ("Add tests for MSA integer compare instructions") - 53e116fed6d ("Add tests for MSA integer subtract instructions") - 666952ea7c1 ("Add tests for MSA bit move instructions") - 72f463bc080 ("Add tests for MSA integer divide instructions") - 8598f5fac1c ("Add tests for MSA FP max/min instructions") - 99d423e576a ("Add tests for MSA shift instructions") - a8f91dd9fd0 ("Add tests for MSA integer dot product instructions") - b62592ab655 ("Add tests for MSA bit counting instructions") - ba632924450 ("Add tests for MSA logic instructions") - fc76f486677 ("Add tests for MSA interleave instructions") Cover them in the buildsys machinery so they are run automatically when calling 'make check-tcg'. Start running them on the mips64el target. Cc: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- tests/tcg/mips/ase-msa.mak | 30 ++++++++++++++++++++++++++++++ MAINTAINERS | 1 + tests/tcg/mips/Makefile.target | 5 +++++ tests/tcg/mips64/Makefile.target | 9 +++++++++ tests/tcg/mips64el/Makefile.target | 12 ++++++++++++ tests/tcg/mipsel/Makefile.target | 9 +++++++++ 6 files changed, 66 insertions(+) create mode 100644 tests/tcg/mips/ase-msa.mak create mode 100644 tests/tcg/mips64/Makefile.target create mode 100644 tests/tcg/mips64el/Makefile.target create mode 100644 tests/tcg/mipsel/Makefile.target diff --git a/tests/tcg/mips/ase-msa.mak b/tests/tcg/mips/ase-msa.mak new file mode 100644 index 00000000000..be1ba967a5b --- /dev/null +++ b/tests/tcg/mips/ase-msa.mak @@ -0,0 +1,30 @@ +# -*- Mode: makefile -*- +# +# MIPS MSA specific TCG tests +# +# Copyright (c) 2021 Philippe Mathieu-Daud=C3=A9 +# +# SPDX-License-Identifier: GPL-2.0-or-later + +MSA_DIR =3D $(SRC_PATH)/tests/tcg/mips/user/ase/msa + +MSA_TEST_CLASS =3D bit-count bit-move bit-set fixed-multiply \ + float-max-min int-add int-average int-compare int-divide \ + int-dot-product interleave int-max-min int-modulo \ + int-multiply int-subtract logic move pack shift + +MSA_TEST_SRCS =3D $(foreach class,$(MSA_TEST_CLASS),$(wildcard $(MSA_DIR)/= $(class)/*.c)) + +MSA_TESTS =3D $(patsubst %.c,%,$(notdir $(MSA_TEST_SRCS))) + +$(MSA_TESTS): CFLAGS+=3D-mmsa $(MSA_CFLAGS) +$(MSA_TESTS): %: $(foreach CLASS,$(MSA_TEST_CLASS),$(wildcard $(MSA_DIR)/$= (CLASS)/%.c)) + $(CC) -static $(CFLAGS) -o $@ \ + $(foreach CLASS,$(MSA_TEST_CLASS),$(wildcard $(MSA_DIR)/$(CLASS)/$@.c)) + +$(foreach test,$(MSA_TESTS),run-$(test)): QEMU_OPTS +=3D -cpu $(MSA_CPU) + +# FIXME: These tests fail when using plugins +ifneq ($(CONFIG_PLUGIN),y) +TESTS +=3D $(MSA_TESTS) +endif diff --git a/MAINTAINERS b/MAINTAINERS index 4e77d03651b..53c6c549b80 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3111,6 +3111,7 @@ R: Jiaxun Yang R: Aleksandar Rikalo S: Odd Fixes F: tcg/mips/ +F: tests/tcg/mips* =20 PPC TCG target M: Richard Henderson diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target index 1a994d5525e..191fe179119 100644 --- a/tests/tcg/mips/Makefile.target +++ b/tests/tcg/mips/Makefile.target @@ -17,3 +17,8 @@ TESTS +=3D $(MIPS_TESTS) hello-mips: CFLAGS+=3D-mno-abicalls -fno-PIC -mabi=3D32 hello-mips: LDFLAGS+=3D-nostdlib endif + +# FIXME enable MSA tests +#MSA_CFLAGS=3D-march=3Dmips64r5 -mnan=3D2008 +#MSA_CPU=3DP5600 +#include $(SRC_PATH)/tests/tcg/mips/ase-msa.mak diff --git a/tests/tcg/mips64/Makefile.target b/tests/tcg/mips64/Makefile.t= arget new file mode 100644 index 00000000000..d876b92f219 --- /dev/null +++ b/tests/tcg/mips64/Makefile.target @@ -0,0 +1,9 @@ +# -*- Mode: makefile -*- +# +# mips64el specific TCG tests +# +# Copyright (c) 2021 Philippe Mathieu-Daud=C3=A9 +# +# SPDX-License-Identifier: GPL-2.0-or-later + +# 64-bit MSA is tested on little-endian target diff --git a/tests/tcg/mips64el/Makefile.target b/tests/tcg/mips64el/Makefi= le.target new file mode 100644 index 00000000000..87c0d6dce18 --- /dev/null +++ b/tests/tcg/mips64el/Makefile.target @@ -0,0 +1,12 @@ +# -*- Mode: makefile -*- +# +# mips64el specific TCG tests +# +# Copyright (c) 2021 Philippe Mathieu-Daud=C3=A9 +# +# SPDX-License-Identifier: GPL-2.0-or-later + +# MSA +MSA_CFLAGS=3D-march=3Dmips64r5 -mnan=3Dlegacy +MSA_CPU=3DLoongson-3A4000 +include $(SRC_PATH)/tests/tcg/mips/ase-msa.mak diff --git a/tests/tcg/mipsel/Makefile.target b/tests/tcg/mipsel/Makefile.t= arget new file mode 100644 index 00000000000..c8acacb4497 --- /dev/null +++ b/tests/tcg/mipsel/Makefile.target @@ -0,0 +1,9 @@ +# -*- Mode: makefile -*- +# +# mipsel specific TCG tests +# +# Copyright (c) 2021 Philippe Mathieu-Daud=C3=A9 +# +# SPDX-License-Identifier: GPL-2.0-or-later + +# 32-bit MSA is tested on big-endian target --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025711; cv=none; d=zohomail.com; s=zohoarc; b=aYHE4/yGC4srYmC0eptOeHNYTnomG1/MAYzgzXKw2TEEIX3Y8VeOmnUofu6TiEllWSSizXyDU8IrDDvBhCq+74cKoz/AfC+OlIDVU9JhDICEtXBI+WaBO+QJDVWTkpIaqOsqiQ1KpIAdm/glsASJunol0ZZCViS3yEv4OX9VQEA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025711; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qpC85BtT3RgnbykCXVzDyO1CuhDm3xChbP8VfA4crRw=; b=fm5MdJferPLRcftIrZO90KCXbN4BC/N2zjvBuP908OJmC5FL1JVtmPqpsKvkhajPTIgzczIhYyOaDtaLeHhRb5kbD/VWp3hqrRkovVRL1R+DJd0CRx9xReI1x+/uhbANwjIJe7OxLBJn8vuF79KBLrUVbEw5X/CLsGrOrfgmpIM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635025711601886.1611714452592; Sat, 23 Oct 2021 14:48:31 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id u18so1391029wrg.5 for ; Sat, 23 Oct 2021 14:48:31 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id o10sm12996960wmq.46.2021.10.23.14.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qpC85BtT3RgnbykCXVzDyO1CuhDm3xChbP8VfA4crRw=; b=HOGkbCqehWu0/fWcBYvuPsDx0nzee8arZGA1+R3W7hRZs70OFMuJmaG61va9C0hitT 9hRCZckvDEGkgDkwSMxs79pJQ5v95Iu9M9kSoSGIx1sZ6eHhS1NehFJtGav1eFwd2SEn GN7yjNwCeI1Pf588p2H/7j+w+DL9Roc+Xz9VRUy2AzYa9Ts2yOIl4mwb1WbVVs8xjhCK znTj4Psjk3WWeWUBeWpEUQ6t7hwaJiRfPyplVrFHLBjFObAPIoApo+2KdXzCGZRtXALz tG4+qxICGNwOfawEF3xheMyfJcZU0FkLIiGHDchEG8JeL/T3c63s9UPRQM91/MpKSwvd N69g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qpC85BtT3RgnbykCXVzDyO1CuhDm3xChbP8VfA4crRw=; b=PBYrH61VWoPuRIf56cVgK6ZKEE3s92zhIqIuyhcyDniWyMF8MiBLyTb4lVR11wsSXx +vzo8F5VH9FFVsK/buGWMLRIri3iebSbeI3PicdN1qdHrOVm/x+ehImuKE83vQnJs2WP CiDsOs4HkahyvnjbeAkrCJNYDhS78nRcbHULJowVYAKCcghw5tTXmaOtin9BuuQ39jqh CmzkY5lO9gNGEgUhWUBZmVl9B3Jg1sxpj72ctL+Xq3ZrfSxrYX7EYevtD9KHixhFh8vd kw5jCrUbn4+fXeq7dTiJwk8kth8kOKeYRtkHMY6GmJio630FJ3M/jCNVyJrOHxytytjV fPYA== X-Gm-Message-State: AOAM533zYJSmu0OLx9C3ogx9MUCuovpDdstjp5LIz0J964V30MFjQUI+ MYic2eFJ7YGUkTCfgUhvpI0= X-Google-Smtp-Source: ABdhPJxG3BQNeXCzCm6iEuG7LbOJOHJ7uaI1f+fA4opBvNGvuA8GJ78yeyoZ5JGoMI1szs2KrMExew== X-Received: by 2002:adf:fd8a:: with SMTP id d10mr10407145wrr.213.1635025709911; Sat, 23 Oct 2021 14:48:29 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 05/33] target/mips: Have check_msa_access() return a boolean Date: Sat, 23 Oct 2021 23:47:35 +0200 Message-Id: <20211023214803.522078-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025712088100001 Have check_msa_access() return a boolean value so we can return early if MSA is not enabled. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa_translate.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 3ef912da6b8..9e0a08fe335 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -293,19 +293,19 @@ void msa_translate_init(void) } } =20 -static inline int check_msa_access(DisasContext *ctx) +static inline bool check_msa_access(DisasContext *ctx) { if (unlikely((ctx->hflags & MIPS_HFLAG_FPU) && !(ctx->hflags & MIPS_HFLAG_F64))) { gen_reserved_instruction(ctx); - return 0; + return false; } =20 if (unlikely(!(ctx->hflags & MIPS_HFLAG_MSA))) { generate_exception_end(ctx, EXCP_MSADIS); - return 0; + return false; } - return 1; + return true; } =20 static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, @@ -354,7 +354,9 @@ static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, in= t s16, TCGCond cond) { TCGv_i64 t0; =20 - check_msa_access(ctx); + if (!check_msa_access(ctx)) { + return false; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -386,7 +388,9 @@ static bool trans_BNZ_V(DisasContext *ctx, arg_msa_bz *= a) =20 static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool i= f_not) { - check_msa_access(ctx); + if (!check_msa_access(ctx)) { + return false; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -2158,7 +2162,9 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) { uint32_t opcode =3D ctx->opcode; =20 - check_msa_access(ctx); + if (!check_msa_access(ctx)) { + return false; + } =20 switch (MASK_MSA_MINOR(opcode)) { case OPC_MSA_I8_00: --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) client-ip=209.85.128.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025716; cv=none; d=zohomail.com; s=zohoarc; b=dRJGck0uJ89Bnb5YQsoTRdbnEh4636MQSubzy/9+knwWD8konKpPO1gTxXlIGIJWhBQLasHmnOLhXldbBiYw+eBJNrBdGJBe/2qSSlg1gFbkw0J7KWyOPhu16fEMB8ov3NvBIRKQLogSL5HQj5qhE8MiS/SPEJfa3AGwr6KWR/8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025716; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tM4MJo3sim3ey0DXA4OE2hR4tKFsgTw872VtuFCw7eA=; b=Y2vNc30+sUHY8xq2kf+0XSNS6op/FKipqS4+QibfsFyUrYT/pANCqtSmq8hXV9nJyvsVloKWrsRHYvfEdnLk6QILY0VmV9Z7Si+6GH8KQaDcjpvG9mg02exqiNoEmd0Iw/X7aY1MN3Ki5JKkyo7wtnx360JxnGQ9CQ7nGwF/8QI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.zohomail.com with SMTPS id 1635025716655484.598916785552; Sat, 23 Oct 2021 14:48:36 -0700 (PDT) Received: by mail-wm1-f43.google.com with SMTP id a20-20020a1c7f14000000b003231d13ee3cso8251144wmd.3 for ; Sat, 23 Oct 2021 14:48:36 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id j7sm15354133wmq.32.2021.10.23.14.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tM4MJo3sim3ey0DXA4OE2hR4tKFsgTw872VtuFCw7eA=; b=bflYF1tF+4PFskwz+8rX8hBFsLGMYy2h0U4QaijKiHYPXjixIYCwSJcvO5vDKrPSip oIVPISCsxsFcmskXoF4TM6NVP2K5RXvXvl1tiYfqSESH1rPRoRtaO3cqgrK8cdDhU2a9 pc3mU8HKygILMJiIXjNvfNSdrMkoP4/MSAo8qx64cDG+h6jUJbX2mPWZZPGvIyr0Eg9o qJzwA+ZtqzEXxC+h7w4EzTPyJaVXu3/HRwTZynM+TuGqhVLqnP2bl2Mhg9Jq/cp/UWFD TxBrX5HovbNfWlgs5YGgT5KeEftW3rTQABudAguDrzZELIU7bjsmrmj2Zokm/9OSMz0U 9XKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=tM4MJo3sim3ey0DXA4OE2hR4tKFsgTw872VtuFCw7eA=; b=l4y7gs6OIglee1XfHhd4fCK49rpiud/vR6+Qb7PoC0gaILZgduWmEcyUH5AkBE6TlY mNkCDwm2jxU/cTtZrfAZikI+h3aBi8DtpsMnFIXlQJ20hx6g5K5+kiM4oCr6nEfWvqr2 /wgbyMFovIbVTNqeStoxSGQv4KIqkWt1GjB0BQDZIX78ZwcdIrgrtQKqxIh59utgaNEF p6H/hugBG+IfpjmA68HEe0PG7v8EYG0+UaBUY5VrxBUYN/uk6XtXqxWQDLS17HUL0gwy axKTZfDttcENUYIf+GeXVIguL/adRWUcsJt3ulTd3ro4hxSaYv50JcnO62HvPU+An/Fm 817g== X-Gm-Message-State: AOAM5334VJyQ2SrwHyZ+x8zBGxVPGgJz/wcn6tHQFLqkA71pEuQGz0uf iEHMeuCjRHZVmKejcwA7q3s= X-Google-Smtp-Source: ABdhPJxht9QSdJHaeqrhEumTPCfKMXya4qVegwBNU8untG18nmDdOH4a8m0t0ltvRUO3GRKBkXGixw== X-Received: by 2002:a05:600c:1c21:: with SMTP id j33mr38522157wms.163.1635025714920; Sat, 23 Oct 2021 14:48:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 06/33] target/mips: Use enum definitions from CPUMIPSMSADataFormat enum Date: Sat, 23 Oct 2021 23:47:36 +0200 Message-Id: <20211023214803.522078-7-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025718283100001 Replace magic DataFormat value by the corresponding enum from CPUMIPSMSADataFormat. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 9e0a08fe335..1c4a802ff55 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1801,10 +1801,10 @@ static void gen_msa_3rf(DisasContext *ctx) case OPC_MULR_Q_df: case OPC_MADDR_Q_df: case OPC_MSUBR_Q_df: - tdf =3D tcg_constant_i32(df + 1); + tdf =3D tcg_constant_i32(DF_HALF + df); break; default: - tdf =3D tcg_constant_i32(df + 2); + tdf =3D tcg_constant_i32(DF_WORD + df); break; } =20 @@ -2033,7 +2033,7 @@ static void gen_msa_2rf(DisasContext *ctx) TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); /* adjust df value for floating-point instruction */ - TCGv_i32 tdf =3D tcg_constant_i32(df + 2); + TCGv_i32 tdf =3D tcg_constant_i32(DF_WORD + df); =20 switch (MASK_MSA_2RF(ctx->opcode)) { case OPC_FCLASS_df: --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025721; cv=none; d=zohomail.com; s=zohoarc; b=jMKbvl7B68lv9R66vassFTUF/VIenWQXM7dKjp8DAkEL2zVVdIpsPtuLmwQg1R19q+bAIoPQz8Tyb0Xyb0HZoedmsDDP0/oXRmhWalzl6wWZ5tm+9hx2WzJFHw9S0a2IIb+n0p3OVBz5AGtqBsakzRRm2is5VfojTJjEkZ6llg4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025721; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eWXKGvZTAb9QLzPIeZwjUz2cD0/0h0fiCLpbOFXLOpg=; b=LlsQM3BpJRgQUdSmFx2gKRUCUZjOFDdQ+0jIbEpSDV8U3V2w6YQtM7Ur4no9A4dF90KY6ACMDvoEH5OkrfT2cB/azNfnekUSfvmt2liIWTp1Xl7KT0m/r9nNmTMZhB2iXDyYpGd4RgMSqv+5SfRW+d19djp/uKOUsyZ/OYFSd+o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1635025721594250.1331888125669; Sat, 23 Oct 2021 14:48:41 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id r7so2757474wrc.10 for ; Sat, 23 Oct 2021 14:48:41 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id e9sm11908032wrn.2.2021.10.23.14.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eWXKGvZTAb9QLzPIeZwjUz2cD0/0h0fiCLpbOFXLOpg=; b=AiY4uKLi6mnTYoxgVMGohV/YLuF0rrwE142gJX+MLAX3Vaq9cIREsEa/X2zibfr5MA CvJh/3KtuI2XTBx5gO6lolUGlkZZ8uPdICa9hr4r2aH2JYMQBLoDIwe8hPcQKPt2P2oS 9hSmZt8jkNzDxl8V82wUsCDizxNOmk+3QwmaUE85qV1WqJZgDDe1Ie91F2RLwZy6ln/1 42wLFyP189xEOn5srcQBFCkNDs2z1uowQiigGkRWavQCCvaBjVXHAEX2AJXXYH9DWfK9 IzaLgE55n1baDq9xckFszWaSS8X9mYGWTo2BkIavwRNkHMAEaMhTVXEcAuO3OzWllQrX uXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=eWXKGvZTAb9QLzPIeZwjUz2cD0/0h0fiCLpbOFXLOpg=; b=uSPm0ByvQPth5SD0gXswm3oDgLBMpWrcj8CEOVwzVA/QA9J1PcRqlfAndMaIvVicSC XTEY8ndYgcCegxZvYP3RN4KzEJwr5Y/3OCnJPt5TX4o9vcZOrG4uSQDyutGTEA1W6roV qq5fqJt3nSpBAZAZWlTV5oa5S1PC1XQ2ijNKXC5jHgOC81GoqfxSTTVv8JRiodv44JB9 cZTIUtqcR+h7LJD+P8lEY5g17jKIGd9yswF6GnKJFf82dLXQhUqXGSVjWO0ki5X4z+GS ACBf1YMs9Sm/Jj9flxwJi/lr0vRh2bp+o2FCS0I5H9Z3epQCgZNhXl5/Y7pYJpvMZJNT 5Q0g== X-Gm-Message-State: AOAM531V8YC/HgJc4ufTR652EA88YZJ/pRbTF/40SCSd/RgiTHFSTmsl JJAWIywcGSpe7dymsvZ1ujI= X-Google-Smtp-Source: ABdhPJyAmDkRRpGx6W2ZCSCfTJUrhg0xoVCkITmpw5QZKhkvIVjGx8zE5Vs/ELPkaRLi3s2F8t36bA== X-Received: by 2002:adf:8919:: with SMTP id s25mr10560428wrs.185.1635025719845; Sat, 23 Oct 2021 14:48:39 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 07/33] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v Date: Sat, 23 Oct 2021 23:47:37 +0200 Message-Id: <20211023214803.522078-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025722329100001 This 'shift amount' format is not always 16-bit, so name it generically as 'sa'. This will help to unify the various arg_msa decodetree generated structures. Rename the @bz format -> @bz_v (specific @bz with df=3D3) and @bz_df -> @bz (generic @bz). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 15 +++++++-------- target/mips/tcg/msa_translate.c | 20 ++++++++++---------- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 74d99f6862c..aa784cf12a9 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -13,19 +13,18 @@ =20 &r rs rt rd sa =20 -&msa_bz df wt s16 +&msa_bz df wt sa =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &r -@bz ...... ... .. wt:5 s16:16 &msa_bz df=3D3 -@bz_df ...... ... df:2 wt:5 s16:16 &msa_bz +@bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 +@bz ...... ... df:2 wt:5 sa:16 &msa_bz =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa DLSA 000000 ..... ..... ..... 000 .. 010101 @lsa =20 -BZ_V 010001 01011 ..... ................ @bz -BNZ_V 010001 01111 ..... ................ @bz - -BZ_x 010001 110 .. ..... ................ @bz_df -BNZ_x 010001 111 .. ..... ................ @bz_df +BZ_V 010001 01011 ..... ................ @bz_v +BNZ_V 010001 01111 ..... ................ @bz_v +BZ 010001 110 .. ..... ................ @bz +BNZ 010001 111 .. ..... ................ @bz =20 MSA 011110 -------------------------- diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 1c4a802ff55..c2a48aecc46 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -350,7 +350,7 @@ static void gen_check_zero_element(TCGv tresult, uint8_= t df, uint8_t wt, tcg_temp_free_i64(t1); } =20 -static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, int s16, TCGCond cond) +static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, int sa, TCGCond cond) { TCGv_i64 t0; =20 @@ -368,7 +368,7 @@ static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, in= t s16, TCGCond cond) tcg_gen_trunc_i64_tl(bcond, t0); tcg_temp_free_i64(t0); =20 - ctx->btarget =3D ctx->base.pc_next + (s16 << 2) + 4; + ctx->btarget =3D ctx->base.pc_next + (sa << 2) + 4; =20 ctx->hflags |=3D MIPS_HFLAG_BC; ctx->hflags |=3D MIPS_HFLAG_BDS32; @@ -378,15 +378,15 @@ static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, = int s16, TCGCond cond) =20 static bool trans_BZ_V(DisasContext *ctx, arg_msa_bz *a) { - return gen_msa_BxZ_V(ctx, a->wt, a->s16, TCG_COND_EQ); + return gen_msa_BxZ_V(ctx, a->wt, a->sa, TCG_COND_EQ); } =20 static bool trans_BNZ_V(DisasContext *ctx, arg_msa_bz *a) { - return gen_msa_BxZ_V(ctx, a->wt, a->s16, TCG_COND_NE); + return gen_msa_BxZ_V(ctx, a->wt, a->sa, TCG_COND_NE); } =20 -static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool i= f_not) +static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int sa, bool if= _not) { if (!check_msa_access(ctx)) { return false; @@ -399,21 +399,21 @@ static bool gen_msa_BxZ(DisasContext *ctx, int df, in= t wt, int s16, bool if_not) =20 gen_check_zero_element(bcond, df, wt, if_not ? TCG_COND_EQ : TCG_COND_= NE); =20 - ctx->btarget =3D ctx->base.pc_next + (s16 << 2) + 4; + ctx->btarget =3D ctx->base.pc_next + (sa << 2) + 4; ctx->hflags |=3D MIPS_HFLAG_BC; ctx->hflags |=3D MIPS_HFLAG_BDS32; =20 return true; } =20 -static bool trans_BZ_x(DisasContext *ctx, arg_msa_bz *a) +static bool trans_BZ(DisasContext *ctx, arg_msa_bz *a) { - return gen_msa_BxZ(ctx, a->df, a->wt, a->s16, false); + return gen_msa_BxZ(ctx, a->df, a->wt, a->sa, false); } =20 -static bool trans_BNZ_x(DisasContext *ctx, arg_msa_bz *a) +static bool trans_BNZ(DisasContext *ctx, arg_msa_bz *a) { - return gen_msa_BxZ(ctx, a->df, a->wt, a->s16, true); + return gen_msa_BxZ(ctx, a->df, a->wt, a->sa, true); } =20 static void gen_msa_i8(DisasContext *ctx) --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) client-ip=209.85.128.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025726; cv=none; d=zohomail.com; s=zohoarc; b=lSAKpSWxUv90WfQzV5Xik7PNwc1QfImkd71H4MDLW+3TbeBr7ucJRJTut3x+wxIFrLKW3bnjc7TDiVwidpLk0KO5qNYeNk/la9IuAqgh1wrCUFSjy+XXD1xjJOOfaqauw2H8KwqZH8TEkyDmRAhBebV0Q/rtNpp3hLOMspcKvks= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025726; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wRefdsaN3G9tHmzokFN7A+u5JQBRpdn2H5WuoRTRYAE=; b=B0DyahnDCi504RYb/TiRbrNcMPCKvW08Zt0zdyYcU+HcOUT1CUjucByrcvpaNQQ3MY7NGNP2WT7JoTvFf+In67/eedxwyjHuPZCGKWzbvdWIKqMv4RIqeAap4TG8uHGp59D0lygmmhSr0z/GiGfM+BNGMEm9QkJvlXKi6S47f8E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.zohomail.com with SMTPS id 1635025726290572.8541151360292; Sat, 23 Oct 2021 14:48:46 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id a20-20020a1c7f14000000b003231d13ee3cso8251513wmd.3 for ; Sat, 23 Oct 2021 14:48:45 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id 89sm778166wrc.47.2021.10.23.14.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wRefdsaN3G9tHmzokFN7A+u5JQBRpdn2H5WuoRTRYAE=; b=Lf8wmN51TwkLtEWsiXUbfwrLq7Y6I2Y9LaGDjsEEg4jXedC5XBGs5/d5zyWBkRwjxA t16i8by9s8iB8rAelPSX9e4LWe5OTCjEjnjALUzz5Fpw2mXS2mBmM1svxrtlmPV5L+Ji XGKNs9FkPcFjLIJa+D8U3WdUHS4mOk5mbU7a1pVlf+RQsYwhWEdZI1P6BRjp5YAKVbtl a7AzyUurGCz+zdUjzQflesSDqAF0vBbs1b3PnDqPm/EJu/rrt6HhgRIombfPCHCqU7Ly AX5NpDH752LpWO8mgfkWLiANQzuaRU+qHH6c8zXQ+JYQp/FqsqZsuNBYTGPscMflM9AI C+VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wRefdsaN3G9tHmzokFN7A+u5JQBRpdn2H5WuoRTRYAE=; b=qizbiHgbpp6xybZhWFJw18Qunz6xWmSH8PBiO8dbRCwLdMLHsM0nfiPB9qcE+rn+Yn V/jzKeDJrM0YbxroRPxWyKrAVUBy0JsP7TuVOpCFRtzdIV0WuVHBoCSJbJSKBD543rEK lpF9QZn7Ra/E9zNCf6FhWoWKSV1Yrrg1zOzp2An1jVewvF1Z860L8Oatpe/bXRrmc5k6 prPPKrVwKH3GiwIJXWQO07j68LS1AipG3B1qnfOmo4kXhmR2GdmuVm4OvSDwZFQDpr8h E7zg7WgVb4Vge2NlgkQFXLN3cnmrykHJJzmAiZSGXKiWrti7zbU2oQLwChQoLLYm6dFC yxKw== X-Gm-Message-State: AOAM5314fzBwLPevxZs5XoyZZknPcFdo1twsxv4jVaFnVA5nvIo9nrt1 aRfLmjzwso2UGPuLKtQQLrc= X-Google-Smtp-Source: ABdhPJwL8EioIwyVPcVEk1382fIPF+/EVUxSDugNTQyac7r7ZRCSquikfWqERKdWKi0MSQkzP06deg== X-Received: by 2002:a1c:1b50:: with SMTP id b77mr9541741wmb.0.1635025724568; Sat, 23 Oct 2021 14:48:44 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree Date: Sat, 23 Oct 2021 23:47:38 +0200 Message-Id: <20211023214803.522078-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025728576100001 Convert the LDI opcode (Immediate Load) to decodetree. Since it overlaps with the generic MSA handler, use a decodetree overlap group. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 8 +++++++- target/mips/tcg/msa_translate.c | 30 ++++++++++++++++++++++-------- 2 files changed, 29 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index aa784cf12a9..86aa66f05b9 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -14,10 +14,12 @@ &r rs rt rd sa =20 &msa_bz df wt sa +&msa_ldst df wd ws sa =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &r @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa DLSA 000000 ..... ..... ..... 000 .. 010101 @lsa @@ -27,4 +29,8 @@ BNZ_V 010001 01111 ..... ................ = @bz_v BZ 010001 110 .. ..... ................ @bz BNZ 010001 111 .. ..... ................ @bz =20 -MSA 011110 -------------------------- +{ + LDI 011110 110 .. .......... ..... 000111 @ldi + + MSA 011110 -------------------------- +} diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index c2a48aecc46..3b0dfcca69d 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -70,7 +70,6 @@ enum { OPC_CLEI_S_df =3D (0x4 << 23) | OPC_MSA_I5_07, OPC_MINI_U_df =3D (0x5 << 23) | OPC_MSA_I5_06, OPC_CLEI_U_df =3D (0x5 << 23) | OPC_MSA_I5_07, - OPC_LDI_df =3D (0x6 << 23) | OPC_MSA_I5_07, =20 /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, @@ -525,13 +524,6 @@ static void gen_msa_i5(DisasContext *ctx) case OPC_CLEI_U_df: gen_helper_msa_clei_u_df(cpu_env, tdf, twd, tws, timm); break; - case OPC_LDI_df: - { - int32_t s10 =3D sextract32(ctx->opcode, 11, 10); - tcg_gen_movi_i32(timm, s10); - gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -544,6 +536,28 @@ static void gen_msa_i5(DisasContext *ctx) tcg_temp_free_i32(timm); } =20 +static bool trans_LDI(DisasContext *ctx, arg_msa_ldst *a) +{ + TCGv_i32 tdf; + TCGv_i32 twd; + TCGv_i32 timm; + + if (!check_msa_access(ctx)) { + return false; + } + + tdf =3D tcg_constant_i32(a->df); + twd =3D tcg_const_i32(a->wd); + timm =3D tcg_const_i32(a->sa); + + gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); + + tcg_temp_free_i32(twd); + tcg_temp_free_i32(timm); + + return true; +} + static void gen_msa_bit(DisasContext *ctx) { #define MASK_MSA_BIT(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025731; cv=none; d=zohomail.com; s=zohoarc; b=eASm7+1hb9WEVKL57K0WqXpdtFVLp1qJO8Vq1XfEDUgelbIJ3BmTugoZocKy43G3HgI9w5BiXpsNzb7C0G4hVYRA5M/BhB6RDlDZ32bZyGKJ3q8RrzzCvMMXyPJNUpXQjOgobCByB0ThMT+vpvpl95NupvFdiVbxDGWPs8/Yf10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025731; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PVaCg6GCUpgKGbLvwmrR25Suk0A+VaCfoj7O99m3aJU=; b=an4m0IHPil3XL8Lg2QUmaShhPO3T0eIg/I5MEhAORk7RJJNC6e0Nk9znpf0ssH8pn1gW5moAcvnvJdbI57DNSjBMDuvo9MB9Z9zw2QjpbG4q+6rqQDNcXh8PRSlUDZgrwuYAL37eSs+cLbg6qZcgRUNmyYWmGb3+nx26JeQiuXw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635025730997688.1576886576067; Sat, 23 Oct 2021 14:48:50 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id v17so3521661wrv.9 for ; Sat, 23 Oct 2021 14:48:50 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id z26sm2160562wmi.45.2021.10.23.14.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PVaCg6GCUpgKGbLvwmrR25Suk0A+VaCfoj7O99m3aJU=; b=QxDRmOK+MIecQYm56Q/iD3FeD3Mw4WPqXJCMWwhB30Sg5XZzeMMPBB4K+3IGtNF14U m5h61wzDidXAbCiqfX7jSTOkH5kJD8QsviMv0hWJLAW/ponzv6KWSK6qGoXYlFNJ2SQ6 EvDveLwpwkINDeIQknsncxQ2UdJf8s9pipDH3xFKhLbP7G7TSXSqoA9PgkVCjqHIJABM Blhjoy9NdZuhjlO6fh2LpvNqNUlhHi1v6QcfD0CKsoN+NMJIpGjqs5ovO162TCJRXqq2 tzehR32YqrzoVxF515qGA8zV7K9EnT5XUD5ex9CYsvxRGk4nkXO3T8sh19LCN897tDLz Ltuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=PVaCg6GCUpgKGbLvwmrR25Suk0A+VaCfoj7O99m3aJU=; b=JILLk4NDT7xpCShk2aBc9nbsISaOu6nmT3prpQ/1Gf6Boa52s08UfS2mChjEAlHAOY TCe4Vm6Cqa7Hbs6heq3/yZGs/2/UxEh/N3qG27FYRvNnqMv6JeIpfapBSnzBer3PdCbh LDoEvD8hlQEmVx9wFYzi6nkdLqe553YQbv+/euyVclyhwBWJTm8zRZ1o2++jjyJ2bUeD Mwv08axOf1RGXHMC4kZSO1iUSTH8FAKQlHJWo/ckanKSntsLToH0CgunKAFBkR0ehSl5 MjnjhqVyiVKEik29EbE+shcP/r2iVexKEB+JSUd3P7uZjgUYcHix5WUYjOkN8BoFEPUB NIyQ== X-Gm-Message-State: AOAM533v62eDEWgLGKBby8q+wNP5f9FwUtopZPfQUJfc1cmtPkm2QYyx zbEbww3zjWBiSRoYG7KSmurpM9HsEyo= X-Google-Smtp-Source: ABdhPJystEv0Cn7c/tICY5XlHxYqVaUNT9N+6ppn444ag+u0FwCOKfY6qvouwamEVY5lr+BCA73hng== X-Received: by 2002:adf:edd2:: with SMTP id v18mr10614122wro.104.1635025729319; Sat, 23 Oct 2021 14:48:49 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 09/33] target/mips: Introduce generic TRANS_CHECK() for decodetree helpers Date: Sat, 23 Oct 2021 23:47:39 +0200 Message-Id: <20211023214803.522078-10-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025732519100001 Similar to the TRANS() macro introduced in commit fb3164e412d, introduce TRANS_CHECK() which takes a boolean expression as argument. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/translate.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/mips/tcg/translate.h b/target/mips/tcg/translate.h index 6111493651f..3ef09cc50c9 100644 --- a/target/mips/tcg/translate.h +++ b/target/mips/tcg/translate.h @@ -224,6 +224,15 @@ bool decode_ext_vr54xx(DisasContext *ctx, uint32_t ins= n); static bool trans_##NAME(DisasContext *ctx, arg_##NAME *a) \ { return FUNC(ctx, a, __VA_ARGS__); } =20 +#define TRANS_CHECK(NAME, CHECK_EXPR, FUNC, ...) \ + static bool trans_##NAME(DisasContext *ctx, arg_##NAME *a) \ + { \ + if (!(CHECK_EXPR)) { \ + return false; \ + } \ + return FUNC(ctx, a, __VA_ARGS__); \ + } + static inline bool cpu_is_bigendian(DisasContext *ctx) { return extract32(ctx->CP0_Config0, CP0C0_BE, 1); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025735; cv=none; d=zohomail.com; s=zohoarc; b=UxlLhrDmEqYS4ydH8w3m6g10Qte0FSer/8aSt5+2etcuQcojr2cK9XHFLetPGoEZSrQJ/3Y0C6du2AMBLaNMVcQNfOaQ23t/imXtt092I0vxhCMEQrme4QrLp+bVp7J66kcfcaD1P7mOH8L3+9IQiy4EUP7ln7c3H5MkVe0oMFI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025735; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+Ns3yPDdWxoYZoBcHHwK2IFet9te9Ef1ptNKNtMRrnA=; b=dmXy0/Pw6+9RjUru1BQRGI7xVeHrNJ6L96ScJTV6o6/jMylCAMn4zKf8lyyxqDOcZ2vd5jgrDEDyQsibzbe2U9J2fsjDQOR0V0V0CuwBmVIFg7acY8Jz2LbgpKHICQ09ldW8n/thRqn3H/2potBoVaV8GncsTf+XnzTb5mg+6KU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1635025735771623.0887983008532; Sat, 23 Oct 2021 14:48:55 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id s19so4724796wra.2 for ; Sat, 23 Oct 2021 14:48:55 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id k10sm14650554wmr.32.2021.10.23.14.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+Ns3yPDdWxoYZoBcHHwK2IFet9te9Ef1ptNKNtMRrnA=; b=pyAhcYePKJKQjPSLDJIFyQ0KgQaWc9OBwb/eCJXHvS0YsgkFZqI+2aO/Iwndg7vBFr dYrShSfe7XJz4L+QG12lTJLm+gjE+GbM6YvYD+zmccoNxhZnkzJBOC7aNVPBKiXC3mdN cMgH6f7mywB7DGtd2uTRoEJKXM0BcyBw6sm/w4eFcVfhcAP2vsHuqZVHWDcSrGzthiwq p+9jI24omnOprv1kRvGYAjiBrWy7iQrJ/miTemcTu9NciWCvsaxxBxzHISej/hvgVlqz YiFXskOPBiLsYn1yNadi4e3qhTvICgrIp9L2BhJNM8N3VRSZd2TlASMLrKFf9VS+TQ3J XvDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+Ns3yPDdWxoYZoBcHHwK2IFet9te9Ef1ptNKNtMRrnA=; b=1Nhp45DyvYperRTwVCDzBMBi9iV3iJOV7GJ+XFtItb+dmdmI+I9qNtM7wFt9AuQEZi o75Zcv9VsGCK0NkZex7/X5Xgf1Jmj7KGcKCF2G47/jIHYei+JJia4+IdkPc/iE8tI812 AfWm6kIjWlGN3TgY2M5rDivNq+bPNue3Zctmzm1pOyOvZgim3DNnEwLufnMDDcs5vL16 570apvtPkBNZJAcH0UyKGsH9Y0OKY3kVWk6mSDkH8ocBwti/T7tepHTkZ2N/zsZEmE1l WnP5xHxrxmwb3em1wnO/hlLcajepA1zPFAHmHcZgPIBlqtmJRFUBc+qYVBe5e2rRa/9K Pqrg== X-Gm-Message-State: AOAM532D7JOQhl+KjIsZjjvLeSHevBnabmS+yRZWHnWeP030Dt7z7H0q Q0QfHLvEN7BFi9g3r1h1oCY= X-Google-Smtp-Source: ABdhPJy9M3aMf80j+V7BZAYIqnpnV/0Uz3HnqA3UZAlT3wzE2v9YdZkWbAW+D9HjDCCJRuKyjBSHJg== X-Received: by 2002:adf:c78d:: with SMTP id l13mr10114222wrg.134.1635025733991; Sat, 23 Oct 2021 14:48:53 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 10/33] target/mips: Extract df_extract() helper Date: Sat, 23 Oct 2021 23:47:40 +0200 Message-Id: <20211023214803.522078-11-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025736518100001 Extract the common code which parses data formats to an helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa_translate.c | 68 +++++++++++++++++++-------------- 1 file changed, 39 insertions(+), 29 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 3b0dfcca69d..7c1bbfaec61 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -272,6 +272,40 @@ static const char msaregnames[][6] =3D { "w30.d0", "w30.d1", "w31.d0", "w31.d1", }; =20 +/* Encoding of Operation Field */ +static const struct dfe { + enum CPUMIPSMSADataFormat df; + int start; + int length; + uint32_t value; +} df_elm[] =3D { + /* Table 3.26 ELM Instruction Format */ + {DF_BYTE, 4, 2, 0b00}, + {DF_HALF, 3, 3, 0b100}, + {DF_WORD, 2, 4, 0b1100}, + {DF_DOUBLE, 1, 5, 0b11100} +}, df_bit[] =3D { + /* Table 3.28 BIT Instruction Format */ + {DF_BYTE, 3, 4, 0b1110}, + {DF_HALF, 4, 3, 0b110}, + {DF_WORD, 5, 2, 0b10}, + {DF_DOUBLE, 6, 1, 0b0} +}; + +/* Extract Operation Field (used by ELM & BIT instructions) */ +static bool df_extract(const struct dfe *s, int value, + enum CPUMIPSMSADataFormat *df, uint32_t *x) +{ + for (unsigned i =3D 0; i < 4; i++) { + if (extract32(value, s->start, s->length) =3D=3D s->value) { + *x =3D extract32(value, 0, s->start); + *df =3D s->df; + return true; + } + } + return false; +} + static TCGv_i64 msa_wr_d[64]; =20 void msa_translate_init(void) @@ -562,7 +596,6 @@ static void gen_msa_bit(DisasContext *ctx) { #define MASK_MSA_BIT(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) uint8_t dfm =3D (ctx->opcode >> 16) & 0x7f; - uint32_t df =3D 0, m =3D 0; uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; =20 @@ -570,20 +603,9 @@ static void gen_msa_bit(DisasContext *ctx) TCGv_i32 tm; TCGv_i32 twd; TCGv_i32 tws; + uint32_t df, m; =20 - if ((dfm & 0x40) =3D=3D 0x00) { - m =3D dfm & 0x3f; - df =3D DF_DOUBLE; - } else if ((dfm & 0x60) =3D=3D 0x40) { - m =3D dfm & 0x1f; - df =3D DF_WORD; - } else if ((dfm & 0x70) =3D=3D 0x60) { - m =3D dfm & 0x0f; - df =3D DF_HALF; - } else if ((dfm & 0x78) =3D=3D 0x70) { - m =3D dfm & 0x7; - df =3D DF_BYTE; - } else { + if (!df_extract(df_bit, dfm, &df, &m)) { gen_reserved_instruction(ctx); return; } @@ -1768,25 +1790,13 @@ static void gen_msa_elm_df(DisasContext *ctx, uint3= 2_t df, uint32_t n) static void gen_msa_elm(DisasContext *ctx) { uint8_t dfn =3D (ctx->opcode >> 16) & 0x3f; - uint32_t df =3D 0, n =3D 0; + uint32_t df, n; =20 - if ((dfn & 0x30) =3D=3D 0x00) { - n =3D dfn & 0x0f; - df =3D DF_BYTE; - } else if ((dfn & 0x38) =3D=3D 0x20) { - n =3D dfn & 0x07; - df =3D DF_HALF; - } else if ((dfn & 0x3c) =3D=3D 0x30) { - n =3D dfn & 0x03; - df =3D DF_WORD; - } else if ((dfn & 0x3e) =3D=3D 0x38) { - n =3D dfn & 0x01; - df =3D DF_DOUBLE; - } else if (dfn =3D=3D 0x3E) { + if (dfn =3D=3D 0x3E) { /* CTCMSA, CFCMSA, MOVE.V */ gen_msa_elm_3e(ctx); return; - } else { + } else if (!df_extract(df_elm, dfn, &df, &n)) { gen_reserved_instruction(ctx); return; } --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025740; cv=none; d=zohomail.com; s=zohoarc; b=h2Ip5/kk1JF8rayv/fvzw1hLJx3U59RzyDKd3QznwW1zC9I1r10ta9ioC4jn5DIClvt17dx1aEy6T3fD3xZjruZM4s6wCx6tkPYY5xCzqo6/RZntybUcHM8LGgwGuxLquL0AOsG7YA6TfPYgXqyStnt9ox1qYZC8jqzaHyW3dd8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025740; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7Twe1tKnuWtesTnk71X2V6F+BbjJ4TQgKol2D+Vvz98=; b=LQPIOBkMRuNFHpQpS/7aRhDAIjIZlejBQyoQZxRLb4zQmL4NtIq+eswNhthfv/cp74F3Vtb6YQMgY6m5f62p6HxR5BPPyB4PsKlk0gLUKb3jjbbyCXNUeR/eXPc37BM75gXEZc5tfCCvUKx9L2bXJ+hJV1U9iS3yKnkSi2b89us= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1635025740451579.4932320302945; Sat, 23 Oct 2021 14:49:00 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id e4so4824043wrc.7 for ; Sat, 23 Oct 2021 14:48:59 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id i24sm12150286wml.26.2021.10.23.14.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7Twe1tKnuWtesTnk71X2V6F+BbjJ4TQgKol2D+Vvz98=; b=Hex5MOIbTKi1Zje7/On3X7aAcBD4ucfx4PfSBAbK9aBW4bIEskzrmfAIIufvT/2oey hUAKU37Xu2WAjIQKWKu4z3SPMqOsqlgUaYcJk3AY7nDbIV9d1IK3G/1+rzo9tkSeTXNQ bHOsC6A9nbmp8703Q6DwCCMYBFvDOc4E8UTN2YvqZMYIUNL7Ry8J1DmkWiYHJF2bPWzI jTq5MFl9rYrhLemRIOxCKCNEUghX+DqGpZOQJFSBbOCfMEsVy/12oHHwU4oOk5N1ra6P mOlpxpv2jT8c/LDtSxiPO0v1AdmxhFeC0oR6+V6OaCOnF0UhT3Ji0PTr/sThTF/8HF6u rDbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=7Twe1tKnuWtesTnk71X2V6F+BbjJ4TQgKol2D+Vvz98=; b=XLHgeIhN9g5/Lj3IO4t4WRiZ50XMSxxjIcMnrvt8dMwDLHlTqxNbI16xxYiZdN+wcN S9Zpsak4EJXmbsWNOhaJMNuqkkhhIlJjBrTcSLwSgoOdYXDEbV5PxPsXUuH0tI8gAA2B BGRWAaHW3lYxWlPaaw5RApzSdxQAk1Cs4do5QCGMonWCqcU0ZGT9KJbZeb3hWgz+Aa7C EqQWREw0FyrUJ7rkVOWLb4kFESKNAnFMhT4jzQZr4NRZvv07ZYD3Ia0q4Rsx+EifuObY tYaKgUtjKAnmFze67Sve4xWeOel6GRPRkMWAbmxv/Xl/gx+U72VxrY2h5QOZFEPDJuW6 BVmw== X-Gm-Message-State: AOAM531p5UZ2kXBMLsdw9yn8nA0P3UEv25xzJu53tMaw4ONoarPum8rV mflmhbBtJtJO6QKrNmWaLeQ= X-Google-Smtp-Source: ABdhPJzoSAq9XsjF3ihflLJxgI9lHbsMLHMQbcqWRJnpTiP2iegX/umLs+p4DkI1OQlmQfHkOt1R0Q== X-Received: by 2002:a5d:4a4d:: with SMTP id v13mr10441801wrs.353.1635025738685; Sat, 23 Oct 2021 14:48:58 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 11/33] target/mips: Convert MSA I5 instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:41 +0200 Message-Id: <20211023214803.522078-12-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025740732100001 Convert instructions with a 5-bit immediate value to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 15 +++++ target/mips/tcg/msa_translate.c | 99 +++++++++------------------------ 2 files changed, 40 insertions(+), 74 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 86aa66f05b9..5aaa85456da 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -19,6 +19,8 @@ @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &r @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst +@s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa @@ -30,6 +32,19 @@ BZ 010001 110 .. ..... ................= @bz BNZ 010001 111 .. ..... ................ @bz =20 { + ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 + SUBVI 011110 001 .. ..... ..... ..... 000110 @u5 + MAXI_S 011110 010 .. ..... ..... ..... 000110 @s5 + MAXI_U 011110 011 .. ..... ..... ..... 000110 @u5 + MINI_S 011110 100 .. ..... ..... ..... 000110 @s5 + MINI_U 011110 101 .. ..... ..... ..... 000110 @u5 + + CEQI 011110 000 .. ..... ..... ..... 000111 @s5 + CLTI_S 011110 010 .. ..... ..... ..... 000111 @s5 + CLTI_U 011110 011 .. ..... ..... ..... 000111 @u5 + CLEI_S 011110 100 .. ..... ..... ..... 000111 @s5 + CLEI_U 011110 101 .. ..... ..... ..... 000111 @u5 + LDI 011110 110 .. .......... ..... 000111 @ldi =20 MSA 011110 -------------------------- diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 7c1bbfaec61..962aef601cb 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -27,8 +27,6 @@ enum { OPC_MSA_I8_00 =3D 0x00 | OPC_MSA, OPC_MSA_I8_01 =3D 0x01 | OPC_MSA, OPC_MSA_I8_02 =3D 0x02 | OPC_MSA, - OPC_MSA_I5_06 =3D 0x06 | OPC_MSA, - OPC_MSA_I5_07 =3D 0x07 | OPC_MSA, OPC_MSA_BIT_09 =3D 0x09 | OPC_MSA, OPC_MSA_BIT_0A =3D 0x0A | OPC_MSA, OPC_MSA_3R_0D =3D 0x0D | OPC_MSA, @@ -58,19 +56,6 @@ enum { }; =20 enum { - /* I5 instruction df(bits 22..21) =3D _b, _h, _w, _d */ - OPC_ADDVI_df =3D (0x0 << 23) | OPC_MSA_I5_06, - OPC_CEQI_df =3D (0x0 << 23) | OPC_MSA_I5_07, - OPC_SUBVI_df =3D (0x1 << 23) | OPC_MSA_I5_06, - OPC_MAXI_S_df =3D (0x2 << 23) | OPC_MSA_I5_06, - OPC_CLTI_S_df =3D (0x2 << 23) | OPC_MSA_I5_07, - OPC_MAXI_U_df =3D (0x3 << 23) | OPC_MSA_I5_06, - OPC_CLTI_U_df =3D (0x3 << 23) | OPC_MSA_I5_07, - OPC_MINI_S_df =3D (0x4 << 23) | OPC_MSA_I5_06, - OPC_CLEI_S_df =3D (0x4 << 23) | OPC_MSA_I5_07, - OPC_MINI_U_df =3D (0x5 << 23) | OPC_MSA_I5_06, - OPC_CLEI_U_df =3D (0x5 << 23) | OPC_MSA_I5_07, - /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, OPC_BMNZI_B =3D (0x0 << 24) | OPC_MSA_I8_01, @@ -341,6 +326,9 @@ static inline bool check_msa_access(DisasContext *ctx) return true; } =20 +#define TRANS_MSA(NAME, trans_func, gen_func) \ + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, gen_func) + static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, TCGCond cond) { @@ -507,69 +495,36 @@ static void gen_msa_i8(DisasContext *ctx) tcg_temp_free_i32(ti8); } =20 -static void gen_msa_i5(DisasContext *ctx) +static bool trans_msa_i5(DisasContext *ctx, arg_msa_ldst *a, + void (*gen_msa_i5)(TCGv_ptr, TCGv_i32, TCGv_i32, + TCGv_i32, TCGv_i32)) { -#define MASK_MSA_I5(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - int8_t s5 =3D (int8_t) sextract32(ctx->opcode, 16, 5); - uint8_t u5 =3D extract32(ctx->opcode, 16, 5); + TCGv_i32 tdf =3D tcg_constant_i32(a->df); + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); + TCGv_i32 timm =3D tcg_const_i32(a->sa); =20 - TCGv_i32 tdf =3D tcg_const_i32(extract32(ctx->opcode, 21, 2)); - TCGv_i32 twd =3D tcg_const_i32(extract32(ctx->opcode, 11, 5)); - TCGv_i32 tws =3D tcg_const_i32(extract32(ctx->opcode, 6, 5)); - TCGv_i32 timm =3D tcg_temp_new_i32(); - tcg_gen_movi_i32(timm, u5); + gen_msa_i5(cpu_env, tdf, twd, tws, timm); =20 - switch (MASK_MSA_I5(ctx->opcode)) { - case OPC_ADDVI_df: - gen_helper_msa_addvi_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_SUBVI_df: - gen_helper_msa_subvi_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_MAXI_S_df: - tcg_gen_movi_i32(timm, s5); - gen_helper_msa_maxi_s_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_MAXI_U_df: - gen_helper_msa_maxi_u_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_MINI_S_df: - tcg_gen_movi_i32(timm, s5); - gen_helper_msa_mini_s_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_MINI_U_df: - gen_helper_msa_mini_u_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_CEQI_df: - tcg_gen_movi_i32(timm, s5); - gen_helper_msa_ceqi_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_CLTI_S_df: - tcg_gen_movi_i32(timm, s5); - gen_helper_msa_clti_s_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_CLTI_U_df: - gen_helper_msa_clti_u_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_CLEI_S_df: - tcg_gen_movi_i32(timm, s5); - gen_helper_msa_clei_s_df(cpu_env, tdf, twd, tws, timm); - break; - case OPC_CLEI_U_df: - gen_helper_msa_clei_u_df(cpu_env, tdf, twd, tws, timm); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } - - tcg_temp_free_i32(tdf); tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(timm); + + return true; } =20 +TRANS_MSA(ADDVI, trans_msa_i5, gen_helper_msa_addvi_df); +TRANS_MSA(SUBVI, trans_msa_i5, gen_helper_msa_subvi_df); +TRANS_MSA(MAXI_S, trans_msa_i5, gen_helper_msa_maxi_s_df); +TRANS_MSA(MAXI_U, trans_msa_i5, gen_helper_msa_maxi_u_df); +TRANS_MSA(MINI_S, trans_msa_i5, gen_helper_msa_mini_s_df); +TRANS_MSA(MINI_U, trans_msa_i5, gen_helper_msa_mini_u_df); +TRANS_MSA(CLTI_S, trans_msa_i5, gen_helper_msa_clti_s_df); +TRANS_MSA(CLTI_U, trans_msa_i5, gen_helper_msa_clti_u_df); +TRANS_MSA(CLEI_S, trans_msa_i5, gen_helper_msa_clei_s_df); +TRANS_MSA(CLEI_U, trans_msa_i5, gen_helper_msa_clei_u_df); +TRANS_MSA(CEQI, trans_msa_i5, gen_helper_msa_ceqi_df); + static bool trans_LDI(DisasContext *ctx, arg_msa_ldst *a) { TCGv_i32 tdf; @@ -2196,10 +2151,6 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) case OPC_MSA_I8_02: gen_msa_i8(ctx); break; - case OPC_MSA_I5_06: - case OPC_MSA_I5_07: - gen_msa_i5(ctx); - break; case OPC_MSA_BIT_09: case OPC_MSA_BIT_0A: gen_msa_bit(ctx); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) client-ip=209.85.128.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025745; cv=none; d=zohomail.com; s=zohoarc; b=i8a1inLQG6bnRB7WWyjSihXNnMTyUoXSDQjTKTQffsrQx/8pCL3V44xELniXmP1afTVaW3WMoA49woyB80TGcRkMOSJFkTzwN2TU7OF+ZgoIuVYNu4tAjVDOobyuyXhak/EMzFsBauBHQxXoxm9yOOw3MMi8dME7xND1WuOlsMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025745; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nsEohNEwrhu8Aem4tlRNJJjtbidr9jHp4BNgaPtAgyw=; b=SHQ4iNx4aYMGFNmKBjyrIFdYMnKGfvY5vx3G2UBiGw4P4hdnk1vm0nppVl9gFt5eQoSBgg3RrI8iT+HaBsjATzyj3L3uDd325Q/wEgOaI9sJ8UFCFFFDWd7d0Yrc1wwwiK1jTkLnAfksF9duJUwyNvwUsXmCIwgqU08TlwbsQoY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.zohomail.com with SMTPS id 1635025745443297.7137492805464; Sat, 23 Oct 2021 14:49:05 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id 67-20020a1c1946000000b0030d4c90fa87so5838569wmz.2 for ; Sat, 23 Oct 2021 14:49:04 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id z135sm16764317wmc.45.2021.10.23.14.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nsEohNEwrhu8Aem4tlRNJJjtbidr9jHp4BNgaPtAgyw=; b=LY3t46G4tZTk2WgPPx8j/chF6bfU2dlqZwFpJmpJ8RPvxR1HyBB4nng/adf7gtJFRs eAzaNeC/v39pt9NvyK8drO4TFTWzM4byAjsXRdssvwui7k0aEAh5CIl6ZyMvzgIjcYTv QbK6fwsZ5BwtBgOSI1d29m5uI290ZEkMTKkI+CVQgwoT714/BhaKHb4AD+BEvSEFd32P ebjnfAMhdyfREXe+sbJtr65u/L7kiUftAzSY86szdql4GxkdZRPFqnFThXoOMhogf6DI EO9Dol7hLVmTKXipSX+l9M3AuMu9hm1QGvJ6vjWrgw232x5vF6PbUr8tRuMtRmWpH3Sx sUzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nsEohNEwrhu8Aem4tlRNJJjtbidr9jHp4BNgaPtAgyw=; b=ft8YEsTwj/FhAFr8NTOEX1CWwjMCewMjRf6lLAU9rcjEI1v2bcJLu2GUXxdv8cbzRz Ljlefl+ZITFlmpeS0vrwDC4liEXiu0vTJphgFRdXAKHKAur2mDVYOz7oPPTF5mCxHiz4 xIavsyDwoionIumi5TEYDdSxHRSAX3X8oIbkJhKkYwkClaNeaNjkm1CYDY+eLz/3SNfW +T/hY16un7fHH9F4gGFpZiwnXKQysnOA+MsV6fKyg5IKQvnpBjTJsxxcntRpn76zt48f 9hr6Mxrl+oqZ5wJBwFMpN0iy928z5UhKSp5to6zedWan+d4dolNq73t63xW3uIJBAuIn buXA== X-Gm-Message-State: AOAM530K5yOzVcX3/YODZ2MIdIMblaaTRLg+PDaFAqrx4oRTj2b14/mo 6XJZrygv2BWjPzHDicJHouo= X-Google-Smtp-Source: ABdhPJzGwyuo6DTM9YMczF5R5OOnAwmJ3P5ys5zRPgIeKlrhZrKOKPiUWNdQnOTs4osMKJmKh7LqCg== X-Received: by 2002:a05:600c:2257:: with SMTP id a23mr18951295wmm.182.1635025743672; Sat, 23 Oct 2021 14:49:03 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:42 +0200 Message-Id: <20211023214803.522078-13-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025746927100001 Convert instructions with an immediate bit index and data format df/m to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 15 +++++ target/mips/tcg/msa_translate.c | 98 ++++++++------------------------- 2 files changed, 39 insertions(+), 74 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 5aaa85456da..91d71ff560c 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -22,6 +22,7 @@ @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 +@bit ...... ... df:7 ws:5 wd:5 ...... &msa_ldst sa= =3D0 =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa DLSA 000000 ..... ..... ..... 000 .. 010101 @lsa @@ -47,5 +48,19 @@ BNZ 010001 111 .. ..... ................= @bz =20 LDI 011110 110 .. .......... ..... 000111 @ldi =20 + SLLI 011110 000 ....... ..... ..... 001001 @bit + SRAI 011110 001 ....... ..... ..... 001001 @bit + SRLI 011110 010 ....... ..... ..... 001001 @bit + BCLRI 011110 011 ....... ..... ..... 001001 @bit + BSETI 011110 100 ....... ..... ..... 001001 @bit + BNEGI 011110 101 ....... ..... ..... 001001 @bit + BINSLI 011110 110 ....... ..... ..... 001001 @bit + BINSRI 011110 111 ....... ..... ..... 001001 @bit + + SAT_S 011110 000 ....... ..... ..... 001010 @bit + SAT_U 011110 001 ....... ..... ..... 001010 @bit + SRARI 011110 010 ....... ..... ..... 001010 @bit + SRLRI 011110 011 ....... ..... ..... 001010 @bit + MSA 011110 -------------------------- } diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 962aef601cb..10bbe25172a 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -27,8 +27,6 @@ enum { OPC_MSA_I8_00 =3D 0x00 | OPC_MSA, OPC_MSA_I8_01 =3D 0x01 | OPC_MSA, OPC_MSA_I8_02 =3D 0x02 | OPC_MSA, - OPC_MSA_BIT_09 =3D 0x09 | OPC_MSA, - OPC_MSA_BIT_0A =3D 0x0A | OPC_MSA, OPC_MSA_3R_0D =3D 0x0D | OPC_MSA, OPC_MSA_3R_0E =3D 0x0E | OPC_MSA, OPC_MSA_3R_0F =3D 0x0F | OPC_MSA, @@ -222,20 +220,6 @@ enum { OPC_MSUBR_Q_df =3D (0xE << 22) | OPC_MSA_3RF_1C, OPC_FSULE_df =3D (0xF << 22) | OPC_MSA_3RF_1A, OPC_FMAX_A_df =3D (0xF << 22) | OPC_MSA_3RF_1B, - - /* BIT instruction df(bits 22..16) =3D _B _H _W _D */ - OPC_SLLI_df =3D (0x0 << 23) | OPC_MSA_BIT_09, - OPC_SAT_S_df =3D (0x0 << 23) | OPC_MSA_BIT_0A, - OPC_SRAI_df =3D (0x1 << 23) | OPC_MSA_BIT_09, - OPC_SAT_U_df =3D (0x1 << 23) | OPC_MSA_BIT_0A, - OPC_SRLI_df =3D (0x2 << 23) | OPC_MSA_BIT_09, - OPC_SRARI_df =3D (0x2 << 23) | OPC_MSA_BIT_0A, - OPC_BCLRI_df =3D (0x3 << 23) | OPC_MSA_BIT_09, - OPC_SRLRI_df =3D (0x3 << 23) | OPC_MSA_BIT_0A, - OPC_BSETI_df =3D (0x4 << 23) | OPC_MSA_BIT_09, - OPC_BNEGI_df =3D (0x5 << 23) | OPC_MSA_BIT_09, - OPC_BINSLI_df =3D (0x6 << 23) | OPC_MSA_BIT_09, - OPC_BINSRI_df =3D (0x7 << 23) | OPC_MSA_BIT_09, }; =20 static const char msaregnames[][6] =3D { @@ -547,78 +531,48 @@ static bool trans_LDI(DisasContext *ctx, arg_msa_ldst= *a) return true; } =20 -static void gen_msa_bit(DisasContext *ctx) +static bool trans_msa_bit(DisasContext *ctx, arg_msa_ldst *a, + void (*gen_msa_bit)(TCGv_ptr, TCGv_i32, TCGv_i32, + TCGv_i32, TCGv_i32)) { -#define MASK_MSA_BIT(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - uint8_t dfm =3D (ctx->opcode >> 16) & 0x7f; - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - TCGv_i32 tdf; TCGv_i32 tm; TCGv_i32 twd; TCGv_i32 tws; uint32_t df, m; =20 - if (!df_extract(df_bit, dfm, &df, &m)) { + if (!df_extract(df_bit, a->df, &df, &m)) { gen_reserved_instruction(ctx); - return; + return true; } =20 - tdf =3D tcg_const_i32(df); + tdf =3D tcg_constant_i32(df); tm =3D tcg_const_i32(m); - twd =3D tcg_const_i32(wd); - tws =3D tcg_const_i32(ws); + twd =3D tcg_const_i32(a->wd); + tws =3D tcg_const_i32(a->ws); =20 - switch (MASK_MSA_BIT(ctx->opcode)) { - case OPC_SLLI_df: - gen_helper_msa_slli_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_SRAI_df: - gen_helper_msa_srai_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_SRLI_df: - gen_helper_msa_srli_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_BCLRI_df: - gen_helper_msa_bclri_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_BSETI_df: - gen_helper_msa_bseti_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_BNEGI_df: - gen_helper_msa_bnegi_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_BINSLI_df: - gen_helper_msa_binsli_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_BINSRI_df: - gen_helper_msa_binsri_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_SAT_S_df: - gen_helper_msa_sat_s_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_SAT_U_df: - gen_helper_msa_sat_u_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_SRARI_df: - gen_helper_msa_srari_df(cpu_env, tdf, twd, tws, tm); - break; - case OPC_SRLRI_df: - gen_helper_msa_srlri_df(cpu_env, tdf, twd, tws, tm); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } + gen_msa_bit(cpu_env, tdf, twd, tws, tm); =20 - tcg_temp_free_i32(tdf); tcg_temp_free_i32(tm); tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); + + return true; } =20 +TRANS_MSA(SLLI, trans_msa_bit, gen_helper_msa_slli_df); +TRANS_MSA(SRAI, trans_msa_bit, gen_helper_msa_srai_df); +TRANS_MSA(SRLI, trans_msa_bit, gen_helper_msa_srli_df); +TRANS_MSA(BCLRI, trans_msa_bit, gen_helper_msa_bclri_df); +TRANS_MSA(BSETI, trans_msa_bit, gen_helper_msa_bseti_df); +TRANS_MSA(BNEGI, trans_msa_bit, gen_helper_msa_bnegi_df); +TRANS_MSA(BINSLI, trans_msa_bit, gen_helper_msa_binsli_df); +TRANS_MSA(BINSRI, trans_msa_bit, gen_helper_msa_binsri_df); +TRANS_MSA(SAT_S, trans_msa_bit, gen_helper_msa_sat_u_df); +TRANS_MSA(SAT_U, trans_msa_bit, gen_helper_msa_sat_u_df); +TRANS_MSA(SRARI, trans_msa_bit, gen_helper_msa_srari_df); +TRANS_MSA(SRLRI, trans_msa_bit, gen_helper_msa_srlri_df); + static void gen_msa_3r(DisasContext *ctx) { #define MASK_MSA_3R(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) @@ -2151,10 +2105,6 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) case OPC_MSA_I8_02: gen_msa_i8(ctx); break; - case OPC_MSA_BIT_09: - case OPC_MSA_BIT_0A: - gen_msa_bit(ctx); - break; case OPC_MSA_3R_0D: case OPC_MSA_3R_0E: case OPC_MSA_3R_0F: --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025750; cv=none; d=zohomail.com; s=zohoarc; b=eeyB2QIeAtinOr+A5zIRG9465P1mATFVA6eVm2K+90w1BXnGow8UTuD4xMEJIUj5gAdoxkdQuawXoJJyjPJdYfjo6JT/5O+LyftbXnQzQlmAe6n4/NoARvE4YDtejoIhqgtdyupr62wdUgpxDarGKdNctoGHN7PIwSmBOPJw5hM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025750; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Mg99jYEYPFU2NQRL9WBrBN9xN6wlefBcRoYkXCdFQxc=; b=bupvgta9WPm9QqGpeGFFInzB0C/ynYqQuu0PWrnks6P4pIlQgzyYgovSh0MfhRzmuAz560WXaahr4W+4RqQW0W0WNFFgZX+hmO+ruBAtdxJGyQZoFc3ilfom2dkoJ8GGp5nvOOaZoYndd8S2oi26k56vQ/CblTwfbpHLNRkqf68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1635025750217182.1288282305568; Sat, 23 Oct 2021 14:49:10 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id e12so4785405wra.4 for ; Sat, 23 Oct 2021 14:49:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id i11sm5151354wmg.46.2021.10.23.14.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mg99jYEYPFU2NQRL9WBrBN9xN6wlefBcRoYkXCdFQxc=; b=QXb3Vks6GSLMXMelnDNSuZ2HBCFxm1tlsQo0MyXmWfw9uweWrt9BvAQEAD9PPFMz4j VRX8yVFCypgQ6ijZnRoBdwSjS6aD+/gG4OTgFQRLGA79hezp0TXfWXNS/Qq3TZQ3J88T mdlw0Fls+WGgYs36hOXMZ2MjRCQovWzOxlwiQPsFtgR9QyxbxonVysYKrJi61BJxcwlO 2v2B9TWMXH7etPPfA9DcU55Ww9QgSwmE4bT/RwT3LedzEX3MLYjO1xSO6ISOB/z0jhAb YhlTccR/ypgccYLLr+lxoPZOHyc7YZGsg2mpjfkbLdirvtrHz7TZen/vhMgirB0P4azh hD9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Mg99jYEYPFU2NQRL9WBrBN9xN6wlefBcRoYkXCdFQxc=; b=TZ9TPMu92cgYOD5JsBrsL5RKMXPjqrpWprdYa7T3YRh5QD6SVGy4VXoJVAheRHN6y4 gNaqmGgHcmOEGHUIsT7mba/2FfLzQxx4FaeOTpK8jlwqT+q28V5S9bMcAkzdDL3whl0q Z7h4NKUoyoJJlNLR3imKzT+26xoN74uh/lY04ZAmH6khRzn20mp+vIy2SBqlDgd5dFHq Lx4EdTxfxMaKjwOz1j084RCvDeUJRi0woKRtHM3mFHnMBsg0ANB0hDy0Oyug284fSamq TGx/MpDFTLSVBlLSUWFVZ8WHherpcgyIMnrJGWjC1+3FAc1IkeeXaKzNXv5lNaNgEQYA GTtg== X-Gm-Message-State: AOAM530AovmgBb84dn3dcPrnDXoa/CisA+1yYtUCqcJuYfe4lnKh5uPv +W3+v4k8jmg0OqQ+UrhK468= X-Google-Smtp-Source: ABdhPJzEVebXzGTA7nALnW601D90ykUbN7bh5yARJPoSJYrAPl0t5jnjWc+mDdWvtErSMst3ecy5zg== X-Received: by 2002:a5d:5915:: with SMTP id v21mr10649362wrd.270.1635025748535; Sat, 23 Oct 2021 14:49:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree Date: Sat, 23 Oct 2021 23:47:43 +0200 Message-Id: <20211023214803.522078-14-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025751071100001 Convert the SHF opcode (Immediate Set Shuffle Elements) to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 3 +++ target/mips/tcg/msa_translate.c | 47 +++++++++++++++++++++------------ 2 files changed, 33 insertions(+), 17 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 91d71ff560c..6347468a709 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -22,6 +22,7 @@ @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 +@i8_df ...... df:2 sa:s8 ws:5 wd:5 ...... &msa_ldst @bit ...... ... df:7 ws:5 wd:5 ...... &msa_ldst sa= =3D0 =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa @@ -33,6 +34,8 @@ BZ 010001 110 .. ..... ................ = @bz BNZ 010001 111 .. ..... ................ @bz =20 { + SHF 011110 .. ........ ..... ..... 000010 @i8_df + ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 SUBVI 011110 001 .. ..... ..... ..... 000110 @u5 MAXI_S 011110 010 .. ..... ..... ..... 000110 @s5 diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 10bbe25172a..7cb078bfe92 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -57,13 +57,10 @@ enum { /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, OPC_BMNZI_B =3D (0x0 << 24) | OPC_MSA_I8_01, - OPC_SHF_B =3D (0x0 << 24) | OPC_MSA_I8_02, OPC_ORI_B =3D (0x1 << 24) | OPC_MSA_I8_00, OPC_BMZI_B =3D (0x1 << 24) | OPC_MSA_I8_01, - OPC_SHF_H =3D (0x1 << 24) | OPC_MSA_I8_02, OPC_NORI_B =3D (0x2 << 24) | OPC_MSA_I8_00, OPC_BSELI_B =3D (0x2 << 24) | OPC_MSA_I8_01, - OPC_SHF_W =3D (0x2 << 24) | OPC_MSA_I8_02, OPC_XORI_B =3D (0x3 << 24) | OPC_MSA_I8_00, =20 /* VEC/2R/2RF instruction */ @@ -454,20 +451,6 @@ static void gen_msa_i8(DisasContext *ctx) case OPC_BSELI_B: gen_helper_msa_bseli_b(cpu_env, twd, tws, ti8); break; - case OPC_SHF_B: - case OPC_SHF_H: - case OPC_SHF_W: - { - uint8_t df =3D (ctx->opcode >> 24) & 0x3; - if (df =3D=3D DF_DOUBLE) { - gen_reserved_instruction(ctx); - } else { - TCGv_i32 tdf =3D tcg_const_i32(df); - gen_helper_msa_shf_df(cpu_env, tdf, twd, tws, ti8); - tcg_temp_free_i32(tdf); - } - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -479,6 +462,36 @@ static void gen_msa_i8(DisasContext *ctx) tcg_temp_free_i32(ti8); } =20 +static bool trans_SHF(DisasContext *ctx, arg_msa_ldst *a) +{ + TCGv_i32 tdf; + TCGv_i32 twd; + TCGv_i32 tws; + TCGv_i32 timm; + + if (a->df =3D=3D DF_DOUBLE) { + gen_reserved_instruction(ctx); + return true; + } + + if (!check_msa_access(ctx)) { + return false; + } + + tdf =3D tcg_constant_i32(a->df); + twd =3D tcg_const_i32(a->wd); + tws =3D tcg_const_i32(a->ws); + timm =3D tcg_const_i32(a->sa); + + gen_helper_msa_shf_df(cpu_env, tdf, twd, tws, timm); + + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twd); + tcg_temp_free_i32(timm); + + return true; +} + static bool trans_msa_i5(DisasContext *ctx, arg_msa_ldst *a, void (*gen_msa_i5)(TCGv_ptr, TCGv_i32, TCGv_i32, TCGv_i32, TCGv_i32)) --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025755; cv=none; d=zohomail.com; s=zohoarc; b=dj/i+FeMS/4lVwEfQnhsnE5U/dVfTUyfBQqmlS2ElCENclCKs0p2O9WTzf/jD1VmStE+GeopwzXRmfpFBfosrHXmqoz7dAGDITF9jL1gCS6ZKiOLsOKcqKPlDdZeimxv0GyjU5twKhtJS3p7qS6IR6FKoj7N51JTNviPksOSjmg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025755; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9vu9D27+ookIEdUzntvIdVfMMkdX35lVhgz6M0Org7w=; b=kMbUOYgDbGCGUeDWvYetkoEhVxBTyr+MSqwJ2uQGECUwb7sRs/HhMMaH9Ny0WuTZvXGJD64Nj8Cryb10V+mHhnkljzs5h+ybRsiEU13FVR2RMrSrD1X1rkzsobdiFZGaCUoDyeA8/dTyjjRX7ALdhn6Ys1OBw/eBnpjxyK0SGJE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1635025755107132.3492876870838; Sat, 23 Oct 2021 14:49:15 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id r7so2759023wrc.10 for ; Sat, 23 Oct 2021 14:49:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id l1sm2403488wrb.73.2021.10.23.14.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9vu9D27+ookIEdUzntvIdVfMMkdX35lVhgz6M0Org7w=; b=D0lcjkuJd8IOslJHGXbV0wz3z6H++oHGGkkzXqYJLyP3rWfEVTjClCvmTJ/tc6jKHE JD4hSSYv+vbqFMG9nMQioqB4p31o6XMLHcMa2mQ8JjXyal34dkeQw4t6o/JvBjH0NrZW KXufS/vJ7V2ZVBaFghtqdHX+o7qM4CpJW8mExDMSCu/xm2Rpc08l0F+GYZlnqc4PHVsx N9MpkYtfC+MSc9lMLNiMwqmTP1gxhKgF4XVw+OjkpcHU+/PZqSzLv1UHn7ly+qHSqB26 Qq5uQ+Z/JCcRu5IHWWaGDXEgeH+iIPcnaNFOJMZLK9k8y05ldYkZ6qTlVLylfIEvO1yF X37A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9vu9D27+ookIEdUzntvIdVfMMkdX35lVhgz6M0Org7w=; b=Ogyy/mXYIB3BmPgDxglMOfsAoRnYx4l1vevc7dlt7t2KXSgN3RHhgvhzJxPqK6SYfh GZeK7bWAo7vgJqeQ/YWRPKCzWElCi8z4l0ciVu3KJsUer4AigO3hjhnUfls9nYTvdh6j UbM2shJDQ1/r//BbHYmFUIcJRlQGGVTLAcB+zfzi0IIu6nj058BZClXiqqKsAMj4rBuD 2wy5xIFQpa8nSgGmaZKoyTj5qNwHw593j3uDFXjsRspOVqdIZm/3Bg5wH128YMtMvb3t PUCEoX4Y27PB37NMgBUiNFFKL9Ng2KUQCLlO7gmQRfMb5exzsdP+CGKZ0bX4MTCmdeL8 6P6A== X-Gm-Message-State: AOAM532lLev8dZyCSzErqzQJq/v4qyPhbsaFyXvG34ErVZOwLwT46hIB 26iAHTy6rWqf7D5gz4bgRK4= X-Google-Smtp-Source: ABdhPJxLWxguDyHgZJEwyqPeMVpkg0GjB2AMyRdmK+G38tZ4eMBlRNtDLFVJAqCcqsw3GRqDZIunQQ== X-Received: by 2002:adf:a486:: with SMTP id g6mr10580590wrb.130.1635025753392; Sat, 23 Oct 2021 14:49:13 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 14/33] target/mips: Convert MSA I8 instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:44 +0200 Message-Id: <20211023214803.522078-15-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025757278100001 Convert instructions with an 8-bit immediate value and either implicit data format or data format df to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 8 ++++ target/mips/tcg/msa_translate.c | 72 +++++++++------------------------ 2 files changed, 26 insertions(+), 54 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 6347468a709..3dd07dced57 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -23,6 +23,7 @@ @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 @i8_df ...... df:2 sa:s8 ws:5 wd:5 ...... &msa_ldst +@i8 ...... .. sa:s8 ws:5 wd:5 ...... &msa_ldst df= =3D0 @bit ...... ... df:7 ws:5 wd:5 ...... &msa_ldst sa= =3D0 =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa @@ -34,6 +35,13 @@ BZ 010001 110 .. ..... ................= @bz BNZ 010001 111 .. ..... ................ @bz =20 { + ANDI 011110 00 ........ ..... ..... 000000 @i8 + ORI 011110 01 ........ ..... ..... 000000 @i8 + NORI 011110 10 ........ ..... ..... 000000 @i8 + XORI 011110 11 ........ ..... ..... 000000 @i8 + BMNZI 011110 00 ........ ..... ..... 000001 @i8 + BMZI 011110 01 ........ ..... ..... 000001 @i8 + BSELI 011110 10 ........ ..... ..... 000001 @i8 SHF 011110 .. ........ ..... ..... 000010 @i8_df =20 ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 7cb078bfe92..2866687635d 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -24,9 +24,6 @@ =20 #define MASK_MSA_MINOR(op) (MASK_OP_MAJOR(op) | (op & 0x3F)) enum { - OPC_MSA_I8_00 =3D 0x00 | OPC_MSA, - OPC_MSA_I8_01 =3D 0x01 | OPC_MSA, - OPC_MSA_I8_02 =3D 0x02 | OPC_MSA, OPC_MSA_3R_0D =3D 0x0D | OPC_MSA, OPC_MSA_3R_0E =3D 0x0E | OPC_MSA, OPC_MSA_3R_0F =3D 0x0F | OPC_MSA, @@ -54,15 +51,6 @@ enum { }; =20 enum { - /* I8 instruction */ - OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, - OPC_BMNZI_B =3D (0x0 << 24) | OPC_MSA_I8_01, - OPC_ORI_B =3D (0x1 << 24) | OPC_MSA_I8_00, - OPC_BMZI_B =3D (0x1 << 24) | OPC_MSA_I8_01, - OPC_NORI_B =3D (0x2 << 24) | OPC_MSA_I8_00, - OPC_BSELI_B =3D (0x2 << 24) | OPC_MSA_I8_01, - OPC_XORI_B =3D (0x3 << 24) | OPC_MSA_I8_00, - /* VEC/2R/2RF instruction */ OPC_AND_V =3D (0x00 << 21) | OPC_MSA_VEC, OPC_OR_V =3D (0x01 << 21) | OPC_MSA_VEC, @@ -418,50 +406,31 @@ static bool trans_BNZ(DisasContext *ctx, arg_msa_bz *= a) return gen_msa_BxZ(ctx, a->df, a->wt, a->sa, true); } =20 -static void gen_msa_i8(DisasContext *ctx) +static bool trans_msa_i8(DisasContext *ctx, arg_msa_ldst *a, + void (*gen_msa_i8)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32)) { -#define MASK_MSA_I8(op) (MASK_MSA_MINOR(op) | (op & (0x03 << 24))) - uint8_t i8 =3D (ctx->opcode >> 16) & 0xff; - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); + TCGv_i32 timm =3D tcg_const_i32(a->sa); =20 - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 ti8 =3D tcg_const_i32(i8); - - switch (MASK_MSA_I8(ctx->opcode)) { - case OPC_ANDI_B: - gen_helper_msa_andi_b(cpu_env, twd, tws, ti8); - break; - case OPC_ORI_B: - gen_helper_msa_ori_b(cpu_env, twd, tws, ti8); - break; - case OPC_NORI_B: - gen_helper_msa_nori_b(cpu_env, twd, tws, ti8); - break; - case OPC_XORI_B: - gen_helper_msa_xori_b(cpu_env, twd, tws, ti8); - break; - case OPC_BMNZI_B: - gen_helper_msa_bmnzi_b(cpu_env, twd, tws, ti8); - break; - case OPC_BMZI_B: - gen_helper_msa_bmzi_b(cpu_env, twd, tws, ti8); - break; - case OPC_BSELI_B: - gen_helper_msa_bseli_b(cpu_env, twd, tws, ti8); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } + gen_msa_i8(cpu_env, twd, tws, timm); =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(ti8); + tcg_temp_free_i32(timm); + + return true; } =20 +TRANS_MSA(ANDI, trans_msa_i8, gen_helper_msa_andi_b); +TRANS_MSA(ORI, trans_msa_i8, gen_helper_msa_ori_b); +TRANS_MSA(NORI, trans_msa_i8, gen_helper_msa_nori_b); +TRANS_MSA(XORI, trans_msa_i8, gen_helper_msa_xori_b); +TRANS_MSA(BMNZI, trans_msa_i8, gen_helper_msa_bmnzi_b); +TRANS_MSA(BMZI, trans_msa_i8, gen_helper_msa_bmzi_b); +TRANS_MSA(BSELI, trans_msa_i8, gen_helper_msa_bseli_b); + static bool trans_SHF(DisasContext *ctx, arg_msa_ldst *a) { TCGv_i32 tdf; @@ -2113,11 +2082,6 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) } =20 switch (MASK_MSA_MINOR(opcode)) { - case OPC_MSA_I8_00: - case OPC_MSA_I8_01: - case OPC_MSA_I8_02: - gen_msa_i8(ctx); - break; case OPC_MSA_3R_0D: case OPC_MSA_3R_0E: case OPC_MSA_3R_0F: --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025760; cv=none; d=zohomail.com; s=zohoarc; b=UW5vTyLljqKF3TZ+S0HgxJvR1kOBrojD/lMGMxT8+uiB/OK/tzkFKmXQg+oH6RYkAUC1CQEY8r1dZyINRgwGr90ng1JHTMw4piAtI46dQP1u/HepCobb/5pwi4Tf12PagUXeJQMKx3JUmcf+jv+LqWWvQ6AIv2VUqL7OTTfDExY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025760; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9oAdN638f3glmAR3nDrRo61QUNkEAnYfFRDh/cNbuiI=; b=LG7padHm+4eOmcNjCQTOr6gtVPvgV4N6xG+RFVt4MrPYRE4WRU4KIaTu2ACeKRj+y9muIocJP50w1z0AUue+B7vuwu2MZ0TrkMk3xw7HP8i9i+2c0L4s+mhBhYExS2jidR5s6jE7VSKkjVLHILXM/RRHIJE2PQeqXFMpzQaGnw0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1635025760046882.8563918828984; Sat, 23 Oct 2021 14:49:20 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id s19so4725871wra.2 for ; Sat, 23 Oct 2021 14:49:19 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id v13sm7361069wrp.11.2021.10.23.14.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9oAdN638f3glmAR3nDrRo61QUNkEAnYfFRDh/cNbuiI=; b=VGHe+dDetJUka8N7Pzf+NIT3YdfcYVIwE1UhHVQRY7xcdpzKKekpLfaqaLBIKKMitf jOtRna7a80Yz+nsqshu5rN/7cH4W1VNCzgC95k4d03NrBKUfvc+pLRESM99wCNtOUzEP 3SRGdymVsOxHxauL7hjDTYUw4WC9AZ8DGr/uZosWIbCDVWEg4uZRDBn19Vu4ZopJpcDt f20op9uSn+4eR6ijTVekcszx+aZuaef/gM6x2jVb9vLhEf9hrdBqlyB/NZnrbWZnPx5d ixuXYzRCTXPGC1hcySCj9Uexh1/eZT21gAyU4tnLE7OBqw43WvIqe1Htq0jziFa0CXdH zULg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9oAdN638f3glmAR3nDrRo61QUNkEAnYfFRDh/cNbuiI=; b=CQI82X/3Y6ZlpKH3o9HrekXvxlSnUgSIKU63rb/6Cfy1u0X8WA/S8Cjoo/qhaZ/WYi rMLVLwgJIOfRGt5sjuyZcEidTpWtrkelJxT0RQq+/jywGmdsMNPZzsn6dl/LN4OQOBlR 3UBAASJoOO3+xmqmgsUugw6hkEG5JPnnB5jiFDNAdcye6g3Xj2ifVRI3wXtWY2YlbWbZ Ut0+v46YqnZVxQUwRwgLRWs0gD3zDhjJtxPs+DGtg07s6DxKPC+v+Qtcs4wpPIe1VPdd 2O5SqeTxs1rgreeTU12AmYllHHlFaInTA6r7zaAnRFJ1poRhHSeJPEgBINEDDNqfCoKF IA+Q== X-Gm-Message-State: AOAM5302KtZNNuGS9pr3S6D+2qTmcS+ZX4virvQWsgxLViUtvIfRu3xv yghKaibz4JR/WasC5ijlpBc6XQutGxs= X-Google-Smtp-Source: ABdhPJw+XrdGbIdBk6cjtCs24BkxXy9Qs1t9x25e5nBoc7HLycCgPbh8sXlWNPWXO78Yaj5R9j8BKA== X-Received: by 2002:a05:6000:247:: with SMTP id m7mr2645421wrz.106.1635025758217; Sat, 23 Oct 2021 14:49:18 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 15/33] target/mips: Convert MSA load/store instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:45 +0200 Message-Id: <20211023214803.522078-16-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025761470100001 Convert load/store instructions to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 4 ++ target/mips/tcg/msa_translate.c | 99 +++++++++++++-------------------- 2 files changed, 44 insertions(+), 59 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 3dd07dced57..5fe6923ace5 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -17,6 +17,7 @@ &msa_ldst df wd ws sa =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &r +@ldst ...... sa:s10 ws:5 wd:5 .... df:2 &msa_ldst @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @@ -73,5 +74,8 @@ BNZ 010001 111 .. ..... ................ = @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + LD 011110 .......... ..... ..... 1000 .. @ldst + ST 011110 .......... ..... ..... 1001 .. @ldst + MSA 011110 -------------------------- } diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 2866687635d..52af99636a4 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -38,16 +38,6 @@ enum { OPC_MSA_3RF_1B =3D 0x1B | OPC_MSA, OPC_MSA_3RF_1C =3D 0x1C | OPC_MSA, OPC_MSA_VEC =3D 0x1E | OPC_MSA, - - /* MI10 instruction */ - OPC_LD_B =3D (0x20) | OPC_MSA, - OPC_LD_H =3D (0x21) | OPC_MSA, - OPC_LD_W =3D (0x22) | OPC_MSA, - OPC_LD_D =3D (0x23) | OPC_MSA, - OPC_ST_B =3D (0x24) | OPC_MSA, - OPC_ST_H =3D (0x25) | OPC_MSA, - OPC_ST_W =3D (0x26) | OPC_MSA, - OPC_ST_D =3D (0x27) | OPC_MSA, }; =20 enum { @@ -298,6 +288,10 @@ static inline bool check_msa_access(DisasContext *ctx) #define TRANS_MSA(NAME, trans_func, gen_func) \ TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, gen_func) =20 +#define TRANS_DF_E(NAME, trans_func, gen_func) \ + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ + gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d) + static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, TCGCond cond) { @@ -2104,55 +2098,6 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) case OPC_MSA_VEC: gen_msa_vec(ctx); break; - case OPC_LD_B: - case OPC_LD_H: - case OPC_LD_W: - case OPC_LD_D: - case OPC_ST_B: - case OPC_ST_H: - case OPC_ST_W: - case OPC_ST_D: - { - int32_t s10 =3D sextract32(ctx->opcode, 16, 10); - uint8_t rs =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - uint8_t df =3D (ctx->opcode >> 0) & 0x3; - - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv taddr =3D tcg_temp_new(); - gen_base_offset_addr(ctx, taddr, rs, s10 << df); - - switch (MASK_MSA_MINOR(opcode)) { - case OPC_LD_B: - gen_helper_msa_ld_b(cpu_env, twd, taddr); - break; - case OPC_LD_H: - gen_helper_msa_ld_h(cpu_env, twd, taddr); - break; - case OPC_LD_W: - gen_helper_msa_ld_w(cpu_env, twd, taddr); - break; - case OPC_LD_D: - gen_helper_msa_ld_d(cpu_env, twd, taddr); - break; - case OPC_ST_B: - gen_helper_msa_st_b(cpu_env, twd, taddr); - break; - case OPC_ST_H: - gen_helper_msa_st_h(cpu_env, twd, taddr); - break; - case OPC_ST_W: - gen_helper_msa_st_w(cpu_env, twd, taddr); - break; - case OPC_ST_D: - gen_helper_msa_st_d(cpu_env, twd, taddr); - break; - } - - tcg_temp_free_i32(twd); - tcg_temp_free(taddr); - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -2162,6 +2107,42 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) return true; } =20 +static bool trans_msa_ldst(DisasContext *ctx, arg_msa_ldst *a, + void (*gen_msa_b)(TCGv_ptr, TCGv_i32, TCGv), + void (*gen_msa_h)(TCGv_ptr, TCGv_i32, TCGv), + void (*gen_msa_w)(TCGv_ptr, TCGv_i32, TCGv), + void (*gen_msa_d)(TCGv_ptr, TCGv_i32, TCGv)) +{ + + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv taddr =3D tcg_temp_new(); + + gen_base_offset_addr(ctx, taddr, a->ws, a->sa << a->df); + + switch (a->df) { + case DF_BYTE: + gen_msa_b(cpu_env, twd, taddr); + break; + case DF_HALF: + gen_msa_h(cpu_env, twd, taddr); + break; + case DF_WORD: + gen_msa_w(cpu_env, twd, taddr); + break; + case DF_DOUBLE: + gen_msa_d(cpu_env, twd, taddr); + break; + } + + tcg_temp_free_i32(twd); + tcg_temp_free(taddr); + + return true; +} + +TRANS_DF_E(LD, trans_msa_ldst, gen_helper_msa_ld); +TRANS_DF_E(ST, trans_msa_ldst, gen_helper_msa_st); + static bool trans_LSA(DisasContext *ctx, arg_r *a) { return gen_lsa(ctx, a->rd, a->rt, a->rs, a->sa); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025764; cv=none; d=zohomail.com; s=zohoarc; b=UgpThyJ91Ga4eCI/dc9IPrpIPPtcrlOA9Vswf8KxCSLiXdz9xBEw/xIyXy+hKcINptJUHOxtyHjce1umYmDfnstMTiArsqYJBp0jcPEJ38cDX/aOvGkcnAQNIjcuhPqJ7eWxELZ0XHEWJ7LsaGWkI1Tse/GyPLvFwJJaNtNk25Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025764; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/82C/RXBbZohXXpaNVo8ZLMmjbXm87ApjflY1VkDUQk=; b=PopCQZw5omZI3UMIAe+hMFlnmY7CSDVP75/P65cdxfyKXNIYoDhoqnauETSZ/G/p/cqjuANjNps7V4RB356dVFy4Q0ybrOFX3zMoy5bj9MRSqTPvBr2fl596aVM6//FLG2oe+xRj7o07g+BoAEtKfigXTajxuM/IrDuf8OpLGbc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635025764736165.16677399963294; Sat, 23 Oct 2021 14:49:24 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id d13so2311052wrf.11 for ; Sat, 23 Oct 2021 14:49:24 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id x8sm6726488wrw.6.2021.10.23.14.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/82C/RXBbZohXXpaNVo8ZLMmjbXm87ApjflY1VkDUQk=; b=BEVg25QkA6rdIuVg01EQfEjTPtRpEMCXjI4pENF+vJA+FCSfEaefhLQlK1WO9YgYRA QyjgRuf3yU+OY1Hed5saAhJrMOsMeYF/3frmNr0X1U6MhIBk3X6E1QWWlBJQx+TyEJYH 40e2YsDglyFXRneEzjiJOOwqX86VoDWcfVfkkFmRa3DthzTARA2tBFgkSN1RfEGiY7J7 NllwkYhjwwJegkKQHB/K3/thIcI5AxwbqEZ7VVzYhInOyCeCspTbKm2gsLoMXnLG2TBh 7FaTXkNRMkhNOpk09mIx93ssQROCs5Sgzhg7TK4otEHQroGVkB+LJVMmeN1R6Ac0VOpQ WfQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/82C/RXBbZohXXpaNVo8ZLMmjbXm87ApjflY1VkDUQk=; b=f+UBL4HSRgR3RGhPD+KV4P1ZVnqEmrg+76uANvAYe6nUQWIglxuRe7mBNhU0UZsuu2 0Zpb1aNsBwaFus/+jHDfXI3ykxtEft9bz9yNdePAgDc08qvzAg/mtyjJ8KHBcHxU5twh t0hpMMbRvchL2Ta4LqfBcvMZHqUmAVmopjYWAaxBSeD2ZNwQqpEfh/uYNeKjwtYTm6mf HctBMHiR7OelNU0AuEJhq3geKQS/CrLoa0hEtQmozaglndro26vDi8taWeSmjIoPEHpU GnCAL3F37xpKm/jfslJG/b+CK33mhC0iCiDLYnvvwszl8gA87H4DQrf+zD3TGrVKZlNT meUQ== X-Gm-Message-State: AOAM531Y/VNmz/WC71h6AC+C1KxiAXTdIO6uZJib7kuf7CY4IdmcUDpc BlDMValV456bs25NYxYJIwU= X-Google-Smtp-Source: ABdhPJyNG4bHsoQ341Cr1ArKRigh9JifdoRRKn2EjufebP5Ut6f0mDq1Y1h70IYzji1V+88M0tWB3w== X-Received: by 2002:adf:fd41:: with SMTP id h1mr1140036wrs.14.1635025763043; Sat, 23 Oct 2021 14:49:23 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 16/33] target/mips: Convert MSA 2RF instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:46 +0200 Message-Id: <20211023214803.522078-17-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025765539100001 Convert 2-register floating-point operations to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 19 ++++++ target/mips/tcg/msa_translate.c | 109 ++++++++------------------------ 2 files changed, 46 insertions(+), 82 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 5fe6923ace5..2997bfa24e3 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -13,6 +13,7 @@ =20 &r rs rt rd sa =20 +&msa_r df wd ws wt &msa_bz df wt sa &msa_ldst df wd ws sa =20 @@ -20,6 +21,7 @@ @ldst ...... sa:s10 ws:5 wd:5 .... df:2 &msa_ldst @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 @@ -74,6 +76,23 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + FCLASS 011110 110010000 . ..... ..... 011110 @2rf + FTRUNC_S 011110 110010001 . ..... ..... 011110 @2rf + FTRUNC_U 011110 110010010 . ..... ..... 011110 @2rf + FSQRT 011110 110010011 . ..... ..... 011110 @2rf + FRSQRT 011110 110010100 . ..... ..... 011110 @2rf + FRCP 011110 110010101 . ..... ..... 011110 @2rf + FRINT 011110 110010110 . ..... ..... 011110 @2rf + FLOG2 011110 110010111 . ..... ..... 011110 @2rf + FEXUPL 011110 110011000 . ..... ..... 011110 @2rf + FEXUPR 011110 110011001 . ..... ..... 011110 @2rf + FFQL 011110 110011010 . ..... ..... 011110 @2rf + FFQR 011110 110011011 . ..... ..... 011110 @2rf + FTINT_S 011110 110011100 . ..... ..... 011110 @2rf + FTINT_U 011110 110011101 . ..... ..... 011110 @2rf + FFINT_S 011110 110011110 . ..... ..... 011110 @2rf + FFINT_U 011110 110011111 . ..... ..... 011110 @2rf + LD 011110 .......... ..... ..... 1000 .. @ldst ST 011110 .......... ..... ..... 1001 .. @ldst =20 diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 52af99636a4..c6a77381c0e 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -41,7 +41,7 @@ enum { }; =20 enum { - /* VEC/2R/2RF instruction */ + /* VEC/2R instruction */ OPC_AND_V =3D (0x00 << 21) | OPC_MSA_VEC, OPC_OR_V =3D (0x01 << 21) | OPC_MSA_VEC, OPC_NOR_V =3D (0x02 << 21) | OPC_MSA_VEC, @@ -51,7 +51,6 @@ enum { OPC_BSEL_V =3D (0x06 << 21) | OPC_MSA_VEC, =20 OPC_MSA_2R =3D (0x18 << 21) | OPC_MSA_VEC, - OPC_MSA_2RF =3D (0x19 << 21) | OPC_MSA_VEC, =20 /* 2R instruction df(bits 17..16) =3D _b, _h, _w, _d */ OPC_FILL_df =3D (0x00 << 18) | OPC_MSA_2R, @@ -59,24 +58,6 @@ enum { OPC_NLOC_df =3D (0x02 << 18) | OPC_MSA_2R, OPC_NLZC_df =3D (0x03 << 18) | OPC_MSA_2R, =20 - /* 2RF instruction df(bit 16) =3D _w, _d */ - OPC_FCLASS_df =3D (0x00 << 17) | OPC_MSA_2RF, - OPC_FTRUNC_S_df =3D (0x01 << 17) | OPC_MSA_2RF, - OPC_FTRUNC_U_df =3D (0x02 << 17) | OPC_MSA_2RF, - OPC_FSQRT_df =3D (0x03 << 17) | OPC_MSA_2RF, - OPC_FRSQRT_df =3D (0x04 << 17) | OPC_MSA_2RF, - OPC_FRCP_df =3D (0x05 << 17) | OPC_MSA_2RF, - OPC_FRINT_df =3D (0x06 << 17) | OPC_MSA_2RF, - OPC_FLOG2_df =3D (0x07 << 17) | OPC_MSA_2RF, - OPC_FEXUPL_df =3D (0x08 << 17) | OPC_MSA_2RF, - OPC_FEXUPR_df =3D (0x09 << 17) | OPC_MSA_2RF, - OPC_FFQL_df =3D (0x0A << 17) | OPC_MSA_2RF, - OPC_FFQR_df =3D (0x0B << 17) | OPC_MSA_2RF, - OPC_FTINT_S_df =3D (0x0C << 17) | OPC_MSA_2RF, - OPC_FTINT_U_df =3D (0x0D << 17) | OPC_MSA_2RF, - OPC_FFINT_S_df =3D (0x0E << 17) | OPC_MSA_2RF, - OPC_FFINT_U_df =3D (0x0F << 17) | OPC_MSA_2RF, - /* 3R instruction df(bits 22..21) =3D _b, _h, _w, d */ OPC_SLL_df =3D (0x0 << 23) | OPC_MSA_3R_0D, OPC_ADDV_df =3D (0x0 << 23) | OPC_MSA_3R_0E, @@ -1932,73 +1913,40 @@ static void gen_msa_2r(DisasContext *ctx) tcg_temp_free_i32(tws); } =20 -static void gen_msa_2rf(DisasContext *ctx) +static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a, + void (*gen_msa_2rf)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32)) { -#define MASK_MSA_2RF(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ - (op & (0xf << 17))) - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - uint8_t df =3D (ctx->opcode >> 16) & 0x1; - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); /* adjust df value for floating-point instruction */ - TCGv_i32 tdf =3D tcg_constant_i32(DF_WORD + df); + TCGv_i32 tdf =3D tcg_constant_i32(DF_WORD + a->df); =20 - switch (MASK_MSA_2RF(ctx->opcode)) { - case OPC_FCLASS_df: - gen_helper_msa_fclass_df(cpu_env, tdf, twd, tws); - break; - case OPC_FTRUNC_S_df: - gen_helper_msa_ftrunc_s_df(cpu_env, tdf, twd, tws); - break; - case OPC_FTRUNC_U_df: - gen_helper_msa_ftrunc_u_df(cpu_env, tdf, twd, tws); - break; - case OPC_FSQRT_df: - gen_helper_msa_fsqrt_df(cpu_env, tdf, twd, tws); - break; - case OPC_FRSQRT_df: - gen_helper_msa_frsqrt_df(cpu_env, tdf, twd, tws); - break; - case OPC_FRCP_df: - gen_helper_msa_frcp_df(cpu_env, tdf, twd, tws); - break; - case OPC_FRINT_df: - gen_helper_msa_frint_df(cpu_env, tdf, twd, tws); - break; - case OPC_FLOG2_df: - gen_helper_msa_flog2_df(cpu_env, tdf, twd, tws); - break; - case OPC_FEXUPL_df: - gen_helper_msa_fexupl_df(cpu_env, tdf, twd, tws); - break; - case OPC_FEXUPR_df: - gen_helper_msa_fexupr_df(cpu_env, tdf, twd, tws); - break; - case OPC_FFQL_df: - gen_helper_msa_ffql_df(cpu_env, tdf, twd, tws); - break; - case OPC_FFQR_df: - gen_helper_msa_ffqr_df(cpu_env, tdf, twd, tws); - break; - case OPC_FTINT_S_df: - gen_helper_msa_ftint_s_df(cpu_env, tdf, twd, tws); - break; - case OPC_FTINT_U_df: - gen_helper_msa_ftint_u_df(cpu_env, tdf, twd, tws); - break; - case OPC_FFINT_S_df: - gen_helper_msa_ffint_s_df(cpu_env, tdf, twd, tws); - break; - case OPC_FFINT_U_df: - gen_helper_msa_ffint_u_df(cpu_env, tdf, twd, tws); - break; - } + gen_msa_2rf(cpu_env, tdf, twd, tws); =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); + + return true; } =20 +TRANS_MSA(FCLASS, trans_msa_2rf, gen_helper_msa_fclass_df); +TRANS_MSA(FTRUNC_S, trans_msa_2rf, gen_helper_msa_fclass_df); +TRANS_MSA(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_s_df); +TRANS_MSA(FSQRT, trans_msa_2rf, gen_helper_msa_fsqrt_df); +TRANS_MSA(FRSQRT, trans_msa_2rf, gen_helper_msa_frsqrt_df); +TRANS_MSA(FRCP, trans_msa_2rf, gen_helper_msa_frcp_df); +TRANS_MSA(FRINT, trans_msa_2rf, gen_helper_msa_frint_df); +TRANS_MSA(FLOG2, trans_msa_2rf, gen_helper_msa_flog2_df); +TRANS_MSA(FEXUPL, trans_msa_2rf, gen_helper_msa_fexupl_df); +TRANS_MSA(FEXUPR, trans_msa_2rf, gen_helper_msa_fexupr_df); +TRANS_MSA(FFQL, trans_msa_2rf, gen_helper_msa_ffql_df); +TRANS_MSA(FFQR, trans_msa_2rf, gen_helper_msa_ffqr_df); +TRANS_MSA(FTINT_S, trans_msa_2rf, gen_helper_msa_ftint_s_df); +TRANS_MSA(FTINT_U, trans_msa_2rf, gen_helper_msa_ftint_u_df); +TRANS_MSA(FFINT_S, trans_msa_2rf, gen_helper_msa_ffint_s_df); +TRANS_MSA(FFINT_U, trans_msa_2rf, gen_helper_msa_ffint_u_df); + static void gen_msa_vec_v(DisasContext *ctx) { #define MASK_MSA_VEC(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21))) @@ -2057,9 +2005,6 @@ static void gen_msa_vec(DisasContext *ctx) case OPC_MSA_2R: gen_msa_2r(ctx); break; - case OPC_MSA_2RF: - gen_msa_2rf(ctx); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) client-ip=209.85.128.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025769; cv=none; d=zohomail.com; s=zohoarc; b=GJKTDCzGiZF7t5/r0bAMW/6gveBx1uDmj0TIMxNIQy9nGm/atH96A/cRNYlFQXtVsMJg8geYDZyNKzb8YZG3NS7+A5eqpC2nteEnPD2g67MsgTc9TudV6srPPxXys2N8bAfkriU0BAWCnfJMN6ZDSwVFmvRsAARKEt1ijA8NsMg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025769; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rRWJ6DnX5aJmnlrbbx5eJIJj5UwX/8+gOkeXTZA3kHs=; b=WopZUWypR66FxCr9D9zC/B6g+P4KSyiXrQNtjUBkqPXfFt7QloZ7ycRxyMmT4RPiTTtg1de1UT3QHn0tNesKLqRXctyie8clWQJOi4viKu5BvENgVGrbRc3Z8r8uEdaNXhCSGr+YEBHlNWwg2lO5e8msRIqATups3mTWHGGvNdk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.zohomail.com with SMTPS id 1635025769391813.4554168399238; Sat, 23 Oct 2021 14:49:29 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id v127so6552103wme.5 for ; Sat, 23 Oct 2021 14:49:28 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id z1sm12187077wre.21.2021.10.23.14.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rRWJ6DnX5aJmnlrbbx5eJIJj5UwX/8+gOkeXTZA3kHs=; b=DZmICpnTBpthHOnOOTwIBPFDdUGIqcGVOfLi0+J3/Sc/IrXzPhtpNLMTO1XSEAyRlb Ybo41l6SvXpTgqvYzqd3IXERNqywSqTpguLaQ8De1VzzH7y8ku4JEUZPlArzwxKOx/Yy Nm1g1+T2MYWyGN2c1r82f2ceAbZx3MO3VahOFMXVvao//ecDsdJUaS59t4CkFJlQTH69 YG9xW8H+uAWqYliXa/h0a64OweQDsbmQ58RvxhEt7yRioT8nE6E1w/9Mc5aeJw/4L/+E sMtQGC9dIQ9b1LDgjk2X0rv6yYiZpJ/ubNPBdBQO/BwWMnbNoyyoXWou/t31E/1F7lcs ROLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=rRWJ6DnX5aJmnlrbbx5eJIJj5UwX/8+gOkeXTZA3kHs=; b=Kwanr9RtgwbQvaMds6+JBFAvTU3fPYF36IZpV7LUDXBzPWfAaHfrtNB1PqwX1rUs0N Uf8c7Leu/YFaQBm6haRPb1qdsHSRaXDPgLAIRElP6QOaFHJBn6S/9h+xJAtvq6iUy2xz nRewIfCezKgvEbAc9dvoX4WkhS4P9M8dRSeiCIgjBqajINW/5M15qiYHT6ssJZTGZx7j jFqbE/yyQEoqXMAwOA/DdfKa6KBhVvg8jX2g3BUOCBkXoTvHL5OedL6e3I3B2EIBTfK9 xok4crD10GZBxdqyqR8IILYWX/WBnU0+LGTXhIxnSbphLQm0ON84B+k9WJAPx9viwoeG WmbQ== X-Gm-Message-State: AOAM5310lW1ns3CjtiA3Veq0tNWvyx/6NFhjM8ftbZcVahrLWfJfkpRM At2RS1/zRllh41XKFJjBXQI= X-Google-Smtp-Source: ABdhPJyBygAVnsy2ANdanKrJwkkp2dP1jUxjkKsqoN5IAR1NI8ZrcYj9A4nNVIjC9oBnSlZWM1kXtw== X-Received: by 2002:a05:600c:4f81:: with SMTP id n1mr38335876wmq.63.1635025767732; Sat, 23 Oct 2021 14:49:27 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 17/33] target/mips: Convert MSA FILL opcode to decodetree Date: Sat, 23 Oct 2021 23:47:47 +0200 Message-Id: <20211023214803.522078-18-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025769645100001 Convert the FILL opcode (Vector Fill from GPR) to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 2 ++ target/mips/tcg/msa_translate.c | 40 +++++++++++++++++++++++---------- 2 files changed, 30 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 2997bfa24e3..e97490cf880 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -21,6 +21,7 @@ @ldst ...... sa:s10 ws:5 wd:5 .... df:2 &msa_ldst @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @@ -76,6 +77,7 @@ BNZ 010001 111 .. ..... ................ = @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + FILL 011110 11000000 .. ..... ..... 011110 @2r FCLASS 011110 110010000 . ..... ..... 011110 @2rf FTRUNC_S 011110 110010001 . ..... ..... 011110 @2rf FTRUNC_U 011110 110010010 . ..... ..... 011110 @2rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index c6a77381c0e..fc0b80f83ac 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -53,7 +53,6 @@ enum { OPC_MSA_2R =3D (0x18 << 21) | OPC_MSA_VEC, =20 /* 2R instruction df(bits 17..16) =3D _b, _h, _w, _d */ - OPC_FILL_df =3D (0x00 << 18) | OPC_MSA_2R, OPC_PCNT_df =3D (0x01 << 18) | OPC_MSA_2R, OPC_NLOC_df =3D (0x02 << 18) | OPC_MSA_2R, OPC_NLZC_df =3D (0x03 << 18) | OPC_MSA_2R, @@ -1844,17 +1843,6 @@ static void gen_msa_2r(DisasContext *ctx) TCGv_i32 tws =3D tcg_const_i32(ws); =20 switch (MASK_MSA_2R(ctx->opcode)) { - case OPC_FILL_df: -#if !defined(TARGET_MIPS64) - /* Double format valid only for MIPS64 */ - if (df =3D=3D DF_DOUBLE) { - gen_reserved_instruction(ctx); - break; - } -#endif - gen_helper_msa_fill_df(cpu_env, tcg_constant_i32(df), - twd, tws); /* trs */ - break; case OPC_NLOC_df: switch (df) { case DF_BYTE: @@ -1913,6 +1901,34 @@ static void gen_msa_2r(DisasContext *ctx) tcg_temp_free_i32(tws); } =20 +static bool trans_FILL(DisasContext *ctx, arg_msa_r *a) +{ + TCGv_i32 twd; + TCGv_i32 tws; + TCGv_i32 tdf; + + if (!check_msa_access(ctx)) { + return false; + } + + if (TARGET_LONG_BITS !=3D 64 && a->df =3D=3D DF_DOUBLE) { + /* Double format valid only for MIPS64 */ + gen_reserved_instruction(ctx); + return true; + } + + twd =3D tcg_const_i32(a->wd); + tws =3D tcg_const_i32(a->ws); + tdf =3D tcg_constant_i32(a->df); + + gen_helper_msa_fill_df(cpu_env, tdf, twd, tws); /* trs */ + + tcg_temp_free_i32(twd); + tcg_temp_free_i32(tws); + + return true; +} + static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a, void (*gen_msa_2rf)(TCGv_ptr, TCGv_i32, TCGv_i32, TCGv_i32)) --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) client-ip=209.85.128.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025774; cv=none; d=zohomail.com; s=zohoarc; b=DBG/9ZY4J6mHfJ/Oq8tHkviaOSLpS7m/2Pe/I8aPRwaxjutV/IKmWMtIo4m+eCHZTdoZvbqmb6cgdB5aGXw3/JCWIjLiL6n41P3FkU5hFS1i4NeD60hQuXcN3NE05hQyUz/Gyu5cWE3/nV+oa1b2Rvn06ANzrS8NR4u+n+Gm64g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025774; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uEqIO2wOqp/xkdcCJeWEtzRHUYdaax9QNLinrvilNug=; b=E1mQi0rJ7Yx24GVph91xbmlPgMD7EwB3dzkAoSdVKF5K3oznKljvzf187J8tFQjsjKMaIEFFiFqLPJmeI3/pq3jeMPCjXGEOOOSGZbhwUmEFuhAjDsEGdumh5XRGGTy+dXfK4C7koo/X14ImKOiyzQ8ghsp6rcg0dtH8DKqgyCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.zohomail.com with SMTPS id 1635025774348205.3100199398017; Sat, 23 Oct 2021 14:49:34 -0700 (PDT) Received: by mail-wm1-f47.google.com with SMTP id y22-20020a1c7d16000000b003231ea3d705so8247884wmc.4 for ; Sat, 23 Oct 2021 14:49:33 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id j7sm15355785wmq.32.2021.10.23.14.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uEqIO2wOqp/xkdcCJeWEtzRHUYdaax9QNLinrvilNug=; b=JW3UZD09gk1Uc8F2x/EVRJ8BvMjLu1Z1Gjh0oJAOD6S3rUIHewk/XhaHCl97KCD+go Ebqp/x7wTowwrFiC8FYcEZZ0FRYWCGjo97LPp/45y7jWUD7Yfh7P2BVpxlXEavWoI42a URKgWTp1gDxj3Bnb3k/6hJRhGEq3TSgfHtkrIZnXFmKl0GxlhLp072L5XSnpM4CXQAfh 1CmTWpSycOZL/3XbpXG7sBwKLH+lB3j3aCcvB569UgyPpKX0Wsvt4r/DWAf2x89MOf+W q6ueMBpGT8BoyJI3UU2YuvrmcCHLhGbD+eVyW6A/i1wrl2Eb2yb1toQ1wS6G3HXMQfDG Id2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=uEqIO2wOqp/xkdcCJeWEtzRHUYdaax9QNLinrvilNug=; b=pKsp1qtMqJdNV48ohc9DzNlmBWX6qBX0EEcJM0j8DdQaZGzSjhiArba+T94GiswIdB abu8TOyUkkTpJIGo1XgEvc20Fy6VubgDVuZk0usS//Ykng0R+vh+lT1g0wYF1OWuRVTE NoiQYyOTOexD3HJ89/98QBbOyYXq+8Fa8lwMMBNhFCO145ez9GXf12qpMrfgchxBYSna OpDD6WS9s1NoDrZymzxxIQa6xQShPC4Ue718RDv549K+D3I13TeXtE2VjlGqve4bhdTP pZJEad37U034ip9I4OBARWY0lzseTGXlnNQpS3Li0z8CqdIzbbRNJLgOYntzB1wIJGuq Rz4w== X-Gm-Message-State: AOAM531E4curdDVkdgNmqMYlAK1WwaWP8ShYLkHAND7atHwk/nFFBHSt 1D8HY3KPNPgpKYJFburWoAA= X-Google-Smtp-Source: ABdhPJxQQF2aPXkiNfvP/VJr4BGgOMJ8FaxpyY1narahwVNa9b2n9LIcCOUHo84hag28HmWBC9XwtA== X-Received: by 2002:a1c:cc19:: with SMTP id h25mr10355724wmb.57.1635025772652; Sat, 23 Oct 2021 14:49:32 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 18/33] target/mips: Convert MSA 2R instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:48 +0200 Message-Id: <20211023214803.522078-19-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025775820100001 Convert 2-register operations to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 3 ++ target/mips/tcg/msa_translate.c | 91 +++++++++------------------------ 2 files changed, 28 insertions(+), 66 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index e97490cf880..88757f547eb 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -78,6 +78,9 @@ BNZ 010001 111 .. ..... ................ = @bz SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 FILL 011110 11000000 .. ..... ..... 011110 @2r + PCNT 011110 11000001 .. ..... ..... 011110 @2r + NLOC 011110 11000010 .. ..... ..... 011110 @2r + NLZC 011110 11000011 .. ..... ..... 011110 @2r FCLASS 011110 110010000 . ..... ..... 011110 @2rf FTRUNC_S 011110 110010001 . ..... ..... 011110 @2rf FTRUNC_U 011110 110010010 . ..... ..... 011110 @2rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index fc0b80f83ac..f54e9d173ac 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -50,13 +50,6 @@ enum { OPC_BMZ_V =3D (0x05 << 21) | OPC_MSA_VEC, OPC_BSEL_V =3D (0x06 << 21) | OPC_MSA_VEC, =20 - OPC_MSA_2R =3D (0x18 << 21) | OPC_MSA_VEC, - - /* 2R instruction df(bits 17..16) =3D _b, _h, _w, _d */ - OPC_PCNT_df =3D (0x01 << 18) | OPC_MSA_2R, - OPC_NLOC_df =3D (0x02 << 18) | OPC_MSA_2R, - OPC_NLZC_df =3D (0x03 << 18) | OPC_MSA_2R, - /* 3R instruction df(bits 22..21) =3D _b, _h, _w, d */ OPC_SLL_df =3D (0x0 << 23) | OPC_MSA_3R_0D, OPC_ADDV_df =3D (0x0 << 23) | OPC_MSA_3R_0E, @@ -1832,75 +1825,44 @@ static void gen_msa_3rf(DisasContext *ctx) tcg_temp_free_i32(twt); } =20 -static void gen_msa_2r(DisasContext *ctx) +static bool trans_msa_2r(DisasContext *ctx, arg_msa_r *a, + void (*gen_msa_2r_b)(TCGv_ptr, TCGv_i32, TCGv_i32= ), + void (*gen_msa_2r_h)(TCGv_ptr, TCGv_i32, TCGv_i32= ), + void (*gen_msa_2r_w)(TCGv_ptr, TCGv_i32, TCGv_i32= ), + void (*gen_msa_2r_d)(TCGv_ptr, TCGv_i32, TCGv_i32= )) { -#define MASK_MSA_2R(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ - (op & (0x7 << 18))) - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - uint8_t df =3D (ctx->opcode >> 16) & 0x3; - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); =20 - switch (MASK_MSA_2R(ctx->opcode)) { - case OPC_NLOC_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_nloc_b(cpu_env, twd, tws); - break; - case DF_HALF: - gen_helper_msa_nloc_h(cpu_env, twd, tws); - break; - case DF_WORD: - gen_helper_msa_nloc_w(cpu_env, twd, tws); - break; - case DF_DOUBLE: - gen_helper_msa_nloc_d(cpu_env, twd, tws); - break; + switch (a->df) { + case DF_BYTE: + if (gen_msa_2r_b =3D=3D NULL) { + gen_reserved_instruction(ctx); + } else { + gen_msa_2r_b(cpu_env, twd, tws); } break; - case OPC_NLZC_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_nlzc_b(cpu_env, twd, tws); - break; - case DF_HALF: - gen_helper_msa_nlzc_h(cpu_env, twd, tws); - break; - case DF_WORD: - gen_helper_msa_nlzc_w(cpu_env, twd, tws); - break; - case DF_DOUBLE: - gen_helper_msa_nlzc_d(cpu_env, twd, tws); - break; - } + case DF_HALF: + gen_msa_2r_h(cpu_env, twd, tws); break; - case OPC_PCNT_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_pcnt_b(cpu_env, twd, tws); - break; - case DF_HALF: - gen_helper_msa_pcnt_h(cpu_env, twd, tws); - break; - case DF_WORD: - gen_helper_msa_pcnt_w(cpu_env, twd, tws); - break; - case DF_DOUBLE: - gen_helper_msa_pcnt_d(cpu_env, twd, tws); - break; - } + case DF_WORD: + gen_msa_2r_w(cpu_env, twd, tws); break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); + case DF_DOUBLE: + gen_msa_2r_d(cpu_env, twd, tws); break; } =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); + + return true; } =20 +TRANS_DF_E(PCNT, trans_msa_2r, gen_helper_msa_pcnt); +TRANS_DF_E(NLOC, trans_msa_2r, gen_helper_msa_nloc); +TRANS_DF_E(NLZC, trans_msa_2r, gen_helper_msa_nlzc); + static bool trans_FILL(DisasContext *ctx, arg_msa_r *a) { TCGv_i32 twd; @@ -2018,9 +1980,6 @@ static void gen_msa_vec(DisasContext *ctx) case OPC_BSEL_V: gen_msa_vec_v(ctx); break; - case OPC_MSA_2R: - gen_msa_2r(ctx); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025779; cv=none; d=zohomail.com; s=zohoarc; b=HydbgSGKia94VEHaGVzJ8eAmy4zmdGBV465jRqpdzxjiK8YIBneqp9yHSzyTezrCEfZSdmMKNKt7RA45sYicgZ73EusRhLagS4LSbW/5gq5FEltHYda+evMCglIAfoTFVVVHDesQg4l0pRZdn+XrTWYijPq1gJ+AYcxC4wAZ0cE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025779; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=V2YNKMYkRLSbMPSCXijWN2U7P7p3cWA9eRMds81+W0U=; b=FX+6SBfY3caUNPblneSZoCbXT8Y0wsBKUuPrXbhAIUg/pIv5aZ9G78FrPhvL/hZ4rq3O8Fjxvcd96NK6J1Xso/UHbWLKW4++kV0NhTozj+geXx+3IssDyOyBEvJSUI/yVKzdEJRJHyRpTf3Qh9O7/7rkrWa2XJ1F/AmRyvKIIBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1635025779325378.0292328906303; Sat, 23 Oct 2021 14:49:39 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id 67-20020a1c1946000000b0030d4c90fa87so5839326wmz.2 for ; Sat, 23 Oct 2021 14:49:38 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id u6sm6838413wmc.29.2021.10.23.14.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V2YNKMYkRLSbMPSCXijWN2U7P7p3cWA9eRMds81+W0U=; b=R0LB1uqQ4MWMkYp6R71QWzcRyJEWnt2arHEZpPEpHPe9sL7rVaZqdS/RxLPnPWoq8Y Q0nTyY1PW1tS8aPF0hVsfJTfIhD7AZ5MFUspJEUxCYd5nGGLqMmXurf+L/WYeCmLVJVe c9UhjKqZPwmbs3IZpn6eF1ohP3Bs5BD7A/5yqV5f5ggDlyBYeQvgp66DmyTnMtNH9wNk NI3iUiKdFwOvfLzRraauXeL/mTupNXe+CrSVDvyVK6XOa749MsDRZ3TsEgIqoflpEkBj Vgv3FS/DNykvJAyuctSZvy2BKNhmdBGhVfyMgxtALQ+NCZe3cYuxZK8f8BLBgZSUJE0U KTjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=V2YNKMYkRLSbMPSCXijWN2U7P7p3cWA9eRMds81+W0U=; b=Z9fqCCA/GIOi/oGL/4I8xLzkyb/vlOgyBK2ZQFxA2LL8qV6qZarM0L9RL3P1jwtjsD 2DHhcJarKXi/s8vaBIzrUNWn+SH0p6j1MbBr3fkvfdc/5qU+pY9CQ0rKMo5sjo0bfCar A+6LFVZM3Jq0e8gTybhIzH458XZwK8wCAEbIte6Al/UoSgqdC7CPzd5Iv1DEWAS5v1gA AueOO0wL3WMOFG4fwhnC96d3uUKFBNyIpHh3+APmigsrqk5H/9M8B1XAuOsXVRTxHqZt oco1/DZCggzDXU/N8L7ufrIeLl0UjoGK1DElFpPOk35F0l3GyN6SVk1XvnpfiPFZZJga LAsA== X-Gm-Message-State: AOAM530WpTm/JbiNV7zoY0CVhrF8KP6QXJPp6QvjaMfl3y6SM+P/gxWr H7O4wTE/thuOEiIA6DZZdlU= X-Google-Smtp-Source: ABdhPJz5dRGwPZc7LkHZtG2qC48I5pTexe744dEl1UPOqSWkKYvoYb4+CX9xlnttuY5ppSUwjd2Sgg== X-Received: by 2002:a05:600c:210a:: with SMTP id u10mr19890632wml.139.1635025777611; Sat, 23 Oct 2021 14:49:37 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 19/33] target/mips: Convert MSA VEC instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:49 +0200 Message-Id: <20211023214803.522078-20-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025779877100001 Convert 3-register instructions with implicit data formats to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 8 ++++ target/mips/tcg/msa_translate.c | 82 +++++++-------------------------- 2 files changed, 24 insertions(+), 66 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 88757f547eb..72447041fef 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -21,6 +21,7 @@ @ldst ...... sa:s10 ws:5 wd:5 .... df:2 &msa_ldst @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @@ -77,6 +78,13 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + AND_V 011110 00000 ..... ..... ..... 011110 @vec + OR_V 011110 00001 ..... ..... ..... 011110 @vec + NOR_V 011110 00010 ..... ..... ..... 011110 @vec + XOR_V 011110 00011 ..... ..... ..... 011110 @vec + BMNZ_V 011110 00100 ..... ..... ..... 011110 @vec + BMZ_V 011110 00101 ..... ..... ..... 011110 @vec + BSEL_V 011110 00110 ..... ..... ..... 011110 @vec FILL 011110 11000000 .. ..... ..... 011110 @2r PCNT 011110 11000001 .. ..... ..... 011110 @2r NLOC 011110 11000010 .. ..... ..... 011110 @2r diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index f54e9d173ac..461a427c9df 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -37,19 +37,9 @@ enum { OPC_MSA_3RF_1A =3D 0x1A | OPC_MSA, OPC_MSA_3RF_1B =3D 0x1B | OPC_MSA, OPC_MSA_3RF_1C =3D 0x1C | OPC_MSA, - OPC_MSA_VEC =3D 0x1E | OPC_MSA, }; =20 enum { - /* VEC/2R instruction */ - OPC_AND_V =3D (0x00 << 21) | OPC_MSA_VEC, - OPC_OR_V =3D (0x01 << 21) | OPC_MSA_VEC, - OPC_NOR_V =3D (0x02 << 21) | OPC_MSA_VEC, - OPC_XOR_V =3D (0x03 << 21) | OPC_MSA_VEC, - OPC_BMNZ_V =3D (0x04 << 21) | OPC_MSA_VEC, - OPC_BMZ_V =3D (0x05 << 21) | OPC_MSA_VEC, - OPC_BSEL_V =3D (0x06 << 21) | OPC_MSA_VEC, - /* 3R instruction df(bits 22..21) =3D _b, _h, _w, d */ OPC_SLL_df =3D (0x0 << 23) | OPC_MSA_3R_0D, OPC_ADDV_df =3D (0x0 << 23) | OPC_MSA_3R_0E, @@ -1925,67 +1915,30 @@ TRANS_MSA(FTINT_U, trans_msa_2rf, gen_helper_msa_f= tint_u_df); TRANS_MSA(FFINT_S, trans_msa_2rf, gen_helper_msa_ffint_s_df); TRANS_MSA(FFINT_U, trans_msa_2rf, gen_helper_msa_ffint_u_df); =20 -static void gen_msa_vec_v(DisasContext *ctx) +static bool trans_msa_vec(DisasContext *ctx, arg_msa_r *a, + void (*gen_msa_vec)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32)) { -#define MASK_MSA_VEC(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21))) - uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twt =3D tcg_const_i32(wt); + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); + TCGv_i32 twt =3D tcg_const_i32(a->wt); =20 - switch (MASK_MSA_VEC(ctx->opcode)) { - case OPC_AND_V: - gen_helper_msa_and_v(cpu_env, twd, tws, twt); - break; - case OPC_OR_V: - gen_helper_msa_or_v(cpu_env, twd, tws, twt); - break; - case OPC_NOR_V: - gen_helper_msa_nor_v(cpu_env, twd, tws, twt); - break; - case OPC_XOR_V: - gen_helper_msa_xor_v(cpu_env, twd, tws, twt); - break; - case OPC_BMNZ_V: - gen_helper_msa_bmnz_v(cpu_env, twd, tws, twt); - break; - case OPC_BMZ_V: - gen_helper_msa_bmz_v(cpu_env, twd, tws, twt); - break; - case OPC_BSEL_V: - gen_helper_msa_bsel_v(cpu_env, twd, tws, twt); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } + gen_msa_vec(cpu_env, twd, tws, twt); =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(twt); + + return true; } =20 -static void gen_msa_vec(DisasContext *ctx) -{ - switch (MASK_MSA_VEC(ctx->opcode)) { - case OPC_AND_V: - case OPC_OR_V: - case OPC_NOR_V: - case OPC_XOR_V: - case OPC_BMNZ_V: - case OPC_BMZ_V: - case OPC_BSEL_V: - gen_msa_vec_v(ctx); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } -} +TRANS_MSA(AND_V, trans_msa_vec, gen_helper_msa_and_v); +TRANS_MSA(OR_V, trans_msa_vec, gen_helper_msa_or_v); +TRANS_MSA(NOR_V, trans_msa_vec, gen_helper_msa_nor_v); +TRANS_MSA(XOR_V, trans_msa_vec, gen_helper_msa_xor_v); +TRANS_MSA(BMNZ_V, trans_msa_vec, gen_helper_msa_bmnz_v); +TRANS_MSA(BMZ_V, trans_msa_vec, gen_helper_msa_bmz_v); +TRANS_MSA(BSEL_V, trans_msa_vec, gen_helper_msa_bsel_v); =20 static bool trans_MSA(DisasContext *ctx, arg_MSA *a) { @@ -2015,9 +1968,6 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) case OPC_MSA_3RF_1C: gen_msa_3rf(ctx); break; - case OPC_MSA_VEC: - gen_msa_vec(ctx); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025784; cv=none; d=zohomail.com; s=zohoarc; b=bCc1xdamv2i2SSUkBl2/CWaLB4C9HM99+iY53jiplwYljZ5DvS7jCtg20+o+IEIJlpatzrNh+Mkmu2dqWba1Fza/C1kMkIxYV/pUFln9j6F3e39TPEiRUjCIFxmFO3aZukLmz6um6WC3JLJolE703XuKrxVEfmJ9lz7I77o6L9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025784; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zlLSqA2ycXVzQUUC1xZxvV3k71wbtC8pyAG2XTINAoI=; b=HdQDbhk1cZ/9THlfRfrTNdZRrhd8QhBhlyz46xI58+SZmpXBEuTk7XJSsBAzm6IjRPyhjhpZzisI0LJSliYvyKOYKFL08uoxwxQw/PYQLboTYCbxJ60/xSMJ/CoHS3ptGYyuoHFpZ8kgmNKEbvIc1zP7OSOqfjQXN2w3xuIu8XI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1635025784135746.4526234031974; Sat, 23 Oct 2021 14:49:44 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id a16so3568356wrh.12 for ; Sat, 23 Oct 2021 14:49:43 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id o40sm6441943wms.10.2021.10.23.14.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zlLSqA2ycXVzQUUC1xZxvV3k71wbtC8pyAG2XTINAoI=; b=gc4MLb8VnPo/+rUWZ1w8EcA+pGy2+H7C/2u7zp4xkHRNnp46+dVgmi+kxNx5ZdKExd Pp+mvwXRGYH6tBreS8MZWylbGxo0tDUosyJpgNexNFLNLDatFyejY7h7600AAnGJQHW+ jvcNfgjp1iFduvCSuLLRJT9jEeTbFsF7YJBOxnMYFop9AVdbcygK88aQ0hTJffSwaxru wntbvFvQw3LJXwtDt5B7TuvXcmwOfBB/R87the1/mHdUkahM/YtZv7ekLoI/jG+bXMt0 yc956ABKiuA/9/UYtvXQ9XfH8wTm+pcutsmX5HfT3jJeNkq9OqPWjxjTDl9Haj433IE4 0A6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zlLSqA2ycXVzQUUC1xZxvV3k71wbtC8pyAG2XTINAoI=; b=LVSHJwbCg548ILxHemIKOjsJdAshrGkJwWN2msA3mn+wg83/N/eTb2zDNvVD51Z8qu 7y9++EzdiW2hmWQJiXfFF/y5hWQ5Pqc8i8f5QwqF7doXuB/3hZEjB1z8GKX9DJ0iA8vT Enf4/L846AgGl532WvD7jpzVYfmoXHEO9POIVM7h+LbsEkvNH883ya5MdLoYHsewbJIR dNSccscg3O0N8m7d7MtxwuDNwH+7MJwNyG0/Wfw3pU8S6IKRZwG8DxnYETqVKXJuR2Qu /+dX9cQe4YvR0DoOQ5rd0dAcQcSoLbbndUiAOCPTaScnAWU2YumXuK6qsxc1M2KgeAjX L4/g== X-Gm-Message-State: AOAM5325DVyr/w2jEQuNZVhiRoW26sC0EIu5lbR4jFV14HhvjDogzGzO UlNKCzc0l9nhrmQJnZ5UOBk= X-Google-Smtp-Source: ABdhPJzbKtVbo+w9okzqp54tTwrrL8cHkFwq47KXitw8rtpJ+3I1AHSuyUH3/IlQw5h6+Yve4VL/Pw== X-Received: by 2002:adf:8b1a:: with SMTP id n26mr10644740wra.182.1635025782398; Sat, 23 Oct 2021 14:49:42 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 20/33] target/mips: Convert MSA 3RF instruction format to decodetree (DF_HALF) Date: Sat, 23 Oct 2021 23:47:50 +0200 Message-Id: <20211023214803.522078-21-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025785982100004 Convert 3-register floating-point or fixed-point operations to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 8 ++++ target/mips/tcg/msa_translate.c | 70 +++++++++++++++------------------ 2 files changed, 39 insertions(+), 39 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 72447041fef..5c6a7415271 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -24,6 +24,7 @@ @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 +@3rf ...... .... df:1 wt:5 ws:5 wd:5 ...... &msa_r @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldst ws= =3D0 @@ -78,6 +79,13 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + MUL_Q 011110 0100 . ..... ..... ..... 011100 @3rf + MADD_Q 011110 0101 . ..... ..... ..... 011100 @3rf + MSUB_Q 011110 0110 . ..... ..... ..... 011100 @3rf + MULR_Q 011110 1100 . ..... ..... ..... 011100 @3rf + MADDR_Q 011110 1101 . ..... ..... ..... 011100 @3rf + MSUBR_Q 011110 1110 . ..... ..... ..... 011100 @3rf + AND_V 011110 00000 ..... ..... ..... 011110 @vec OR_V 011110 00001 ..... ..... ..... 011110 @vec NOR_V 011110 00010 ..... ..... ..... 011110 @vec diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 461a427c9df..6e50bc9edf4 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -130,12 +130,9 @@ enum { OPC_FCNE_df =3D (0x3 << 22) | OPC_MSA_3RF_1C, OPC_FCLT_df =3D (0x4 << 22) | OPC_MSA_3RF_1A, OPC_FMADD_df =3D (0x4 << 22) | OPC_MSA_3RF_1B, - OPC_MUL_Q_df =3D (0x4 << 22) | OPC_MSA_3RF_1C, OPC_FCULT_df =3D (0x5 << 22) | OPC_MSA_3RF_1A, OPC_FMSUB_df =3D (0x5 << 22) | OPC_MSA_3RF_1B, - OPC_MADD_Q_df =3D (0x5 << 22) | OPC_MSA_3RF_1C, OPC_FCLE_df =3D (0x6 << 22) | OPC_MSA_3RF_1A, - OPC_MSUB_Q_df =3D (0x6 << 22) | OPC_MSA_3RF_1C, OPC_FCULE_df =3D (0x7 << 22) | OPC_MSA_3RF_1A, OPC_FEXP2_df =3D (0x7 << 22) | OPC_MSA_3RF_1B, OPC_FSAF_df =3D (0x8 << 22) | OPC_MSA_3RF_1A, @@ -149,13 +146,10 @@ enum { OPC_FSNE_df =3D (0xB << 22) | OPC_MSA_3RF_1C, OPC_FSLT_df =3D (0xC << 22) | OPC_MSA_3RF_1A, OPC_FMIN_df =3D (0xC << 22) | OPC_MSA_3RF_1B, - OPC_MULR_Q_df =3D (0xC << 22) | OPC_MSA_3RF_1C, OPC_FSULT_df =3D (0xD << 22) | OPC_MSA_3RF_1A, OPC_FMIN_A_df =3D (0xD << 22) | OPC_MSA_3RF_1B, - OPC_MADDR_Q_df =3D (0xD << 22) | OPC_MSA_3RF_1C, OPC_FSLE_df =3D (0xE << 22) | OPC_MSA_3RF_1A, OPC_FMAX_df =3D (0xE << 22) | OPC_MSA_3RF_1B, - OPC_MSUBR_Q_df =3D (0xE << 22) | OPC_MSA_3RF_1C, OPC_FSULE_df =3D (0xF << 22) | OPC_MSA_3RF_1A, OPC_FMAX_A_df =3D (0xF << 22) | OPC_MSA_3RF_1B, }; @@ -251,6 +245,9 @@ static inline bool check_msa_access(DisasContext *ctx) #define TRANS_MSA(NAME, trans_func, gen_func) \ TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, gen_func) =20 +#define TRANS_DF(NAME, trans_func, df, gen_func) \ + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, df, gen_func) + #define TRANS_DF_E(NAME, trans_func, gen_func) \ TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d) @@ -1652,6 +1649,33 @@ static void gen_msa_elm(DisasContext *ctx) gen_msa_elm_df(ctx, df, n); } =20 +static bool trans_msa_3rf(DisasContext *ctx, arg_msa_r *a, + enum CPUMIPSMSADataFormat df_base, + void (*gen_msa_3rf)(TCGv_ptr, TCGv_i32, TCGv_i32, + TCGv_i32, TCGv_i32)) +{ + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); + TCGv_i32 twt =3D tcg_const_i32(a->wt); + /* adjust df value for floating-point instruction */ + TCGv_i32 tdf =3D tcg_constant_i32(a->df + df_base); + + gen_msa_3rf(cpu_env, tdf, twd, tws, twt); + + tcg_temp_free_i32(twt); + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twd); + + return true; +} + +TRANS_DF(MUL_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_mul_q_df); +TRANS_DF(MADD_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_madd_q_df); +TRANS_DF(MSUB_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_msub_q_df); +TRANS_DF(MULR_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_mulr_q_df); +TRANS_DF(MADDR_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_maddr_q_df); +TRANS_DF(MSUBR_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_msubr_q_df); + static void gen_msa_3rf(DisasContext *ctx) { #define MASK_MSA_3RF(op) (MASK_MSA_MINOR(op) | (op & (0xf << 22))) @@ -1663,22 +1687,8 @@ static void gen_msa_3rf(DisasContext *ctx) TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); TCGv_i32 twt =3D tcg_const_i32(wt); - TCGv_i32 tdf; - /* adjust df value for floating-point instruction */ - switch (MASK_MSA_3RF(ctx->opcode)) { - case OPC_MUL_Q_df: - case OPC_MADD_Q_df: - case OPC_MSUB_Q_df: - case OPC_MULR_Q_df: - case OPC_MADDR_Q_df: - case OPC_MSUBR_Q_df: - tdf =3D tcg_constant_i32(DF_HALF + df); - break; - default: - tdf =3D tcg_constant_i32(DF_WORD + df); - break; - } + TCGv_i32 tdf =3D tcg_constant_i32(DF_WORD + df); =20 switch (MASK_MSA_3RF(ctx->opcode)) { case OPC_FCAF_df: @@ -1720,24 +1730,15 @@ static void gen_msa_3rf(DisasContext *ctx) case OPC_FMADD_df: gen_helper_msa_fmadd_df(cpu_env, tdf, twd, tws, twt); break; - case OPC_MUL_Q_df: - gen_helper_msa_mul_q_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_FCULT_df: gen_helper_msa_fcult_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FMSUB_df: gen_helper_msa_fmsub_df(cpu_env, tdf, twd, tws, twt); break; - case OPC_MADD_Q_df: - gen_helper_msa_madd_q_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_FCLE_df: gen_helper_msa_fcle_df(cpu_env, tdf, twd, tws, twt); break; - case OPC_MSUB_Q_df: - gen_helper_msa_msub_q_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_FCULE_df: gen_helper_msa_fcule_df(cpu_env, tdf, twd, tws, twt); break; @@ -1777,27 +1778,18 @@ static void gen_msa_3rf(DisasContext *ctx) case OPC_FMIN_df: gen_helper_msa_fmin_df(cpu_env, tdf, twd, tws, twt); break; - case OPC_MULR_Q_df: - gen_helper_msa_mulr_q_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_FSULT_df: gen_helper_msa_fsult_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FMIN_A_df: gen_helper_msa_fmin_a_df(cpu_env, tdf, twd, tws, twt); break; - case OPC_MADDR_Q_df: - gen_helper_msa_maddr_q_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_FSLE_df: gen_helper_msa_fsle_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FMAX_df: gen_helper_msa_fmax_df(cpu_env, tdf, twd, tws, twt); break; - case OPC_MSUBR_Q_df: - gen_helper_msa_msubr_q_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_FSULE_df: gen_helper_msa_fsule_df(cpu_env, tdf, twd, tws, twt); break; --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025789; cv=none; d=zohomail.com; s=zohoarc; b=IuLM4UXF5+bhOfEsTGsqHRHUEzs29prkHVU8KIFiZuAFbEaE+nBwnryVt8V+Np/B11xFtWQSKgpjraEqGgJoTv/ntjr7Anxm7sDze4mxcqJM8KGb3XiNtwSYQLkD4MorJ8cK96bWyQUoJXy/bLOXnztsauEw0RQa83zRvjttHds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025789; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zRLAt8udUNKq0HVc05uP2X7/xjNCiQRVmBo+fRVE4WY=; b=S+hQab3U0LK65cYPJDkLtH2gykrEuGZOnp6wfkjkoUGb8fDidMYSI2hiyktGEQVNLIbPl9A055fWy5nfTDj/JTYtGnzw16cM0Dm3JvXZxJCfwkZnPvYHjrNX9Nxazp/ypUaVTuszEDHRh3gpvt+Yqec7BT7Qk/svYNA2lInY45o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1635025789088446.5924442438502; Sat, 23 Oct 2021 14:49:49 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id b133-20020a1c808b000000b0032ca4d18aebso4495796wmd.2 for ; Sat, 23 Oct 2021 14:49:48 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id u17sm2760940wrp.93.2021.10.23.14.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zRLAt8udUNKq0HVc05uP2X7/xjNCiQRVmBo+fRVE4WY=; b=piLeJhAYAX4yxFtCEP27w0bCixBldPmqTpkzP6cU6dxPNeOvan055EWteR8o/h6DcD P6JR6FrE3tt1/yMuAyxyHKXclImekcNoWrla3tqnE6u7p8NVIaB2uaidJCP8Kv4/CAS4 gjwI0WEAS9yHpTqmaR7Qt5VRrQmv3vwXcopPomXI+Spr9lN0+nXK4OWxwhltFl71OUit I48zG33LxUGg8ID+jF5i8tS/JBvD48cTqf8Bmcfs0JAPqiRcHTddRHn4MKcssC2uUznI WmbPVRnCnxKbYE9vDN8Eun6azqH9qwxc8hjoo0wRWSjSIivbajiK0nz/QNckEE5TuN2c 9nHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zRLAt8udUNKq0HVc05uP2X7/xjNCiQRVmBo+fRVE4WY=; b=CdMQy/CN+GGnTfi438qtQVIP2akoHBG7kOAwE5cDJ0K86OS6SyFsIas1fx6s6dN6Fn 0R5U9nx4m1bo2hHsd5AJVE/HyYuIzXzn4nSWbFMBK0ZvruWqUlhpGtwRUTCNBTB9GsUk pJuotmBn8uCI2VYjZrz3DgFeIJrFwFj6xMDUqrh4rSfQT4r4izA8p1oriTKjJ5oXhw63 7f650RR+WYPo7LPwWx5szIelYhoBh2KvYQcmOyGcwQla0AqINfs8kukhB2KCFmEL/Z5K nB8D9V9QwnMxjei4NcUI4sMwoRR1MErquh/kcd9EcBzuNrekZZAcZh3z1R/gPJ7ptQ/J 1knQ== X-Gm-Message-State: AOAM530QcsgW7KEGXbOtAbfHvOv2Kph0+146ursoukRtzdmWR6UWA5ey 4/809uWDkRUkCyssFTeTrpY= X-Google-Smtp-Source: ABdhPJx8t9pviNSSL2nvjgvtrWQmvUskT9a6W3Tmfd7qLBbrgXnlV/sgdFMKGsbfsmE4rdM/9mdWwQ== X-Received: by 2002:a7b:cc8c:: with SMTP id p12mr9360121wma.105.1635025787340; Sat, 23 Oct 2021 14:49:47 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 21/33] target/mips: Convert MSA 3RF instruction format to decodetree (DF_WORD) Date: Sat, 23 Oct 2021 23:47:51 +0200 Message-Id: <20211023214803.522078-22-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025790009100001 Convert 3-register floating-point or fixed-point operations to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 37 ++++++ target/mips/tcg/msa_translate.c | 213 ++++++-------------------------- 2 files changed, 74 insertions(+), 176 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 5c6a7415271..28b7a71d930 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -79,9 +79,46 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + FCAF 011110 0000 . ..... ..... ..... 011010 @3rf + FCUN 011110 0001 . ..... ..... ..... 011010 @3rf + FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf + FCUEQ 011110 0011 . ..... ..... ..... 011010 @3rf + FCLT 011110 0100 . ..... ..... ..... 011010 @3rf + FCULT 011110 0101 . ..... ..... ..... 011010 @3rf + FCLE 011110 0110 . ..... ..... ..... 011010 @3rf + FCULE 011110 0111 . ..... ..... ..... 011010 @3rf + FSAF 011110 1000 . ..... ..... ..... 011010 @3rf + FSUN 011110 1001 . ..... ..... ..... 011010 @3rf + FSEQ 011110 1010 . ..... ..... ..... 011010 @3rf + FSUEQ 011110 1011 . ..... ..... ..... 011010 @3rf + FSLT 011110 1100 . ..... ..... ..... 011010 @3rf + FSULT 011110 1101 . ..... ..... ..... 011010 @3rf + FSLE 011110 1110 . ..... ..... ..... 011010 @3rf + FSULE 011110 1111 . ..... ..... ..... 011010 @3rf + + FADD 011110 0000 . ..... ..... ..... 011011 @3rf + FSUB 011110 0001 . ..... ..... ..... 011011 @3rf + FMUL 011110 0010 . ..... ..... ..... 011011 @3rf + FDIV 011110 0011 . ..... ..... ..... 011011 @3rf + FMADD 011110 0100 . ..... ..... ..... 011011 @3rf + FMSUB 011110 0101 . ..... ..... ..... 011011 @3rf + FEXP2 011110 0111 . ..... ..... ..... 011011 @3rf + FEXDO 011110 1000 . ..... ..... ..... 011011 @3rf + FTQ 011110 1010 . ..... ..... ..... 011011 @3rf + FMIN 011110 1100 . ..... ..... ..... 011011 @3rf + FMIN_A 011110 1101 . ..... ..... ..... 011011 @3rf + FMAX 011110 1110 . ..... ..... ..... 011011 @3rf + FMAX_A 011110 1111 . ..... ..... ..... 011011 @3rf + + FCOR 011110 0001 . ..... ..... ..... 011100 @3rf + FCUNE 011110 0010 . ..... ..... ..... 011100 @3rf + FCNE 011110 0011 . ..... ..... ..... 011100 @3rf MUL_Q 011110 0100 . ..... ..... ..... 011100 @3rf MADD_Q 011110 0101 . ..... ..... ..... 011100 @3rf MSUB_Q 011110 0110 . ..... ..... ..... 011100 @3rf + FSOR 011110 1001 . ..... ..... ..... 011100 @3rf + FSUNE 011110 1010 . ..... ..... ..... 011100 @3rf + FSNE 011110 1011 . ..... ..... ..... 011100 @3rf MULR_Q 011110 1100 . ..... ..... ..... 011100 @3rf MADDR_Q 011110 1101 . ..... ..... ..... 011100 @3rf MSUBR_Q 011110 1110 . ..... ..... ..... 011100 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 6e50bc9edf4..4543b7abdfb 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -34,9 +34,6 @@ enum { OPC_MSA_3R_14 =3D 0x14 | OPC_MSA, OPC_MSA_3R_15 =3D 0x15 | OPC_MSA, OPC_MSA_ELM =3D 0x19 | OPC_MSA, - OPC_MSA_3RF_1A =3D 0x1A | OPC_MSA, - OPC_MSA_3RF_1B =3D 0x1B | OPC_MSA, - OPC_MSA_3RF_1C =3D 0x1C | OPC_MSA, }; =20 enum { @@ -115,43 +112,6 @@ enum { OPC_COPY_U_df =3D (0x3 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_INSERT_df =3D (0x4 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_INSVE_df =3D (0x5 << 22) | (0x00 << 16) | OPC_MSA_ELM, - - /* 3RF instruction _df(bit 21) =3D _w, _d */ - OPC_FCAF_df =3D (0x0 << 22) | OPC_MSA_3RF_1A, - OPC_FADD_df =3D (0x0 << 22) | OPC_MSA_3RF_1B, - OPC_FCUN_df =3D (0x1 << 22) | OPC_MSA_3RF_1A, - OPC_FSUB_df =3D (0x1 << 22) | OPC_MSA_3RF_1B, - OPC_FCOR_df =3D (0x1 << 22) | OPC_MSA_3RF_1C, - OPC_FCEQ_df =3D (0x2 << 22) | OPC_MSA_3RF_1A, - OPC_FMUL_df =3D (0x2 << 22) | OPC_MSA_3RF_1B, - OPC_FCUNE_df =3D (0x2 << 22) | OPC_MSA_3RF_1C, - OPC_FCUEQ_df =3D (0x3 << 22) | OPC_MSA_3RF_1A, - OPC_FDIV_df =3D (0x3 << 22) | OPC_MSA_3RF_1B, - OPC_FCNE_df =3D (0x3 << 22) | OPC_MSA_3RF_1C, - OPC_FCLT_df =3D (0x4 << 22) | OPC_MSA_3RF_1A, - OPC_FMADD_df =3D (0x4 << 22) | OPC_MSA_3RF_1B, - OPC_FCULT_df =3D (0x5 << 22) | OPC_MSA_3RF_1A, - OPC_FMSUB_df =3D (0x5 << 22) | OPC_MSA_3RF_1B, - OPC_FCLE_df =3D (0x6 << 22) | OPC_MSA_3RF_1A, - OPC_FCULE_df =3D (0x7 << 22) | OPC_MSA_3RF_1A, - OPC_FEXP2_df =3D (0x7 << 22) | OPC_MSA_3RF_1B, - OPC_FSAF_df =3D (0x8 << 22) | OPC_MSA_3RF_1A, - OPC_FEXDO_df =3D (0x8 << 22) | OPC_MSA_3RF_1B, - OPC_FSUN_df =3D (0x9 << 22) | OPC_MSA_3RF_1A, - OPC_FSOR_df =3D (0x9 << 22) | OPC_MSA_3RF_1C, - OPC_FSEQ_df =3D (0xA << 22) | OPC_MSA_3RF_1A, - OPC_FTQ_df =3D (0xA << 22) | OPC_MSA_3RF_1B, - OPC_FSUNE_df =3D (0xA << 22) | OPC_MSA_3RF_1C, - OPC_FSUEQ_df =3D (0xB << 22) | OPC_MSA_3RF_1A, - OPC_FSNE_df =3D (0xB << 22) | OPC_MSA_3RF_1C, - OPC_FSLT_df =3D (0xC << 22) | OPC_MSA_3RF_1A, - OPC_FMIN_df =3D (0xC << 22) | OPC_MSA_3RF_1B, - OPC_FSULT_df =3D (0xD << 22) | OPC_MSA_3RF_1A, - OPC_FMIN_A_df =3D (0xD << 22) | OPC_MSA_3RF_1B, - OPC_FSLE_df =3D (0xE << 22) | OPC_MSA_3RF_1A, - OPC_FMAX_df =3D (0xE << 22) | OPC_MSA_3RF_1B, - OPC_FSULE_df =3D (0xF << 22) | OPC_MSA_3RF_1A, - OPC_FMAX_A_df =3D (0xF << 22) | OPC_MSA_3RF_1B, }; =20 static const char msaregnames[][6] =3D { @@ -1669,144 +1629,50 @@ static bool trans_msa_3rf(DisasContext *ctx, arg_m= sa_r *a, return true; } =20 +TRANS_DF(FCAF, trans_msa_3rf, DF_WORD, gen_helper_msa_fcaf_df); +TRANS_DF(FCUN, trans_msa_3rf, DF_WORD, gen_helper_msa_fcun_df); +TRANS_DF(FCEQ, trans_msa_3rf, DF_WORD, gen_helper_msa_fceq_df); +TRANS_DF(FCUEQ, trans_msa_3rf, DF_WORD, gen_helper_msa_fcueq_df); +TRANS_DF(FCLT, trans_msa_3rf, DF_WORD, gen_helper_msa_fclt_df); +TRANS_DF(FCULT, trans_msa_3rf, DF_WORD, gen_helper_msa_fcult_df); +TRANS_DF(FCLE, trans_msa_3rf, DF_WORD, gen_helper_msa_fcle_df); +TRANS_DF(FCULE, trans_msa_3rf, DF_WORD, gen_helper_msa_fcule_df); +TRANS_DF(FSAF, trans_msa_3rf, DF_WORD, gen_helper_msa_fsaf_df); +TRANS_DF(FSUN, trans_msa_3rf, DF_WORD, gen_helper_msa_fsun_df); +TRANS_DF(FSEQ, trans_msa_3rf, DF_WORD, gen_helper_msa_fseq_df); +TRANS_DF(FSUEQ, trans_msa_3rf, DF_WORD, gen_helper_msa_fsueq_df); +TRANS_DF(FSLT, trans_msa_3rf, DF_WORD, gen_helper_msa_fslt_df); +TRANS_DF(FSULT, trans_msa_3rf, DF_WORD, gen_helper_msa_fsult_df); +TRANS_DF(FSLE, trans_msa_3rf, DF_WORD, gen_helper_msa_fsle_df); +TRANS_DF(FSULE, trans_msa_3rf, DF_WORD, gen_helper_msa_fsule_df); + +TRANS_DF(FADD, trans_msa_3rf, DF_WORD, gen_helper_msa_fadd_df); +TRANS_DF(FSUB, trans_msa_3rf, DF_WORD, gen_helper_msa_fsub_df); +TRANS_DF(FMUL, trans_msa_3rf, DF_WORD, gen_helper_msa_fmul_df); +TRANS_DF(FDIV, trans_msa_3rf, DF_WORD, gen_helper_msa_fdiv_df); +TRANS_DF(FMADD, trans_msa_3rf, DF_WORD, gen_helper_msa_fmadd_df); +TRANS_DF(FMSUB, trans_msa_3rf, DF_WORD, gen_helper_msa_fmsub_df); +TRANS_DF(FEXP2, trans_msa_3rf, DF_WORD, gen_helper_msa_fexp2_df); +TRANS_DF(FEXDO, trans_msa_3rf, DF_WORD, gen_helper_msa_fexdo_df); +TRANS_DF(FTQ, trans_msa_3rf, DF_WORD, gen_helper_msa_ftq_df); +TRANS_DF(FMIN, trans_msa_3rf, DF_WORD, gen_helper_msa_fmin_df); +TRANS_DF(FMIN_A, trans_msa_3rf, DF_WORD, gen_helper_msa_fmin_a_df); +TRANS_DF(FMAX, trans_msa_3rf, DF_WORD, gen_helper_msa_fmax_df); +TRANS_DF(FMAX_A, trans_msa_3rf, DF_WORD, gen_helper_msa_fmax_a_df); + +TRANS_DF(FCOR, trans_msa_3rf, DF_WORD, gen_helper_msa_fcor_df); +TRANS_DF(FCUNE, trans_msa_3rf, DF_WORD, gen_helper_msa_fcune_df); +TRANS_DF(FCNE, trans_msa_3rf, DF_WORD, gen_helper_msa_fcne_df); TRANS_DF(MUL_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_mul_q_df); TRANS_DF(MADD_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_madd_q_df); TRANS_DF(MSUB_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_msub_q_df); +TRANS_DF(FSOR, trans_msa_3rf, DF_WORD, gen_helper_msa_fsor_df); +TRANS_DF(FSUNE, trans_msa_3rf, DF_WORD, gen_helper_msa_fsune_df); +TRANS_DF(FSNE, trans_msa_3rf, DF_WORD, gen_helper_msa_fsne_df); TRANS_DF(MULR_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_mulr_q_df); TRANS_DF(MADDR_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_maddr_q_df); TRANS_DF(MSUBR_Q, trans_msa_3rf, DF_HALF, gen_helper_msa_msubr_q_df); =20 -static void gen_msa_3rf(DisasContext *ctx) -{ -#define MASK_MSA_3RF(op) (MASK_MSA_MINOR(op) | (op & (0xf << 22))) - uint8_t df =3D (ctx->opcode >> 21) & 0x1; - uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twt =3D tcg_const_i32(wt); - /* adjust df value for floating-point instruction */ - TCGv_i32 tdf =3D tcg_constant_i32(DF_WORD + df); - - switch (MASK_MSA_3RF(ctx->opcode)) { - case OPC_FCAF_df: - gen_helper_msa_fcaf_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FADD_df: - gen_helper_msa_fadd_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCUN_df: - gen_helper_msa_fcun_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSUB_df: - gen_helper_msa_fsub_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCOR_df: - gen_helper_msa_fcor_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCEQ_df: - gen_helper_msa_fceq_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FMUL_df: - gen_helper_msa_fmul_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCUNE_df: - gen_helper_msa_fcune_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCUEQ_df: - gen_helper_msa_fcueq_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FDIV_df: - gen_helper_msa_fdiv_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCNE_df: - gen_helper_msa_fcne_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCLT_df: - gen_helper_msa_fclt_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FMADD_df: - gen_helper_msa_fmadd_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCULT_df: - gen_helper_msa_fcult_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FMSUB_df: - gen_helper_msa_fmsub_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCLE_df: - gen_helper_msa_fcle_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FCULE_df: - gen_helper_msa_fcule_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FEXP2_df: - gen_helper_msa_fexp2_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSAF_df: - gen_helper_msa_fsaf_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FEXDO_df: - gen_helper_msa_fexdo_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSUN_df: - gen_helper_msa_fsun_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSOR_df: - gen_helper_msa_fsor_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSEQ_df: - gen_helper_msa_fseq_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FTQ_df: - gen_helper_msa_ftq_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSUNE_df: - gen_helper_msa_fsune_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSUEQ_df: - gen_helper_msa_fsueq_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSNE_df: - gen_helper_msa_fsne_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSLT_df: - gen_helper_msa_fslt_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FMIN_df: - gen_helper_msa_fmin_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSULT_df: - gen_helper_msa_fsult_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FMIN_A_df: - gen_helper_msa_fmin_a_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSLE_df: - gen_helper_msa_fsle_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FMAX_df: - gen_helper_msa_fmax_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FSULE_df: - gen_helper_msa_fsule_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_FMAX_A_df: - gen_helper_msa_fmax_a_df(cpu_env, tdf, twd, tws, twt); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } - - tcg_temp_free_i32(twd); - tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); -} - static bool trans_msa_2r(DisasContext *ctx, arg_msa_r *a, void (*gen_msa_2r_b)(TCGv_ptr, TCGv_i32, TCGv_i32= ), void (*gen_msa_2r_h)(TCGv_ptr, TCGv_i32, TCGv_i32= ), @@ -1955,11 +1821,6 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) case OPC_MSA_ELM: gen_msa_elm(ctx); break; - case OPC_MSA_3RF_1A: - case OPC_MSA_3RF_1B: - case OPC_MSA_3RF_1C: - gen_msa_3rf(ctx); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025793; cv=none; d=zohomail.com; s=zohoarc; b=AX3hV4FfvB0vcbQg9M9q6YTT/c/TWwi31Ho4rILYMkB/UAisP3lTm9kzFdK0AVMSQrjwkQSxBNlKktHReatkvcvXpkAUqpV61Eb+QJaDPBDSTJKgf6TOfFMs8ctW22dn0CYnPZVicx955UwHjjLGYPQghBO/kb7/31rto1QoT/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025793; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4W4U2ZakVa+VyW3piwFf7vBo1nL6bSIlarNPs7+y7Kw=; b=HzzlCTpozvs8xL3n9Pc60cNYXlFQiNbrXQztHI00pWYwUVBFNxTMC6l71mF1hi38jFYEa9bMsgkJFMOVPGJ2gPHEnbAj9j83cNq07cJGgajQ1R+1+yZ0cWd2CYoIfplrdlV2sHexy5VeJqti1NUGgmIs3C08ltfMVoZ1166usbI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635025793950528.2526845337019; Sat, 23 Oct 2021 14:49:53 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id a16so3568814wrh.12 for ; Sat, 23 Oct 2021 14:49:53 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id s9sm14187283wmj.39.2021.10.23.14.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4W4U2ZakVa+VyW3piwFf7vBo1nL6bSIlarNPs7+y7Kw=; b=VuyV8XslVDeoeSNIxNvKcUvNzL38hEGa91GbyPHVxCIGrJEPGaLzQCZGRJiStd7i/1 ZUehFvm1SEB8BxT8JYVDJkoxfTpZCOWulWQ9WUfkR6QSKAEdy/HtcgEI7rEdPcMugMUC kDIODr/A0FiJKNwenwfvqBk/1xD0MlEAv9zElkqgw4QWw/oj81QFE8uWlltCp/ZrMVC5 3PRTD/zC5zPs1wh23Qb34VKIrmW4cLkZcUqcWd+vt4enHpkfDsRQF2sXwTfYzGZGluu2 AN3Pf4iSp0dRnozzSOx+GNwhP4++ZYkbNB0Fq1qblsPfhPU/j7By9N1ZFCCdE1UPWO0v vUJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4W4U2ZakVa+VyW3piwFf7vBo1nL6bSIlarNPs7+y7Kw=; b=pOF8sFV/2tHX+3LERJwaRh/1g7uciazbYu1GLS43Cx/TfHAaFfVywuLUoVy7YxpQ2G RNUeOxfxq+OlU3ywJVCGVjfGeBlRKd21RCgP5NAqyY15J/kAcFVkdEZqVuaJE3r3JajL 6goHaw7eFDmSkCRpRucu4Qb468gL8WjmIs7oW/UmtoCL5behzmbt872B2HLPo/koP/4y ir751Zu0x60B6Rfs3XT0ytK5kHaqO+hJKxXtfOYqacZ7NNnmeLC94t7QtC1NrCn+fS8k kWzeM9pahYm9SlcQX9n4NF/zAGBFCSookEWT80sM5m1b0a/r8MWnOURnGvpt9d5+sgnV cJXw== X-Gm-Message-State: AOAM532pcvYpc27kRam8i+kHVHqPS+hUzKeR/9ZULTK5JJ35oP9Oq3jE 5kb/XiWHlRH7VRYRfVrNA1Q= X-Google-Smtp-Source: ABdhPJxZbFht8X8DalrfGadgjecRpedjlIg3ms6TTyc3GOpSUBcc5+g6x2PNTXpoA+wW6OEiVxR3ug== X-Received: by 2002:adf:a30c:: with SMTP id c12mr10719166wrb.366.1635025792193; Sat, 23 Oct 2021 14:49:52 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 22/33] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4) Date: Sat, 23 Oct 2021 23:47:52 +0200 Message-Id: <20211023214803.522078-23-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025796122100001 Convert 3-register operations to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 6 ++++++ target/mips/tcg/msa_translate.c | 35 ++++++++++++++++++++++----------- 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 28b7a71d930..ca0fd568560 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -24,6 +24,7 @@ @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 +@3r ...... ... df:2 wt:5 ws:5 wd:5 ...... &msa_r @3rf ...... .... df:1 wt:5 ws:5 wd:5 ...... &msa_r @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_ldst @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_ldst @@ -79,6 +80,11 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + SLD 011110 000 .. ..... ..... ..... 010100 @3r + SPLAT 011110 001 .. ..... ..... ..... 010100 @3r + + VSHF 011110 000 .. ..... ..... ..... 010101 @3r + FCAF 011110 0000 . ..... ..... ..... 011010 @3rf FCUN 011110 0001 . ..... ..... ..... 011010 @3rf FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 4543b7abdfb..0c7055c68bd 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -45,15 +45,12 @@ enum { OPC_SUBS_S_df =3D (0x0 << 23) | OPC_MSA_3R_11, OPC_MULV_df =3D (0x0 << 23) | OPC_MSA_3R_12, OPC_DOTP_S_df =3D (0x0 << 23) | OPC_MSA_3R_13, - OPC_SLD_df =3D (0x0 << 23) | OPC_MSA_3R_14, - OPC_VSHF_df =3D (0x0 << 23) | OPC_MSA_3R_15, OPC_SRA_df =3D (0x1 << 23) | OPC_MSA_3R_0D, OPC_SUBV_df =3D (0x1 << 23) | OPC_MSA_3R_0E, OPC_ADDS_A_df =3D (0x1 << 23) | OPC_MSA_3R_10, OPC_SUBS_U_df =3D (0x1 << 23) | OPC_MSA_3R_11, OPC_MADDV_df =3D (0x1 << 23) | OPC_MSA_3R_12, OPC_DOTP_U_df =3D (0x1 << 23) | OPC_MSA_3R_13, - OPC_SPLAT_df =3D (0x1 << 23) | OPC_MSA_3R_14, OPC_SRAR_df =3D (0x1 << 23) | OPC_MSA_3R_15, OPC_SRL_df =3D (0x2 << 23) | OPC_MSA_3R_0D, OPC_MAX_S_df =3D (0x2 << 23) | OPC_MSA_3R_0E, @@ -469,6 +466,29 @@ TRANS_MSA(SAT_U, trans_msa_bit, gen_helper_msa_sat_= u_df); TRANS_MSA(SRARI, trans_msa_bit, gen_helper_msa_srari_df); TRANS_MSA(SRLRI, trans_msa_bit, gen_helper_msa_srlri_df); =20 +static bool trans_msa_3r_df(DisasContext *ctx, arg_msa_r *a, + void (*gen_msa_3r_df)(TCGv_ptr, TCGv_i32, TCGv= _i32, + TCGv_i32, TCGv_i32)) +{ + TCGv_i32 tdf =3D tcg_constant_i32(a->df); + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); + TCGv_i32 twt =3D tcg_const_i32(a->wt); + + gen_msa_3r_df(cpu_env, tdf, twd, tws, twt); + + tcg_temp_free_i32(twd); + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twt); + + return true; +} + +TRANS_MSA(SLD, trans_msa_3r_df, gen_helper_msa_sld_df); +TRANS_MSA(SPLAT, trans_msa_3r_df, gen_helper_msa_splat_df); + +TRANS_MSA(VSHF, trans_msa_3r_df, gen_helper_msa_vshf_df); + static void gen_msa_3r(DisasContext *ctx) { #define MASK_MSA_3R(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) @@ -1219,12 +1239,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SLD_df: - gen_helper_msa_sld_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_VSHF_df: - gen_helper_msa_vshf_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBV_df: switch (df) { case DF_BYTE: @@ -1257,9 +1271,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SPLAT_df: - gen_helper_msa_splat_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBSUS_U_df: switch (df) { case DF_BYTE: --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025798; cv=none; d=zohomail.com; s=zohoarc; b=j2xnrlt7mu6DnYcyx0tnbVNEtuyhom/N/yHT+75bTDEdDCu28yKd0Z+Usb49ZgKHlL43rvs+ojIf9EEndBzWLowKupAyc8RntOUh+shZXJxbyNVINF3Hj0Uuc6fYPvaJkOH8twJBDL3GIJF6mPH1mZ+g4weVXTyfOllGwCm/hLo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025798; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sPvSWraAlK7Nph4ty/Vbsk19Tc0DzeKGebIhAV3dvYU=; b=NfLsWIdTGS44OhkgSHvNqarsRAWUXa+Iq5d7G7+/RkEbhxw42b+yhm/vvRA9mAJ4di6D3aRAHUFwA+bGPYRE/krZThgbPV6VncZ0Mx+v3U2liMVMF2NE4F3Ghu+n4P+yK8KmnThAYyXEmQav7HqXTQ2Hx8uljtohZXzNsoLWN3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635025798907319.42225531843474; Sat, 23 Oct 2021 14:49:58 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id v17so3524965wrv.9 for ; Sat, 23 Oct 2021 14:49:58 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id w14sm2381838wmi.37.2021.10.23.14.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sPvSWraAlK7Nph4ty/Vbsk19Tc0DzeKGebIhAV3dvYU=; b=EirtFh+ic9zODrrAjfdgoFlsvaXSvFoALvFg/Hh9R5Qhm0EHSrmKEjmDQN11Bi6w2Q 8XtDc5Wu8YxZjzLGddLGlg/b6egLHNl5IiNcq1GOg5/lqsMafEwrFZYYUrOEzNEyepQb l6dKGgx7qKGOZL8X/9T+j1x/edFbTWS96AIcTYmYxjrdGpq2+N5enKShAo96MkMZcRs4 HEPwJg4ZYrRfiNgKkzcW2rX1XEH9p7UdBvOPv+5HDzbcam/BLBpObFLiSZbtCAuL575p XA7mXesTMF3p3TZ1x29HBYO4xD9P7SOfHkRQlGw8XdVnctNyPU80V52QtQp9FtalEf0O Fe7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=sPvSWraAlK7Nph4ty/Vbsk19Tc0DzeKGebIhAV3dvYU=; b=mKiK1aKQO3KyWogGyaZo19HB9/PFpqEiDo+1JmDMM7n/RsDnNJnKD6GUTDTNIQNSCX vnbbNBRhC3NrF9Yf2qrclHyAQpw4pDt12Tak1ez33ad/BFPUQ/H9fZygaerH1IFbVoXc KsV7qQhjwJHS3foY19s5tLFVm/ajX/WMZRNYSnmdgUAu3gd1T3WyQ2/k5kj2U0hDFElY Q7sQlRzV/c6DHv5djKGWuE1datt5BCu1GGmCSacumHoji0UaSWWj2KbUHqV6dp18VcOq iSby1MhzYY3lgOspxmALcR2Pi7zJ5yCa2WT0kp0L6UacxlrAXPNRVI8HS5QHeo6XU8N0 B4EA== X-Gm-Message-State: AOAM532/k4QVrBnJdhq+dmPOOSV09mrHRQvnvXmy4cWA7rm5KtBABfKq vhF7q/Rj7zd9K4mfA+JhHZo= X-Google-Smtp-Source: ABdhPJwbgrvGfwIHcZOZp109liCaJrw9YaBgOf4XJA09GOGM32tLWxdZtCi3S4uiUaovdFwuWDmn/g== X-Received: by 2002:a5d:64cd:: with SMTP id f13mr10997199wri.92.1635025797098; Sat, 23 Oct 2021 14:49:57 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 23/33] target/mips: Convert MSA 3R instruction format to decodetree (part 2/4) Date: Sat, 23 Oct 2021 23:47:53 +0200 Message-Id: <20211023214803.522078-24-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025800240100003 Convert 3-register operations to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 11 ++ target/mips/tcg/msa_translate.c | 213 +++++++++----------------------- 2 files changed, 66 insertions(+), 158 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index ca0fd568560..4a9cf85fa7a 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -80,10 +80,21 @@ BNZ 010001 111 .. ..... ...............= . @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + DOTP_S 011110 000.. ..... ..... ..... 010011 @3r + DOTP_U 011110 001.. ..... ..... ..... 010011 @3r + DPADD_S 011110 010.. ..... ..... ..... 010011 @3r + DPADD_U 011110 011.. ..... ..... ..... 010011 @3r + DPSUB_S 011110 100.. ..... ..... ..... 010011 @3r + DPSUB_U 011110 101.. ..... ..... ..... 010011 @3r + SLD 011110 000 .. ..... ..... ..... 010100 @3r SPLAT 011110 001 .. ..... ..... ..... 010100 @3r =20 VSHF 011110 000 .. ..... ..... ..... 010101 @3r + HADD_S 011110 100.. ..... ..... ..... 010101 @3r + HADD_U 011110 101.. ..... ..... ..... 010101 @3r + HSUB_S 011110 110.. ..... ..... ..... 010101 @3r + HSUB_U 011110 111.. ..... ..... ..... 010101 @3r =20 FCAF 011110 0000 . ..... ..... ..... 011010 @3rf FCUN 011110 0001 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 0c7055c68bd..e1da532e5c9 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -44,13 +44,11 @@ enum { OPC_ADD_A_df =3D (0x0 << 23) | OPC_MSA_3R_10, OPC_SUBS_S_df =3D (0x0 << 23) | OPC_MSA_3R_11, OPC_MULV_df =3D (0x0 << 23) | OPC_MSA_3R_12, - OPC_DOTP_S_df =3D (0x0 << 23) | OPC_MSA_3R_13, OPC_SRA_df =3D (0x1 << 23) | OPC_MSA_3R_0D, OPC_SUBV_df =3D (0x1 << 23) | OPC_MSA_3R_0E, OPC_ADDS_A_df =3D (0x1 << 23) | OPC_MSA_3R_10, OPC_SUBS_U_df =3D (0x1 << 23) | OPC_MSA_3R_11, OPC_MADDV_df =3D (0x1 << 23) | OPC_MSA_3R_12, - OPC_DOTP_U_df =3D (0x1 << 23) | OPC_MSA_3R_13, OPC_SRAR_df =3D (0x1 << 23) | OPC_MSA_3R_15, OPC_SRL_df =3D (0x2 << 23) | OPC_MSA_3R_0D, OPC_MAX_S_df =3D (0x2 << 23) | OPC_MSA_3R_0E, @@ -58,7 +56,6 @@ enum { OPC_ADDS_S_df =3D (0x2 << 23) | OPC_MSA_3R_10, OPC_SUBSUS_U_df =3D (0x2 << 23) | OPC_MSA_3R_11, OPC_MSUBV_df =3D (0x2 << 23) | OPC_MSA_3R_12, - OPC_DPADD_S_df =3D (0x2 << 23) | OPC_MSA_3R_13, OPC_PCKEV_df =3D (0x2 << 23) | OPC_MSA_3R_14, OPC_SRLR_df =3D (0x2 << 23) | OPC_MSA_3R_15, OPC_BCLR_df =3D (0x3 << 23) | OPC_MSA_3R_0D, @@ -66,7 +63,6 @@ enum { OPC_CLT_U_df =3D (0x3 << 23) | OPC_MSA_3R_0F, OPC_ADDS_U_df =3D (0x3 << 23) | OPC_MSA_3R_10, OPC_SUBSUU_S_df =3D (0x3 << 23) | OPC_MSA_3R_11, - OPC_DPADD_U_df =3D (0x3 << 23) | OPC_MSA_3R_13, OPC_PCKOD_df =3D (0x3 << 23) | OPC_MSA_3R_14, OPC_BSET_df =3D (0x4 << 23) | OPC_MSA_3R_0D, OPC_MIN_S_df =3D (0x4 << 23) | OPC_MSA_3R_0E, @@ -74,30 +70,24 @@ enum { OPC_AVE_S_df =3D (0x4 << 23) | OPC_MSA_3R_10, OPC_ASUB_S_df =3D (0x4 << 23) | OPC_MSA_3R_11, OPC_DIV_S_df =3D (0x4 << 23) | OPC_MSA_3R_12, - OPC_DPSUB_S_df =3D (0x4 << 23) | OPC_MSA_3R_13, OPC_ILVL_df =3D (0x4 << 23) | OPC_MSA_3R_14, - OPC_HADD_S_df =3D (0x4 << 23) | OPC_MSA_3R_15, OPC_BNEG_df =3D (0x5 << 23) | OPC_MSA_3R_0D, OPC_MIN_U_df =3D (0x5 << 23) | OPC_MSA_3R_0E, OPC_CLE_U_df =3D (0x5 << 23) | OPC_MSA_3R_0F, OPC_AVE_U_df =3D (0x5 << 23) | OPC_MSA_3R_10, OPC_ASUB_U_df =3D (0x5 << 23) | OPC_MSA_3R_11, OPC_DIV_U_df =3D (0x5 << 23) | OPC_MSA_3R_12, - OPC_DPSUB_U_df =3D (0x5 << 23) | OPC_MSA_3R_13, OPC_ILVR_df =3D (0x5 << 23) | OPC_MSA_3R_14, - OPC_HADD_U_df =3D (0x5 << 23) | OPC_MSA_3R_15, OPC_BINSL_df =3D (0x6 << 23) | OPC_MSA_3R_0D, OPC_MAX_A_df =3D (0x6 << 23) | OPC_MSA_3R_0E, OPC_AVER_S_df =3D (0x6 << 23) | OPC_MSA_3R_10, OPC_MOD_S_df =3D (0x6 << 23) | OPC_MSA_3R_12, OPC_ILVEV_df =3D (0x6 << 23) | OPC_MSA_3R_14, - OPC_HSUB_S_df =3D (0x6 << 23) | OPC_MSA_3R_15, OPC_BINSR_df =3D (0x7 << 23) | OPC_MSA_3R_0D, OPC_MIN_A_df =3D (0x7 << 23) | OPC_MSA_3R_0E, OPC_AVER_U_df =3D (0x7 << 23) | OPC_MSA_3R_10, OPC_MOD_U_df =3D (0x7 << 23) | OPC_MSA_3R_12, OPC_ILVOD_df =3D (0x7 << 23) | OPC_MSA_3R_14, - OPC_HSUB_U_df =3D (0x7 << 23) | OPC_MSA_3R_15, =20 /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ OPC_SLDI_df =3D (0x0 << 22) | (0x00 << 16) | OPC_MSA_ELM, @@ -209,6 +199,10 @@ static inline bool check_msa_access(DisasContext *ctx) TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d) =20 +#define TRANS_DF_B(NAME, trans_func, gen_func) \ + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ + NULL, gen_func##_h, gen_func##_w, gen_func##_d) + static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, TCGCond cond) { @@ -484,10 +478,61 @@ static bool trans_msa_3r_df(DisasContext *ctx, arg_ms= a_r *a, return true; } =20 +static bool trans_msa_3r(DisasContext *ctx, arg_msa_r *a, + void (*gen_msa_3r_b)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_3r_h)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_3r_w)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_3r_d)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32)) +{ + TCGv_i32 twd =3D tcg_const_i32(a->wd); + TCGv_i32 tws =3D tcg_const_i32(a->ws); + TCGv_i32 twt =3D tcg_const_i32(a->wt); + + switch (a->df) { + case DF_BYTE: + if (gen_msa_3r_b =3D=3D NULL) { + gen_reserved_instruction(ctx); + } else { + gen_msa_3r_b(cpu_env, twd, tws, twt); + } + break; + case DF_HALF: + gen_msa_3r_h(cpu_env, twd, tws, twt); + break; + case DF_WORD: + gen_msa_3r_w(cpu_env, twd, tws, twt); + break; + case DF_DOUBLE: + gen_msa_3r_d(cpu_env, twd, tws, twt); + break; + } + + tcg_temp_free_i32(twt); + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twd); + + return true; +} + +TRANS_DF_B(DOTP_S, trans_msa_3r, gen_helper_msa_dotp_s); +TRANS_DF_B(DOTP_U, trans_msa_3r, gen_helper_msa_dotp_u); +TRANS_DF_B(DPADD_S, trans_msa_3r, gen_helper_msa_dpadd_s); +TRANS_DF_B(DPADD_U, trans_msa_3r, gen_helper_msa_dpadd_u); +TRANS_DF_B(DPSUB_S, trans_msa_3r, gen_helper_msa_dpsub_s); +TRANS_DF_B(DPSUB_U, trans_msa_3r, gen_helper_msa_dpsub_u); + TRANS_MSA(SLD, trans_msa_3r_df, gen_helper_msa_sld_df); TRANS_MSA(SPLAT, trans_msa_3r_df, gen_helper_msa_splat_df); =20 TRANS_MSA(VSHF, trans_msa_3r_df, gen_helper_msa_vshf_df); +TRANS_DF_B(HADD_S, trans_msa_3r, gen_helper_msa_hadd_s); +TRANS_DF_B(HADD_U, trans_msa_3r, gen_helper_msa_hadd_u); +TRANS_DF_B(HSUB_S, trans_msa_3r, gen_helper_msa_hsub_s); +TRANS_DF_B(HSUB_U, trans_msa_3r, gen_helper_msa_hsub_u); =20 static void gen_msa_3r(DisasContext *ctx) { @@ -1303,154 +1348,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - - case OPC_DOTP_S_df: - case OPC_DOTP_U_df: - case OPC_DPADD_S_df: - case OPC_DPADD_U_df: - case OPC_DPSUB_S_df: - case OPC_HADD_S_df: - case OPC_DPSUB_U_df: - case OPC_HADD_U_df: - case OPC_HSUB_S_df: - case OPC_HSUB_U_df: - if (df =3D=3D DF_BYTE) { - gen_reserved_instruction(ctx); - break; - } - switch (MASK_MSA_3R(ctx->opcode)) { - case OPC_HADD_S_df: - switch (df) { - case DF_HALF: - gen_helper_msa_hadd_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_hadd_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_hadd_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_HADD_U_df: - switch (df) { - case DF_HALF: - gen_helper_msa_hadd_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_hadd_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_hadd_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_HSUB_S_df: - switch (df) { - case DF_HALF: - gen_helper_msa_hsub_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_hsub_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_hsub_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_HSUB_U_df: - switch (df) { - case DF_HALF: - gen_helper_msa_hsub_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_hsub_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_hsub_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DOTP_S_df: - switch (df) { - case DF_HALF: - gen_helper_msa_dotp_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_dotp_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_dotp_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DOTP_U_df: - switch (df) { - case DF_HALF: - gen_helper_msa_dotp_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_dotp_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_dotp_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DPADD_S_df: - switch (df) { - case DF_HALF: - gen_helper_msa_dpadd_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_dpadd_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_dpadd_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DPADD_U_df: - switch (df) { - case DF_HALF: - gen_helper_msa_dpadd_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_dpadd_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_dpadd_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DPSUB_S_df: - switch (df) { - case DF_HALF: - gen_helper_msa_dpsub_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_dpsub_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_dpsub_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DPSUB_U_df: - switch (df) { - case DF_HALF: - gen_helper_msa_dpsub_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_dpsub_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_dpsub_u_d(cpu_env, twd, tws, twt); - break; - } - break; - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025803; cv=none; d=zohomail.com; s=zohoarc; b=lVoiUfdvTqWhMAsH/7QF3Vmg7gDFzS0SN9kP76R8q/sTwTbXHC+luraUS+4yA6zBG4TfDdiavxhu0iMHx0/+nG1/gMThB2JnD74ZGl+ki0ey09giNW5XaWNFqJjeH7Wo1tMPrBlW/yippVDJfXoMpWVvGrTx7nULI0CsiRfUsSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025803; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0YrhHvQhCI1smRtdOyBIO6rYsfXznJ3uddD3K7WX1EM=; b=jAjRAyAIdTS/5xtseOnxK0IajgDtAZI86ve6jE0kiOjVdjDf7AR+i9YO6gd7KUmjNqrri4o4moaQoImNh5e213wllImK27t6pbFbLXg37xXWjqkUORXtH02mv+kPa6JxIozBg108A6M1zg7c9SNFAHsF/GjMg6uQ/ri2X0F9fIY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 1635025803920568.8983411312115; Sat, 23 Oct 2021 14:50:03 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id g141so6567337wmg.4 for ; Sat, 23 Oct 2021 14:50:03 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id m15sm12369083wmq.0.2021.10.23.14.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0YrhHvQhCI1smRtdOyBIO6rYsfXznJ3uddD3K7WX1EM=; b=XNQ0OFWChBPPxUM/S5D3YgXD0E9HY/BS7D22AadXe87Bjr/k5ICkfoohwOUubBEsF6 gySsNU6kM6ND4d+vjjMsob1rl9OdBZE5mBilR8pRJgZek6nO4jvEXaqsLhhDPb+L6amY jy/qhLNqJ7vMbjikCe9bbiw1L8oy4rqbFnCf8/EobgctnIda1syvvgWQ1EIrb2RuQG7Z Ny+TgxCg6a8XZAUePdP0SFSkbPVAR4DijMXy80PjivnHMcxJcEQwZ0Jy8gnG6hMgKAtF OWYROfqNcx4v2gsAvblMIM6JaFuIrD7T9/Ex5xqHO3A/STM/XdsbfkEETgsaQU6I8xut YxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0YrhHvQhCI1smRtdOyBIO6rYsfXznJ3uddD3K7WX1EM=; b=BgaPOZCTmTHVvGvoQjriZA4nTGzZJdA+DLPcY1ly2beP133RvwbuUr9/ZmZqcwWNMG TlUnB7teGGIA6DOy3p+16U6Gpg92qiID0t6aQM6gGPGpQJhXn/U/081zBuIGtkxRInis 2lsh007wmulcKX+7nVbk5h1hO3GsUfGrt6n5kNT1q/g2eXB3hn6nR9xaar9WuQrcyCBT 3+vffkurh3FlovDUVZlgLiTJG0v1bEqcRtNYynnMYrR57Rl/W19K8OgXJOtP2SCQn36Q LtPbd3yiIlxuzxpjWL4qdw3L9LZoAn2CSMzlwXbPQEID4sTmIxcHpSEU+DKrp4S34UA7 zRJA== X-Gm-Message-State: AOAM533TjP6GqRSZiAMgYRv3ttfilXfCCFTWIVSSvOUVvgNRR97D5C+D AtfDnm0uizWGuYa+2LMS1FZsqQz5BG8= X-Google-Smtp-Source: ABdhPJyuHnoGeFFWHhvMmEX0+GsJvbUaGdY3I4rEBg4bmvxXt8fbta7c9Sa1et6/bxzcZpPd1ilISA== X-Received: by 2002:a7b:c413:: with SMTP id k19mr2884560wmi.142.1635025802247; Sat, 23 Oct 2021 14:50:02 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 24/33] target/mips: Convert MSA 3R instruction format to decodetree (part 3/4) Date: Sat, 23 Oct 2021 23:47:54 +0200 Message-Id: <20211023214803.522078-25-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025804318100001 Convert BINSL (Vector Bit Insert Left) and BINSR (Vector Bit Insert Right) opcodes to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 3 +++ target/mips/tcg/msa_translate.c | 37 +++------------------------------ 2 files changed, 6 insertions(+), 34 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 4a9cf85fa7a..1d6fd86ef3d 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -80,6 +80,9 @@ BNZ 010001 111 .. ..... ................ = @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + BINSL 011110 110.. ..... ..... ..... 001101 @3r + BINSR 011110 111.. ..... ..... ..... 001101 @3r + DOTP_S 011110 000.. ..... ..... ..... 010011 @3r DOTP_U 011110 001.. ..... ..... ..... 010011 @3r DPADD_S 011110 010.. ..... ..... ..... 010011 @3r diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index e1da532e5c9..1b69ec149a5 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -78,12 +78,10 @@ enum { OPC_ASUB_U_df =3D (0x5 << 23) | OPC_MSA_3R_11, OPC_DIV_U_df =3D (0x5 << 23) | OPC_MSA_3R_12, OPC_ILVR_df =3D (0x5 << 23) | OPC_MSA_3R_14, - OPC_BINSL_df =3D (0x6 << 23) | OPC_MSA_3R_0D, OPC_MAX_A_df =3D (0x6 << 23) | OPC_MSA_3R_0E, OPC_AVER_S_df =3D (0x6 << 23) | OPC_MSA_3R_10, OPC_MOD_S_df =3D (0x6 << 23) | OPC_MSA_3R_12, OPC_ILVEV_df =3D (0x6 << 23) | OPC_MSA_3R_14, - OPC_BINSR_df =3D (0x7 << 23) | OPC_MSA_3R_0D, OPC_MIN_A_df =3D (0x7 << 23) | OPC_MSA_3R_0E, OPC_AVER_U_df =3D (0x7 << 23) | OPC_MSA_3R_10, OPC_MOD_U_df =3D (0x7 << 23) | OPC_MSA_3R_12, @@ -518,6 +516,9 @@ static bool trans_msa_3r(DisasContext *ctx, arg_msa_r *= a, return true; } =20 +TRANS_DF_E(BINSL, trans_msa_3r, gen_helper_msa_binsl); +TRANS_DF_E(BINSR, trans_msa_3r, gen_helper_msa_binsr); + TRANS_DF_B(DOTP_S, trans_msa_3r, gen_helper_msa_dotp_s); TRANS_DF_B(DOTP_U, trans_msa_3r, gen_helper_msa_dotp_u); TRANS_DF_B(DPADD_S, trans_msa_3r, gen_helper_msa_dpadd_s); @@ -548,38 +549,6 @@ static void gen_msa_3r(DisasContext *ctx) TCGv_i32 twt =3D tcg_const_i32(wt); =20 switch (MASK_MSA_3R(ctx->opcode)) { - case OPC_BINSL_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_binsl_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_binsl_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_binsl_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_binsl_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_BINSR_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_binsr_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_binsr_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_binsr_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_binsr_d(cpu_env, twd, tws, twt); - break; - } - break; case OPC_BCLR_df: switch (df) { case DF_BYTE: --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025809; cv=none; d=zohomail.com; s=zohoarc; b=I83dWaL9xE3XjFQLTEX0FSZvaSSDl9DVNJ8dwV1a1DZ79yylDDRNHlioz/W6OMm8B7LBiBns+jqKUQ7S/3rCogGiHbsFEAkAcZq8XcxEsqbEkpIRYOPY+wfQmYDAYdQsWvNT3d4wJNGHqsK6iUZzPxeX1oO2Aue5lqmIr+fHpjE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025809; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZJZwaVHlByWEV1I2KOab7SpQV5BrdWj9m0L75aq5ezM=; b=BgpGQNPgy9/kwgoL7Z51watYnoHIYR28etCLbhcY0OelU2LM60Ev9JZIfp+9AHe0UGDGT5dKJkvp95jSru7IwK4FZQNUE7HDKTnt6dvS5mpJLnEBFDLxWJzKuathRmH8tRpRE3gL+C7oKIGGxEMyRCVvGJdhu7WDNfPrtd+7cxU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635025809438520.350240833004; Sat, 23 Oct 2021 14:50:09 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id e12so4788231wra.4 for ; Sat, 23 Oct 2021 14:50:08 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id r15sm6134227wru.9.2021.10.23.14.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZJZwaVHlByWEV1I2KOab7SpQV5BrdWj9m0L75aq5ezM=; b=KF+SeY6qB1Z5hpG3tFMRN5NQoSKr9sBHhssCc55/9/IT1pXalIUUmXcOV28jz1PxPK 7X/RXS/+QRBShfdiqh/3TAF9IaHwAG0Ennl3bhYWyyY3bDatPkeIUz3+/Wc3cTiuKZ7k WqTzbo1sKlzhG4CNxrHylORrKwqNyRltEPebzz05YHkODc4xP+LIX/F318tbc8GvEUod FFZqi4I0zhwEQlHfGtxZhLeX2HOMaIARWutBKgRoYSFH8VFsgvnjXthB7Iqic/V4xY38 84hyMoINOc+UU4cezjaXa7g5isQrNAVOCl6QKfD1qKCBKxQY/LqYq6w8QrLSkZiLO2Lv tNFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZJZwaVHlByWEV1I2KOab7SpQV5BrdWj9m0L75aq5ezM=; b=AGGizP75+eQBq+5LcuQD9q4t1nLbvDcRUiysgPxD9IMA4yxmTVnBQop2HM49/ExrDc ppl/DOqh2l0X5NzJjthyyHPFE9fiH4yS5TlZEePnOniBsxjM5WHKYbT6a78MLfhk0kqi iR6x4QEJNfCgsXRz1ri1aBgbHQx2ew2sMDcWUy2yQOBvfDfarXToH3moYDzAMROeIt+h RAKq7jcRJGGnd4imiplcM1O+lrwoyV1RRwAx4WktxClPpYcB6EjfgGjjINNH/k+5a43i QkfGR0WjBT64GYjnAnje2KREYrYjQLBcJ9co7x0FfKOizZoQSb8gUqXKledB8abuBgTI P6pQ== X-Gm-Message-State: AOAM532WLt3R+0y5mFYx0RUWg2Ceypzi+Yd7FZzCO7t9MV7a1k9J5DdG YXnU3Ws1FaZZIkrSo6Yyb2E= X-Google-Smtp-Source: ABdhPJwzQk4D4+FMUKOzqOTxrSOKoGwx18dZmiOn04aDIdTmHrVge8n4CHSs/diKmpSo8UgXn7utcw== X-Received: by 2002:adf:ee8d:: with SMTP id b13mr3751547wro.50.1635025807451; Sat, 23 Oct 2021 14:50:07 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 25/33] target/mips: Convert MSA 3R instruction format to decodetree (part 4/4) Date: Sat, 23 Oct 2021 23:47:55 +0200 Message-Id: <20211023214803.522078-26-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025810462100001 Convert 3-register operations to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 53 ++ target/mips/tcg/msa_translate.c | 916 ++------------------------------ 2 files changed, 106 insertions(+), 863 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 1d6fd86ef3d..3d0d9a52675 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -80,9 +80,54 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + SLL 011110 000.. ..... ..... ..... 001101 @3r + SRA 011110 001.. ..... ..... ..... 001101 @3r + SRL 011110 010.. ..... ..... ..... 001101 @3r + BCLR 011110 011.. ..... ..... ..... 001101 @3r + BSET 011110 100.. ..... ..... ..... 001101 @3r + BNEG 011110 101.. ..... ..... ..... 001101 @3r BINSL 011110 110.. ..... ..... ..... 001101 @3r BINSR 011110 111.. ..... ..... ..... 001101 @3r =20 + ADDV 011110 000.. ..... ..... ..... 001110 @3r + SUBV 011110 001.. ..... ..... ..... 001110 @3r + MAX_S 011110 010.. ..... ..... ..... 001110 @3r + MAX_U 011110 011.. ..... ..... ..... 001110 @3r + MIN_S 011110 100.. ..... ..... ..... 001110 @3r + MIN_U 011110 101.. ..... ..... ..... 001110 @3r + MAX_A 011110 110.. ..... ..... ..... 001110 @3r + MIN_A 011110 111.. ..... ..... ..... 001110 @3r + + CEQ 011110 000.. ..... ..... ..... 001111 @3r + CLT_S 011110 010.. ..... ..... ..... 001111 @3r + CLT_U 011110 011.. ..... ..... ..... 001111 @3r + CLE_S 011110 100.. ..... ..... ..... 001111 @3r + CLE_U 011110 101.. ..... ..... ..... 001111 @3r + + ADD_A 011110 000.. ..... ..... ..... 010000 @3r + ADDS_A 011110 001.. ..... ..... ..... 010000 @3r + ADDS_S 011110 010.. ..... ..... ..... 010000 @3r + ADDS_U 011110 011.. ..... ..... ..... 010000 @3r + AVE_S 011110 100.. ..... ..... ..... 010000 @3r + AVE_U 011110 101.. ..... ..... ..... 010000 @3r + AVER_S 011110 110.. ..... ..... ..... 010000 @3r + AVER_U 011110 111.. ..... ..... ..... 010000 @3r + + SUBS_S 011110 000.. ..... ..... ..... 010001 @3r + SUBS_U 011110 001.. ..... ..... ..... 010001 @3r + SUBSUS_U 011110 010.. ..... ..... ..... 010001 @3r + SUBSUU_S 011110 011.. ..... ..... ..... 010001 @3r + ASUB_S 011110 100.. ..... ..... ..... 010001 @3r + ASUB_U 011110 101.. ..... ..... ..... 010001 @3r + + MULV 011110 000.. ..... ..... ..... 010010 @3r + MADDV 011110 001.. ..... ..... ..... 010010 @3r + MSUBV 011110 010.. ..... ..... ..... 010010 @3r + DIV_S 011110 100.. ..... ..... ..... 010010 @3r + DIV_U 011110 101.. ..... ..... ..... 010010 @3r + MOD_S 011110 110.. ..... ..... ..... 010010 @3r + MOD_U 011110 111.. ..... ..... ..... 010010 @3r + DOTP_S 011110 000.. ..... ..... ..... 010011 @3r DOTP_U 011110 001.. ..... ..... ..... 010011 @3r DPADD_S 011110 010.. ..... ..... ..... 010011 @3r @@ -92,8 +137,16 @@ BNZ 010001 111 .. ..... ...............= . @bz =20 SLD 011110 000 .. ..... ..... ..... 010100 @3r SPLAT 011110 001 .. ..... ..... ..... 010100 @3r + PCKEV 011110 010 .. ..... ..... ..... 010100 @3r + PCKOD 011110 011 .. ..... ..... ..... 010100 @3r + ILVL 011110 100 .. ..... ..... ..... 010100 @3r + ILVR 011110 101 .. ..... ..... ..... 010100 @3r + ILVEV 011110 110 .. ..... ..... ..... 010100 @3r + ILVOD 011110 111 .. ..... ..... ..... 010100 @3r =20 VSHF 011110 000 .. ..... ..... ..... 010101 @3r + SRAR 011110 001 .. ..... ..... ..... 010101 @3r + SRLR 011110 010 .. ..... ..... ..... 010101 @3r HADD_S 011110 100.. ..... ..... ..... 010101 @3r HADD_U 011110 101.. ..... ..... ..... 010101 @3r HSUB_S 011110 110.. ..... ..... ..... 010101 @3r diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 1b69ec149a5..7813c126069 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -24,69 +24,10 @@ =20 #define MASK_MSA_MINOR(op) (MASK_OP_MAJOR(op) | (op & 0x3F)) enum { - OPC_MSA_3R_0D =3D 0x0D | OPC_MSA, - OPC_MSA_3R_0E =3D 0x0E | OPC_MSA, - OPC_MSA_3R_0F =3D 0x0F | OPC_MSA, - OPC_MSA_3R_10 =3D 0x10 | OPC_MSA, - OPC_MSA_3R_11 =3D 0x11 | OPC_MSA, - OPC_MSA_3R_12 =3D 0x12 | OPC_MSA, - OPC_MSA_3R_13 =3D 0x13 | OPC_MSA, - OPC_MSA_3R_14 =3D 0x14 | OPC_MSA, - OPC_MSA_3R_15 =3D 0x15 | OPC_MSA, OPC_MSA_ELM =3D 0x19 | OPC_MSA, }; =20 enum { - /* 3R instruction df(bits 22..21) =3D _b, _h, _w, d */ - OPC_SLL_df =3D (0x0 << 23) | OPC_MSA_3R_0D, - OPC_ADDV_df =3D (0x0 << 23) | OPC_MSA_3R_0E, - OPC_CEQ_df =3D (0x0 << 23) | OPC_MSA_3R_0F, - OPC_ADD_A_df =3D (0x0 << 23) | OPC_MSA_3R_10, - OPC_SUBS_S_df =3D (0x0 << 23) | OPC_MSA_3R_11, - OPC_MULV_df =3D (0x0 << 23) | OPC_MSA_3R_12, - OPC_SRA_df =3D (0x1 << 23) | OPC_MSA_3R_0D, - OPC_SUBV_df =3D (0x1 << 23) | OPC_MSA_3R_0E, - OPC_ADDS_A_df =3D (0x1 << 23) | OPC_MSA_3R_10, - OPC_SUBS_U_df =3D (0x1 << 23) | OPC_MSA_3R_11, - OPC_MADDV_df =3D (0x1 << 23) | OPC_MSA_3R_12, - OPC_SRAR_df =3D (0x1 << 23) | OPC_MSA_3R_15, - OPC_SRL_df =3D (0x2 << 23) | OPC_MSA_3R_0D, - OPC_MAX_S_df =3D (0x2 << 23) | OPC_MSA_3R_0E, - OPC_CLT_S_df =3D (0x2 << 23) | OPC_MSA_3R_0F, - OPC_ADDS_S_df =3D (0x2 << 23) | OPC_MSA_3R_10, - OPC_SUBSUS_U_df =3D (0x2 << 23) | OPC_MSA_3R_11, - OPC_MSUBV_df =3D (0x2 << 23) | OPC_MSA_3R_12, - OPC_PCKEV_df =3D (0x2 << 23) | OPC_MSA_3R_14, - OPC_SRLR_df =3D (0x2 << 23) | OPC_MSA_3R_15, - OPC_BCLR_df =3D (0x3 << 23) | OPC_MSA_3R_0D, - OPC_MAX_U_df =3D (0x3 << 23) | OPC_MSA_3R_0E, - OPC_CLT_U_df =3D (0x3 << 23) | OPC_MSA_3R_0F, - OPC_ADDS_U_df =3D (0x3 << 23) | OPC_MSA_3R_10, - OPC_SUBSUU_S_df =3D (0x3 << 23) | OPC_MSA_3R_11, - OPC_PCKOD_df =3D (0x3 << 23) | OPC_MSA_3R_14, - OPC_BSET_df =3D (0x4 << 23) | OPC_MSA_3R_0D, - OPC_MIN_S_df =3D (0x4 << 23) | OPC_MSA_3R_0E, - OPC_CLE_S_df =3D (0x4 << 23) | OPC_MSA_3R_0F, - OPC_AVE_S_df =3D (0x4 << 23) | OPC_MSA_3R_10, - OPC_ASUB_S_df =3D (0x4 << 23) | OPC_MSA_3R_11, - OPC_DIV_S_df =3D (0x4 << 23) | OPC_MSA_3R_12, - OPC_ILVL_df =3D (0x4 << 23) | OPC_MSA_3R_14, - OPC_BNEG_df =3D (0x5 << 23) | OPC_MSA_3R_0D, - OPC_MIN_U_df =3D (0x5 << 23) | OPC_MSA_3R_0E, - OPC_CLE_U_df =3D (0x5 << 23) | OPC_MSA_3R_0F, - OPC_AVE_U_df =3D (0x5 << 23) | OPC_MSA_3R_10, - OPC_ASUB_U_df =3D (0x5 << 23) | OPC_MSA_3R_11, - OPC_DIV_U_df =3D (0x5 << 23) | OPC_MSA_3R_12, - OPC_ILVR_df =3D (0x5 << 23) | OPC_MSA_3R_14, - OPC_MAX_A_df =3D (0x6 << 23) | OPC_MSA_3R_0E, - OPC_AVER_S_df =3D (0x6 << 23) | OPC_MSA_3R_10, - OPC_MOD_S_df =3D (0x6 << 23) | OPC_MSA_3R_12, - OPC_ILVEV_df =3D (0x6 << 23) | OPC_MSA_3R_14, - OPC_MIN_A_df =3D (0x7 << 23) | OPC_MSA_3R_0E, - OPC_AVER_U_df =3D (0x7 << 23) | OPC_MSA_3R_10, - OPC_MOD_U_df =3D (0x7 << 23) | OPC_MSA_3R_12, - OPC_ILVOD_df =3D (0x7 << 23) | OPC_MSA_3R_14, - /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ OPC_SLDI_df =3D (0x0 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, @@ -516,9 +457,54 @@ static bool trans_msa_3r(DisasContext *ctx, arg_msa_r = *a, return true; } =20 +TRANS_DF_E(SLL, trans_msa_3r, gen_helper_msa_sll); +TRANS_DF_E(SRA, trans_msa_3r, gen_helper_msa_sra); +TRANS_DF_E(SRL, trans_msa_3r, gen_helper_msa_srl); +TRANS_DF_E(BCLR, trans_msa_3r, gen_helper_msa_bclr); +TRANS_DF_E(BSET, trans_msa_3r, gen_helper_msa_bset); +TRANS_DF_E(BNEG, trans_msa_3r, gen_helper_msa_bneg); TRANS_DF_E(BINSL, trans_msa_3r, gen_helper_msa_binsl); TRANS_DF_E(BINSR, trans_msa_3r, gen_helper_msa_binsr); =20 +TRANS_DF_E(ADDV, trans_msa_3r, gen_helper_msa_addv); +TRANS_DF_E(SUBV, trans_msa_3r, gen_helper_msa_subv); +TRANS_DF_E(MAX_S, trans_msa_3r, gen_helper_msa_max_s); +TRANS_DF_E(MAX_U, trans_msa_3r, gen_helper_msa_max_u); +TRANS_DF_E(MIN_S, trans_msa_3r, gen_helper_msa_min_s); +TRANS_DF_E(MIN_U, trans_msa_3r, gen_helper_msa_min_u); +TRANS_DF_E(MAX_A, trans_msa_3r, gen_helper_msa_max_a); +TRANS_DF_E(MIN_A, trans_msa_3r, gen_helper_msa_min_a); + +TRANS_DF_E(CEQ, trans_msa_3r, gen_helper_msa_ceq); +TRANS_DF_E(CLT_S, trans_msa_3r, gen_helper_msa_clt_s); +TRANS_DF_E(CLT_U, trans_msa_3r, gen_helper_msa_clt_u); +TRANS_DF_E(CLE_S, trans_msa_3r, gen_helper_msa_cle_s); +TRANS_DF_E(CLE_U, trans_msa_3r, gen_helper_msa_cle_u); + +TRANS_DF_E(ADD_A, trans_msa_3r, gen_helper_msa_add_a); +TRANS_DF_E(ADDS_A, trans_msa_3r, gen_helper_msa_adds_a); +TRANS_DF_E(ADDS_S, trans_msa_3r, gen_helper_msa_adds_s); +TRANS_DF_E(ADDS_U, trans_msa_3r, gen_helper_msa_adds_u); +TRANS_DF_E(AVE_S, trans_msa_3r, gen_helper_msa_ave_s); +TRANS_DF_E(AVE_U, trans_msa_3r, gen_helper_msa_ave_u); +TRANS_DF_E(AVER_S, trans_msa_3r, gen_helper_msa_aver_s); +TRANS_DF_E(AVER_U, trans_msa_3r, gen_helper_msa_aver_u); + +TRANS_DF_E(SUBS_S, trans_msa_3r, gen_helper_msa_subs_s); +TRANS_DF_E(SUBS_U, trans_msa_3r, gen_helper_msa_subs_u); +TRANS_DF_E(SUBSUS_U, trans_msa_3r, gen_helper_msa_subsus_u); +TRANS_DF_E(SUBSUU_S, trans_msa_3r, gen_helper_msa_subsuu_s); +TRANS_DF_E(ASUB_S, trans_msa_3r, gen_helper_msa_asub_s); +TRANS_DF_E(ASUB_U, trans_msa_3r, gen_helper_msa_asub_u); + +TRANS_DF_E(MULV, trans_msa_3r, gen_helper_msa_mulv); +TRANS_DF_E(MADDV, trans_msa_3r, gen_helper_msa_maddv); +TRANS_DF_E(MSUBV, trans_msa_3r, gen_helper_msa_msubv); +TRANS_DF_E(DIV_S, trans_msa_3r, gen_helper_msa_div_s); +TRANS_DF_E(DIV_U, trans_msa_3r, gen_helper_msa_div_u); +TRANS_DF_E(MOD_S, trans_msa_3r, gen_helper_msa_mod_s); +TRANS_DF_E(MOD_U, trans_msa_3r, gen_helper_msa_mod_u); + TRANS_DF_B(DOTP_S, trans_msa_3r, gen_helper_msa_dotp_s); TRANS_DF_B(DOTP_U, trans_msa_3r, gen_helper_msa_dotp_u); TRANS_DF_B(DPADD_S, trans_msa_3r, gen_helper_msa_dpadd_s); @@ -528,806 +514,21 @@ TRANS_DF_B(DPSUB_U, trans_msa_3r, gen_helper_= msa_dpsub_u); =20 TRANS_MSA(SLD, trans_msa_3r_df, gen_helper_msa_sld_df); TRANS_MSA(SPLAT, trans_msa_3r_df, gen_helper_msa_splat_df); +TRANS_DF_E(PCKEV, trans_msa_3r, gen_helper_msa_pckev); +TRANS_DF_E(PCKOD, trans_msa_3r, gen_helper_msa_pckod); +TRANS_DF_E(ILVL, trans_msa_3r, gen_helper_msa_ilvl); +TRANS_DF_E(ILVR, trans_msa_3r, gen_helper_msa_ilvr); +TRANS_DF_E(ILVEV, trans_msa_3r, gen_helper_msa_ilvev); +TRANS_DF_E(ILVOD, trans_msa_3r, gen_helper_msa_ilvod); =20 TRANS_MSA(VSHF, trans_msa_3r_df, gen_helper_msa_vshf_df); +TRANS_DF_E(SRAR, trans_msa_3r, gen_helper_msa_srar); +TRANS_DF_E(SRLR, trans_msa_3r, gen_helper_msa_srlr); TRANS_DF_B(HADD_S, trans_msa_3r, gen_helper_msa_hadd_s); TRANS_DF_B(HADD_U, trans_msa_3r, gen_helper_msa_hadd_u); TRANS_DF_B(HSUB_S, trans_msa_3r, gen_helper_msa_hsub_s); TRANS_DF_B(HSUB_U, trans_msa_3r, gen_helper_msa_hsub_u); =20 -static void gen_msa_3r(DisasContext *ctx) -{ -#define MASK_MSA_3R(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - uint8_t df =3D (ctx->opcode >> 21) & 0x3; - uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - - TCGv_i32 tdf =3D tcg_const_i32(df); - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twt =3D tcg_const_i32(wt); - - switch (MASK_MSA_3R(ctx->opcode)) { - case OPC_BCLR_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_bclr_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_bclr_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_bclr_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_bclr_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_BNEG_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_bneg_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_bneg_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_bneg_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_bneg_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_BSET_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_bset_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_bset_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_bset_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_bset_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ADD_A_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_add_a_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_add_a_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_add_a_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_add_a_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ADDS_A_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_adds_a_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_adds_a_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_adds_a_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_adds_a_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ADDS_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_adds_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_adds_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_adds_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_adds_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ADDS_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_adds_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_adds_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_adds_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_adds_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ADDV_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_addv_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_addv_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_addv_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_addv_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_AVE_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_ave_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_ave_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_ave_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_ave_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_AVE_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_ave_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_ave_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_ave_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_ave_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_AVER_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_aver_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_aver_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_aver_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_aver_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_AVER_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_aver_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_aver_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_aver_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_aver_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_CEQ_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_ceq_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_ceq_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_ceq_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_ceq_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_CLE_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_cle_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_cle_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_cle_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_cle_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_CLE_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_cle_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_cle_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_cle_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_cle_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_CLT_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_clt_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_clt_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_clt_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_clt_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_CLT_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_clt_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_clt_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_clt_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_clt_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DIV_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_div_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_div_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_div_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_div_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_DIV_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_div_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_div_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_div_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_div_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MAX_A_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_max_a_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_max_a_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_max_a_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_max_a_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MAX_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_max_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_max_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_max_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_max_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MAX_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_max_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_max_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_max_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_max_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MIN_A_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_min_a_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_min_a_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_min_a_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_min_a_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MIN_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_min_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_min_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_min_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_min_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MIN_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_min_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_min_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_min_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_min_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MOD_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_mod_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_mod_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_mod_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_mod_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MOD_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_mod_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_mod_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_mod_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_mod_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MADDV_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_maddv_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_maddv_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_maddv_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_maddv_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MSUBV_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_msubv_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_msubv_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_msubv_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_msubv_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ASUB_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_asub_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_asub_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_asub_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_asub_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ASUB_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_asub_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_asub_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_asub_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_asub_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ILVEV_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_ilvev_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_ilvev_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_ilvev_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_ilvev_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ILVOD_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_ilvod_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_ilvod_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_ilvod_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_ilvod_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ILVL_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_ilvl_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_ilvl_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_ilvl_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_ilvl_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_ILVR_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_ilvr_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_ilvr_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_ilvr_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_ilvr_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_PCKEV_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_pckev_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_pckev_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_pckev_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_pckev_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_PCKOD_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_pckod_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_pckod_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_pckod_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_pckod_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SLL_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_sll_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_sll_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_sll_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_sll_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SRA_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_sra_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_sra_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_sra_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_sra_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SRAR_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_srar_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_srar_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_srar_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_srar_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SRL_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_srl_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_srl_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_srl_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_srl_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SRLR_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_srlr_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_srlr_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_srlr_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_srlr_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SUBS_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_subs_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_subs_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_subs_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_subs_s_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_MULV_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_mulv_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_mulv_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_mulv_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_mulv_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SUBV_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_subv_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_subv_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_subv_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_subv_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SUBS_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_subs_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_subs_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_subs_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_subs_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SUBSUS_U_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_subsus_u_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_subsus_u_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_subsus_u_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_subsus_u_d(cpu_env, twd, tws, twt); - break; - } - break; - case OPC_SUBSUU_S_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_subsuu_s_b(cpu_env, twd, tws, twt); - break; - case DF_HALF: - gen_helper_msa_subsuu_s_h(cpu_env, twd, tws, twt); - break; - case DF_WORD: - gen_helper_msa_subsuu_s_w(cpu_env, twd, tws, twt); - break; - case DF_DOUBLE: - gen_helper_msa_subsuu_s_d(cpu_env, twd, tws, twt); - break; - } - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } - tcg_temp_free_i32(twd); - tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); - tcg_temp_free_i32(tdf); -} - static void gen_msa_elm_3e(DisasContext *ctx) { #define MASK_MSA_ELM_DF3E(op) (MASK_MSA_MINOR(op) | (op & (0x3FF << 16))) @@ -1684,17 +885,6 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) } =20 switch (MASK_MSA_MINOR(opcode)) { - case OPC_MSA_3R_0D: - case OPC_MSA_3R_0E: - case OPC_MSA_3R_0F: - case OPC_MSA_3R_10: - case OPC_MSA_3R_11: - case OPC_MSA_3R_12: - case OPC_MSA_3R_13: - case OPC_MSA_3R_14: - case OPC_MSA_3R_15: - gen_msa_3r(ctx); - break; case OPC_MSA_ELM: gen_msa_elm(ctx); break; --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025816; cv=none; d=zohomail.com; s=zohoarc; b=iPM5Kzg5smb58wlOCliSdppPKZJ4wu79RXnUHxys3zaqKeHEqEvpoTl3mYKtoqeCdAOzZU6VPSXZHmE4FBN11TrjiJ8vK28OI5SmFhu9hkeBkB43HnXCimDFtHRSAdLxXg9L/DCwE+pd+O8MsdDErVfhQk/cAFnaZOHwl0mPHeM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025816; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pPgOOsJ1tcp3zk061urgzOCJTIxjGxhIl2eWZ/P+Epc=; b=RNGz+cbn2B2VpA/qnlU8GWAQGyVJAJ6HDWu7S8r+HKi55uNl5eXi3X1/7SYFlwCQU0xKK93lhy53Swg5ETwr6/yw/GveNcuvEh130PXISsuCCE77Zyd+EKs+FS35HwitFYzfXBbWZV3z/+2sixUOivWvXi1iR8Iwh5OHFf2w8GA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 1635025816878589.7876755997406; Sat, 23 Oct 2021 14:50:16 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id g201-20020a1c20d2000000b00327775075f7so127793wmg.5 for ; Sat, 23 Oct 2021 14:50:16 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id k36sm1514103wms.21.2021.10.23.14.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pPgOOsJ1tcp3zk061urgzOCJTIxjGxhIl2eWZ/P+Epc=; b=Ricy8C19AUpbmq9b29txE4ooJrPKn1SgAy1UFkb5cGk7LUQxFrFypYpsikTobXVtom swZ/fGiuHzKx/3dsyirb6PtH3WMcPOa+KnRUyZ6Gm+RXVlNw5BEJdn/pzkFXWA5pBMhe D8n+/TPZ9Uj/WbtoBiXA4m84Y0hRNsi1MasRzpntK+YG8vOESY7+2xe2mJ1HENlf8cL4 Art+gFORTgHa6sNm4W1X7ffKpwbscF2kyqC+XQZYG599X20uLeHl5hD6FhGfpaRFR0gg dyCneP/bTHOLOCkRVrEdik5dUyd8V4he9cPhTANajn1aGCht2jOXoWiDWB+MJJ4vNX3r /Cdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pPgOOsJ1tcp3zk061urgzOCJTIxjGxhIl2eWZ/P+Epc=; b=14kTWZ6fS21MqWkeLyb/sxbzWzasyUZ+LvxUk7vzqOCOkHqXHOMGMydUzKRwKioHvh CUvz0xXRz+Wh8pI4xRaJhC/54Ej39RQqZ/jvBF2DgWk5bCfDsMlAw5yUSl7kDM+FzgIL mQ8KOWsfPIgj/F31oKL445lEicEJnMj0ufXZyY6ikcQQAf94dh/jA46HaUJ9ZGUPGwr5 zvKH4JpYXHCmO2JOnx+GABwHlpxYtNeDRN7saWvZY1i6tRkDbdc7oGjmiKwpFcZJ9J+n QMjhvyIMmrkwBHptp9reQTl6EyCJcRPud1fzXaXYClCzrCxWL+L1qCYWRhWXsBifcnWp cM3w== X-Gm-Message-State: AOAM532JM0TFcE5XQ/RdulqqwOry/lHSdZwflef+P/XTAZd/HebeF2FT KlEjoEFw+f5vc1VsfyGRl00= X-Google-Smtp-Source: ABdhPJypYUNRlxpNgxxoOMZnhWk3Dj/FIfNFw2PLNX0V16FtPLihEni3tRFA8r97uN+WYGTcj8LyDg== X-Received: by 2002:a1c:7911:: with SMTP id l17mr38985962wme.138.1635025815195; Sat, 23 Oct 2021 14:50:15 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 26/33] target/mips: Convert MSA ELM instruction format to decodetree Date: Sat, 23 Oct 2021 23:47:56 +0200 Message-Id: <20211023214803.522078-27-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025818849100001 Convert instructions with an immediate element index and data format df/n to decodetree. Since the 'data format' and 'n' fields are constant values, use tcg_constant_i32() instead of a TCG temporaries. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 6 +++++ target/mips/tcg/msa_translate.c | 46 +++++++++++++++++++++++---------- 2 files changed, 39 insertions(+), 13 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 3d0d9a52675..0f1674cd318 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -15,12 +15,14 @@ =20 &msa_r df wd ws wt &msa_bz df wt sa +&msa_elm df wd ws &msa_ldst df wd ws sa =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &r @ldst ...... sa:s10 ws:5 wd:5 .... df:2 &msa_ldst @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@elm_df ...... .... df:6 ws:5 wd:5 ...... &msa_elm @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @@ -152,6 +154,10 @@ BNZ 010001 111 .. ..... ..............= .. @bz HSUB_S 011110 110.. ..... ..... ..... 010101 @3r HSUB_U 011110 111.. ..... ..... ..... 010101 @3r =20 + SLDI 011110 0000 ...... ..... ..... 011001 @elm_df + SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df + INSVE 011110 0101 ...... ..... ..... 011001 @elm_df + FCAF 011110 0000 . ..... ..... ..... 011010 @3rf FCUN 011110 0001 . ..... ..... ..... 011010 @3rf FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 7813c126069..95dcd4b5b06 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -29,15 +29,12 @@ enum { =20 enum { /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ - OPC_SLDI_df =3D (0x0 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_SPLATI_df =3D (0x1 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_COPY_S_df =3D (0x2 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_COPY_U_df =3D (0x3 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_INSERT_df =3D (0x4 << 22) | (0x00 << 16) | OPC_MSA_ELM, - OPC_INSVE_df =3D (0x5 << 22) | (0x00 << 16) | OPC_MSA_ELM, }; =20 static const char msaregnames[][6] =3D { @@ -561,6 +558,39 @@ static void gen_msa_elm_3e(DisasContext *ctx) tcg_temp_free_i32(tsr); } =20 +static bool trans_msa_elm_df(DisasContext *ctx, arg_msa_elm *a, + void (*gen_msa_elm_df)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32, + TCGv_i32)) +{ + TCGv_i32 twd; + TCGv_i32 tws; + TCGv_i32 tdf; + TCGv_i32 tn; + uint32_t df, n; + + if (!df_extract(df_elm, a->df, &df, &n)) { + gen_reserved_instruction(ctx); + return true; + } + + twd =3D tcg_const_i32(a->wd); + tws =3D tcg_const_i32(a->ws); + tdf =3D tcg_constant_i32(df); + tn =3D tcg_constant_i32(n); + + gen_msa_elm_df(cpu_env, tdf, twd, tws, tn); + + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twd); + + return true; +} + +TRANS_MSA(SLDI, trans_msa_elm_df, gen_helper_msa_sldi_df); +TRANS_MSA(SPLATI, trans_msa_elm_df, gen_helper_msa_splati_df); +TRANS_MSA(INSVE, trans_msa_elm_df, gen_helper_msa_insve_df); + static void gen_msa_elm_df(DisasContext *ctx, uint32_t df, uint32_t n) { #define MASK_MSA_ELM(op) (MASK_MSA_MINOR(op) | (op & (0xf << 22))) @@ -570,18 +600,8 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t= df, uint32_t n) TCGv_i32 tws =3D tcg_const_i32(ws); TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tn =3D tcg_const_i32(n); - TCGv_i32 tdf =3D tcg_constant_i32(df); =20 switch (MASK_MSA_ELM(ctx->opcode)) { - case OPC_SLDI_df: - gen_helper_msa_sldi_df(cpu_env, tdf, twd, tws, tn); - break; - case OPC_SPLATI_df: - gen_helper_msa_splati_df(cpu_env, tdf, twd, tws, tn); - break; - case OPC_INSVE_df: - gen_helper_msa_insve_df(cpu_env, tdf, twd, tws, tn); - break; case OPC_COPY_S_df: case OPC_COPY_U_df: case OPC_INSERT_df: --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025821; cv=none; d=zohomail.com; s=zohoarc; b=d0nUjAYeadbxhKLSCQvCRDdFOX5Cma8hxJtzorTTjFKwclP6AsMUO2C95Q72RN2lxOLFqGAjFY94HPo921BUbVRqJaKDKF9eP6EJRcp6iX5OKPxXXtSjdgWHBAOygYTpfl7w3NS1VQbiRicdddoakq64wC0xZlRn+nE1eCoN8W0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025821; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qDHiAkaJ1MayXxmzfFfuU1YwcKAXMhm8sLiXLX0b59w=; b=Yv34TQTsRfw4Ekqo16jC8NZCThrlPH/SHQPhZsH/HY72EfxAy269Jr7CjC3eCebv/j4DWk9y8j5UGrrvveBYM5I3vcxydlHRbwvTQJDQcx5p3gWvps878BpX7SsxeYmtS6LcpUvZhPspVq6kC9bXs+ttNgSih/58vTOMmp4noic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 1635025821671841.5771161028892; Sat, 23 Oct 2021 14:50:21 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id v17so3526243wrv.9 for ; Sat, 23 Oct 2021 14:50:21 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id 126sm6044486wmz.28.2021.10.23.14.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qDHiAkaJ1MayXxmzfFfuU1YwcKAXMhm8sLiXLX0b59w=; b=bZ1e+UBcAC7eng1B6TS6tCPYnCQzm929hgRmbOTFfnYHC5Bzjr2De+A+AsgGjgTbCL PBFuOjfFSl5Yq8oVSaWE9Sy5mLMm3GzXaSyK3G2a8D3O/7nchDI0ZJN1uNDqv9L6MK8U ZmWjZaj6vZQp+rjPtrE1umpFGqEOaUQRhKvPGf9JitidOSYh+5DEAlJeeALlDlM4XcES SqMlffCu5LTJ7IaXlHiO0wHW564phjTBhKz+YxWFVPLK7oLYvM6c/z9uk7Nc319nXO7H Y8W6am6+FCvVJRji75uVhdRW2B/agbFIV8sFquz7Mq7fHrabUQOHmVUtebHOrey0eQxg +Odg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qDHiAkaJ1MayXxmzfFfuU1YwcKAXMhm8sLiXLX0b59w=; b=AUmiCxeEwUm8t3nceRkWFwMNThe7rg5GfmHm37TYQIZdyPDYU7o97LBS8/ksCz9GGk oZjgZO9FC5QXaI82hIF1AjBizlJj6UmAkaZlYVX2c5dNGxUPV6Qd0RkS+ajXndDO3HXu xLCQ2Mc8PbfF3u21hthRtXVHCnaEx47GkB0qDWrPOLB7GiMXqd+DwZ9w+M4+vHWTxVQ4 iD18jStZe0ee9utla5a1uAjxZbmRLFOmLIFhZSVJLBC28lAWn/f02f+WeQNBzmx9MsaJ 72pKnBtCemifq6PJXp9UHxImFpCDPc6HC7iVJohVKAKFqnHSnHxc5hLJ7/ktcsV5h4iW MEVA== X-Gm-Message-State: AOAM531MulbCp339OWJR7osEx9blHQyD0kSJl2c/f1HzKfIhprvzE9Dl gRRWEaoVzprtJyLIeDxcQDI= X-Google-Smtp-Source: ABdhPJxpj/9uEE2b9gny23sMxoBmadNo7ZQmtnzETbtQw53X6Fiad7p/JRLZd0HOTPQ58gtAk6RNYg== X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr8046579wri.359.1635025819944; Sat, 23 Oct 2021 14:50:19 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 27/33] target/mips: Convert MSA COPY_U opcode to decodetree Date: Sat, 23 Oct 2021 23:47:57 +0200 Message-Id: <20211023214803.522078-28-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025822858100001 Convert the COPY_U opcode (Element Copy to GPR Unsigned) to decodetree. Since the 'n' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/tcg/msa.decode | 1 + target/mips/tcg/msa_translate.c | 90 +++++++++++++++++++++++---------- 2 files changed, 65 insertions(+), 26 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 0f1674cd318..80a06d12746 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -156,6 +156,7 @@ BNZ 010001 111 .. ..... ...............= . @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df + COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df =20 FCAF 011110 0000 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 95dcd4b5b06..e033b365fdd 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -33,7 +33,6 @@ enum { OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_COPY_S_df =3D (0x2 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_COPY_U_df =3D (0x3 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_INSERT_df =3D (0x4 << 22) | (0x00 << 16) | OPC_MSA_ELM, }; =20 @@ -139,6 +138,11 @@ static inline bool check_msa_access(DisasContext *ctx) TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ NULL, gen_func##_h, gen_func##_w, gen_func##_d) =20 +#define TRANS_DF_W64(NAME, trans_func, gen_func) \ + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ + DF_HALF, DF_WORD, \ + gen_func##_b, gen_func##_h, gen_func##_w, NULL) + static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, TCGCond cond) { @@ -591,6 +595,65 @@ TRANS_MSA(SLDI, trans_msa_elm_df, gen_helper_msa_s= ldi_df); TRANS_MSA(SPLATI, trans_msa_elm_df, gen_helper_msa_splati_df); TRANS_MSA(INSVE, trans_msa_elm_df, gen_helper_msa_insve_df); =20 +static bool trans_msa_elm_d64(DisasContext *ctx, arg_msa_elm *a, + enum CPUMIPSMSADataFormat df_max32, + enum CPUMIPSMSADataFormat df_max64, + void (*gen_msa_elm_b)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_elm_h)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_elm_w)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32), + void (*gen_msa_elm_d)(TCGv_ptr, TCGv_i32, + TCGv_i32, TCGv_i32)) +{ + TCGv_i32 twd; + TCGv_i32 tws; + TCGv_i32 tn; + uint32_t df, n; + + if (!df_extract(df_elm, a->df, &df, &n)) { + gen_reserved_instruction(ctx); + return true; + } + + if (df > (TARGET_LONG_BITS =3D=3D 64 ? df_max64 : df_max32)) { + gen_reserved_instruction(ctx); + return true; + } + + if (a->wd =3D=3D 0) { + /* Treat as NOP. */ + return true; + } + + twd =3D tcg_const_i32(a->wd); + tws =3D tcg_const_i32(a->ws); + tn =3D tcg_constant_i32(n); + + switch (a->df) { + case DF_BYTE: + gen_msa_elm_b(cpu_env, twd, tws, tn); + break; + case DF_HALF: + gen_msa_elm_h(cpu_env, twd, tws, tn); + break; + case DF_WORD: + gen_msa_elm_w(cpu_env, twd, tws, tn); + break; + case DF_DOUBLE: + g_assert_not_reached(); + break; + } + + tcg_temp_free_i32(tws); + tcg_temp_free_i32(twd); + + return true; +} + +TRANS_DF_W64(COPY_U, trans_msa_elm_d64, gen_helper_msa_copy_u); + static void gen_msa_elm_df(DisasContext *ctx, uint32_t df, uint32_t n) { #define MASK_MSA_ELM(op) (MASK_MSA_MINOR(op) | (op & (0xf << 22))) @@ -603,7 +666,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t = df, uint32_t n) =20 switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_COPY_S_df: - case OPC_COPY_U_df: case OPC_INSERT_df: #if !defined(TARGET_MIPS64) /* Double format valid only for MIPS64 */ @@ -611,11 +673,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t= df, uint32_t n) gen_reserved_instruction(ctx); break; } - if ((MASK_MSA_ELM(ctx->opcode) =3D=3D OPC_COPY_U_df) && - (df =3D=3D DF_WORD)) { - gen_reserved_instruction(ctx); - break; - } #endif switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_COPY_S_df: @@ -634,25 +691,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_t= df, uint32_t n) case DF_DOUBLE: gen_helper_msa_copy_s_d(cpu_env, twd, tws, tn); break; -#endif - default: - assert(0); - } - } - break; - case OPC_COPY_U_df: - if (likely(wd !=3D 0)) { - switch (df) { - case DF_BYTE: - gen_helper_msa_copy_u_b(cpu_env, twd, tws, tn); - break; - case DF_HALF: - gen_helper_msa_copy_u_h(cpu_env, twd, tws, tn); - break; -#if defined(TARGET_MIPS64) - case DF_WORD: - gen_helper_msa_copy_u_w(cpu_env, twd, tws, tn); - break; #endif default: assert(0); --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) client-ip=209.85.128.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025826; cv=none; d=zohomail.com; s=zohoarc; b=Vgp86140ekUdEtgz9FtoiNJSQQKIj7+q6uh6kYzmyjQJLdynw6O2H4od+QrVL8Q1iRDh4ANAhGy81NIr0wX5p4mo8S4f03HEUH3g9BG1wai79LeXKR8kTSOc7UgTK0sqTEYydaGpTAReNE055sC73DXlS8hTEk0YS0slVhMPrHQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025826; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ibIGTNc/VyjFjQlNiFJLRqQgcFwCs2aG6VjX1PSyJdM=; b=nNQ+dv6aE2oeWGYgLfb4kXTwk8aVMyMNkbaG/lC/NlkQcxzpPsEvUTkOt/mS+rh37UrLhYJpdEgkbyCyjGGz8lyYufAJxt6EhIpRcuGU+wG9bxuMl/DomgIOKI+yt4QCKk3fgWWNUNQN14ye2TQrnB7+xoUoK087aw5s8X93Dx0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.zohomail.com with SMTPS id 1635025826265742.3828195536461; Sat, 23 Oct 2021 14:50:26 -0700 (PDT) Received: by mail-wm1-f45.google.com with SMTP id 71-20020a1c014a000000b0032cafd23b1dso1284832wmb.4 for ; Sat, 23 Oct 2021 14:50:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id p21sm939656wmc.11.2021.10.23.14.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ibIGTNc/VyjFjQlNiFJLRqQgcFwCs2aG6VjX1PSyJdM=; b=oEL4MThd0vAK56jT7P2Pmwfi75LD2av/x0C3hJDbrZHSIeqHt5WcX3v26cMlaNnWQk CZ23XH1tAVmCZhiHkpG1/dMj3YSEapTVqWE7JnHu06epi5ckpprTsRmc5+5kOmvZWUOH op+ummDH3RzzT4qEVIQPEo4QSGtvPUvitrds0FvpcTTCUsWUJf4MzMzg/FpGh+aanI5W UYmoHozM7ebjkbSY4oCWrY+v1jPMrJbHRQjQDpz2xHLK1bhZxbUTun0B4q32kO57773S ZtQ1uABGmWz4SepJR22I9b6gsZM4q9Z11G+SyOz+bgwJIlWbtU4YgNNU48TsLkoUxCq1 17lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ibIGTNc/VyjFjQlNiFJLRqQgcFwCs2aG6VjX1PSyJdM=; b=7x3NsQ3vZgDXmbi/JRtQL04Q8qeUaAazJw4NP+lAqQnS7lP8+u7gjBcUgaExyZ/I7z FD4VnLGIP6fRSK21cXUNgwquBJGODP/zxebjROMA0viGF0ZlLvRmXque6HSf6KvuJnXG +qBQ1ExsrruuAvMh5Ros9iVOMgYYGhgFi4TVN9SD2TBIef5lbN0hrBzHKnhD7zu50INR Nil25u6+bkDyuEsnsv+ZsMCOgiJdIkT1LX5iR6rF01wDy/sm0+8+Dzlz2cYA7emLIfbz zxKTX5zKS82KdcKkydyzq1Tx+iyrNWLDnsQ95t0GoI5rsT6cfYI9jBzk8xe7OYLmVPki JnrA== X-Gm-Message-State: AOAM531IeAMQGgKHWITRgz+qLwfKqDTjlAsqsLxfAjOcGzXgQ2Z92jsI Dc00ajtjaYTXWhZ5rE/B/pY= X-Google-Smtp-Source: ABdhPJxgUXFxc5RpGen/H2VaXAkUChYpT+FLv6tte1oicEfb6xlom4pCdyQA0H6hrx9uf1vwz6ptsA== X-Received: by 2002:a05:600c:4ece:: with SMTP id g14mr9283107wmq.95.1635025824519; Sat, 23 Oct 2021 14:50:24 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 28/33] target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree Date: Sat, 23 Oct 2021 23:47:58 +0200 Message-Id: <20211023214803.522078-29-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025827018100001 Convert the COPY_S (Element Copy to GPR Signed) opcode and INSERT (GPR Insert Element) opcode to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 2 + target/mips/tcg/msa_translate.c | 92 ++++----------------------------- 2 files changed, 12 insertions(+), 82 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 80a06d12746..dc5e561b9dc 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -156,7 +156,9 @@ BNZ 010001 111 .. ..... ...............= . @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df + COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df + INSERT 011110 0100 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df =20 FCAF 011110 0000 . ..... ..... ..... 011010 @3rf diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index e033b365fdd..ff5dbd99f84 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -31,9 +31,7 @@ enum { /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_COPY_S_df =3D (0x2 << 22) | (0x00 << 16) | OPC_MSA_ELM, OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_INSERT_df =3D (0x4 << 22) | (0x00 << 16) | OPC_MSA_ELM, }; =20 static const char msaregnames[][6] =3D { @@ -138,6 +136,11 @@ static inline bool check_msa_access(DisasContext *ctx) TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ NULL, gen_func##_h, gen_func##_w, gen_func##_d) =20 +#define TRANS_DF_D64(NAME, trans_func, gen_func) \ + TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ + DF_WORD, DF_DOUBLE, \ + gen_func##_b, gen_func##_h, gen_func##_w, gen_func##_d) + #define TRANS_DF_W64(NAME, trans_func, gen_func) \ TRANS_CHECK(NAME, check_msa_access(ctx), trans_func, \ DF_HALF, DF_WORD, \ @@ -642,7 +645,8 @@ static bool trans_msa_elm_d64(DisasContext *ctx, arg_ms= a_elm *a, gen_msa_elm_w(cpu_env, twd, tws, tn); break; case DF_DOUBLE: - g_assert_not_reached(); + assert(gen_msa_elm_d !=3D NULL); + gen_msa_elm_d(cpu_env, twd, tws, tn); break; } =20 @@ -652,97 +656,21 @@ static bool trans_msa_elm_d64(DisasContext *ctx, arg_= msa_elm *a, return true; } =20 +TRANS_DF_D64(COPY_S, trans_msa_elm_d64, gen_helper_msa_copy_s); TRANS_DF_W64(COPY_U, trans_msa_elm_d64, gen_helper_msa_copy_u); - -static void gen_msa_elm_df(DisasContext *ctx, uint32_t df, uint32_t n) -{ -#define MASK_MSA_ELM(op) (MASK_MSA_MINOR(op) | (op & (0xf << 22))) - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; - - TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tn =3D tcg_const_i32(n); - - switch (MASK_MSA_ELM(ctx->opcode)) { - case OPC_COPY_S_df: - case OPC_INSERT_df: -#if !defined(TARGET_MIPS64) - /* Double format valid only for MIPS64 */ - if (df =3D=3D DF_DOUBLE) { - gen_reserved_instruction(ctx); - break; - } -#endif - switch (MASK_MSA_ELM(ctx->opcode)) { - case OPC_COPY_S_df: - if (likely(wd !=3D 0)) { - switch (df) { - case DF_BYTE: - gen_helper_msa_copy_s_b(cpu_env, twd, tws, tn); - break; - case DF_HALF: - gen_helper_msa_copy_s_h(cpu_env, twd, tws, tn); - break; - case DF_WORD: - gen_helper_msa_copy_s_w(cpu_env, twd, tws, tn); - break; -#if defined(TARGET_MIPS64) - case DF_DOUBLE: - gen_helper_msa_copy_s_d(cpu_env, twd, tws, tn); - break; -#endif - default: - assert(0); - } - } - break; - case OPC_INSERT_df: - switch (df) { - case DF_BYTE: - gen_helper_msa_insert_b(cpu_env, twd, tws, tn); - break; - case DF_HALF: - gen_helper_msa_insert_h(cpu_env, twd, tws, tn); - break; - case DF_WORD: - gen_helper_msa_insert_w(cpu_env, twd, tws, tn); - break; -#if defined(TARGET_MIPS64) - case DF_DOUBLE: - gen_helper_msa_insert_d(cpu_env, twd, tws, tn); - break; -#endif - default: - assert(0); - } - break; - } - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - } - tcg_temp_free_i32(twd); - tcg_temp_free_i32(tws); - tcg_temp_free_i32(tn); -} +TRANS_DF_D64(INSERT, trans_msa_elm_d64, gen_helper_msa_insert); =20 static void gen_msa_elm(DisasContext *ctx) { uint8_t dfn =3D (ctx->opcode >> 16) & 0x3f; - uint32_t df, n; =20 if (dfn =3D=3D 0x3E) { /* CTCMSA, CFCMSA, MOVE.V */ gen_msa_elm_3e(ctx); return; - } else if (!df_extract(df_elm, dfn, &df, &n)) { - gen_reserved_instruction(ctx); - return; } =20 - gen_msa_elm_df(ctx, df, n); + gen_reserved_instruction(ctx); } =20 static bool trans_msa_3rf(DisasContext *ctx, arg_msa_r *a, --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025830; cv=none; d=zohomail.com; s=zohoarc; b=jDvym6xC9FdV7QZcX9n+8SfodQlzKk9ENIZFG8ZIT1uNd3nRZkPW9nfw/eqBFVPDxkbvL+CQoumDh5UYTZwrZbu+IlW4zVsGbIay1YUfpT90u9TIADcw6mqlIPFv0in8A9Q5PjiYvN/lxlZbDkyuT5Qg+rKGsqx7FYXy2UzAdnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025830; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HfZ6rYii68KhWE0NxYMgEJrFZqSlTNn66/qs8YyNLIU=; b=OND0+NfcMHHzRvYT5+lTJs8dw7z8oeubKPIlVU+XpurYynJfKDt6G+eESoa1TKa3oZqIbXR2kVFliY+L+C0GKTloT3wlkPfOSA7oI2HcnV5GMHQjcUfCnCW5XI3rCi5R+/04Bdot2Kpr+usppaDHFuhiR6oX8jzI/fkOyLhdQyM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1635025830974252.5829362072809; Sat, 23 Oct 2021 14:50:30 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id d10so721034wrb.1 for ; Sat, 23 Oct 2021 14:50:30 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id z6sm15392203wmp.1.2021.10.23.14.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HfZ6rYii68KhWE0NxYMgEJrFZqSlTNn66/qs8YyNLIU=; b=b5P2lOaZ7D/lCmlqVKbwkOKW7tKR2tt8DVqF5l9iVps6Bat/Ho1oHlEJhaDC/7/dS1 MlkZNBXEZwNb7caPWXKS+Ag0EkuuCYuw0EzxXBvrtuQA5dJdKzDEmjdFmvr7IKnfL34s dWJ2JmomnAQkrMkkfDj/p5ND5pOCOJ66sTdghF2/nKBasOSA6WjkI6GUNmhJeaQGqON1 8Y54pjhhwroegEZlnaXFXnnNP1reC8Dn4fSF0vMWZsHdDUroL8a2WZlcugoJjR1JaB4u YZlvJvShnLLhdIbSo9d3ERKnFaEWFV/Hu9hkpJ/DM4O7iYkjgJvw8YY36fBfGLsV0zDk /pnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HfZ6rYii68KhWE0NxYMgEJrFZqSlTNn66/qs8YyNLIU=; b=J5QtORMjsngldK+1Yal0VNxLm22O9d46ArIR3T4QTJ0TM6v7D4ul59bYNgJS0fjaFg BqD0zY+NDpDQfDthqhAATnGLHgoi5kteJCcePWX2+wWyInfNCuTIvC7DF2UnThp56xi/ MYjce7jLtquoprYpIjqWdnafCea3a40gzLfa+oO4diDHCylVpZIYBNg6ZAJyBCMnJMQQ O5TknDzo3llMDmSpBkIX1s3Cefwe+9uoCWUPbBOzFW8Oq9TmPIETNYnTV5QLajII3B2g m5Y5Wyoho3btkNZx5x2qSChvhgULBuanCMPAX9F5QI1lVNjX/22FfeDThzyR41nke+8a Udfg== X-Gm-Message-State: AOAM530nMwFuIYiR0zStwZEeCjhoT9l0qQfe6Vgln7v9vdlwWTyOqXx1 HNTy0SVEjn9Gw1rV4HR32Kc= X-Google-Smtp-Source: ABdhPJzHl+dSkHrDEutBsmvOsxRXFXrwBYpTfYv81up4a8FN18pxemoVORvrAM67GePLoSo/MzzUQw== X-Received: by 2002:a05:6000:186a:: with SMTP id d10mr10855818wri.279.1635025829325; Sat, 23 Oct 2021 14:50:29 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 29/33] target/mips: Convert MSA MOVE.V opcode to decodetree Date: Sat, 23 Oct 2021 23:47:59 +0200 Message-Id: <20211023214803.522078-30-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025833063100001 Convert the MOVE.V opcode (Vector Move) to decodetree. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 6 +++++- target/mips/tcg/msa_translate.c | 26 +++++++++++++++++++++----- 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index dc5e561b9dc..1bde1983de3 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -23,6 +23,7 @@ @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz @elm_df ...... .... df:6 ws:5 wd:5 ...... &msa_elm +@elm ...... .......... ws:5 wd:5 ...... &msa_elm df=3D0 @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... df:1 ws:5 wd:5 ...... &msa_r wt=3D0 @@ -156,7 +157,10 @@ BNZ 010001 111 .. ..... ..............= .. @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df - COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + { + MOVE_V 011110 0010111110 ..... ..... 011001 @elm + COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + } COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df INSERT 011110 0100 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index ff5dbd99f84..b03cde964e0 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -31,7 +31,6 @@ enum { /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, }; =20 static const char msaregnames[][6] =3D { @@ -533,6 +532,26 @@ TRANS_DF_B(HADD_U, trans_msa_3r, gen_helper_ms= a_hadd_u); TRANS_DF_B(HSUB_S, trans_msa_3r, gen_helper_msa_hsub_s); TRANS_DF_B(HSUB_U, trans_msa_3r, gen_helper_msa_hsub_u); =20 +static bool trans_MOVE_V(DisasContext *ctx, arg_msa_elm *a) +{ + TCGv_i32 tsr; + TCGv_i32 tdt; + + if (!check_msa_access(ctx)) { + return false; + } + + tsr =3D tcg_const_i32(a->ws); + tdt =3D tcg_const_i32(a->wd); + + gen_helper_msa_move_v(cpu_env, tdt, tsr); + + tcg_temp_free_i32(tdt); + tcg_temp_free_i32(tsr); + + return true; +} + static void gen_msa_elm_3e(DisasContext *ctx) { #define MASK_MSA_ELM_DF3E(op) (MASK_MSA_MINOR(op) | (op & (0x3FF << 16))) @@ -551,9 +570,6 @@ static void gen_msa_elm_3e(DisasContext *ctx) gen_helper_msa_cfcmsa(telm, cpu_env, tsr); gen_store_gpr(telm, dest); break; - case OPC_MOVE_V: - gen_helper_msa_move_v(cpu_env, tdt, tsr); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -665,7 +681,7 @@ static void gen_msa_elm(DisasContext *ctx) uint8_t dfn =3D (ctx->opcode >> 16) & 0x3f; =20 if (dfn =3D=3D 0x3E) { - /* CTCMSA, CFCMSA, MOVE.V */ + /* CTCMSA, CFCMSA */ gen_msa_elm_3e(ctx); return; } --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025835; cv=none; d=zohomail.com; s=zohoarc; b=Uo6M9TeHFVxCdnRVyi6bDLONHzaHGvguRykWhSQEhr3Vcu78PgfVYn9ODJSItLYmvrzPnh7D9B0awQXOTvwtd0MOHbeiUDfaSd2Qu04t3Ix0EKa3wS481MwyWpAeuJzvsIVcj4Np6SYNLsfLnOuQtPSCE+DtPivzXMB1ceu5iYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025835; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hFBg7Xzxc2sF0VEfzsaEDrCd/QEx1NCLFI179J2xsC8=; b=fC1MV9DvKMBtmLGcJclC142Nxw/beex6MS1mWGz4gYADnNZghmitAoCQBAFywO+3YwtENAgj18IK42qe+EIe6f4rF88zHdAnetH7S0lTg1wPV0BGf9cY8C03JBzw0EoxNYnu+seWSPMq1bIggFoq/5+5VNmnWj+ylEcfN4iJA/Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1635025835772793.9500139226835; Sat, 23 Oct 2021 14:50:35 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id v127so6553200wme.5 for ; Sat, 23 Oct 2021 14:50:35 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id 19sm5816726wmb.24.2021.10.23.14.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hFBg7Xzxc2sF0VEfzsaEDrCd/QEx1NCLFI179J2xsC8=; b=Mnt7o3k93l07KIO71V/yFO8nil6ft07wik+jPArGKgNtnJcWBTC+dkDKRkHKaQjfNL ZllQpxBQYArdJD2JdKmAM2Zcd3zSx9CLijNLa4YQG/fstZQ+k0oS4b4BCFO9nCPZLo7S EAHMebhQl7hcAI4rFd9BHIi/QVPCelysmDYRFFFGEmhbsiiDmnH+d6oUZp2z3/QLbmaA vBOReKsNKz9KU+JsaX7MEp0sFp539j7tgDkhWU57r7suUUApkdnq4O2N/Gvylac/Mqdj fd1ljUh8pxul9NMHDeZXrff9C0l7lwauhBlUaMZfb0z8eaDct/v4xO+aZlhAz7rMmSQb CZTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=hFBg7Xzxc2sF0VEfzsaEDrCd/QEx1NCLFI179J2xsC8=; b=v2uhEYJxxmIxXiqK4lOhv8qUfv36PzvcgjhjyTV4c2U4xiqkI0jIQJ8jnjk0/UFph6 VNguVLA5eW123J73cYDfUdcYB2yVmNm2qQD3lkEELOgjqlWX4SDKiDKdaWmc0zxhU4eO YdSk31MiSuTciEBEydY5Rln1s9ShQ1MIOxJXkgUn/b/aCuYGkcuScK/v8JiLeJ41zsBb kkC8N3X/O3cY7QXASLlCSAphv16V57yyVtBHEztsZhCfU+hk7X63ONU3jEW4tyC8ZqDM PCxod9tJWm5N1fvjEmVULpCZimfltwojjFchm7NKQBtTWEm8BiDpP/+ki8vGN3RR3VAR IAUg== X-Gm-Message-State: AOAM531Iu0zJyp3z29A3nq/m0fpX1C7kaIPXtw7t6jGx6Byi2bNn9uon VIe6SRiWVENMoPl9c9hblRY= X-Google-Smtp-Source: ABdhPJx16EnYMuqyLDx6SHqgVIIMJZDskLN9zvR6/ae3D5ig/8jmySKGsaCNsareYaX92FIrEVtFvA== X-Received: by 2002:a1c:c908:: with SMTP id f8mr38353804wmb.142.1635025834073; Sat, 23 Oct 2021 14:50:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 30/33] target/mips: Convert CFCMSA and CTCMSA opcodes to decodetree Date: Sat, 23 Oct 2021 23:48:00 +0200 Message-Id: <20211023214803.522078-31-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025837223100001 Convert the CFCMSA (Copy From Control MSA register) and CTCMSA (Copy To Control MSA register) opcodes to decodetree. Since they respectively overlap with the SLDI and SPLATI opcodes, use decodetree overlap groups. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 10 +++- target/mips/tcg/msa_translate.c | 95 ++++++++++++--------------------- 2 files changed, 42 insertions(+), 63 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 1bde1983de3..52dac0fde6d 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -155,8 +155,14 @@ BNZ 010001 111 .. ..... ..............= .. @bz HSUB_S 011110 110.. ..... ..... ..... 010101 @3r HSUB_U 011110 111.. ..... ..... ..... 010101 @3r =20 - SLDI 011110 0000 ...... ..... ..... 011001 @elm_df - SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df + { + CTCMSA 011110 0000111110 ..... ..... 011001 @elm + SLDI 011110 0000 ...... ..... ..... 011001 @elm_df + } + { + CFCMSA 011110 0001111110 ..... ..... 011001 @elm + SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df + } { MOVE_V 011110 0010111110 ..... ..... 011001 @elm COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index b03cde964e0..51af6f39cc4 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -20,19 +20,6 @@ /* Include the auto-generated decoder. */ #include "decode-msa.c.inc" =20 -#define OPC_MSA (0x1E << 26) - -#define MASK_MSA_MINOR(op) (MASK_OP_MAJOR(op) | (op & 0x3F)) -enum { - OPC_MSA_ELM =3D 0x19 | OPC_MSA, -}; - -enum { - /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ - OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, -}; - static const char msaregnames[][6] =3D { "w0.d0", "w0.d1", "w1.d0", "w1.d1", "w2.d0", "w2.d1", "w3.d0", "w3.d1", @@ -552,33 +539,46 @@ static bool trans_MOVE_V(DisasContext *ctx, arg_msa_e= lm *a) return true; } =20 -static void gen_msa_elm_3e(DisasContext *ctx) +static bool trans_CTCMSA(DisasContext *ctx, arg_msa_elm *a) { -#define MASK_MSA_ELM_DF3E(op) (MASK_MSA_MINOR(op) | (op & (0x3FF << 16))) - uint8_t source =3D (ctx->opcode >> 11) & 0x1f; - uint8_t dest =3D (ctx->opcode >> 6) & 0x1f; - TCGv telm =3D tcg_temp_new(); - TCGv_i32 tsr =3D tcg_const_i32(source); - TCGv_i32 tdt =3D tcg_const_i32(dest); + TCGv telm; + TCGv_i32 tdt; =20 - switch (MASK_MSA_ELM_DF3E(ctx->opcode)) { - case OPC_CTCMSA: - gen_load_gpr(telm, source); - gen_helper_msa_ctcmsa(cpu_env, telm, tdt); - break; - case OPC_CFCMSA: - gen_helper_msa_cfcmsa(telm, cpu_env, tsr); - gen_store_gpr(telm, dest); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; + if (!check_msa_access(ctx)) { + return false; } =20 + telm =3D tcg_temp_new(); + tdt =3D tcg_const_i32(a->wd); + + gen_load_gpr(telm, a->ws); + gen_helper_msa_ctcmsa(cpu_env, telm, tdt); + tcg_temp_free(telm); tcg_temp_free_i32(tdt); + + return true; +} + +static bool trans_CFCMSA(DisasContext *ctx, arg_msa_elm *a) +{ + TCGv telm; + TCGv_i32 tsr; + + if (!check_msa_access(ctx)) { + return false; + } + + telm =3D tcg_temp_new(); + tsr =3D tcg_const_i32(a->ws); + + gen_helper_msa_cfcmsa(telm, cpu_env, tsr); + gen_store_gpr(telm, a->wd); + + tcg_temp_free(telm); tcg_temp_free_i32(tsr); + + return true; } =20 static bool trans_msa_elm_df(DisasContext *ctx, arg_msa_elm *a, @@ -676,19 +676,6 @@ TRANS_DF_D64(COPY_S, trans_msa_elm_d64, gen_helper_= msa_copy_s); TRANS_DF_W64(COPY_U, trans_msa_elm_d64, gen_helper_msa_copy_u); TRANS_DF_D64(INSERT, trans_msa_elm_d64, gen_helper_msa_insert); =20 -static void gen_msa_elm(DisasContext *ctx) -{ - uint8_t dfn =3D (ctx->opcode >> 16) & 0x3f; - - if (dfn =3D=3D 0x3E) { - /* CTCMSA, CFCMSA */ - gen_msa_elm_3e(ctx); - return; - } - - gen_reserved_instruction(ctx); -} - static bool trans_msa_3rf(DisasContext *ctx, arg_msa_r *a, enum CPUMIPSMSADataFormat df_base, void (*gen_msa_3rf)(TCGv_ptr, TCGv_i32, TCGv_i32, @@ -880,21 +867,7 @@ TRANS_MSA(BSEL_V, trans_msa_vec, gen_helper_msa_bsel= _v); =20 static bool trans_MSA(DisasContext *ctx, arg_MSA *a) { - uint32_t opcode =3D ctx->opcode; - - if (!check_msa_access(ctx)) { - return false; - } - - switch (MASK_MSA_MINOR(opcode)) { - case OPC_MSA_ELM: - gen_msa_elm(ctx); - break; - default: - MIPS_INVAL("MSA instruction"); - gen_reserved_instruction(ctx); - break; - } + gen_reserved_instruction(ctx); =20 return true; } --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025840; cv=none; d=zohomail.com; s=zohoarc; b=LgOo99OlHOS7ux4oR+ZtBNKpWLkzwxR7bn6TQCxgINfNcYE1cQksyFuKdD9vdGkVT/t0gN7ElyT/H0q4/bW/swjKnjBcG5DXOMNJsMJGpMdt/589TXDLoqhA/afu3GJqW2oYHNbjpwucn3IUVjvu6iMp9YunSorhfl18Wurrpe8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025840; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/DCgbVw+IWwtmfhUeAw0OJzG5d3SGRVlyig0pM8g5Pc=; b=BOvBHNbq/w4+bN1jrLsLBGiWVq7Kokw6COHPMx7nGSAazoAopWAuA3JcJm0JDE+AMCKHommHdc7Ih6Y54PHcta3qLd22BNwRLRrT2NLDKeob0ba4Obh/96h40tS//gi8vji6dZnOdT1LQdfy/zFm10dJYWdP7GsuxbALiq60WYI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1635025840776971.9118175833546; Sat, 23 Oct 2021 14:50:40 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id r7so2763189wrc.10 for ; Sat, 23 Oct 2021 14:50:40 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id o10sm12999826wmq.46.2021.10.23.14.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/DCgbVw+IWwtmfhUeAw0OJzG5d3SGRVlyig0pM8g5Pc=; b=lUzLDqp3jtACykWhHjgcvlgfNJ4BPpYSRu9/XVThB2iSlCp8FPVKQ9kjYroJbOawm+ uFAgh5OayPQBv6d8oniGsdzf/rr1S4WvPMPLnyqnV//JfIxHigDyeEo/nM0SPDK/0eme 9K13Vbge71e8pV6Py6EB5b/mbwuyuFN61oEKipoVhgej18A0JoEWwvNTVKT0CIK+mRe4 NB2dSUjMHCrFi9oDkvG1bxJXe8wiZZM6RutKtzUfcKnXTfvRb5v741xE+ejwFr1qb3gi XPSmcmz1W4mBNKQgRY+etCMlC+QdqWOn3VBLoKFRgJk20o7Sjem1lWMXs1UakvYMhZZp AKVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/DCgbVw+IWwtmfhUeAw0OJzG5d3SGRVlyig0pM8g5Pc=; b=OcjH6mpVIUAAiCdxTmhdAyrHJtkAHBVbdorSEv28DqnZ4VCmO4iPFI6Q/cu4nIFTPC 2ifDn4UtTKOlzcIbi4Ae68QHgiDM1XotMaBGCmkJ5oNFSIBWJZ7GbTArNHl1mAkb3mYE O5+NH4Bt1IURwB9xEXifAVRinpxEzNlHETVu1NLQqqlWDtkSyOCsNrJWAH8PzcIQwwb2 /dfLZ7Byz/shOpxYitoW5ODFplfxPnWiNZQUZy96yYszoea1S8fCh5EFvh6wGVWp6U6W qDg5+n9mcfFghJsn+WcNr9Ev2sLaOh2PWJAdEUtKbE1LDZgRArCP95yeAd11BdU3LwcF Z7Nw== X-Gm-Message-State: AOAM533UMMlyrwgPU0DOJ9vmGgxBhxAbHMNl/pqDELslicXff8xOie0j Y4rdJSNzRdwoGdmrbA4UoVtoJ7vQCJg= X-Google-Smtp-Source: ABdhPJwzcYgLCMgXjh4owB7y6WR4htDU7K0R0civQf3D+XVYiVs5I2jRyoWdfEsnxTPVshYBt+1rHA== X-Received: by 2002:a5d:4949:: with SMTP id r9mr1857262wrs.439.1635025839117; Sat, 23 Oct 2021 14:50:39 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 31/33] target/mips: Remove generic MSA opcode Date: Sat, 23 Oct 2021 23:48:01 +0200 Message-Id: <20211023214803.522078-32-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025841438100001 All opcodes have been converted to decodetree. The generic MSA handler is now pointless, remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 2 -- target/mips/tcg/msa_translate.c | 7 ------- 2 files changed, 9 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 52dac0fde6d..8189eae3499 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -245,6 +245,4 @@ BNZ 010001 111 .. ..... ...............= . @bz =20 LD 011110 .......... ..... ..... 1000 .. @ldst ST 011110 .......... ..... ..... 1001 .. @ldst - - MSA 011110 -------------------------- } diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 51af6f39cc4..5d8cad378e6 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -865,13 +865,6 @@ TRANS_MSA(BMNZ_V, trans_msa_vec, gen_helper_msa_bmnz= _v); TRANS_MSA(BMZ_V, trans_msa_vec, gen_helper_msa_bmz_v); TRANS_MSA(BSEL_V, trans_msa_vec, gen_helper_msa_bsel_v); =20 -static bool trans_MSA(DisasContext *ctx, arg_MSA *a) -{ - gen_reserved_instruction(ctx); - - return true; -} - static bool trans_msa_ldst(DisasContext *ctx, arg_msa_ldst *a, void (*gen_msa_b)(TCGv_ptr, TCGv_i32, TCGv), void (*gen_msa_h)(TCGv_ptr, TCGv_i32, TCGv), --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025845; cv=none; d=zohomail.com; s=zohoarc; b=M6FNj9G/WRuOLORwRyyrJuaQFiWafZNBHfXC8wD5VjH1ByLg5A3DLWULq1botymTs+1yYGYgtKgha2lguW9IC8DTFqC/PGSBc8KU7rORLIXr1+aq0BPVepD8/wJe7GNIwEVQLnIBj5HC3WL+WsflSdIMWVDOKFWo7/kT4Quf/eY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025845; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5T4gXPoUo/qza6spxy7SgG6iv4hgkAkl7bCbMPO3Vzc=; b=JKS8AvBMo10mQivSNx93bPFF+2ONARQmj97ejxEku7laKcPIc1r194sn1XtodZrdSW3fHSxgIB0C9skyV+cI7qz9mHNyyjqUqcBjZ3AQO+14qWLqmIyxK8kqWQyY8+q9gOD/ZjREPzFKnow+stg4WPOnX0+c/nu5L/mxa2oTKv8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1635025845946366.2285178646298; Sat, 23 Oct 2021 14:50:45 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id d10so721706wrb.1 for ; Sat, 23 Oct 2021 14:50:45 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id e6sm5082225wrr.69.2021.10.23.14.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5T4gXPoUo/qza6spxy7SgG6iv4hgkAkl7bCbMPO3Vzc=; b=UYtzagVdXoenxfrIq7nDfSM6Spoj7mYlvpQ3V9L70aW1hEJP4Or3lYRrY0r4YTNQ/O uaesm7CSfCvO0jSoqHLsMWxi1KWCGV8dQ56hfethspcI3pkpqzU3HMMs6hRZ5pz4Sl/R +7HhJnKcFiU2mdQAK+GZGhcauTeioKZ2M5s/ouDmhtyO63OMen6Bkip53WRag//0FXVh R+gsRCqUX1+HRSPXOcky0KedK8MThblMIdYd0NfXLVCc6H4gZzBARC9etuV0ucJnCeTy 4rw+5si/plYjhXYbIubWFcro8wEDne+5y/fJRrHCtdrCOGk9VLjoMlrejGxyl5QpLUhd hdow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5T4gXPoUo/qza6spxy7SgG6iv4hgkAkl7bCbMPO3Vzc=; b=yf+hsAeAcUWptWMCgGcZtHPNLZmoUVSrwXo3eKhYCJPwdC9LzS9KbI0PYGgesUjy+D PGJd0C9YCWayN0QWvopzl+aoLRlZDoulUOW/xV0LihLn55CWxwmdXojfstCXYJ8VTqYM 39oPzZID3xOe7VT/Xh7fYnarSUcestZGeLIXE9z1uSeyUsX/fHlEnKz2gVdkSPOLjP80 T0Qt271ayZKJ0S1ONAyBvLblvK04YWEYcrKp++y9onS6EyakZNr3VP25Et6q4nCL8gJH m3hrrh2aFJc10VBLMltprNnsMhkyCT50cy+urdVucGzbvK5WIv5PPTSRnA6hkdD8duIh GKyg== X-Gm-Message-State: AOAM531LpwZN7OCvAO6uji9ihpJ68gbleBmkaQITxeRpMvZ/qfFmXGb2 RRE3uJbXX4v0P8vKDpeOLE4= X-Google-Smtp-Source: ABdhPJwfG2q3QIgO6Wr1XGyAdyclFIdFdWvOXpkx79P2jFY19AcfCgt0AfZFxnfEFfgGpi7o0OJ5lQ== X-Received: by 2002:adf:c986:: with SMTP id f6mr11044180wrh.216.1635025843889; Sat, 23 Oct 2021 14:50:43 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 32/33] target/mips: Remove one MSA unnecessary decodetree overlap group Date: Sat, 23 Oct 2021 23:48:02 +0200 Message-Id: <20211023214803.522078-33-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025847548100001 Only the MSA generic opcode was overlapping with the other instructions. Since the previous commit removed it, we can now remove the overlap group. The decodetree script forces us to re-indent the opcodes. Diff trivial to review using `git-diff --ignore-all-space`. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa.decode | 398 ++++++++++++++++++------------------- 1 file changed, 198 insertions(+), 200 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 8189eae3499..9af995b71b6 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -44,205 +44,203 @@ BNZ_V 010001 01111 ..... .............= ... @bz_v BZ 010001 110 .. ..... ................ @bz BNZ 010001 111 .. ..... ................ @bz =20 +ANDI 011110 00 ........ ..... ..... 000000 @i8 +ORI 011110 01 ........ ..... ..... 000000 @i8 +NORI 011110 10 ........ ..... ..... 000000 @i8 +XORI 011110 11 ........ ..... ..... 000000 @i8 +BMNZI 011110 00 ........ ..... ..... 000001 @i8 +BMZI 011110 01 ........ ..... ..... 000001 @i8 +BSELI 011110 10 ........ ..... ..... 000001 @i8 +SHF 011110 .. ........ ..... ..... 000010 @i8_df + +ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 +SUBVI 011110 001 .. ..... ..... ..... 000110 @u5 +MAXI_S 011110 010 .. ..... ..... ..... 000110 @s5 +MAXI_U 011110 011 .. ..... ..... ..... 000110 @u5 +MINI_S 011110 100 .. ..... ..... ..... 000110 @s5 +MINI_U 011110 101 .. ..... ..... ..... 000110 @u5 + +CEQI 011110 000 .. ..... ..... ..... 000111 @s5 +CLTI_S 011110 010 .. ..... ..... ..... 000111 @s5 +CLTI_U 011110 011 .. ..... ..... ..... 000111 @u5 +CLEI_S 011110 100 .. ..... ..... ..... 000111 @s5 +CLEI_U 011110 101 .. ..... ..... ..... 000111 @u5 + +LDI 011110 110 .. .......... ..... 000111 @ldi + +SLLI 011110 000 ....... ..... ..... 001001 @bit +SRAI 011110 001 ....... ..... ..... 001001 @bit +SRLI 011110 010 ....... ..... ..... 001001 @bit +BCLRI 011110 011 ....... ..... ..... 001001 @bit +BSETI 011110 100 ....... ..... ..... 001001 @bit +BNEGI 011110 101 ....... ..... ..... 001001 @bit +BINSLI 011110 110 ....... ..... ..... 001001 @bit +BINSRI 011110 111 ....... ..... ..... 001001 @bit + +SAT_S 011110 000 ....... ..... ..... 001010 @bit +SAT_U 011110 001 ....... ..... ..... 001010 @bit +SRARI 011110 010 ....... ..... ..... 001010 @bit +SRLRI 011110 011 ....... ..... ..... 001010 @bit + +SLL 011110 000.. ..... ..... ..... 001101 @3r +SRA 011110 001.. ..... ..... ..... 001101 @3r +SRL 011110 010.. ..... ..... ..... 001101 @3r +BCLR 011110 011.. ..... ..... ..... 001101 @3r +BSET 011110 100.. ..... ..... ..... 001101 @3r +BNEG 011110 101.. ..... ..... ..... 001101 @3r +BINSL 011110 110.. ..... ..... ..... 001101 @3r +BINSR 011110 111.. ..... ..... ..... 001101 @3r + +ADDV 011110 000.. ..... ..... ..... 001110 @3r +SUBV 011110 001.. ..... ..... ..... 001110 @3r +MAX_S 011110 010.. ..... ..... ..... 001110 @3r +MAX_U 011110 011.. ..... ..... ..... 001110 @3r +MIN_S 011110 100.. ..... ..... ..... 001110 @3r +MIN_U 011110 101.. ..... ..... ..... 001110 @3r +MAX_A 011110 110.. ..... ..... ..... 001110 @3r +MIN_A 011110 111.. ..... ..... ..... 001110 @3r + +CEQ 011110 000.. ..... ..... ..... 001111 @3r +CLT_S 011110 010.. ..... ..... ..... 001111 @3r +CLT_U 011110 011.. ..... ..... ..... 001111 @3r +CLE_S 011110 100.. ..... ..... ..... 001111 @3r +CLE_U 011110 101.. ..... ..... ..... 001111 @3r + +ADD_A 011110 000.. ..... ..... ..... 010000 @3r +ADDS_A 011110 001.. ..... ..... ..... 010000 @3r +ADDS_S 011110 010.. ..... ..... ..... 010000 @3r +ADDS_U 011110 011.. ..... ..... ..... 010000 @3r +AVE_S 011110 100.. ..... ..... ..... 010000 @3r +AVE_U 011110 101.. ..... ..... ..... 010000 @3r +AVER_S 011110 110.. ..... ..... ..... 010000 @3r +AVER_U 011110 111.. ..... ..... ..... 010000 @3r + +SUBS_S 011110 000.. ..... ..... ..... 010001 @3r +SUBS_U 011110 001.. ..... ..... ..... 010001 @3r +SUBSUS_U 011110 010.. ..... ..... ..... 010001 @3r +SUBSUU_S 011110 011.. ..... ..... ..... 010001 @3r +ASUB_S 011110 100.. ..... ..... ..... 010001 @3r +ASUB_U 011110 101.. ..... ..... ..... 010001 @3r + +MULV 011110 000.. ..... ..... ..... 010010 @3r +MADDV 011110 001.. ..... ..... ..... 010010 @3r +MSUBV 011110 010.. ..... ..... ..... 010010 @3r +DIV_S 011110 100.. ..... ..... ..... 010010 @3r +DIV_U 011110 101.. ..... ..... ..... 010010 @3r +MOD_S 011110 110.. ..... ..... ..... 010010 @3r +MOD_U 011110 111.. ..... ..... ..... 010010 @3r + +DOTP_S 011110 000.. ..... ..... ..... 010011 @3r +DOTP_U 011110 001.. ..... ..... ..... 010011 @3r +DPADD_S 011110 010.. ..... ..... ..... 010011 @3r +DPADD_U 011110 011.. ..... ..... ..... 010011 @3r +DPSUB_S 011110 100.. ..... ..... ..... 010011 @3r +DPSUB_U 011110 101.. ..... ..... ..... 010011 @3r + +SLD 011110 000 .. ..... ..... ..... 010100 @3r +SPLAT 011110 001 .. ..... ..... ..... 010100 @3r +PCKEV 011110 010 .. ..... ..... ..... 010100 @3r +PCKOD 011110 011 .. ..... ..... ..... 010100 @3r +ILVL 011110 100 .. ..... ..... ..... 010100 @3r +ILVR 011110 101 .. ..... ..... ..... 010100 @3r +ILVEV 011110 110 .. ..... ..... ..... 010100 @3r +ILVOD 011110 111 .. ..... ..... ..... 010100 @3r + +VSHF 011110 000 .. ..... ..... ..... 010101 @3r +SRAR 011110 001 .. ..... ..... ..... 010101 @3r +SRLR 011110 010 .. ..... ..... ..... 010101 @3r +HADD_S 011110 100.. ..... ..... ..... 010101 @3r +HADD_U 011110 101.. ..... ..... ..... 010101 @3r +HSUB_S 011110 110.. ..... ..... ..... 010101 @3r +HSUB_U 011110 111.. ..... ..... ..... 010101 @3r + { - ANDI 011110 00 ........ ..... ..... 000000 @i8 - ORI 011110 01 ........ ..... ..... 000000 @i8 - NORI 011110 10 ........ ..... ..... 000000 @i8 - XORI 011110 11 ........ ..... ..... 000000 @i8 - BMNZI 011110 00 ........ ..... ..... 000001 @i8 - BMZI 011110 01 ........ ..... ..... 000001 @i8 - BSELI 011110 10 ........ ..... ..... 000001 @i8 - SHF 011110 .. ........ ..... ..... 000010 @i8_df - - ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 - SUBVI 011110 001 .. ..... ..... ..... 000110 @u5 - MAXI_S 011110 010 .. ..... ..... ..... 000110 @s5 - MAXI_U 011110 011 .. ..... ..... ..... 000110 @u5 - MINI_S 011110 100 .. ..... ..... ..... 000110 @s5 - MINI_U 011110 101 .. ..... ..... ..... 000110 @u5 - - CEQI 011110 000 .. ..... ..... ..... 000111 @s5 - CLTI_S 011110 010 .. ..... ..... ..... 000111 @s5 - CLTI_U 011110 011 .. ..... ..... ..... 000111 @u5 - CLEI_S 011110 100 .. ..... ..... ..... 000111 @s5 - CLEI_U 011110 101 .. ..... ..... ..... 000111 @u5 - - LDI 011110 110 .. .......... ..... 000111 @ldi - - SLLI 011110 000 ....... ..... ..... 001001 @bit - SRAI 011110 001 ....... ..... ..... 001001 @bit - SRLI 011110 010 ....... ..... ..... 001001 @bit - BCLRI 011110 011 ....... ..... ..... 001001 @bit - BSETI 011110 100 ....... ..... ..... 001001 @bit - BNEGI 011110 101 ....... ..... ..... 001001 @bit - BINSLI 011110 110 ....... ..... ..... 001001 @bit - BINSRI 011110 111 ....... ..... ..... 001001 @bit - - SAT_S 011110 000 ....... ..... ..... 001010 @bit - SAT_U 011110 001 ....... ..... ..... 001010 @bit - SRARI 011110 010 ....... ..... ..... 001010 @bit - SRLRI 011110 011 ....... ..... ..... 001010 @bit - - SLL 011110 000.. ..... ..... ..... 001101 @3r - SRA 011110 001.. ..... ..... ..... 001101 @3r - SRL 011110 010.. ..... ..... ..... 001101 @3r - BCLR 011110 011.. ..... ..... ..... 001101 @3r - BSET 011110 100.. ..... ..... ..... 001101 @3r - BNEG 011110 101.. ..... ..... ..... 001101 @3r - BINSL 011110 110.. ..... ..... ..... 001101 @3r - BINSR 011110 111.. ..... ..... ..... 001101 @3r - - ADDV 011110 000.. ..... ..... ..... 001110 @3r - SUBV 011110 001.. ..... ..... ..... 001110 @3r - MAX_S 011110 010.. ..... ..... ..... 001110 @3r - MAX_U 011110 011.. ..... ..... ..... 001110 @3r - MIN_S 011110 100.. ..... ..... ..... 001110 @3r - MIN_U 011110 101.. ..... ..... ..... 001110 @3r - MAX_A 011110 110.. ..... ..... ..... 001110 @3r - MIN_A 011110 111.. ..... ..... ..... 001110 @3r - - CEQ 011110 000.. ..... ..... ..... 001111 @3r - CLT_S 011110 010.. ..... ..... ..... 001111 @3r - CLT_U 011110 011.. ..... ..... ..... 001111 @3r - CLE_S 011110 100.. ..... ..... ..... 001111 @3r - CLE_U 011110 101.. ..... ..... ..... 001111 @3r - - ADD_A 011110 000.. ..... ..... ..... 010000 @3r - ADDS_A 011110 001.. ..... ..... ..... 010000 @3r - ADDS_S 011110 010.. ..... ..... ..... 010000 @3r - ADDS_U 011110 011.. ..... ..... ..... 010000 @3r - AVE_S 011110 100.. ..... ..... ..... 010000 @3r - AVE_U 011110 101.. ..... ..... ..... 010000 @3r - AVER_S 011110 110.. ..... ..... ..... 010000 @3r - AVER_U 011110 111.. ..... ..... ..... 010000 @3r - - SUBS_S 011110 000.. ..... ..... ..... 010001 @3r - SUBS_U 011110 001.. ..... ..... ..... 010001 @3r - SUBSUS_U 011110 010.. ..... ..... ..... 010001 @3r - SUBSUU_S 011110 011.. ..... ..... ..... 010001 @3r - ASUB_S 011110 100.. ..... ..... ..... 010001 @3r - ASUB_U 011110 101.. ..... ..... ..... 010001 @3r - - MULV 011110 000.. ..... ..... ..... 010010 @3r - MADDV 011110 001.. ..... ..... ..... 010010 @3r - MSUBV 011110 010.. ..... ..... ..... 010010 @3r - DIV_S 011110 100.. ..... ..... ..... 010010 @3r - DIV_U 011110 101.. ..... ..... ..... 010010 @3r - MOD_S 011110 110.. ..... ..... ..... 010010 @3r - MOD_U 011110 111.. ..... ..... ..... 010010 @3r - - DOTP_S 011110 000.. ..... ..... ..... 010011 @3r - DOTP_U 011110 001.. ..... ..... ..... 010011 @3r - DPADD_S 011110 010.. ..... ..... ..... 010011 @3r - DPADD_U 011110 011.. ..... ..... ..... 010011 @3r - DPSUB_S 011110 100.. ..... ..... ..... 010011 @3r - DPSUB_U 011110 101.. ..... ..... ..... 010011 @3r - - SLD 011110 000 .. ..... ..... ..... 010100 @3r - SPLAT 011110 001 .. ..... ..... ..... 010100 @3r - PCKEV 011110 010 .. ..... ..... ..... 010100 @3r - PCKOD 011110 011 .. ..... ..... ..... 010100 @3r - ILVL 011110 100 .. ..... ..... ..... 010100 @3r - ILVR 011110 101 .. ..... ..... ..... 010100 @3r - ILVEV 011110 110 .. ..... ..... ..... 010100 @3r - ILVOD 011110 111 .. ..... ..... ..... 010100 @3r - - VSHF 011110 000 .. ..... ..... ..... 010101 @3r - SRAR 011110 001 .. ..... ..... ..... 010101 @3r - SRLR 011110 010 .. ..... ..... ..... 010101 @3r - HADD_S 011110 100.. ..... ..... ..... 010101 @3r - HADD_U 011110 101.. ..... ..... ..... 010101 @3r - HSUB_S 011110 110.. ..... ..... ..... 010101 @3r - HSUB_U 011110 111.. ..... ..... ..... 010101 @3r - - { - CTCMSA 011110 0000111110 ..... ..... 011001 @elm - SLDI 011110 0000 ...... ..... ..... 011001 @elm_df - } - { - CFCMSA 011110 0001111110 ..... ..... 011001 @elm - SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df - } - { - MOVE_V 011110 0010111110 ..... ..... 011001 @elm - COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df - } - COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df - INSERT 011110 0100 ...... ..... ..... 011001 @elm_df - INSVE 011110 0101 ...... ..... ..... 011001 @elm_df - - FCAF 011110 0000 . ..... ..... ..... 011010 @3rf - FCUN 011110 0001 . ..... ..... ..... 011010 @3rf - FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf - FCUEQ 011110 0011 . ..... ..... ..... 011010 @3rf - FCLT 011110 0100 . ..... ..... ..... 011010 @3rf - FCULT 011110 0101 . ..... ..... ..... 011010 @3rf - FCLE 011110 0110 . ..... ..... ..... 011010 @3rf - FCULE 011110 0111 . ..... ..... ..... 011010 @3rf - FSAF 011110 1000 . ..... ..... ..... 011010 @3rf - FSUN 011110 1001 . ..... ..... ..... 011010 @3rf - FSEQ 011110 1010 . ..... ..... ..... 011010 @3rf - FSUEQ 011110 1011 . ..... ..... ..... 011010 @3rf - FSLT 011110 1100 . ..... ..... ..... 011010 @3rf - FSULT 011110 1101 . ..... ..... ..... 011010 @3rf - FSLE 011110 1110 . ..... ..... ..... 011010 @3rf - FSULE 011110 1111 . ..... ..... ..... 011010 @3rf - - FADD 011110 0000 . ..... ..... ..... 011011 @3rf - FSUB 011110 0001 . ..... ..... ..... 011011 @3rf - FMUL 011110 0010 . ..... ..... ..... 011011 @3rf - FDIV 011110 0011 . ..... ..... ..... 011011 @3rf - FMADD 011110 0100 . ..... ..... ..... 011011 @3rf - FMSUB 011110 0101 . ..... ..... ..... 011011 @3rf - FEXP2 011110 0111 . ..... ..... ..... 011011 @3rf - FEXDO 011110 1000 . ..... ..... ..... 011011 @3rf - FTQ 011110 1010 . ..... ..... ..... 011011 @3rf - FMIN 011110 1100 . ..... ..... ..... 011011 @3rf - FMIN_A 011110 1101 . ..... ..... ..... 011011 @3rf - FMAX 011110 1110 . ..... ..... ..... 011011 @3rf - FMAX_A 011110 1111 . ..... ..... ..... 011011 @3rf - - FCOR 011110 0001 . ..... ..... ..... 011100 @3rf - FCUNE 011110 0010 . ..... ..... ..... 011100 @3rf - FCNE 011110 0011 . ..... ..... ..... 011100 @3rf - MUL_Q 011110 0100 . ..... ..... ..... 011100 @3rf - MADD_Q 011110 0101 . ..... ..... ..... 011100 @3rf - MSUB_Q 011110 0110 . ..... ..... ..... 011100 @3rf - FSOR 011110 1001 . ..... ..... ..... 011100 @3rf - FSUNE 011110 1010 . ..... ..... ..... 011100 @3rf - FSNE 011110 1011 . ..... ..... ..... 011100 @3rf - MULR_Q 011110 1100 . ..... ..... ..... 011100 @3rf - MADDR_Q 011110 1101 . ..... ..... ..... 011100 @3rf - MSUBR_Q 011110 1110 . ..... ..... ..... 011100 @3rf - - AND_V 011110 00000 ..... ..... ..... 011110 @vec - OR_V 011110 00001 ..... ..... ..... 011110 @vec - NOR_V 011110 00010 ..... ..... ..... 011110 @vec - XOR_V 011110 00011 ..... ..... ..... 011110 @vec - BMNZ_V 011110 00100 ..... ..... ..... 011110 @vec - BMZ_V 011110 00101 ..... ..... ..... 011110 @vec - BSEL_V 011110 00110 ..... ..... ..... 011110 @vec - FILL 011110 11000000 .. ..... ..... 011110 @2r - PCNT 011110 11000001 .. ..... ..... 011110 @2r - NLOC 011110 11000010 .. ..... ..... 011110 @2r - NLZC 011110 11000011 .. ..... ..... 011110 @2r - FCLASS 011110 110010000 . ..... ..... 011110 @2rf - FTRUNC_S 011110 110010001 . ..... ..... 011110 @2rf - FTRUNC_U 011110 110010010 . ..... ..... 011110 @2rf - FSQRT 011110 110010011 . ..... ..... 011110 @2rf - FRSQRT 011110 110010100 . ..... ..... 011110 @2rf - FRCP 011110 110010101 . ..... ..... 011110 @2rf - FRINT 011110 110010110 . ..... ..... 011110 @2rf - FLOG2 011110 110010111 . ..... ..... 011110 @2rf - FEXUPL 011110 110011000 . ..... ..... 011110 @2rf - FEXUPR 011110 110011001 . ..... ..... 011110 @2rf - FFQL 011110 110011010 . ..... ..... 011110 @2rf - FFQR 011110 110011011 . ..... ..... 011110 @2rf - FTINT_S 011110 110011100 . ..... ..... 011110 @2rf - FTINT_U 011110 110011101 . ..... ..... 011110 @2rf - FFINT_S 011110 110011110 . ..... ..... 011110 @2rf - FFINT_U 011110 110011111 . ..... ..... 011110 @2rf - - LD 011110 .......... ..... ..... 1000 .. @ldst - ST 011110 .......... ..... ..... 1001 .. @ldst + CTCMSA 011110 0000111110 ..... ..... 011001 @elm + SLDI 011110 0000 ...... ..... ..... 011001 @elm_df } +{ + CFCMSA 011110 0001111110 ..... ..... 011001 @elm + SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df +} +{ + MOVE_V 011110 0010111110 ..... ..... 011001 @elm + COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df +} +COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df +INSERT 011110 0100 ...... ..... ..... 011001 @elm_df +INSVE 011110 0101 ...... ..... ..... 011001 @elm_df + +FCAF 011110 0000 . ..... ..... ..... 011010 @3rf +FCUN 011110 0001 . ..... ..... ..... 011010 @3rf +FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf +FCUEQ 011110 0011 . ..... ..... ..... 011010 @3rf +FCLT 011110 0100 . ..... ..... ..... 011010 @3rf +FCULT 011110 0101 . ..... ..... ..... 011010 @3rf +FCLE 011110 0110 . ..... ..... ..... 011010 @3rf +FCULE 011110 0111 . ..... ..... ..... 011010 @3rf +FSAF 011110 1000 . ..... ..... ..... 011010 @3rf +FSUN 011110 1001 . ..... ..... ..... 011010 @3rf +FSEQ 011110 1010 . ..... ..... ..... 011010 @3rf +FSUEQ 011110 1011 . ..... ..... ..... 011010 @3rf +FSLT 011110 1100 . ..... ..... ..... 011010 @3rf +FSULT 011110 1101 . ..... ..... ..... 011010 @3rf +FSLE 011110 1110 . ..... ..... ..... 011010 @3rf +FSULE 011110 1111 . ..... ..... ..... 011010 @3rf + +FADD 011110 0000 . ..... ..... ..... 011011 @3rf +FSUB 011110 0001 . ..... ..... ..... 011011 @3rf +FMUL 011110 0010 . ..... ..... ..... 011011 @3rf +FDIV 011110 0011 . ..... ..... ..... 011011 @3rf +FMADD 011110 0100 . ..... ..... ..... 011011 @3rf +FMSUB 011110 0101 . ..... ..... ..... 011011 @3rf +FEXP2 011110 0111 . ..... ..... ..... 011011 @3rf +FEXDO 011110 1000 . ..... ..... ..... 011011 @3rf +FTQ 011110 1010 . ..... ..... ..... 011011 @3rf +FMIN 011110 1100 . ..... ..... ..... 011011 @3rf +FMIN_A 011110 1101 . ..... ..... ..... 011011 @3rf +FMAX 011110 1110 . ..... ..... ..... 011011 @3rf +FMAX_A 011110 1111 . ..... ..... ..... 011011 @3rf + +FCOR 011110 0001 . ..... ..... ..... 011100 @3rf +FCUNE 011110 0010 . ..... ..... ..... 011100 @3rf +FCNE 011110 0011 . ..... ..... ..... 011100 @3rf +MUL_Q 011110 0100 . ..... ..... ..... 011100 @3rf +MADD_Q 011110 0101 . ..... ..... ..... 011100 @3rf +MSUB_Q 011110 0110 . ..... ..... ..... 011100 @3rf +FSOR 011110 1001 . ..... ..... ..... 011100 @3rf +FSUNE 011110 1010 . ..... ..... ..... 011100 @3rf +FSNE 011110 1011 . ..... ..... ..... 011100 @3rf +MULR_Q 011110 1100 . ..... ..... ..... 011100 @3rf +MADDR_Q 011110 1101 . ..... ..... ..... 011100 @3rf +MSUBR_Q 011110 1110 . ..... ..... ..... 011100 @3rf + +AND_V 011110 00000 ..... ..... ..... 011110 @vec +OR_V 011110 00001 ..... ..... ..... 011110 @vec +NOR_V 011110 00010 ..... ..... ..... 011110 @vec +XOR_V 011110 00011 ..... ..... ..... 011110 @vec +BMNZ_V 011110 00100 ..... ..... ..... 011110 @vec +BMZ_V 011110 00101 ..... ..... ..... 011110 @vec +BSEL_V 011110 00110 ..... ..... ..... 011110 @vec +FILL 011110 11000000 .. ..... ..... 011110 @2r +PCNT 011110 11000001 .. ..... ..... 011110 @2r +NLOC 011110 11000010 .. ..... ..... 011110 @2r +NLZC 011110 11000011 .. ..... ..... 011110 @2r +FCLASS 011110 110010000 . ..... ..... 011110 @2rf +FTRUNC_S 011110 110010001 . ..... ..... 011110 @2rf +FTRUNC_U 011110 110010010 . ..... ..... 011110 @2rf +FSQRT 011110 110010011 . ..... ..... 011110 @2rf +FRSQRT 011110 110010100 . ..... ..... 011110 @2rf +FRCP 011110 110010101 . ..... ..... 011110 @2rf +FRINT 011110 110010110 . ..... ..... 011110 @2rf +FLOG2 011110 110010111 . ..... ..... 011110 @2rf +FEXUPL 011110 110011000 . ..... ..... 011110 @2rf +FEXUPR 011110 110011001 . ..... ..... 011110 @2rf +FFQL 011110 110011010 . ..... ..... 011110 @2rf +FFQR 011110 110011011 . ..... ..... 011110 @2rf +FTINT_S 011110 110011100 . ..... ..... 011110 @2rf +FTINT_U 011110 110011101 . ..... ..... 011110 @2rf +FFINT_S 011110 110011110 . ..... ..... 011110 @2rf +FFINT_U 011110 110011111 . ..... ..... 011110 @2rf + +LD 011110 .......... ..... ..... 1000 .. @ldst +ST 011110 .......... ..... ..... 1001 .. @ldst --=20 2.31.1 From nobody Sat May 18 12:12:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635025850; cv=none; d=zohomail.com; s=zohoarc; b=C2hVGc1Q428rr1DDdPZGwEmBBzN1xTxugUfZWpAoxayhHlhu1cnLeCm0SrBN30nnmqwlRVETQEvhzqeW+UDSE5qXHoLSfhXoNEstP8JVIs8NLhq20sNCmGkuyhmf7/ivKWDT5Aw5b7RwThs9WLwlHrqqVU7YnSFlFhp5ZkuiBsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635025850; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QX0MqgtzyZKOctor19fJypxbHtnwnz4pOB3v/AvZpLk=; b=jUCeYiS9i4VaFhB+jZOVaXgUSc8UON3r/xTgUG9zcr5+qgjfOwJZQVfLTunxqhrQDZy1WxRYy8Y7Ub4/YDcx1t742N9Qzi88vUbtCJhumNIxvpGc8k1gZWJXtnhwlwEhnWygIw6Ll2EJAK6kj+a3BC22d1RoOhv8MS7GFW5A3K8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1635025850643980.6595516245902; Sat, 23 Oct 2021 14:50:50 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id k7so184630wrd.13 for ; Sat, 23 Oct 2021 14:50:49 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id c17sm11722128wmk.23.2021.10.23.14.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 14:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QX0MqgtzyZKOctor19fJypxbHtnwnz4pOB3v/AvZpLk=; b=a9WAet9wlHs/m6yUXVfaEv9ZQHmNcINmLCfX2FwCy+oPlBiSWkaVSCIt7dk1NeuD1W LcQW7WIOKgE+4/y8RYJOad9vONB0qjptd8eeDTppAOg7vPlct4et5G17sUNuCoWx97d6 4TxmHr9RYMe1RT0RY6GaaOW+I/lr3r+ixb4kqZEBG3Wl0i/YxYwrNDk/Dp/EsrwojsAD 31O4DoHWixW6QvQOIA5xTocWei7y6IxYpdZhjI0DGn56cJPMUOWccj8UhabsfzxOo05Q VeNTgpfUu5m71rIxZVFVRa+uIuH6lwXSd8gSQ55OJrPZ5jmBdTVu3RKaxtvDPBa95Okl TSPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QX0MqgtzyZKOctor19fJypxbHtnwnz4pOB3v/AvZpLk=; b=rOXsf67ejLfJAawO9Il94ZCjaXkyPhTro/9Fjk6D7W9TIOedYmUpb1pZepnJ7G3dsg j9IJQTJt+A4HXER4t8IdQ4D4w7cLcOyMA9HqrfhN/hDaEjLyQAEyASiQ11zvhLqdfvUc vK1qp9tZbGyPyx/mrcdc3rF9RqGjYXRLH4wZhZ5dASwUpv7KiOnLa9wc3qVqCi0L499+ kj+910zAFoCcjD13benGtzvHosW/FJX5wZkFOfFf/jUvXMIfMYISaPByZBzVJQX7nwAb EBWsfjQ8/22ynAAcIe7XLYM2tKhyek64VFNP3uqGJ70OMOzYQfbqWk6FNpHu2lk9soio YdWQ== X-Gm-Message-State: AOAM532e+Wu73zSQvjBvengAZUC9TWQpIqOzyyYL5SWJPcTCOLM5HYcf 2v7XdUA4Yyke650+jyaYb+w= X-Google-Smtp-Source: ABdhPJzwzbWy4hC6N9VL4jOhne6J1b8w6nWQ24GmtOpZ6a8lxON6prJKBAxJBSU/vKsUHrl36LVyDA== X-Received: by 2002:a05:6000:128f:: with SMTP id f15mr10517415wrx.143.1635025848768; Sat, 23 Oct 2021 14:50:48 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Luis Pires Subject: [PATCH 33/33] target/mips: Adjust style in msa_translate_init() Date: Sat, 23 Oct 2021 23:48:03 +0200 Message-Id: <20211023214803.522078-34-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211023214803.522078-1-f4bug@amsat.org> References: <20211023214803.522078-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635025851614100001 While the first 'off' variable assignment is unused, it helps to better understand the code logic. Move the assignation where it would have been used so it is easier to compare the MSA registers based on FPU ones versus the MSA specific registers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 5d8cad378e6..d196cad196b 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -80,13 +80,15 @@ void msa_translate_init(void) int i; =20 for (i =3D 0; i < 32; i++) { - int off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]); + int off; =20 /* * The MSA vector registers are mapped on the * scalar floating-point unit (FPU) registers. */ + off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]); msa_wr_d[i * 2] =3D fpu_f64[i]; + off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[1]); msa_wr_d[i * 2 + 1] =3D tcg_global_mem_new_i64(cpu_env, off, msaregnames[i * 2 + 1= ]); --=20 2.31.1