From nobody Sat May 18 17:15:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) client-ip=209.85.128.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635007413; cv=none; d=zohomail.com; s=zohoarc; b=MQY/vsnOHCXAB1dk/rj3qhaZgzlxi3e8h5QnJMrFsOLky0v9TI2JnMkk2kZijOrVh6e80XzH28CFAgRVURTEOD3iupOpEXnBjzaXyDNeUolkltHogaPdAnfkve3UzImF8YcvgbS99bhg9mbjv/hHsJEpPQtCBUKouU3lhKKx0gU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635007413; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=IQCLqFOJROXCm/K6M4eVPt6GVd+TPhtk2cQ63WfdEqew48yi5QhDD6dnZjmM3PFA5p6N0fvPSiqEHvMicntzYnwJ97+I4E4CLE7uR/1QX3was5x+tiU6uW8yoooTFcQZgSFSCheX29gwjyFni0iaHWjgKyU7aPMC5W1LWfZCBtY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.zohomail.com with SMTPS id 1635007413590389.6221237522909; Sat, 23 Oct 2021 09:43:33 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id m42so6117620wms.2 for ; Sat, 23 Oct 2021 09:43:33 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id k6sm11478768wri.83.2021.10.23.09.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 09:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=BGiGzrmKwvK3vOEiWCYA7h+8saonT4rKow5+osr07+qtqcWbPLj7c/a8w3cWrQfGY+ gYTmN+TkToyb95ZA7Q7LXOYeG2NAaUiQ+3IpIEV5vdgUrk/L3DYfnpdzNDX8vuv8AWL5 j8oyDA7iNQvarxOrePv6fsAXueYgw4xOdGOAeEdSxLWUmMhujg3eXlvvVPSJQWBm6Tlk cJnIzF6F73Nt5LeNZBvFRqVPabI+KX64Ud6XRLXnJ98i9y/wEq6h5/FFpbGQGS91SKI4 0/zy536ZHlXCFBIosEqtHILwIg0YiE6llRxw5vOGUkiNvPFj9FBlIQLbCeGIT7nZz6kq Kaqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=4h8cd2gj6LioCQKjAoPWyLIIdDE8FcGsphzqJRwMU9Y=; b=EtzV9Cu08KzqSjG0At12U5fNescLSik+s9ds6m4i0I4ufCbPTIeh7ht/wfPQON0BpO USQ9p50Nrsjhpk7ELY0MVr3xqSG90hYz8F5LQO12FEdtTBFNcTc/WvMoRAopEURZ0gRX kh+eYzkpgOGUZze/X+oR0JKmXSm2Pzm8vH8L7Byl7jc40SAeJaHjx1F/LQy63aJIO7rK C8tC5InMnLDhKo3L0GLLf0SOsb+AYtHoNNE17qIaE7k4gTIQgZu/Tj1yWy5Xe81IzKff EvGtiiMvAVC5RTs5uW+vdcN00PaClC0NYIxed3LcLs6A5zrcKe/EkXTYghfYUbYAZVoE W3sw== X-Gm-Message-State: AOAM530CAyOvjPFJBnixiA4rCkVWcko6GsYxvKBxCcCy8kIbtqP6vr5p q4Z0shvqltmQsiIskZgyKlQ= X-Google-Smtp-Source: ABdhPJw+dLngtrh3xgWKdY01Fc1RkuKoxB64GzgG01aaw2tQnuICPOf6L6VL7enfwEY7e6yWXXdAGg== X-Received: by 2002:a1c:c90f:: with SMTP id f15mr7723168wmb.78.1635007411918; Sat, 23 Oct 2021 09:43:31 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Yoshinori Sato , Matheus Ferst , qemu-riscv@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] tests/tcg: Fix some targets default cross compiler path Date: Sat, 23 Oct 2021 18:43:29 +0200 Message-Id: <20211023164329.328137-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635007416059100001 We do not want a shell command substitution, but a parameter substitution (with assignment). Replace $() -> ${}, otherwise the expanded command return an empty string and the $cross_cc variable is not set. Fixes: 634ef789f8e ("tests/tcg: add more default compilers to configure.sh") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/tcg/configure.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 1f985ccfc0c..b8574165fa6 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -46,7 +46,7 @@ fi : ${cross_cc_aarch64=3D"aarch64-linux-gnu-gcc"} : ${cross_cc_aarch64_be=3D"$cross_cc_aarch64"} : ${cross_cc_cflags_aarch64_be=3D"-mbig-endian"} -: $(cross_cc_alpha=3D"alpha-linux-gnu-gcc") +: ${cross_cc_alpha=3D"alpha-linux-gnu-gcc"} : ${cross_cc_arm=3D"arm-linux-gnueabihf-gcc"} : ${cross_cc_cflags_armeb=3D"-mbig-endian"} : ${cross_cc_hexagon=3D"hexagon-unknown-linux-musl-clang"} @@ -55,17 +55,17 @@ fi : ${cross_cc_i386=3D"i686-linux-gnu-gcc"} : ${cross_cc_cflags_i386=3D"-m32"} : ${cross_cc_m68k=3D"m68k-linux-gnu-gcc"} -: $(cross_cc_mips64el=3D"mips64el-linux-gnuabi64-gcc") -: $(cross_cc_mips64=3D"mips64-linux-gnuabi64-gcc") -: $(cross_cc_mipsel=3D"mipsel-linux-gnu-gcc") -: $(cross_cc_mips=3D"mips-linux-gnu-gcc") +: ${cross_cc_mips64el=3D"mips64el-linux-gnuabi64-gcc"} +: ${cross_cc_mips64=3D"mips64-linux-gnuabi64-gcc"} +: ${cross_cc_mipsel=3D"mipsel-linux-gnu-gcc"} +: ${cross_cc_mips=3D"mips-linux-gnu-gcc"} : ${cross_cc_ppc=3D"powerpc-linux-gnu-gcc"} : ${cross_cc_cflags_ppc=3D"-m32"} : ${cross_cc_ppc64=3D"powerpc64-linux-gnu-gcc"} : ${cross_cc_ppc64le=3D"powerpc64le-linux-gnu-gcc"} -: $(cross_cc_riscv64=3D"riscv64-linux-gnu-gcc") +: ${cross_cc_riscv64=3D"riscv64-linux-gnu-gcc"} : ${cross_cc_s390x=3D"s390x-linux-gnu-gcc"} -: $(cross_cc_sh4=3D"sh4-linux-gnu-gcc") +: ${cross_cc_sh4=3D"sh4-linux-gnu-gcc"} : ${cross_cc_cflags_sparc=3D"-m32 -mv8plus -mcpu=3Dultrasparc"} : ${cross_cc_sparc64=3D"sparc64-linux-gnu-gcc"} : ${cross_cc_cflags_sparc64=3D"-m64 -mcpu=3Dultrasparc"} --=20 2.31.1