From nobody Sat Apr 27 16:42:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1634924758; cv=none; d=zohomail.com; s=zohoarc; b=WPZRvrZG748I10TIOr/WeIfgA860I4XB5L9TEqOIYU2YopTX40xNcakCMT8hE8Jv/ORXeqqJ1R6LlOwwak2FZqGiK98zB88+2OwbHhz40CBXb8bBqtFq+rKYVW2aDDqWVymz8UFp6tp2IYUl7BAs0WZxAqPnG2tA+lLBndDIk9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634924758; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nvBa77aLNZQfHIimBSDDT1Fr1da5qnINngy8APoER3U=; b=l8e11ATKCO8BbvLxs/GKd2g3czUP9yS/7zPTBFpXMHjWSYK0uS4ZRugSmtRIvcJ5pU9krbtgyekE3rYKMU1NOJxleMB6a0z81Kzc37e+J83jtfJi7N78Nc/CYvszADejZaOM02gN07Zwxu0Ibm4LbiiG6sRMqkvUPlXvylYUs+g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 163492475884855.80791336855691; Fri, 22 Oct 2021 10:45:58 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id m22so5331855wrb.0 for ; Fri, 22 Oct 2021 10:45:58 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id t12sm9723786wmq.44.2021.10.22.10.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 10:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nvBa77aLNZQfHIimBSDDT1Fr1da5qnINngy8APoER3U=; b=Y97uEyudeMooiPm+HVQEnv4Fs6ZwBJlhyaLldppU7gmNckW3d9IVbby7LXalG4FDW+ /HrzQwQLt49dS6scqgk6yfWUYwqzj849BlSapBex6EZumLLw+z8cZpRtVF5CgFX1D6xw 6cxSrVLrW8E14BWoTvl6E/PZB4yq4aKfmPahn+0AtiqmERgxO+8Q8Ahy9tddbiC+Nh8+ AgkNzh3zXzFu2yugSmx/YS3GmTGfftsUsKUtMIwChcwZ4Ix6J7DOtXY/Pb21x4Ii1rRW H1y9EKkabZSbeOWyUVLQDnEwP+UeCthPYqoCt4ucJ4PruAH/RFLKEM7sgrjXpTQQKZZI NUOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nvBa77aLNZQfHIimBSDDT1Fr1da5qnINngy8APoER3U=; b=0gIH1WrXWYPNYPI5QVpC0x1Cn8/R+piewLbeo+RS+Y6kAS0pTelgDxrpoqaFBn+5hg KJj5NrzIRdeL3+JjBCs+EKn7FC8mNh81wiyqUyWuUxk7jclLHKOwZ+AMp763dm8fNcYI 4kOKAgW1glVlLEf4RpyxUng6h/RtGl2lzgVqDhrTGr5SkfTe8OB0X4jFafXudVjWytoW tfWD+kAaGDJh+riRODQ4l8MRCnoxgFH5R7cJsSr/H19/OHlqaAoIzA3T1TjMQbVAUrSM Ltxi1IqUEmCNe4ayJNx+OAPLLlxCvxxmvR63wP3vk5JJgYg9zV8Pwn+IbNy2uqTnwFee HD2w== X-Gm-Message-State: AOAM530EDoB+duuZ0AthIMBVdVF6gWVqvB8kz6DQY3fKrNJDbxvjTo5m L3I6EdmI53F6rp9F462juNM= X-Google-Smtp-Source: ABdhPJysIenNA/laCKCwsozrV6aJDiZHfKEQj6rQTiI0/tq+KR/a3YZEPPoGvGATD8tiRKu5VZI7Iw== X-Received: by 2002:adf:ab03:: with SMTP id q3mr1620853wrc.396.1634924757079; Fri, 22 Oct 2021 10:45:57 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Huacai Chen , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 1/3] target/mips: Fix MSA MADDV.B opcode Date: Fri, 22 Oct 2021 19:45:48 +0200 Message-Id: <20211022174550.36937-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211022174550.36937-1-f4bug@amsat.org> References: <20211022174550.36937-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1634924760498100001 The result of the 'Vector Multiply and Add' opcode is incorrect with Byte vectors. Probably due to a copy/paste error, commit 7a7a162adde mistakenly used the $wt (target register) instead of $wd (destination register) as first operand. Fix that. Cc: Aleksandar Rikalo Fixes: 7a7a162adde ("target/mips: msa: Split helpers for MADDV.") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_helper.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index e40c1b70575..d978909527f 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -3231,22 +3231,22 @@ void helper_msa_maddv_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 - pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwt->b[0], pws->b[0], pwt->b[0]= ); - pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwt->b[1], pws->b[1], pwt->b[1]= ); - pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwt->b[2], pws->b[2], pwt->b[2]= ); - pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwt->b[3], pws->b[3], pwt->b[3]= ); - pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwt->b[4], pws->b[4], pwt->b[4]= ); - pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwt->b[5], pws->b[5], pwt->b[5]= ); - pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwt->b[6], pws->b[6], pwt->b[6]= ); - pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwt->b[7], pws->b[7], pwt->b[7]= ); - pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwt->b[8], pws->b[8], pwt->b[8]= ); - pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwt->b[9], pws->b[9], pwt->b[9]= ); - pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwt->b[10], pws->b[10], pwt->b[10= ]); - pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwt->b[11], pws->b[11], pwt->b[11= ]); - pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwt->b[12], pws->b[12], pwt->b[12= ]); - pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwt->b[13], pws->b[13], pwt->b[13= ]); - pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwt->b[14], pws->b[14], pwt->b[14= ]); - pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwt->b[15], pws->b[15], pwt->b[15= ]); + pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwd->b[0], pws->b[0], pwt->b[0]= ); + pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwd->b[1], pws->b[1], pwt->b[1]= ); + pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwd->b[2], pws->b[2], pwt->b[2]= ); + pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwd->b[3], pws->b[3], pwt->b[3]= ); + pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwd->b[4], pws->b[4], pwt->b[4]= ); + pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwd->b[5], pws->b[5], pwt->b[5]= ); + pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwd->b[6], pws->b[6], pwt->b[6]= ); + pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwd->b[7], pws->b[7], pwt->b[7]= ); + pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwd->b[8], pws->b[8], pwt->b[8]= ); + pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwd->b[9], pws->b[9], pwt->b[9]= ); + pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwd->b[10], pws->b[10], pwt->b[10= ]); + pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwd->b[11], pws->b[11], pwt->b[11= ]); + pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwd->b[12], pws->b[12], pwt->b[12= ]); + pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwd->b[13], pws->b[13], pwt->b[13= ]); + pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwd->b[14], pws->b[14], pwt->b[14= ]); + pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwd->b[15], pws->b[15], pwt->b[15= ]); } =20 void helper_msa_maddv_h(CPUMIPSState *env, --=20 2.31.1 From nobody Sat Apr 27 16:42:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1634924763; cv=none; d=zohomail.com; s=zohoarc; b=bV34tyb2zlMTEFRHQ8E+C0zAsroIhVvUGH3LHEVItjdnopBpPp2cU44YwzOp6XlvFOk3R8J5SAaPBAuf73pIer/LdDgXbqgjNuTY6wOrHRaczzLwEEiki3Oh2E9DKCnD1SAZoBUOiCw7xGF3EXAdV7WbZX5TEnyfAsW9e49lLV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634924763; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nMlUbAJKPz64aG6NoJAByuuRWcS3lFAt42R/dbZcatc=; b=VMTHAxO/YNJMN6fFPo1FI39x/7ypnb6KgYplHGO3qOtjB8X4CqhXcMfycnnlzhyeJ5FRSxI+KhCTrc4+jt2WMu7PRd4XmTQq//KvMdckwNYEi74+ShLNbeS8qUPEOOqc3BIOJoH0iswXK8BFt1ZTWdsITeREujn9zhzdqx9IZhY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1634924763928151.85803803597435; Fri, 22 Oct 2021 10:46:03 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id o20so530642wro.3 for ; Fri, 22 Oct 2021 10:46:03 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id l2sm4726848wrx.68.2021.10.22.10.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 10:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nMlUbAJKPz64aG6NoJAByuuRWcS3lFAt42R/dbZcatc=; b=EZFQ5GWsqGsIdcW9loUdW832gKdSIOUxtJ5Cq0N32MbDRkEV1XPn8qdANkGTAetLEB Lq+D7F4DsFFC8CPmvhcvk2zEQjZ0oNAhC281zxUWnTqFnbJ74F42j0woU4G3ELECerx+ HJR8B/uc4km5maldFxEtvoGwfnacKuLuVQ+FVQamF427RAL+R7roCNNa7ex8R2YsSDEm u4dGijv2zzVjksYIkW6KIoThHOmQImynbHlTfEZ84L+WzfFFWqg9M4CY6Bvr8dQolzm/ tBki95KDnANbSVcy8PsUlVXFawoGyQ8VZnr9mcOFwGrHAbTu1KE4fWgKnkcAfiawrV3w UbaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nMlUbAJKPz64aG6NoJAByuuRWcS3lFAt42R/dbZcatc=; b=R8ND+oOvmF9eKZ5j9mJp5aSkvgGBVrX9Nza5e1atIQMq98E+M5jyamOcGZJsQTVmRO jPacca1BA/XTR+y4nAp/mNBJZkbZfyyWoUairB8BqOq3j8cDTw5lTcfONGY0dSNmSy2y 8jPFXYIo7p9ytUIuYN58IFdOjzT5pvYC2ttf+8SLzHQeKO7HCMNnKVLBOKNGHKYPNtv6 yzoPDbEiqFBUhBTqRTl2SCK60wwPoTKkiYppG5z6k3Ni+JRX4R24/iZZN86kBKBCVODa gWtOvKujlxLbFTJL5zxmMHuzxIyFT9EP+NGTguKBVgI9cywSpSdIAg8irQAqc1sIZl9A ydfQ== X-Gm-Message-State: AOAM530RJ58oSiIgKAAmel4jwgij1r0LhQz9NdOHUJsWaPI5nqMVrHsK 3pfj7voc8vOkWlgYyglB1GA= X-Google-Smtp-Source: ABdhPJx2BRSQwQOBVfl19InZJXBlJ848FKIMCE3f0ALcWfC7frLYFymcK5eo8u0Fj4j1IFgSsYRxhw== X-Received: by 2002:adf:9787:: with SMTP id s7mr1488499wrb.191.1634924761808; Fri, 22 Oct 2021 10:46:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Huacai Chen , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 2/3] target/mips: Fix MSA MSUBV.B opcode Date: Fri, 22 Oct 2021 19:45:49 +0200 Message-Id: <20211022174550.36937-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211022174550.36937-1-f4bug@amsat.org> References: <20211022174550.36937-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1634924765318100001 The result of the 'Vector Multiply and Subtract' opcode is incorrect with Byte vectors. Probably due to a copy/paste error, commit 5f148a02327 mistakenly used the $wt (target register) instead of $wd (destination register) as first operand. Fix that. Cc: Aleksandar Rikalo Fixes: 5f148a02327 ("target/mips: msa: Split helpers for MSUBV.") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_helper.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index d978909527f..5667b1f0a15 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -3303,22 +3303,22 @@ void helper_msa_msubv_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 - pwd->b[0] =3D msa_msubv_df(DF_BYTE, pwt->b[0], pws->b[0], pwt->b[0]= ); - pwd->b[1] =3D msa_msubv_df(DF_BYTE, pwt->b[1], pws->b[1], pwt->b[1]= ); - pwd->b[2] =3D msa_msubv_df(DF_BYTE, pwt->b[2], pws->b[2], pwt->b[2]= ); - pwd->b[3] =3D msa_msubv_df(DF_BYTE, pwt->b[3], pws->b[3], pwt->b[3]= ); - pwd->b[4] =3D msa_msubv_df(DF_BYTE, pwt->b[4], pws->b[4], pwt->b[4]= ); - pwd->b[5] =3D msa_msubv_df(DF_BYTE, pwt->b[5], pws->b[5], pwt->b[5]= ); - pwd->b[6] =3D msa_msubv_df(DF_BYTE, pwt->b[6], pws->b[6], pwt->b[6]= ); - pwd->b[7] =3D msa_msubv_df(DF_BYTE, pwt->b[7], pws->b[7], pwt->b[7]= ); - pwd->b[8] =3D msa_msubv_df(DF_BYTE, pwt->b[8], pws->b[8], pwt->b[8]= ); - pwd->b[9] =3D msa_msubv_df(DF_BYTE, pwt->b[9], pws->b[9], pwt->b[9]= ); - pwd->b[10] =3D msa_msubv_df(DF_BYTE, pwt->b[10], pws->b[10], pwt->b[10= ]); - pwd->b[11] =3D msa_msubv_df(DF_BYTE, pwt->b[11], pws->b[11], pwt->b[11= ]); - pwd->b[12] =3D msa_msubv_df(DF_BYTE, pwt->b[12], pws->b[12], pwt->b[12= ]); - pwd->b[13] =3D msa_msubv_df(DF_BYTE, pwt->b[13], pws->b[13], pwt->b[13= ]); - pwd->b[14] =3D msa_msubv_df(DF_BYTE, pwt->b[14], pws->b[14], pwt->b[14= ]); - pwd->b[15] =3D msa_msubv_df(DF_BYTE, pwt->b[15], pws->b[15], pwt->b[15= ]); + pwd->b[0] =3D msa_msubv_df(DF_BYTE, pwd->b[0], pws->b[0], pwt->b[0]= ); + pwd->b[1] =3D msa_msubv_df(DF_BYTE, pwd->b[1], pws->b[1], pwt->b[1]= ); + pwd->b[2] =3D msa_msubv_df(DF_BYTE, pwd->b[2], pws->b[2], pwt->b[2]= ); + pwd->b[3] =3D msa_msubv_df(DF_BYTE, pwd->b[3], pws->b[3], pwt->b[3]= ); + pwd->b[4] =3D msa_msubv_df(DF_BYTE, pwd->b[4], pws->b[4], pwt->b[4]= ); + pwd->b[5] =3D msa_msubv_df(DF_BYTE, pwd->b[5], pws->b[5], pwt->b[5]= ); + pwd->b[6] =3D msa_msubv_df(DF_BYTE, pwd->b[6], pws->b[6], pwt->b[6]= ); + pwd->b[7] =3D msa_msubv_df(DF_BYTE, pwd->b[7], pws->b[7], pwt->b[7]= ); + pwd->b[8] =3D msa_msubv_df(DF_BYTE, pwd->b[8], pws->b[8], pwt->b[8]= ); + pwd->b[9] =3D msa_msubv_df(DF_BYTE, pwd->b[9], pws->b[9], pwt->b[9]= ); + pwd->b[10] =3D msa_msubv_df(DF_BYTE, pwd->b[10], pws->b[10], pwt->b[10= ]); + pwd->b[11] =3D msa_msubv_df(DF_BYTE, pwd->b[11], pws->b[11], pwt->b[11= ]); + pwd->b[12] =3D msa_msubv_df(DF_BYTE, pwd->b[12], pws->b[12], pwt->b[12= ]); + pwd->b[13] =3D msa_msubv_df(DF_BYTE, pwd->b[13], pws->b[13], pwt->b[13= ]); + pwd->b[14] =3D msa_msubv_df(DF_BYTE, pwd->b[14], pws->b[14], pwt->b[14= ]); + pwd->b[15] =3D msa_msubv_df(DF_BYTE, pwd->b[15], pws->b[15], pwt->b[15= ]); } =20 void helper_msa_msubv_h(CPUMIPSState *env, --=20 2.31.1 From nobody Sat Apr 27 16:42:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1634924768; cv=none; d=zohomail.com; s=zohoarc; b=cexXoH1wWc8FJYqzwYI/jkwwwy56k1lugNhM+QUGCfZgABglmaQPy2t+EOAt/jMopR8KfDgfynmzVo2VzOJhG4o/+jakMJn8wikajK4AJeM8WUMzE0iiDsd0cSBWUDhqonoh3qUv0nsTpgFoqYAOy77BIAl0Hk/ol4o4vSpHOUI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634924768; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9jfi6V3ZggWbRfP1dtoRvCwxf46pdyiI8ewC4QVCUpA=; b=Eo77mWhtaukeBusNCkFWXgIK2CatnCveMG35iOUS4iOyuyZmWDZdszUBKJ4LnhVJpjJawXj4B/vLJpsV1MZ2sO9i0m+2PVo90CfYT5nnop5i8ofT4vO/RTaJ0+XTZfsfm2KwFyRvCxuU0upM4GA1lG4Wx9IhgKNuHKwjMJTjlsE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1634924768125568.8144051723332; Fri, 22 Oct 2021 10:46:08 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id d3so2072184wrh.8 for ; Fri, 22 Oct 2021 10:46:07 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id g8sm8341147wrx.26.2021.10.22.10.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 10:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9jfi6V3ZggWbRfP1dtoRvCwxf46pdyiI8ewC4QVCUpA=; b=P2g7D2VLs5cFVed5N8vMkE/RGQYg7rthLHOq04ITbvpB20G74LMdv+H7TeL+vNBQug hwa4lkKkgT0LHDVbYhBPm68H85HYcxR6zYZa2kSko+0/h0ILPJIObCRM/ou9+Mx8oLo1 efcIvvBJJO4vK6t1x1145cdLlUUDpyuovtyMJlTrD3ymTGO+MDO6vrwtFrfjFfRUXjHi D2T0KKiHPOcdBJpXC4OnImox1pzGbfYqieULvHDsz3bgg0aCvNnioUIBGKrVk+99UK+J LhpKd4MieGDHlggmIzZKnGu29dOnHZAQXBC+MdiC7n5FQHvfxE67WzilQ8f/h50Yt+QL NQ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9jfi6V3ZggWbRfP1dtoRvCwxf46pdyiI8ewC4QVCUpA=; b=mgDMUcoaErxpC9dgHg0B6cBhE+4NK/QIo3IDw8KMhUM1i34PqEf8pc89qXr038oj1/ Ly8HFL+9i8sFgmnUKqzSTHvNjF0i3lzX7PJjFSVBsSV8WNhEaDWuQ2M469dG7OvCksol tallo3OB5ZnQAx7p7QxB7U9DX523z8vhrMfl9a0XLc5S771u8np/DoHt8PfvFWYbj7PD b+Gnp9pBVplDrA59DnwylrhwI2n8ZkzsFxwOAOd8lHGGIeiTnE20xR+EfUJT2V03TeUr x6S/6xwEg2G5ovBrdEu27t24pnTJd7ziroS/AzS+jKs8PA5LoW0frE9wV2ORGjAbG104 mfSg== X-Gm-Message-State: AOAM533xziaf/WynJW3374ezAOAHXE+ioxQ/zBfPbnaQWYBhs7A4Y+e+ 1glV73+0g1igtXb4V8sww8I= X-Google-Smtp-Source: ABdhPJz2QD82D5XQKhtWrqwrMCqoI5D6CXqXIhxpTmM47JzVurNdshNsAsg11A2/GNIeg3eMl9ImEQ== X-Received: by 2002:a5d:58ec:: with SMTP id f12mr1629474wrd.24.1634924766457; Fri, 22 Oct 2021 10:46:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Huacai Chen , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 3/3] target/mips: Fix Loongson-3A4000 MSAIR config register Date: Fri, 22 Oct 2021 19:45:50 +0200 Message-Id: <20211022174550.36937-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211022174550.36937-1-f4bug@amsat.org> References: <20211022174550.36937-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1634924769530100001 When using the Loongson-3A4000 CPU, the MSAIR is returned with a zero value (because unimplemented). Checking on real hardware, this value appears incorrect: $ cat /proc/cpuinfo system type : generic-loongson-machine machine : loongson,generic cpu model : Loongson-3 V0.4 FPU V0.1 model name : Loongson-3A R4 (Loongson-3A4000) @ 1800MHz isa : mips1 mips2 mips3 mips4 mips5 mips32r1 mips32r2 mips64r= 1 mips64r2 ASEs implemented : vz msa loongson-mmi loongson-cam loongson-ext l= oongson-ext2 ... Checking the CFCMSA opcode result with gdb we get 0x60140: Breakpoint 1, 0x00000001200037c4 in main () 1: x/i $pc =3D> 0x1200037c4 : cfcmsa v0,msa_ir (gdb) si 0x00000001200037c8 in main () (gdb) i r v0 v0: 0x60140 So set MSAIR=3D0x60140 for the Loongson-3A4000 CPU model added in commit af868995e1b ("target/mips: Add Loongson-3 CPU definition"). Cc: Huacai Chen Cc: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Jiaxun Yang --- target/mips/cpu-defs.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/target/mips/cpu-defs.c.inc b/target/mips/cpu-defs.c.inc index cbc45fcb0e8..f43a8e7c9d9 100644 --- a/target/mips/cpu-defs.c.inc +++ b/target/mips/cpu-defs.c.inc @@ -886,6 +886,7 @@ const mips_def_t mips_defs[] =3D (0x1 << FCR0_D) | (0x1 << FCR0_S), .CP1_fcr31 =3D 0, .CP1_fcr31_rw_bitmask =3D 0xFF83FFFF, + .MSAIR =3D (0x601 << MSAIR_ProcID) | (0x40 << MSAIR_Rev), .SEGBITS =3D 48, .PABITS =3D 48, .insn_flags =3D CPU_MIPS64R2 | INSN_LOONGSON3A | --=20 2.31.1