[PATCH v5 0/4] VNC-related HMP/QMP fixes

Stefan Reiter posted 4 patches 2 years, 5 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211019155443.1447372-1-s.reiter@proxmox.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Eric Blake <eblake@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>
There is a newer version of this series
hmp-commands.hx            |  24 +++---
monitor/hmp-cmds.c         |  56 ++++++++++++-
monitor/hmp.c              |  17 +++-
monitor/monitor-internal.h |   3 +-
monitor/qmp-cmds.c         |  62 ++++++---------
qapi/ui.json               | 156 ++++++++++++++++++++++++++++++++-----
6 files changed, 244 insertions(+), 74 deletions(-)
[PATCH v5 0/4] VNC-related HMP/QMP fixes
Posted by Stefan Reiter 2 years, 5 months ago
Since the removal of the generic 'qmp_change' command, one can no longer replace
the 'default' VNC display listen address at runtime (AFAIK). For our users who
need to set up a secondary VNC access port, this means configuring a second VNC
display (in addition to our standard one for web-access), but it turns out one
cannot set a password on this second display at the moment, as the
'set_password' call only operates on the 'default' display.

Additionally, using secret objects, the password is only read once at startup.
This could be considered a bug too, but is not touched in this series and left
for a later date.


v4 -> v5:
* add comment to patch 1 in "monitor-internal.h" - I left Eric's R-b since the
  code is the same, hope that's ok
* use qapi_free_SetPasswordOptions and friends, don't leak strdups
* split QAPI change into 3 seperate patches

v3 -> v4:
* drop previously patch 1, this was fixed here instead:
  https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg02529.html
* patch 1: add Eric's R-b
* patch 2: remove if-assignment, use 'deprecated' feature in schema

v2 -> v3:
* refactor QMP schema for set/expire_password as suggested by Eric Blake and
  Markus Armbruster

v1 -> v2:
* add Marc-André's R-b on patch 1
* use '-d' flag as suggested by Eric Blake and Gerd Hoffmann
  * I didn't see a way to do this yet, so I added a "flags with values" arg type


 qemu: Stefan Reiter (4):
  monitor/hmp: add support for flag argument with value
  qapi/monitor: refactor set/expire_password with enums
  qapi/monitor: allow VNC display id in set/expire_password
  qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate

 hmp-commands.hx            |  24 +++---
 monitor/hmp-cmds.c         |  56 ++++++++++++-
 monitor/hmp.c              |  17 +++-
 monitor/monitor-internal.h |   3 +-
 monitor/qmp-cmds.c         |  62 ++++++---------
 qapi/ui.json               | 156 ++++++++++++++++++++++++++++++++-----
 6 files changed, 244 insertions(+), 74 deletions(-)

-- 
2.30.2