From nobody Mon Feb 9 12:25:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1634653530; cv=pass; d=zohomail.com; s=zohoarc; b=ZnJXFK8eUfmHF8YzBjnqtXkaO3nZ+6d6CbaFGUQHuj2OvMW5NXjrJfbfV6i5FEkddYqartdlE7tuCVKhX0xqA1ZN7p1RB/LpDvlkeosbkCNsqwH9Uuprx1pRuf5yJCq67qpajWvOoPGyzOS18W9+NDZc90U+vbulwXyglgqvWY8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634653530; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rpHV6SblamuH9pRvxIeBV2ts8xEuCx/gKb1Pd6OPiVg=; b=FcERASoiOizRuEMuIB19VAQQY8t1UwnNibC2A97PAe2gH8pSnKTu+VXgO1MFlFnPl83HcBoy52bVgl/U2ffLsRgxCkqqOcOrtx8sf9ksb8tqDqO5o/TWjeatMZaQ1lQIuyxrF1jrXtuzoJn7apLrs9ZSxEetJQu3OV8rRuVAMag= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1634653530421675.1016286754706; Tue, 19 Oct 2021 07:25:30 -0700 (PDT) Received: from localhost ([::1]:45022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcq3V-0005O3-EU for importer@patchew.org; Tue, 19 Oct 2021 10:25:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpql-0004Rc-NA; Tue, 19 Oct 2021 10:12:19 -0400 Received: from mail-co1nam11on2073.outbound.protection.outlook.com ([40.107.220.73]:46337 helo=NAM11-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcpqj-0004F5-7B; Tue, 19 Oct 2021 10:12:19 -0400 Received: from DS7PR03CA0251.namprd03.prod.outlook.com (2603:10b6:5:3b3::16) by BYAPR12MB4760.namprd12.prod.outlook.com (2603:10b6:a03:9c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Tue, 19 Oct 2021 14:12:12 +0000 Received: from DM6NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b3:cafe::8c) by DS7PR03CA0251.outlook.office365.com (2603:10b6:5:3b3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Tue, 19 Oct 2021 14:12:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT034.mail.protection.outlook.com (10.13.173.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 14:12:09 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 19 Oct 2021 09:12:04 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nNEk3gv808+iWebQsUa8d0nOAjBoLjv7AG5WzhmkD0mSSJW3UPNUB8LSyO2C1Rp81E3CpP5foXt5gSRJhi+mJL2zEF4jTWMtmCglM7bvikLL6xSiPGwdUMgTKEEXBlvR+SpsllPIjBQpmuy7QwZdEZDOeorCNl9ON3s/kvurl7gFDN8wWXGyTDngCdiLY2xYreZDNS32MMzlxnyFYCzc3EfsGNMkBoqEK7KZmc/EZwFBKzb9yZwYp4/rCBYUs1DAWYqvGgsHzJckycpb9NOIm9GW3AgfSee4y3MyyPo0NlA5LYOCF6Mw8Ma2Lp7IVzXYhMy3J4GJ3BZiAyAVu2Umng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rpHV6SblamuH9pRvxIeBV2ts8xEuCx/gKb1Pd6OPiVg=; b=ISVGfm2km5Ns0sGaogS4OIR9IurSGrmxisLyBjmyf7zsRJPDvWarnIS0Yj8d4cVBGbWNFihGdVSy+PrwWQ1VirPKbhpOrciKnxZoef5xN3piRPBX/ovcROh4aRyKWLhc+BvbwY3Qm3xz3HDlBlbYT9xhWGAidw3goNpPzXOU6prtHQX5rDcX582ixB/pG7Xv3V+JyPjvoZE7efZejPWkeI7TJEeLXErFKKL01BhTPDDdJP3f4jfP6pKIN6ZQSa3CCyCKwdc1lMePXreHN3/JfwekhVZU5Kk25h429Yu2ywbMgOeJ0Dv5qjy9BLNemHbyjlX6KrPFJz0Jzgco5zec/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rpHV6SblamuH9pRvxIeBV2ts8xEuCx/gKb1Pd6OPiVg=; b=0IHDLVURU1j87uXOhG7Xm+9N6PihQQjz/FZCydjFgB/+COgAZBxZWWX3A5PJsMF3vB1iO8ro+4l21ZcMhB6Wuf2DyvEn9UWFoOR0mOT2FNgUVrETVBs9tleZlbI4r8fnBbv94suub9V6qX3IRgGylVBnJibsY0sg4ZlLBbrdvcA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; From: Michael Roth To: CC: , Max Filippov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 09/64] target/xtensa: fix access ring in l32ex Date: Tue, 19 Oct 2021 09:08:49 -0500 Message-ID: <20211019140944.152419-10-michael.roth@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019140944.152419-1-michael.roth@amd.com> References: <20211019140944.152419-1-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8d3445b-0884-4223-f2b5-08d9930a70b9 X-MS-TrafficTypeDiagnostic: BYAPR12MB4760: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RZ/56qZ8C2uS2uAZA1QKcdb5p8LPuh2PcjIlnbwYs0fdXvqMVntAiBH86bO5yHcPL7SzFVTFgmKwOnJGaKlGCNkwWgoK/Aa38PAZ+eRyo2neOcebZ5KIzAQMAb54nIB2TYnhqOqicnWIPXhpyr3YpckULs+LnV+yYJPMQsBcXFcedA6aB2hSAEmHwTfsSL/WAdWK6OizznwD39qBWPymJgT0OMdsRbmVBulqH7bd4x08hsJh7fdwX0fbTiVGICt/okm0RNUIlc8Dcdp8YfAM3PrSa1/XPUZR6pD8JXJbrTrlMl/omKA+rFpyJz0CDR2bnym/k8sObelqOr6imzco1Xm/E1wNA4w4wcE9a1PWiBuGu9nUxsIyDrVjf1NGcJQ6oaIxl3THjl/53OGuQF9akg7174ozHCZQRL7wF+Y1eHP/WMdPiRMJ67icvNXN1OqSM9U+Ap3CHP0OUdMV8Uht26hdiQF3Fari/M2q5GeSytUOlSD9dOoYKzkE0YT0tjDF/snIvu7z+/QbYxfvTOeipyEMOLLZH4ng7rgUcP3W2RZQtUqA0rhRv36ofnFjGfUe0pQmD3ChYAZuNE26wIbJ3TES/QhEqa5ruMWSU6V5h1owdrA2I53acrmnMkLoYqMBITN8VNvz+4kFvJHvuJiolt6VASffNQJ5vYay7S40mgGokyEioygFPHz5RYhqY/dWCRqmoYS9b75HwJut0gupOFrpOt/AG0lGRJ5J72DpCmE= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(47076005)(356005)(86362001)(81166007)(2906002)(1076003)(4326008)(26005)(36860700001)(6916009)(6666004)(508600001)(44832011)(82310400003)(83380400001)(70206006)(5660300002)(336012)(36756003)(426003)(54906003)(316002)(2616005)(8936002)(70586007)(16526019)(8676002)(186003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 14:12:09.1760 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8d3445b-0884-4223-f2b5-08d9930a70b9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4760 Received-SPF: softfail client-ip=40.107.220.73; envelope-from=Michael.Roth@amd.com; helo=NAM11-CO1-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1634653531777100001 From: Max Filippov l32ex does memory access as all regular load/store operations at CRING level. Fix apparent pasto from l32e that caused it to use RING instead. This is a correctness issue, not a security issue, because in the worst case the privilege level of memory access may be lowered, resulting in an exception when the correct implementation would've succeeded. In no case it would allow memory access that would've raised an exception in the correct implementation. Cc: qemu-stable@nongnu.org Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Max Filippov (cherry picked from commit 735aa900e4bf57b777ac620bed7c88234ec4b601) Signed-off-by: Michael Roth --- target/xtensa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 0ae4efc48a..1678b65607 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -1817,7 +1817,7 @@ static void translate_l32ex(DisasContext *dc, const O= pcodeArg arg[], tcg_gen_mov_i32(addr, arg[1].in); gen_load_store_alignment(dc, 2, addr, true); gen_check_exclusive(dc, addr, false); - tcg_gen_qemu_ld_i32(arg[0].out, addr, dc->ring, MO_TEUL); + tcg_gen_qemu_ld_i32(arg[0].out, addr, dc->cring, MO_TEUL); tcg_gen_mov_i32(cpu_exclusive_addr, addr); tcg_gen_mov_i32(cpu_exclusive_val, arg[0].out); tcg_temp_free(addr); --=20 2.25.1