From nobody Tue Feb 10 19:00:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1634511194; cv=none; d=zohomail.com; s=zohoarc; b=dxwuiE6FrsQtSYGRPqyGrg5YJsZ6Go3lm9SS6z6qCdGLGhk3pug+no1Jpl8HM3rD0WRt4e6qE/FybfN0miXElBbdcBn43OxOu3LovVUWDukvpzj1J0HfKrL8S1Z6mjNQzFbwcZrfaslrOy3O+jtOS+lyrqNFG29Mj8owwoD23xA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634511194; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qWW6jaAc1xuKmuHwt0Vz/fW3KIsJVwuG8QDNEQr3f7g=; b=kLZ7KYjlUrIyHNuR0pgJEPekMD6s5802hC9nJ3ayrQ0TwfyN6UYBB1n7w2xZSaJaE5gVYjhhXTpSBzqyx4TAjmDYnlyAZBn+Hn3v8ehOKMJWJm545uFg85x6cdlMnhXtcMRU5zdBkHJR8owyAa6KlxF6an7+yjwRjfUNq0uEUZo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 1634511194883785.7672501524668; Sun, 17 Oct 2021 15:53:14 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id 67-20020a1c1946000000b0030d4c90fa87so6945437wmz.2 for ; Sun, 17 Oct 2021 15:53:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (213.red-81-36-146.dynamicip.rima-tde.net. [81.36.146.213]) by smtp.gmail.com with ESMTPSA id z6sm11193001wro.25.2021.10.17.15.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Oct 2021 15:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qWW6jaAc1xuKmuHwt0Vz/fW3KIsJVwuG8QDNEQr3f7g=; b=RZSODLe+syIUlFYLRz+oPdliMxQcyA5tQ4bFBkXNGhgw/jPeqU6pwm5ZakSBDSza4/ kFunzYPh0bJNeTSX0rJzAp5c6jxV+bSQx4w1HKHAYFkBQDtFsl7JOAKQE5kNhBW/TIx2 WmJcJebIDcxAEKeB4xS0RLzBGa7POAF9FM5fcobvB68aLGYhxTDPLVQmeV2uuvkkFxLf cVe6eD/0lIgfSDDlVSG7A8yI4EEcYaMztftqDUi9bCtRHxHIr0WJrOrxkBRb20cRP6p2 nh2XBGs7muIgM3osmh8uDzxJS5xhjpmq3aqpp6I/rnDsp5Mge5IqSF/ilbW3EN24Id9E TjYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qWW6jaAc1xuKmuHwt0Vz/fW3KIsJVwuG8QDNEQr3f7g=; b=uqHeEvOnF33fvdYNTBNfYeuqRkEbNG+TawfiIH0aqPw39HKA2uR7YwhQ74Ioeu4pv+ rv50Gha52sOzgq9w2rhQ3VC02LX0k5LYf3clPpLIVPHFzu1FqbmT5UqJw6SbLabAFK/j jSVxH/QeNvYHRJb68TfNUHJPglPEa+tiI1YAX82IpGbVLw/pwbyjXm02+edik2R/Umfq YFkbK3j83h0nwOrUIP/1xsUba9hVxIlT8MEfCn/jCZKxVHk5Pp4SynDxwKekyyVrsNX3 Qij2VIA8P5U1/PRz2GJfVU+8ez/fcfwjEyaxOolVSYCxPsQjc0TIGqhAxcEEcR0nngVg LYRQ== X-Gm-Message-State: AOAM531mlIqxX4YCX/aqG2rPhF265iIZ3p88mbVUhzZ1LGApkUtCb7ZI QnSowyzT6CcvbvEjjFXJoEk= X-Google-Smtp-Source: ABdhPJxUreoZ8svBH9LF6ksCA/G1iZdAsrk8Wlhv6qxsUnzQlesUt/xFinaqvD+d0xM86LRlIpBdVw== X-Received: by 2002:a05:600c:299:: with SMTP id 25mr27633481wmk.22.1634511193075; Sun, 17 Oct 2021 15:53:13 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , Richard Henderson Subject: [PULL 05/17] target/mips: Remove unused register from MSA 2R/2RF instruction format Date: Mon, 18 Oct 2021 00:52:33 +0200 Message-Id: <20211017225245.2618892-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211017225245.2618892-1-f4bug@amsat.org> References: <20211017225245.2618892-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1634511196828100001 Commits cbe50b9a8e7 ("target-mips: add MSA VEC/2R format instructions") and 3bdeb68866e ("target-mips: add MSA 2RF format instructions") added the MSA 2R/2RF instructions. However these instructions don't use any target vector register, so remove the unused TCG temporaries. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211003175743.3738710-2-f4bug@amsat.org> --- target/mips/tcg/msa_translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 8170a8df26b..ee6424126f7 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1942,13 +1942,11 @@ static void gen_msa_2r(DisasContext *ctx) { #define MASK_MSA_2R(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ (op & (0x7 << 18))) - uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; uint8_t df =3D (ctx->opcode >> 16) & 0x3; TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twt =3D tcg_const_i32(wt); TCGv_i32 tdf =3D tcg_const_i32(df); =20 switch (MASK_MSA_2R(ctx->opcode)) { @@ -2018,7 +2016,6 @@ static void gen_msa_2r(DisasContext *ctx) =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); tcg_temp_free_i32(tdf); } =20 @@ -2026,13 +2023,11 @@ static void gen_msa_2rf(DisasContext *ctx) { #define MASK_MSA_2RF(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ (op & (0xf << 17))) - uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; uint8_t df =3D (ctx->opcode >> 16) & 0x1; TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twt =3D tcg_const_i32(wt); /* adjust df value for floating-point instruction */ TCGv_i32 tdf =3D tcg_const_i32(df + 2); =20 @@ -2089,7 +2084,6 @@ static void gen_msa_2rf(DisasContext *ctx) =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); tcg_temp_free_i32(tdf); } =20 --=20 2.31.1