From nobody Tue Feb 10 17:52:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) client-ip=209.85.128.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1634511253; cv=none; d=zohomail.com; s=zohoarc; b=V9YdRAPGX+e51wpTSEH6HAFkiWohjpgRKbowh8aTAf9zYwic8R8bakGfcYlFpbqjhFhidnPi1XexRrTCVUopFLLaHKiBSrzhO4P+IJDzeoLoY5eODxT/ZoUCw/kSTfvpnlGMwH5MBwZdO7IjWlvTIYw9dhEuJEZNOSzgrUDmKss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634511253; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cAlFbLE9wEpuh6Lb0mTS+p4wTMdHmTaWF5EoIoUfJp4=; b=OJsclY+AqoSMf1BecHvMcV5/R35u4QLL37TUE6gbxmuSdG1qYaJhpGIyB6eFJyz1WpCzFFQeEqgX7bMz/OqtVNZPNFJ70VwvUk4EUT+JeIQKTTU3QL5dNpq5i8P1ut6KsoT3K5d0FQPGfkmorrt/J7xZpYe1GsB1uQQJ+qivfDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.zohomail.com with SMTPS id 1634511253432191.47830692111972; Sun, 17 Oct 2021 15:54:13 -0700 (PDT) Received: by mail-wm1-f45.google.com with SMTP id d198-20020a1c1dcf000000b00322f53b9b89so3223662wmd.0 for ; Sun, 17 Oct 2021 15:54:12 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (213.red-81-36-146.dynamicip.rima-tde.net. [81.36.146.213]) by smtp.gmail.com with ESMTPSA id c15sm10875404wrs.19.2021.10.17.15.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Oct 2021 15:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cAlFbLE9wEpuh6Lb0mTS+p4wTMdHmTaWF5EoIoUfJp4=; b=LcMHtS2NLYBgKbbJDnucsTIEwbiSYGW6a1OgF/VztCro4kj1MwU7CcVajezRk4R0yV RnvcrwLaNC6gugouQf7JBWWciBbcB1ifV43vXwO+HI+LD+OuNH99SN9Qb3b7znh+OatS /ZuMqsFD5GCoYAUaQVrGhhIWz9OQorf3/OCQCKlDMcOfZiFbqhsv2KCf5AjrBSJadYNF QoWOCrAt5Slm6cDD0k528Q//WIT+ic9PMR+gwoZwiDc/knnGr2j7LGDgK0oDFXduJDj+ HPA26aCzUjbnXmXzKXCuwZ4lWpefHTj81Gd7kZkp8xOacQm1MbC6rYHQ9B52BjdAhvLj 3fiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cAlFbLE9wEpuh6Lb0mTS+p4wTMdHmTaWF5EoIoUfJp4=; b=LaJYxQWZVrIbp9FL7vXr0+Ce0SEhxahYBIWpspOX2/oRv2D6yZtL/PBKEuiIvUlnEL YUbCWIMo5bhPqXlu2bkwwA2hDr5p7R09I18kYB0+BIond26Lg+AJCyMhlH0xumI4crq7 aNx8C5Kee/G5wajCFl1Hl3Zb9Hf53pBWqx823vnBwIIds4vYweIIxomzBTeAoCxvjmUZ H2XThFvD/axgI71npFTMGwNm4AtkSCSF0z6OuQ/7h/sdvZVQVt/7WIWyUekxdBvngO+p AptIJCfXdfj6SM52STuvlzYoQop3CKWQzsNRP3iBuTkDSld6UV/Ff6swgenLoprhvVDJ O0Hw== X-Gm-Message-State: AOAM531nlSvoJzUo5iX1nBB15gHRDmh5LN/cJP4xFeaVCtybl4RuL+F3 2FDVDyyaRSxjeztmEPW0OwE= X-Google-Smtp-Source: ABdhPJyj6inFirO95zb/Hm0mYjH7e4EQubGQ75m7F35xXVQ7UsbfYvabVtp3w26Y8vNADgQgh6XGOA== X-Received: by 2002:a7b:c386:: with SMTP id s6mr41152667wmj.183.1634511251578; Sun, 17 Oct 2021 15:54:11 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , BALATON Zoltan Subject: [PULL 17/17] via-ide: Avoid using isa_get_irq() Date: Mon, 18 Oct 2021 00:52:45 +0200 Message-Id: <20211017225245.2618892-18-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211017225245.2618892-1-f4bug@amsat.org> References: <20211017225245.2618892-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1634511254486100001 From: BALATON Zoltan Use via_isa_set_irq() which better encapsulates irq handling in the vt82xx model and avoids using isa_get_irq() that has a comment saying it should not be used. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <26cb1848c9fc0360df7a57c2c9ba5e03c4a692b5.1634259980.git.balato= n@eik.bme.hu> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/ide/via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index e91dad632a9..82def819c41 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -29,7 +29,7 @@ #include "migration/vmstate.h" #include "qemu/module.h" #include "sysemu/dma.h" - +#include "hw/isa/vt82c686.h" #include "hw/ide/pci.h" #include "trace.h" =20 @@ -112,7 +112,7 @@ static void via_ide_set_irq(void *opaque, int n, int le= vel) d->config[0x70 + n * 8] &=3D ~0x80; } =20 - qemu_set_irq(isa_get_irq(NULL, 14 + n), level); + via_isa_set_irq(pci_get_function_0(d), 14 + n, level); } =20 static void via_ide_reset(DeviceState *dev) --=20 2.31.1