From nobody Tue Feb 10 11:34:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1634511214; cv=none; d=zohomail.com; s=zohoarc; b=Ysdk2AmNpW2ioyUKNxP2xRelmtOdDfN6PGtKKrzCqLXlREBrVSRwntdThID+p7NlweqIb9UV8R5WGObZx3cBYy/DRm7Fa6CMXpbzFVtxu3YGMKso5jT4UEW7cVmIQca1ZNIwysVFI8s1RlyugDn9oM74i621d3otH/C3mZqMo8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634511214; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vP1k7G6kYb0ZSEIWtvfL0SOPPZNd2sVy+iXF6U+13xE=; b=FvtODFFIIKZJj5Htldt7kn2jlZN6zAOND0ggkqJYZhCBqkJQMzfvX7sRt5LIMZv0f6lKmqEZK9Vp8lo3+6uN0l1W4nnEAEylKAOYB9Or/BMBW6KNpSsZvfoHxRddE/CA/EdPB3JR8ZkPkzSzWjXnBJZD2/VwXpm+mrDRfIXdZIc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.zohomail.com with SMTPS id 1634511214231638.9317691272412; Sun, 17 Oct 2021 15:53:34 -0700 (PDT) Received: by mail-wm1-f54.google.com with SMTP id j75-20020a1c234e000000b00323023159e1so559862wmj.2 for ; Sun, 17 Oct 2021 15:53:33 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (213.red-81-36-146.dynamicip.rima-tde.net. [81.36.146.213]) by smtp.gmail.com with ESMTPSA id o26sm16626125wmc.17.2021.10.17.15.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Oct 2021 15:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vP1k7G6kYb0ZSEIWtvfL0SOPPZNd2sVy+iXF6U+13xE=; b=NkJff89eRufUKp/yPO1QySa0M4DqQH+XB/DYT24lT55dE29ss3f2cla725XlBtRo74 ESjHcpceKVtueuXUvkBx67QoqIkcicdBcFIHkDrJZCQBTX8CiQtRPYZsByL/RcMy+MIX VB5dBcdxc2y4Jhl2laW4zyiXEG6zk7KPdiqYTbH+LbU0u15WFoRzC1JRV7I9mhlZCBH2 eyK6CLS0bbze+I0Oe556ohsymFiLJS7i00HfmDrV+13bFhMPy6+K0fElWyaqPW8IMEFy 3UeBHwcaT3Lq6DUTkt9Gy2VnDMJGLwcAZp5bKeaDlTb4nFNubVcUUcn23DoPz19qjoWR 8hEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vP1k7G6kYb0ZSEIWtvfL0SOPPZNd2sVy+iXF6U+13xE=; b=hz/6fxdGEQxYKRRaHmopfKgC+Q9HLVhrRY/OoLV/qBCnB7G8KibvBnXbG5k0h1LMo5 RpIUORcR2pyawbKVizXPajTuI1AJ0WElkiM7Y2jehrTL2zMP4ANqHUlNTQt6IU5C4JFw wSWm2Zd9Bx7mmq0cOoAJNfppC1XD1UmC/mLTf8gmp6n5hfZfwfzB613nwTNC6pBwxHtP uifeQPWNaJar6NFr7VidKIDP00B5Y5eGv9nKaszKtDwCDumueWCFCUIUV+YMxnx5k8T5 xQpME1ryAwvW7chRYWe2Kzg7a5xK+O3t/ADQre7RzHCv0SbpK8vMN0x5e1/T7m62mRWh ophQ== X-Gm-Message-State: AOAM533l54VIYXIITLMOrpKWV8OzBWVbvvHpyiOqK+P1My/LrWKPs/d/ xOdYn4erL91szlNSOKkxmvTsc7R81eE= X-Google-Smtp-Source: ABdhPJx8GRp/kZZSmQKWdaQlN6JZlmmKuXUqIhaHCV1QieOPYUIdh9FDPzypJXLqXzM/bxGP+pAyOQ== X-Received: by 2002:a1c:cc0f:: with SMTP id h15mr26788505wmb.37.1634511212463; Sun, 17 Oct 2021 15:53:32 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , Richard Henderson Subject: [PULL 09/17] target/mips: Use tcg_constant_i32() in gen_msa_3rf() Date: Mon, 18 Oct 2021 00:52:37 +0200 Message-Id: <20211017225245.2618892-10-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211017225245.2618892-1-f4bug@amsat.org> References: <20211017225245.2618892-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1634511215188100001 Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20211003175743.3738710-6-f4bug@amsat.org> --- target/mips/tcg/msa_translate.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index bbe9146513a..e107cad57ee 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1790,10 +1790,22 @@ static void gen_msa_3rf(DisasContext *ctx) TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); TCGv_i32 twt =3D tcg_const_i32(wt); - TCGv_i32 tdf =3D tcg_temp_new_i32(); + TCGv_i32 tdf; =20 /* adjust df value for floating-point instruction */ - tcg_gen_movi_i32(tdf, df + 2); + switch (MASK_MSA_3RF(ctx->opcode)) { + case OPC_MUL_Q_df: + case OPC_MADD_Q_df: + case OPC_MSUB_Q_df: + case OPC_MULR_Q_df: + case OPC_MADDR_Q_df: + case OPC_MSUBR_Q_df: + tdf =3D tcg_constant_i32(df + 1); + break; + default: + tdf =3D tcg_constant_i32(df + 2); + break; + } =20 switch (MASK_MSA_3RF(ctx->opcode)) { case OPC_FCAF_df: @@ -1836,7 +1848,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmadd_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MUL_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mul_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULT_df: @@ -1846,14 +1857,12 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmsub_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADD_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_madd_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCLE_df: gen_helper_msa_fcle_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUB_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msub_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULE_df: @@ -1896,7 +1905,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MULR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mulr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULT_df: @@ -1906,7 +1914,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_a_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADDR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_maddr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSLE_df: @@ -1916,7 +1923,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmax_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUBR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msubr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULE_df: @@ -1934,7 +1940,6 @@ static void gen_msa_3rf(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(twt); - tcg_temp_free_i32(tdf); } =20 static void gen_msa_2r(DisasContext *ctx) --=20 2.31.1