From nobody Sun May 19 05:00:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1634290177988155.71265006727958; Fri, 15 Oct 2021 02:29:37 -0700 (PDT) Received: from localhost ([::1]:44896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbJWy-0000uj-Pu for importer@patchew.org; Fri, 15 Oct 2021 05:29:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbJPh-0005NA-GC for qemu-devel@nongnu.org; Fri, 15 Oct 2021 05:22:05 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:55705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbJPe-0006Gv-OR for qemu-devel@nongnu.org; Fri, 15 Oct 2021 05:22:04 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 5A2EA748F58; Fri, 15 Oct 2021 11:21:59 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 3E863748F57; Fri, 15 Oct 2021 11:21:59 +0200 (CEST) In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH] via-ide: Set user_creatable to false Date: Fri, 15 Oct 2021 11:16:54 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org Message-Id: <20211015092159.3E863748F57@zero.eik.bme.hu> X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Huacai Chen , Gerd Hoffmann , Philippe M-D Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1634290179738100003 Content-Type: text/plain; charset="utf-8" This model only works as a function of the via superio chip not as a standalone PCI device. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- This should be before the last patch changing via-ide or squshed into it. And similar to usb part but there I need to add it to the info struct. I can resend with these if you think this series worth the hassle. The previous one fixing the usb irq works without this clean up. hw/ide/via.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ide/via.c b/hw/ide/via.c index 252d18f4ac..82def819c4 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -217,6 +217,9 @@ static void via_ide_class_init(ObjectClass *klass, void= *data) =20 dc->reset =3D via_ide_reset; dc->vmsd =3D &vmstate_ide_pci; + /* Reason: only works as function of VIA southbridge */ + dc->user_creatable =3D false; + k->realize =3D via_ide_realize; k->exit =3D via_ide_exitfn; k->vendor_id =3D PCI_VENDOR_ID_VIA; --=20 2.21.4