From nobody Wed Feb 11 10:12:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1634273313230672.806471984961; Thu, 14 Oct 2021 21:48:33 -0700 (PDT) Received: from localhost ([::1]:57224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbF8y-0003ex-8P for importer@patchew.org; Fri, 15 Oct 2021 00:48:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbEcI-0006yK-C9 for qemu-devel@nongnu.org; Fri, 15 Oct 2021 00:14:47 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:37684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbEcE-0002xM-SJ for qemu-devel@nongnu.org; Fri, 15 Oct 2021 00:14:45 -0400 Received: by mail-pl1-x62d.google.com with SMTP id n11so5612973plf.4 for ; Thu, 14 Oct 2021 21:14:42 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id q8sm10236885pja.52.2021.10.14.21.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 21:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VGqZOPjwuoviGfiS5SB/EShJZs+j0SuqFPzdROiPbhU=; b=bHyCnYFAxOJGBUQhByKTz2G+C+TKM1+9Twr4BQ50SSIdgcpIQVvnNjjNizrhi9vHUX No1gRmsFkRLfVOMn/hUltUj+RX82BMudTBQXRIIjUupe/C0UBvBr+TTgVP4ewFOBTZyg BT4F60+TMaMBQUrt8u5fb+VwATekXE6rLfmm58c5X4fD5ACGtdkL/Gh/3gergKeo61EP qNvWotd3fgjdcXb0CuIBTcG7R5w6zGyGkzbiDYRXRSzF0NuJm8sU6Rd1aGKAXY59MbUz h8MMGs6ANt1k9Ofb6Ovu3Bs7N+lKvYCaUsoHHhnimtkpT9tScRKHapzFggTkEB0W1sxz 7lHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VGqZOPjwuoviGfiS5SB/EShJZs+j0SuqFPzdROiPbhU=; b=uE33lICWkEKYzRDqNeO8geEli/xWeMmC2HKmccHcg/OxMzD3/atwBTAI5ZNsY76FCj 8CO+ObbNVPF7ndK8fhh6fE1EmHuIWNGqnokEACGcqem2y0SxG9z68IZ70CqeKNglNSoJ LFKZKXKk1Ik7QpEaiVDMerv1hjQ1rdCvoY7+zoRxnR5EMEtmOmTvCzhXe+HC+fbvXVJ1 NtUTQT8hs26ApIjObgBD48bbaoLKerHnAdKofAbZoZs3KSVi7mufvouOtzJ1NpYMLsgC jVhQX3ypFJ1p5vY+dU+o3+rI1TTMufcEkixKQuNzkzTqJ4e4M7+UJeGFrmBNqw30jFEb wjDQ== X-Gm-Message-State: AOAM532xUc1xipTTHxxFBzsBV3u9xHQENX4qHFcEBnkEfLQc4sTEUmly s0KbObc4k9M1VQwV6z4SLaCzkGclA6HhAQ== X-Google-Smtp-Source: ABdhPJxydz6Nn+1x41mzg1aPvKLt6MOOarFyIcE4PGnjiSmHitY5Ansp5Mteo3gNVdk4oA+dbscz9Q== X-Received: by 2002:a17:90a:ac0a:: with SMTP id o10mr24726301pjq.125.1634271281599; Thu, 14 Oct 2021 21:14:41 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v5 59/67] accel/tcg: Report unaligned load/store for user-only Date: Thu, 14 Oct 2021 21:10:45 -0700 Message-Id: <20211015041053.2769193-60-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211015041053.2769193-1-richard.henderson@linaro.org> References: <20211015041053.2769193-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , alex.bennee@linaro.org, laurent@vivier.eu, imp@bsdimp.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1634273315351100001 Content-Type: text/plain; charset="utf-8" Use the new cpu_loop_exit_sigbus for cpu_mmu_lookup. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Reviewed-by: Warner Losh --- accel/tcg/user-exec.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index 92cbffd7c6..7d50dd54f6 100644 --- a/accel/tcg/user-exec.c +++ b/accel/tcg/user-exec.c @@ -220,9 +220,14 @@ static void validate_memop(MemOpIdx oi, MemOp expected) static void *cpu_mmu_lookup(CPUArchState *env, target_ulong addr, MemOpIdx oi, uintptr_t ra, MMUAccessType type) { + MemOp mop =3D get_memop(oi); + int a_bits =3D get_alignment_bits(mop); void *ret; =20 - /* TODO: Enforce guest required alignment. */ + /* Enforce guest required alignment. */ + if (unlikely(addr & ((1 << a_bits) - 1))) { + cpu_loop_exit_sigbus(env_cpu(env), addr, type, ra); + } =20 ret =3D g2h(env_cpu(env), addr); set_helper_retaddr(ra); --=20 2.25.1