[PATCH v2 0/2] hw/core/machine: Add an unit test for smp_parse

Yanan Wang posted 2 patches 1 week, 3 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211013074119.23028-1-wangyanan55@huawei.com
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
MAINTAINERS                 |   2 +
hw/core/machine-smp.c       | 181 +++++++++++
hw/core/machine.c           | 159 ----------
hw/core/meson.build         |   2 +
include/hw/boards.h         |   1 +
tests/unit/meson.build      |   1 +
tests/unit/test-smp-parse.c | 604 ++++++++++++++++++++++++++++++++++++
7 files changed, 791 insertions(+), 159 deletions(-)
create mode 100644 hw/core/machine-smp.c
create mode 100644 tests/unit/test-smp-parse.c

[PATCH v2 0/2] hw/core/machine: Add an unit test for smp_parse

Posted by Yanan Wang 1 week, 3 days ago
Hi,

This is v2 which introduces an unit test for generic smp_parse().

We have had enough discussions about what kind of SMP configurations
by the user should be considered valid and what should be invalid.
Since we have finished optimizing the SMP parsing code, then this
test normatively listed all the possible valid/invalid configurations
that the user can provide. This can be a testing tool when we
introduce new topology members and need to touch the parsing code.

For your reference, some related discussion is here:
https://lore.kernel.org/qemu-devel/YOxf+sxzUSJdbY+j@redhat.com/

Changelog:
v1->v2:
- split smp_parse out into a separate .c file instead of a header (patch #1)
- dropped an unnecessary function and add Andrew's R-b (patch #2)
- v1: https://lore.kernel.org/qemu-devel/20211010103954.20644-1-wangyanan55@huawei.com/

Yanan Wang (2):
  hw/core/machine: Split out the smp parsing code
  tests/unit: Add an unit test for smp parsing

 MAINTAINERS                 |   2 +
 hw/core/machine-smp.c       | 181 +++++++++++
 hw/core/machine.c           | 159 ----------
 hw/core/meson.build         |   2 +
 include/hw/boards.h         |   1 +
 tests/unit/meson.build      |   1 +
 tests/unit/test-smp-parse.c | 604 ++++++++++++++++++++++++++++++++++++
 7 files changed, 791 insertions(+), 159 deletions(-)
 create mode 100644 hw/core/machine-smp.c
 create mode 100644 tests/unit/test-smp-parse.c

--
2.19.1