From nobody Tue Feb 10 20:30:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1633637365; cv=none; d=zohomail.com; s=zohoarc; b=LRZKipM2Faljr3fknS7kvT/nn4SMVJcEhnzQh68O5sZeRWSPGyIJpMVoDvkEkgaatXH5Fy+eaxbFRyjKVltXZjTqOqrr+VMV+qokJII74ZAIEMJiprFHTeumOWnaK9Plu853jgh/CtNFh7fFQ0/fJUZXSAiHF0DJf2YJjUzwxyM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633637365; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/vbKJTGG/osCQnHCopwdaDi44nUoZOlB0Lh8d456MxE=; b=MO/Ek2A39BsLTeJr9MI3GRDu57ied35fFGSwK4Mmayr1VFvBthYFh6WEsap0hd8exYYdxDlxRZI/YDBSsn/O7d7ywkgjq91hsGCnBCwnP4DlHK6PHkORyu9dsMbIv+7rhbFcsh0EvWpqd+NLvaKind5FHff2q02a+Vdqx96KA3I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1633637365937867.776342065245; Thu, 7 Oct 2021 13:09:25 -0700 (PDT) Received: from localhost ([::1]:60846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYZhk-0000sH-Ub for importer@patchew.org; Thu, 07 Oct 2021 16:09:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYZTv-0000HM-Ez for qemu-devel@nongnu.org; Thu, 07 Oct 2021 15:55:08 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:34650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYZTs-00076s-V9 for qemu-devel@nongnu.org; Thu, 07 Oct 2021 15:55:07 -0400 Received: by mail-pg1-x52e.google.com with SMTP id 133so842755pgb.1 for ; Thu, 07 Oct 2021 12:55:04 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id y4sm216555pfn.193.2021.10.07.12.55.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 12:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=/vbKJTGG/osCQnHCopwdaDi44nUoZOlB0Lh8d456MxE=; b=Nn1aeNWEnBDVFCwL9AjEh6P7uZBIhgVjZ8COfn0356ocFooRzXjslN2vSijm4Ey8Vr sqkrWjgc98mk1vQWLb42NNBBvf1s7AihrFa1EBx/S+j7UIpfjgv4wr8uIvrD0wajTd9q cc2Oph6YdxCWxqUI2MzktrmMFq4O154qwRJyjojD8bdmW+E2O7rUCoamkUzWVYsjgLtd NdDO5b3rbVP2pFCz+RysHSrLOs36/aEhpTljbKTS/10ahURM973Ycg4O+US204dFsmY2 lwY2/AzEvB/W+o2R3xNUBaLe4gCM9iCMJ39eo0tja5m3+vgrFZB81eIexLaa/6DOKg6i MVtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/vbKJTGG/osCQnHCopwdaDi44nUoZOlB0Lh8d456MxE=; b=w1MmguEtWRGFVnLQyQN8YARoPmBdDfsiAOidAkxwAxhiRwWaj6r1KGWXeQ1W6brVto nLVMOVNgY+F9S/8xapTAEjvLmna2kIMjBOqQq40a88lRIVNaue9qzUDxkmdi/P8cjpDB kHvCMpsWguA/+QIBrQafW6Lgm3d+gd1PCgDYk98RS0MWKh6Ro0xB8T1ylTx53DggSUeS /WJ4iIkTstgCfXp7eEMVtDs0Na05sg8hSwwf6DoqBNkBVBNXrHVKAxxmrt6HWbAQaWST wtF3ywBqNqjsX1CGH82r7qwyqN9vhSO8Lz4KwStJPjhadg+uB0E1gGqkqm9TbbQRNSSG 1wng== X-Gm-Message-State: AOAM531HDGZ/boum7E1FGB75EpgtT5haEZ7Gnd5bNV+ksMLOQt1fJPzw YYTTqFIBdg7g4rmoJzNfHULeqW4rrKN3uw== X-Google-Smtp-Source: ABdhPJy1tykAFk2gjolVALfyfbEeND/L0oIS2TN3VJjj57s73/VU9LSodJ+9xkdKiqKg/A7Lk6aoJw== X-Received: by 2002:a05:6a00:14c2:b0:44c:d483:4df3 with SMTP id w2-20020a056a0014c200b0044cd4834df3mr1147028pfu.52.1633636503597; Thu, 07 Oct 2021 12:55:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 08/48] tcg/optimize: Split out fold_call Date: Thu, 7 Oct 2021 12:54:16 -0700 Message-Id: <20211007195456.1168070-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211007195456.1168070-1-richard.henderson@linaro.org> References: <20211007195456.1168070-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1633637366692100001 Content-Type: text/plain; charset="utf-8" Calls are special in that they have a variable number of arguments, and need to be able to clobber globals. Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Luis Pires --- tcg/optimize.c | 63 ++++++++++++++++++++++++++++++++------------------ 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index fad6f5de1f..74b9aa025a 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -624,10 +624,42 @@ static void copy_propagate(OptContext *ctx, TCGOp *op, } } =20 +static bool fold_call(OptContext *ctx, TCGOp *op) +{ + TCGContext *s =3D ctx->tcg; + int nb_oargs =3D TCGOP_CALLO(op); + int nb_iargs =3D TCGOP_CALLI(op); + int flags, i; + + init_arguments(ctx, op, nb_oargs + nb_iargs); + copy_propagate(ctx, op, nb_oargs, nb_iargs); + + /* If the function reads or writes globals, reset temp data. */ + flags =3D tcg_call_flags(op); + if (!(flags & (TCG_CALL_NO_READ_GLOBALS | TCG_CALL_NO_WRITE_GLOBALS)))= { + int nb_globals =3D s->nb_globals; + + for (i =3D 0; i < nb_globals; i++) { + if (test_bit(i, ctx->temps_used.l)) { + reset_ts(&ctx->tcg->temps[i]); + } + } + } + + /* Reset temp data for outputs. */ + for (i =3D 0; i < nb_oargs; i++) { + reset_temp(op->args[i]); + } + + /* Stop optimizing MB across calls. */ + ctx->prev_mb =3D NULL; + return true; +} + /* Propagate constants and copies, fold constant expressions. */ void tcg_optimize(TCGContext *s) { - int nb_temps, nb_globals, i; + int nb_temps, i; TCGOp *op, *op_next; OptContext ctx =3D { .tcg =3D s }; =20 @@ -637,8 +669,6 @@ void tcg_optimize(TCGContext *s) available through the doubly linked circular list. */ =20 nb_temps =3D s->nb_temps; - nb_globals =3D s->nb_globals; - for (i =3D 0; i < nb_temps; ++i) { s->temps[i].state_ptr =3D NULL; } @@ -647,17 +677,17 @@ void tcg_optimize(TCGContext *s) uint64_t z_mask, partmask, affected, tmp; int nb_oargs, nb_iargs; TCGOpcode opc =3D op->opc; - const TCGOpDef *def =3D &tcg_op_defs[opc]; + const TCGOpDef *def; =20 - /* Count the arguments, and initialize the temps that are - going to be used */ + /* Calls are special. */ if (opc =3D=3D INDEX_op_call) { - nb_oargs =3D TCGOP_CALLO(op); - nb_iargs =3D TCGOP_CALLI(op); - } else { - nb_oargs =3D def->nb_oargs; - nb_iargs =3D def->nb_iargs; + fold_call(&ctx, op); + continue; } + + def =3D &tcg_op_defs[opc]; + nb_oargs =3D def->nb_oargs; + nb_iargs =3D def->nb_iargs; init_arguments(&ctx, op, nb_oargs + nb_iargs); copy_propagate(&ctx, op, nb_oargs, nb_iargs); =20 @@ -1549,16 +1579,6 @@ void tcg_optimize(TCGContext *s) if (def->flags & TCG_OPF_BB_END) { memset(&ctx.temps_used, 0, sizeof(ctx.temps_used)); } else { - if (opc =3D=3D INDEX_op_call && - !(tcg_call_flags(op) - & (TCG_CALL_NO_READ_GLOBALS | TCG_CALL_NO_WRITE_GLOBALS)= )) { - for (i =3D 0; i < nb_globals; i++) { - if (test_bit(i, ctx.temps_used.l)) { - reset_ts(&s->temps[i]); - } - } - } - for (i =3D 0; i < nb_oargs; i++) { reset_temp(op->args[i]); /* Save the corresponding known-zero bits mask for the @@ -1599,7 +1619,6 @@ void tcg_optimize(TCGContext *s) case INDEX_op_qemu_st_i32: case INDEX_op_qemu_st8_i32: case INDEX_op_qemu_st_i64: - case INDEX_op_call: /* Opcodes that touch guest memory stop the optimization. = */ ctx.prev_mb =3D NULL; break; --=20 2.25.1