From nobody Tue Feb 10 13:36:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1633638895; cv=none; d=zohomail.com; s=zohoarc; b=SyFWEAdAwF81l4fCHrRuQvEmEYiGcTfBsmLw6NR/pnovTR88qy4e3SPHNyhYGw4SfS42PNchuirFY61yJmp+Es22mHym4A11z8atqYBGoqImPjGfb+WxdaKuvDy/fGQhZ4kuN/T0MoGKWJVWham3lDdg75bY+yqLzXXpdvgarMA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633638895; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8nskxwkPEdtZ9CUJwGKk8ZbCvAbk0j+Jxy5B05St7jg=; b=KRaFSKfqd3XS7I4pvMX2W7ioAOX63TTjdEcLs2Lev9OtMf5G75IxpYSxmlSkSzYl+lDR/ZuetlvcVdU8lKmtBhnpz5cJT7BniUIL2g5s0M9Pl/tncJ4THEjoWGAginV3UkXgowVvXLL086bCBxqDvJzU2W90qd/L1Un2CaeNYEo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1633638895134790.2708094077907; Thu, 7 Oct 2021 13:34:55 -0700 (PDT) Received: from localhost ([::1]:38824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYa6Q-0001Nc-0h for importer@patchew.org; Thu, 07 Oct 2021 16:34:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYZUL-0000SH-1F for qemu-devel@nongnu.org; Thu, 07 Oct 2021 15:55:34 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:39665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYZUJ-0007hs-GO for qemu-devel@nongnu.org; Thu, 07 Oct 2021 15:55:32 -0400 Received: by mail-pl1-x629.google.com with SMTP id c4so4637517pls.6 for ; Thu, 07 Oct 2021 12:55:27 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id y4sm216555pfn.193.2021.10.07.12.55.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 12:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=8nskxwkPEdtZ9CUJwGKk8ZbCvAbk0j+Jxy5B05St7jg=; b=Jt3K8i+NgZwuxjFtrFu+wUx9G5YHPJ70Nvnhk9kT0SX06FIsiTxFdxc49yWSvdNxdd YODVE/4fM8A5WODjUACLmdD9GqBaKdSaIE2XJxSu90cxlI8gKrl+bsiZxBNYdDpKL6Bj 88R81by00wBF+3zIzwveIyF6z5UJIuVDNLg0ery2tS1Jkt0dnXHXwd25aN0Mjxr8kjMM iM3+3tJhPaGcDuibpMJktuQL0uajJvV7Fuvh3F9J6PCg9rXPAZmjpXUeNbvXDoqxJjQa QDeGH/LvaTf6KAzYg2L5z0OJZeD5fNhTMwxLN3Uc8X4mVmnDPR3agHDzagyQhgvwtvUH Qsow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8nskxwkPEdtZ9CUJwGKk8ZbCvAbk0j+Jxy5B05St7jg=; b=c7Zkba1kq4WTXMyEEOUYMe0MPunR+nB5Ez+F8AB7Nm5zxjclGkQi9p1O653eSuPFwS v+Z9A0DnQBuMQMIN9kmzxLhLGev8LZtVRpJLvEiwGI9sC8LKm7ZCFaZOVURUmgIdbVUH u41FTFzcu+FMcfVyntEfuabJbCOVTVgWxGXdGguSgXjMhFqZ/+euXWVjsMkqds/7Y2Bt MX9v/fW7QdecJfN8TqVwc+8PLDB/vbw+WjRFAnyOC63xhm3+5kaK3yBxyvFTXVGiBnIs F3qDdoolpRlmvqDSrhD00AP3UzWdpKupUD35laFUBF9e6+FkuO+GwzNc1GV9aLiaKUos CfHw== X-Gm-Message-State: AOAM533J0umvLhkK2jxcnH0S7qpS7nuh5+o6FuTG/IHq6tVqxuQnC2BL a+8tTJUpYhuJ5GrUVWdnZtEvY3hRX5w+Qw== X-Google-Smtp-Source: ABdhPJxm1quRGAKodWkpS7QnW5lzA5J60YIke9NkiZ8RnlX01gVUUNkICWBRuAJGm2cuXT/wStXeow== X-Received: by 2002:a17:90a:a60e:: with SMTP id c14mr7715444pjq.70.1633636526488; Thu, 07 Oct 2021 12:55:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 39/48] tcg/optimize: Expand fold_mulu2_i32 to all 4-arg multiplies Date: Thu, 7 Oct 2021 12:54:47 -0700 Message-Id: <20211007195456.1168070-40-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211007195456.1168070-1-richard.henderson@linaro.org> References: <20211007195456.1168070-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1633638896923100001 Content-Type: text/plain; charset="utf-8" Rename to fold_multiply2, and handle muls2_i32, mulu2_i64, and muls2_i64. Signed-off-by: Richard Henderson --- tcg/optimize.c | 44 +++++++++++++++++++++++++++++++++++--------- 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index d82d0f15c7..0011ac31ec 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1400,19 +1400,44 @@ static bool fold_multiply(OptContext *ctx, TCGOp *o= p) return false; } =20 -static bool fold_mulu2_i32(OptContext *ctx, TCGOp *op) +static bool fold_multiply2(OptContext *ctx, TCGOp *op) { if (arg_is_const(op->args[2]) && arg_is_const(op->args[3])) { - uint32_t a =3D arg_info(op->args[2])->val; - uint32_t b =3D arg_info(op->args[3])->val; - uint64_t r =3D (uint64_t)a * b; + uint64_t a =3D arg_info(op->args[2])->val; + uint64_t b =3D arg_info(op->args[3])->val; + uint64_t h, l; TCGArg rl, rh; - TCGOp *op2 =3D tcg_op_insert_before(ctx->tcg, op, INDEX_op_mov_i32= ); + TCGOp *op2; + + switch (op->opc) { + case INDEX_op_mulu2_i32: + l =3D (uint64_t)(uint32_t)a * (uint32_t)b; + h =3D (int32_t)(l >> 32); + l =3D (int32_t)l; + break; + case INDEX_op_muls2_i32: + l =3D (int64_t)(int32_t)a * (int32_t)b; + h =3D l >> 32; + l =3D (int32_t)l; + break; + case INDEX_op_mulu2_i64: + mulu64(&l, &h, a, b); + break; + case INDEX_op_muls2_i64: + muls64(&l, &h, a, b); + break; + default: + g_assert_not_reached(); + } =20 rl =3D op->args[0]; rh =3D op->args[1]; - tcg_opt_gen_movi(ctx, op, rl, (int32_t)r); - tcg_opt_gen_movi(ctx, op2, rh, (int32_t)(r >> 32)); + + /* The proper opcode is supplied by tcg_opt_gen_mov. */ + op2 =3D tcg_op_insert_before(ctx->tcg, op, 0); + + tcg_opt_gen_movi(ctx, op, rl, l); + tcg_opt_gen_movi(ctx, op2, rh, h); return true; } return false; @@ -1912,8 +1937,9 @@ void tcg_optimize(TCGContext *s) CASE_OP_32_64(muluh): done =3D fold_multiply(&ctx, op); break; - case INDEX_op_mulu2_i32: - done =3D fold_mulu2_i32(&ctx, op); + CASE_OP_32_64(muls2): + CASE_OP_32_64(mulu2): + done =3D fold_multiply2(&ctx, op); break; CASE_OP_32_64(nand): done =3D fold_nand(&ctx, op); --=20 2.25.1