From nobody Mon Feb 9 16:12:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633623493; cv=none; d=zohomail.com; s=zohoarc; b=lU6bYwEm2lsHrPQGkBIir2kb6JQEKdVSRBFIYLJY7E4o4N1g12xqlKdqxDrsEmtwPVRp5S6eDNWLEeMcCddPVOmb8EeM61/9WN2pEEnhf6rO6C19yaFS3z6jTygk95Wplupv9Zndr70WLSKTvTZNjQBkKaNEYIxMGrYnkUPGwng= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633623493; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yEEZxUHWCMFJAaUbuJlVLcx9kbNHe4+tPDUcbMRvNgA=; b=neYuAoj1nSo88OZJS6jDaqn+XyZfnNteV2zD7x9RZF3wZJMTad/bM0rwfC9bVyyjqNaxjwIsPAySZ/K+FKjdaFNmXYGkVUwqV26e6Xagzau8WcBiHkEo4zyRd1s+U1pi72afvJbDvUF4H1q/vxXPCujHEDkiyXbL+fAC01kJaeI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1633623493322626.262228395519; Thu, 7 Oct 2021 09:18:13 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-29-H6BXwIgWMReiWE4C5YXdow-1; Thu, 07 Oct 2021 12:18:10 -0400 Received: by mail-wr1-f70.google.com with SMTP id o2-20020a5d4a82000000b00160c6b7622aso5037806wrq.12 for ; Thu, 07 Oct 2021 09:18:10 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id y23sm1025623wmj.42.2021.10.07.09.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 09:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633623492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yEEZxUHWCMFJAaUbuJlVLcx9kbNHe4+tPDUcbMRvNgA=; b=C2/0brevDUV6v6RqoUi8CIOQPUSlOobQZ52RQXj4FPySnhna1uuuffbn0zyGEO7PSBgM+7 llfKtK26v/lXrv8jMNxco6MvzdtK2h+yYc6AWBQjNZ5DAbqsw2jo3rd4bTkSW6Y34SSGhr 9E9WDknxycTb1cvgwlMVQCQvvOd3CNk= X-MC-Unique: H6BXwIgWMReiWE4C5YXdow-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yEEZxUHWCMFJAaUbuJlVLcx9kbNHe4+tPDUcbMRvNgA=; b=WAqSYv1NvO9xxQjn8Ugc5Eq3RE916Ne525HNKP7B6U1V2V1+oVzqeNGSB5yb+7+eea ItBKXbUFgovcDbF164/g/jMs34/7Q7Eh2USbb2ufS49FugF6eWGNlgrei1vWFVef2aJU KA8Deli72GkZU1UXfnHnndIBnoPw1M6Tx97w1R93NL/oDe9362n+ahuLuJ4jEToHgBWK od+/OxqQ6Bh47r+RNhc1j/6w6qp/HTHRjZDLIDuOm6LUakfxF2sQQAk4q68qJaGqv1yU /mEQCY4a2Nxoe2ZCZsgqbC5xTayj7u0Y60HcVNpr9/A4K93fgbKbFK4tqY1DZ4+G76bx o3qg== X-Gm-Message-State: AOAM531g4AH6BHOsMIPGjJy2Zh1x9y6XWjxR9Ci5OH3N9EXMUUnZYzfp ef9UB0YKRxNTKv6ulDJkP+2uHSkmQjRGTcaF/j4lhuAmV5fWUf4nkRnm6E1YT4j0fHhyrnpeMEx 7Ugmk970jDkcQOg== X-Received: by 2002:a1c:e90a:: with SMTP id q10mr5781387wmc.108.1633623489196; Thu, 07 Oct 2021 09:18:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyp5Icsi0NLMXs/baHrjAWHmxKv/JAM8Pc+VahgSSp1ZOQcJVEBNNgny0Hxow6Cf8o/4Ee8g== X-Received: by 2002:a1c:e90a:: with SMTP id q10mr5781363wmc.108.1633623489052; Thu, 07 Oct 2021 09:18:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , "Dr. David Alan Gilbert" , James Bottomley , Brijesh Singh , Sergio Lopez , Dov Murik , Connor Kuehl , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 11/23] target/i386/sev: sev_get_attestation_report use g_autofree Date: Thu, 7 Oct 2021 18:17:04 +0200 Message-Id: <20211007161716.453984-12-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211007161716.453984-1-philmd@redhat.com> References: <20211007161716.453984-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633623494541100003 From: "Dr. David Alan Gilbert" Removes a whole bunch of g_free's and a goto. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Connor Kuehl Reviewed-by: Brijesh Singh Message-Id: <20210603113017.34922-1-dgilbert@redhat.com> Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/sev.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index 9e3f2ec8dd3..3a30ba6d94a 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -521,8 +521,8 @@ sev_get_attestation_report(const char *mnonce, Error **= errp) struct kvm_sev_attestation_report input =3D {}; SevAttestationReport *report =3D NULL; SevGuestState *sev =3D sev_guest; - guchar *data; - guchar *buf; + g_autofree guchar *data =3D NULL; + g_autofree guchar *buf =3D NULL; gsize len; int err =3D 0, ret; =20 @@ -542,7 +542,6 @@ sev_get_attestation_report(const char *mnonce, Error **= errp) if (len !=3D sizeof(input.mnonce)) { error_setg(errp, "SEV: mnonce must be %zu bytes (got %" G_GSIZE_FO= RMAT ")", sizeof(input.mnonce), len); - g_free(buf); return NULL; } =20 @@ -554,7 +553,6 @@ sev_get_attestation_report(const char *mnonce, Error **= errp) error_setg(errp, "SEV: Failed to query the attestation report" " length ret=3D%d fw_err=3D%d (%s)", ret, err, fw_error_to_str(err)); - g_free(buf); return NULL; } } @@ -569,7 +567,7 @@ sev_get_attestation_report(const char *mnonce, Error **= errp) if (ret) { error_setg_errno(errp, errno, "SEV: Failed to get attestation repo= rt" " ret=3D%d fw_err=3D%d (%s)", ret, err, fw_error_to_str(er= r)); - goto e_free_data; + return NULL; } =20 report =3D g_new0(SevAttestationReport, 1); @@ -577,9 +575,6 @@ sev_get_attestation_report(const char *mnonce, Error **= errp) =20 trace_kvm_sev_attestation_report(mnonce, report->data); =20 -e_free_data: - g_free(data); - g_free(buf); return report; } =20 --=20 2.31.1