From nobody Mon Feb 9 11:06:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633538999; cv=none; d=zohomail.com; s=zohoarc; b=gerPvreVAkej6QJMbFncI2z8DAvRQP9RYVC/vsNbusW8PIKlKCVLE87FKSfeaEedDzIkxXldRahMLbt8rRkWzeCLW2M7v5bgEPR1kQnZ8GVRaRwyvs/vBz+4K773spktLn06kLCO9XJF627RVlgCDVOQVO9XK3ibGKft84J8H4A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633538999; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=d3SY8kt+0eUr16xiO6WRv5UUaNaOH2E74e2h2BTlxRY=; b=m2xC3ePXgfwlneU3Iv0JUowHpB/FpcckcyOW3D7/J3Y14m4C0yZlb5kYhmje5WYesW5Gzd7H0LD1NAU7KeGqxRibFF22n79SFIlxoWzlNcVDccWtX3F5NJ7PNA6fX9U7fCwed9ybQeVQWj9PCK5OImlQVH1yDX96jXeK4behcps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1633538999187237.53870707680232; Wed, 6 Oct 2021 09:49:59 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-542-qUXqGNsoMLK6Dv1pTDUzpA-1; Wed, 06 Oct 2021 12:49:56 -0400 Received: by mail-wr1-f71.google.com with SMTP id l6-20020adfa386000000b00160c4c1866eso2549830wrb.4 for ; Wed, 06 Oct 2021 09:49:56 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id k22sm21875271wrd.59.2021.10.06.09.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 09:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633538998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d3SY8kt+0eUr16xiO6WRv5UUaNaOH2E74e2h2BTlxRY=; b=RBuZldxpt2+H8VjqJj4puyGxU/7Es5yOPD4FU4N4GKJc//omfMXbpSMoN9JNhbbZAy5EKf 93d3/cviQK/G5JBPUc1VGSilgnNf1zbHJo1CLKC5egJkJkK5dG8msqWdveLySDGPXCQQ7Y khG4DQzTYg3394gsYVIYzq8OMq/TdT8= X-MC-Unique: qUXqGNsoMLK6Dv1pTDUzpA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d3SY8kt+0eUr16xiO6WRv5UUaNaOH2E74e2h2BTlxRY=; b=RZq8LdZzB51btROeVAzhfyV4fSdPHQnpaoEFIWR1htx9k0MiKSD1IUki2gPZjooQW5 aRk0UAEgwNAhrLvdANHrS/tgvGk8EIeGMXEGVX/SU0ZS1nu1y0979hQxhSy5oVh92ilT 5w22TGmIjLRjDqpYyl+Dtlb6Dw3qX16MY90Fb5JOaORIjn2yzdAYtJ0izuukZZ/SS50z 2J1j5gepilATtNozLPWWWy8zNlznEHeIx/ruHC6DJ9B6goM69QqW3SnwdIumOTcR2Q5Q v0a30M+VI+weZcek4qBueBN/AhN///rre629d7fvuMSHxeOfolb3/Jw77Y+LhBArutWg rkPQ== X-Gm-Message-State: AOAM530bIrq/4GO+wmussUJdKG7mPu8m/Lvwscc2M7GIyfRXpCpSPAw/ DQxn5Ola/njw08deF+Gfk/58onAEFM8YCm1x/Plxjo4KLrDqPkJfBtYsSBfKCzj0fWkyZGy1cvO rC9CDZf/RV/kXkA== X-Received: by 2002:a1c:158:: with SMTP id 85mr10873929wmb.187.1633538995573; Wed, 06 Oct 2021 09:49:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYXrWDPsnysXoTslg9CNi8EtDOIX+tHxKAHzrlnJ6h+EnzldDiVm9QAyPTkus4yIScFH6FPg== X-Received: by 2002:a1c:158:: with SMTP id 85mr10873911wmb.187.1633538995379; Wed, 06 Oct 2021 09:49:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Fam Zheng , Stefan Hajnoczi , Hanna Reitz , Kevin Wolf , qemu-block@nongnu.org, Max Reitz Subject: [PATCH 5/5] block/nvme: Fix memory leak from nvme_init_queue() Date: Wed, 6 Oct 2021 18:49:31 +0200 Message-Id: <20211006164931.172349-6-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211006164931.172349-1-philmd@redhat.com> References: <20211006164931.172349-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633539000139100001 nvme_create_queue_pair() allocates resources with qemu_vfio_dma_map(), but we never release them. Do it in nvme_free_queue() which is called from nvme_free_queue_pair(). Reported by valgrind: =3D=3D252858=3D=3D 520,192 bytes in 1 blocks are still reachable in loss = record 8,293 of 8,302 =3D=3D252858=3D=3D at 0x4846803: memalign (vg_replace_malloc.c:1265) =3D=3D252858=3D=3D by 0x484691F: posix_memalign (vg_replace_malloc.c:1= 429) =3D=3D252858=3D=3D by 0xB8AFE4: qemu_try_memalign (oslib-posix.c:210) =3D=3D252858=3D=3D by 0xA9E315: nvme_create_queue_pair (nvme.c:229) =3D=3D252858=3D=3D by 0xAA0125: nvme_init (nvme.c:799) =3D=3D252858=3D=3D by 0xAA081C: nvme_file_open (nvme.c:953) =3D=3D252858=3D=3D by 0xA23DDD: bdrv_open_driver (block.c:1550) =3D=3D252858=3D=3D by 0xA24806: bdrv_open_common (block.c:1827) =3D=3D252858=3D=3D by 0xA2889B: bdrv_open_inherit (block.c:3747) =3D=3D252858=3D=3D by 0xA28DE4: bdrv_open (block.c:3840) =3D=3D252858=3D=3D by 0x9E0F8E: bds_tree_init (blockdev.c:675) =3D=3D252858=3D=3D by 0x9E7C74: qmp_blockdev_add (blockdev.c:3551) Fixes: bdd6a90a9e5 ("block: Add VFIO based NVMe driver") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nvme.c b/block/nvme.c index 6e476f54b9f..903c8ffa060 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -185,6 +185,7 @@ static bool nvme_init_queue(BDRVNVMeState *s, NVMeQueue= *q, =20 static void nvme_free_queue(BDRVNVMeState *s, NVMeQueue *q) { + qemu_vfio_dma_unmap(s->vfio, q->queue); qemu_vfree(q->queue); } =20 --=20 2.31.1