From nobody Mon Feb 9 11:30:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633538985; cv=none; d=zohomail.com; s=zohoarc; b=Uaenw+vwd0yC1DXAKetFYeDztqkOgn3unDDIZXUBUXCEAL/l1KxbBiqbL9Vv+5mjIfzoP0CGJHxUOSNF6ld4VSZFCsAsYjDOVrePzrpLTigT1jPTdXYYB9s7LZM4+KYoeu+7h+hhuQFz8BOtAWAcwmzp8WRF6VyjXEGs0TAupg8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633538985; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=uyPtVC6HvIWx2rYECRqbct1GQVLi/CnHV8MyElho2m0=; b=RX61XX3JPp9kn9Ui83v+zb4VB3g2X2ErTcQeUwF+8ESyE+fPLU12d6M/x21/Ksh0tNy0E42SAllyaJbyHHTjfn4u7uW3L9nK+GBUePEjKyOqGXWop/v2p0gU918QtbYk9g9I34U33G5BYE3DUGnKy89PD1s07uNIsIz372muxvc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1633538985734671.3044657917577; Wed, 6 Oct 2021 09:49:45 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-DDN_EYoHNIO0jzCk4d1BUQ-1; Wed, 06 Oct 2021 12:49:43 -0400 Received: by mail-wr1-f69.google.com with SMTP id h11-20020adfa4cb000000b00160c791a550so2375463wrb.6 for ; Wed, 06 Oct 2021 09:49:43 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id p3sm5905016wmp.43.2021.10.06.09.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 09:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633538984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uyPtVC6HvIWx2rYECRqbct1GQVLi/CnHV8MyElho2m0=; b=EGGtptHMWR5bhnkmRq4nc0U8ajF4PeznpwZbaxxQCXA3DQBQ9u9IhFM+KDNRpgqVWhCYnU /G2hWRS00tYzePxDIGT8ngTj93SAVdyGEBf96O7zTXc7jqh/kyqZDFXgVo+I+WJD59XsGS rHtdq92RfSOvchgJxGx+JKbX0E8x3hM= X-MC-Unique: DDN_EYoHNIO0jzCk4d1BUQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uyPtVC6HvIWx2rYECRqbct1GQVLi/CnHV8MyElho2m0=; b=LJscuD6jPxFVrV7pWvcFUY+RQEjpM7Q8NBk0KFhArgfwXaKl9gLDQ+rNQ53zf7N7lu 0JI/r1yPSx47j/q2Cu5s4c/cEjMBId6rxRYocKX2C2W4bKJHaM/jB6t4outTKBfz3Oxn 8lWO8GIDki8XwTodgGFBF/bXO8W2SXvxl1Cod1D//2bhluzfQ8r75l/x0UugKBbNu8PG xFg6olsw3uZ0aJaK3g3sEb0VUDnzfPzGTPyV/kdrAaDtoKA2zF2S9WmD7qUUoWQ8Z4u6 wlH5007eRFyY0D26lSl3qvU6jDAxmbsclNj56E13r+5g9Voo9tUSG6KyGYFXE2HfgLqy pCng== X-Gm-Message-State: AOAM530p+Ry7/wdzynzKOHjrhav+Tr2iz0sYWg84zzTa01qz3u5vZvNv zN/IJWlS5ogTZ2mOgEwE6shdgqX35JdEk82ObBCgg08RT/EPJXgiXkzgSv9vRC37WHmwjXd7bda L/LKdjOjIGlRN5w== X-Received: by 2002:a7b:c314:: with SMTP id k20mr11104721wmj.50.1633538982133; Wed, 06 Oct 2021 09:49:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQsYH0xOdrDeZY6YPbibs3veeOy7/Xb5lWWrxX+u9T5Y8Dqs5Uf2WytMSPIYbHg1lGNOGlxg== X-Received: by 2002:a7b:c314:: with SMTP id k20mr11104708wmj.50.1633538982005; Wed, 06 Oct 2021 09:49:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Fam Zheng , Stefan Hajnoczi , Hanna Reitz , Kevin Wolf , qemu-block@nongnu.org, Max Reitz Subject: [PATCH 2/5] block/nvme: Display CQ/SQ pointer in nvme_free_queue_pair() Date: Wed, 6 Oct 2021 18:49:28 +0200 Message-Id: <20211006164931.172349-3-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211006164931.172349-1-philmd@redhat.com> References: <20211006164931.172349-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633538986104100001 For debugging purpose it is helpful to know the CQ/SQ pointers. We already have a trace event in nvme_free_queue_pair(), extend it to report these pointer addresses. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Hajnoczi --- block/nvme.c | 2 +- block/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index fefcc04abe6..0c94799a541 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -185,7 +185,7 @@ static bool nvme_init_queue(BDRVNVMeState *s, NVMeQueue= *q, =20 static void nvme_free_queue_pair(NVMeQueuePair *q) { - trace_nvme_free_queue_pair(q->index, q); + trace_nvme_free_queue_pair(q->index, q, &q->cq, &q->sq); if (q->completion_bh) { qemu_bh_delete(q->completion_bh); } diff --git a/block/trace-events b/block/trace-events index f2d0a9b62a7..491e765c611 100644 --- a/block/trace-events +++ b/block/trace-events @@ -157,7 +157,7 @@ nvme_dsm_done(void *s, int64_t offset, int64_t bytes, i= nt ret) "s %p offset 0x%" nvme_dma_map_flush(void *s) "s %p" nvme_free_req_queue_wait(void *s, unsigned q_index) "s %p q #%u" nvme_create_queue_pair(unsigned q_index, void *q, size_t size, void *aio_c= ontext, int fd) "index %u q %p size %zu aioctx %p fd %d" -nvme_free_queue_pair(unsigned q_index, void *q) "index %u q %p" +nvme_free_queue_pair(unsigned q_index, void *q, void *cq, void *sq) "index= %u q %p cq %p sq %p" nvme_cmd_map_qiov(void *s, void *cmd, void *req, void *qiov, int entries) = "s %p cmd %p req %p qiov %p entries %d" nvme_cmd_map_qiov_pages(void *s, int i, uint64_t page) "s %p page[%d] 0x%"= PRIx64 nvme_cmd_map_qiov_iov(void *s, int i, void *page, int pages) "s %p iov[%d]= %p pages %d" --=20 2.31.1