From nobody Mon Feb 9 06:34:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633460305; cv=none; d=zohomail.com; s=zohoarc; b=jzqyWLuqw+V+c7NBKcElJ9auxoCqhENnI0ZcGH9TcgDTikui/QnAjwIg6aX7IxlgOZ8SZOblDd9NHgkpx3ftwfBZRViCOAF5rjL3XVT05H3jTCBQskEElzkjy6Epo0JC09XdXpUhuiWiFSJGmV8sf1TBB8iX2gGnES3wH8sCsOM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633460305; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WZHNlTuTnklt4Xwql7kVo/EoV/I/Z/JZGj7l0lQfqyg=; b=BwOCyCh8roDJA0mAyJm7P8ngErjsHTMoqT1LPNvcv0bFnQKhnc5bRu9CDts+3/y24b+zoLsdLC8AKFlstIpbiF3F4ZY7y8WERmzt8mk7c25rZqU0NZrzi9TlHZBqEhHy0JAfz1ZbEvYwwJHo5TSmPjybzzG9r280RTk13qV/+SU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1633460305149465.559038557157; Tue, 5 Oct 2021 11:58:25 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-sgZaqnO6N0CI71KxhxBQ0g-1; Tue, 05 Oct 2021 14:58:23 -0400 Received: by mail-wr1-f70.google.com with SMTP id s18-20020adfbc12000000b00160b2d4d5ebso77632wrg.7 for ; Tue, 05 Oct 2021 11:58:22 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id h17sm3382759wrx.55.2021.10.05.11.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 11:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633460304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WZHNlTuTnklt4Xwql7kVo/EoV/I/Z/JZGj7l0lQfqyg=; b=bttIkjEFVpM0FVBIqJTggQLAJ1huAGG8duMhBxPYZ/IK1Hcct7Y9CzBOB/MYLWCJlAGhTg jRrlgQRhApujJ8A3T8NsrnxIfQVdupPx1ia0847aly2W7Rp8EJu0xsPhGIvKAeXTmkF0Vk gy0X19nWpLyba3/tnP/lN0G29ibhOuw= X-MC-Unique: sgZaqnO6N0CI71KxhxBQ0g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WZHNlTuTnklt4Xwql7kVo/EoV/I/Z/JZGj7l0lQfqyg=; b=a9hytjch2Ai8uVpRMATml/pWCMS7cYVfGv9oRmXmMqY8QXgo89A6+FMr0BC6uP/Mk1 sLQKsMpK22YGf+jTtLDVARXEdcFCH0ndTXnTVsCxXOHhvn/TPGGNwWoN+sivFEi8XlFs S7CzeHmp6ytcld1e6MIQHhrFGaP/Uqowxr2VAGidiS6KUZfSuDUNmlnHv3dNChC4WbDx DoLGWDSMfQ2YZ3Iri4s8e1jWrOFr+4DYDxUpcuXv/22wnB7bT+en+oIzMsqCSVrVq38L IRGyJM6ZGoy8wLwjsF0rEpqyhEahDkr+kkaaxB72rjFBUNV3G4RZ53+44FK+I1eFFW96 noRw== X-Gm-Message-State: AOAM530etyL2GA1rMY9l8icKc67WMdA97pyHRc2aW/W/S/wS9mRlAdR4 o3RmemWmvNbOKiSsr9kEOOIvCMsaGBUhyTcCWa7G05gx27mLb5N3Ck1+UlBt6ZizDsUg6ePaXg2 6Ew4dqJr4ugUSgQ== X-Received: by 2002:a1c:3b06:: with SMTP id i6mr5330290wma.172.1633460302028; Tue, 05 Oct 2021 11:58:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyV8xwrb2B23Lu4C67s97BE/vo8DdZ5JC2Yvzb8kRL4v6ceSDU53m5SUnUzUxbiru8jpeaWw== X-Received: by 2002:a1c:3b06:: with SMTP id i6mr5330274wma.172.1633460301883; Tue, 05 Oct 2021 11:58:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Dr . David Alan Gilbert" , Vladimir Sementsov-Ogievskiy , Kevin Wolf , Stefan Hajnoczi , "Michael S. Tsirkin" , Fam Zheng , Hanna Reitz , Paolo Bonzini , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 3/4] hw/scsi/scsi-generic: Use automatic AIO context lock Date: Tue, 5 Oct 2021 20:58:06 +0200 Message-Id: <20211005185807.4134557-4-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211005185807.4134557-1-philmd@redhat.com> References: <20211005185807.4134557-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633460305338100001 Use the automatic AIO context acquire/release in scsi_command_complete(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/scsi-generic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 665baf900e4..08ef623c030 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -114,9 +114,9 @@ static void scsi_command_complete(void *opaque, int ret) assert(r->req.aiocb !=3D NULL); r->req.aiocb =3D NULL; =20 - aio_context_acquire(blk_get_aio_context(s->conf.blk)); - scsi_command_complete_noio(r, ret); - aio_context_release(blk_get_aio_context(s->conf.blk)); + WITH_AIO_CONTEXT_ACQUIRE_GUARD(blk_get_aio_context(s->conf.blk)) { + scsi_command_complete_noio(r, ret); + } } =20 static int execute_command(BlockBackend *blk, --=20 2.31.1