From nobody Tue Feb 10 03:56:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283894; cv=none; d=zohomail.com; s=zohoarc; b=MSXM81K4i10yRyz82eCUqC+4chKQaFvbP3ahzv3SQruyrFHN1204WpqNv/6XeBHipeYk4UFR/l7knOZVYNozFq8ESCCaq2OwZwrUvJ/6sMChjh1VDRftB4TmlFL8H02cwxKjxG8W/bH4XMRrRZeeFKvYzGpZx6+hD+6c7eP3RIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283894; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=D0CPzyO8gzNn5EXtO6Agp6kUYxs4C9PP2ZtLig34eEJCwC6HaF6K0r21RFoWzrzQg0zbLsWkcTNLKTvdnuwvC3+At+8iQWA3LMI8FWg3InjG/iHiCyWhGwwV79Y7RqbSVQBllcboVoFblkv6wxr2heoVT5nZap7V3Kf4+demVek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1633283894863393.04409455517043; Sun, 3 Oct 2021 10:58:14 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id j10-20020a1c230a000000b0030d523b6693so6534606wmj.2 for ; Sun, 03 Oct 2021 10:58:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id p6sm7508691wrj.95.2021.10.03.10.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=heyTkqrEddrxX4nRPI+sZdGCq825lzySUhCayps+4/7gOV95EorAgm3BX44r1ZEbgJ b5YSZtnf6eU6ua0Afil7vRJXd9aa2MLAyI1Q4lKOYq9+nMlArMFX+kifBsV7aqMgBshY mMW/5qknzuXquUFCbtrsrefjiD+gyK8Bv/BjYVNWWo6Xd13fpnX6u4HhGFBEMbEhbeF5 2WqMAdPvOFCRbsV3aCcLE4heBwsm1+UwZjVcGlwmxB7Y+a9a6TobE1v+MhZ5j7Vl3Zlb jYqmBUQyIIaZcfi7TZ13OQNDSWTQ2AdQkEudj0kOJTgwJF6gLzMUv7FV7GvbHOdW5Ypm OtOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=MV7Acv2cmzVwMTY7pGy5XQytUmwftVCATnlX+8daGLpXHhrWhH5pzU6HXTc0F3Bs37 /+o2TSsYeWHNpa7PsquigRB3JdoI/NAFlVOG6FOFKHWGk8fHDjQMXAMh8vewp1K/Kx8V hGg4DtjhT7e8pl4OtTpdY6M4WaJm3uENDVOt8KjunlLBnFFg2PojUKygJRkCNLQoa7Tz vLER8imR+lxtQn/c4RYKMCFzZtd0Eos9O+ijCcmF6xej9F3VNh4GVmRVSwJFn3oEeyVi fb3g0VdwY3z38tdp2E8OmBLg7pmlc0hT0kZBZmx6lmR6tCGYb8Y+hNet1nKSgfBWaG/D MtlQ== X-Gm-Message-State: AOAM531BcDsHZYm4ZRagoW0tO99XbvyYuxz00SBkRQNCySFDt45/0AGo cfQzX6ukJSmdjnPF/TTgfMc= X-Google-Smtp-Source: ABdhPJxvwuCumsr8NNeeMw8ghCCwqo//WGAtcbT4Ag5BtmhFF217UgEdiv31yWOiYejoN+BwOKLF2w== X-Received: by 2002:a05:600c:3646:: with SMTP id y6mr14745336wmq.61.1633283893117; Sun, 03 Oct 2021 10:58:13 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i5() Date: Sun, 3 Oct 2021 19:57:41 +0200 Message-Id: <20211003175743.3738710-7-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283895733100001 We already use sextract32(), use extract32() for completeness instead of open-coding it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index e107cad57ee..3ef912da6b8 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -473,15 +473,12 @@ static void gen_msa_i8(DisasContext *ctx) static void gen_msa_i5(DisasContext *ctx) { #define MASK_MSA_I5(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - uint8_t df =3D (ctx->opcode >> 21) & 0x3; int8_t s5 =3D (int8_t) sextract32(ctx->opcode, 16, 5); - uint8_t u5 =3D (ctx->opcode >> 16) & 0x1f; - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; + uint8_t u5 =3D extract32(ctx->opcode, 16, 5); =20 - TCGv_i32 tdf =3D tcg_const_i32(df); - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); + TCGv_i32 tdf =3D tcg_const_i32(extract32(ctx->opcode, 21, 2)); + TCGv_i32 twd =3D tcg_const_i32(extract32(ctx->opcode, 11, 5)); + TCGv_i32 tws =3D tcg_const_i32(extract32(ctx->opcode, 6, 5)); TCGv_i32 timm =3D tcg_temp_new_i32(); tcg_gen_movi_i32(timm, u5); =20 --=20 2.31.1