From nobody Wed Feb 11 05:28:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283890; cv=none; d=zohomail.com; s=zohoarc; b=U5t+Z+Jok5dIlgpIqpoGZqdRhDVh8JcjOPMrOfLKGlCyDUob3Uo23R/8ITYm6y+8x3DGIARVK03X5Vq/6EnyYwdpHsCVQRLBW1REGaQHADmwKLG5+ShaWxSFdtxIKUXORmJe40RdoNenyDbuh6zHld1wsF4zof12LWz6F9zzUjs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=PVKuBSfqfZIunK1IS9SkSO10nae1yDOTpq6qk/aJm03aJa60zOqdlYSn9S+WGZ+5ljRU21YnQ4ZQ/qGHGxw4e36eMqwZQOcqVYtqbyDj6k21I2xKppl4bu0SCTwh2Ep/enGAi1v2dRKuY8P4poiskV3s0BEuRZg8igB7HVYra2U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 163328389017184.29553369283519; Sun, 3 Oct 2021 10:58:10 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id v17so26081123wrv.9 for ; Sun, 03 Oct 2021 10:58:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id k18sm11933999wrh.68.2021.10.03.10.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=SO06pSfq2CCDJxqQQ5sCvbpP5HSge2Hl36omH3M5jizdjqg/lkmu5dRqvP4G88TpYi sV3TVQBtJPp/PjoYH84URx0xRnPAsbbcXNufDpNPpc/IgZXn/I1j2sbKEPk++BG0Gl2N Slpe5MkFHxrNOnX5Apok/tqDyC6Lyfq8GYbd6dL6vpkpEFNxT3isv9WmzSRUZX5j71lg l+IGa3cB814m4DNoSTKgJ2cR+ZXniCNnYXgzFSbpB8U4bKeE4PIzX4dF0A0gMXq2EdfS 7VU4EsjwmrUQkUs1rN+W7ZNt1CEOWBZ+9PuygdD/utaGhcRCyRzQYxvWY2/AELIaQ0Zi bDmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=NRNlacvZYgG+hg0lNrJcIRYiVS1awX1hPHM5ENVvJUMm4wwih5xt88QwLKHRQeMirP bIjVIWTKh6rIc+GVb9jnu76J6sd2Y2A9d1rTR41DPKp9yH3PwJqndYfS/kUSAZUAgHUV A5iOXPwCNKoPKrIX3LCYBaPHrfuw2J0qFPTbqUfirt8upnLd0MjU84ZN2TKCj5Xhl0ca W/YxItmXd/ca3nteNXv9DNnb8b+ds0F9yXeUivsUiznsTgpr4mMaHLNaqCEMp4AxyRPr vfO5umB1JUuLgkSee4v7c5MLSDGR9UQQ2cXcZu1m0kII2bbCz7Wz3JHYo/lse3Wc17CZ Vf1g== X-Gm-Message-State: AOAM530ZVOfD6d8+0YDSMKbwFNlxRIdxnwScLnbqjR1hY4tDLxA/p77/ kw/41c62rz5ecYAiNZ9KYep24AtHulk= X-Google-Smtp-Source: ABdhPJxw+wMy5P1ZQfwNeBbQoeaFyc7lv9XiHtXRAEhGQoGlYoE1/+D9087VqBkRwa+Ma+7UJ9kz8w== X-Received: by 2002:a5d:6d8e:: with SMTP id l14mr9803986wrs.196.1633283888347; Sun, 03 Oct 2021 10:58:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 5/8] target/mips: Use tcg_constant_i32() in gen_msa_3rf() Date: Sun, 3 Oct 2021 19:57:40 +0200 Message-Id: <20211003175743.3738710-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283891454100001 Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index bbe9146513a..e107cad57ee 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1790,10 +1790,22 @@ static void gen_msa_3rf(DisasContext *ctx) TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); TCGv_i32 twt =3D tcg_const_i32(wt); - TCGv_i32 tdf =3D tcg_temp_new_i32(); + TCGv_i32 tdf; =20 /* adjust df value for floating-point instruction */ - tcg_gen_movi_i32(tdf, df + 2); + switch (MASK_MSA_3RF(ctx->opcode)) { + case OPC_MUL_Q_df: + case OPC_MADD_Q_df: + case OPC_MSUB_Q_df: + case OPC_MULR_Q_df: + case OPC_MADDR_Q_df: + case OPC_MSUBR_Q_df: + tdf =3D tcg_constant_i32(df + 1); + break; + default: + tdf =3D tcg_constant_i32(df + 2); + break; + } =20 switch (MASK_MSA_3RF(ctx->opcode)) { case OPC_FCAF_df: @@ -1836,7 +1848,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmadd_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MUL_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mul_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULT_df: @@ -1846,14 +1857,12 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmsub_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADD_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_madd_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCLE_df: gen_helper_msa_fcle_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUB_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msub_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULE_df: @@ -1896,7 +1905,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MULR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mulr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULT_df: @@ -1906,7 +1914,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_a_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADDR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_maddr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSLE_df: @@ -1916,7 +1923,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmax_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUBR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msubr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULE_df: @@ -1934,7 +1940,6 @@ static void gen_msa_3rf(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(twt); - tcg_temp_free_i32(tdf); } =20 static void gen_msa_2r(DisasContext *ctx) --=20 2.31.1