From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) client-ip=209.85.128.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283871; cv=none; d=zohomail.com; s=zohoarc; b=L14m2Hogf93GXfm1W7JzgtkRkwiO8iUKr7brYipnCVPJW5JAnShslocZgioX+xKts8q/FQyrhA4SuQvM5eJM4PaZoUMyYl0Hyf78FFMuAQpRmINpM0iJHDcaNgZtbnU4n0JQFJMM04Pj3uxwADdM9Hy/Go9fkIYP+YKYi2lH03E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283871; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=l/rdeP+spIdDQqIh+wJEBCFICiFkl7U81t6jAZeqrt0=; b=KMRlEGhFU0bXf71BjzdiGYoSr/Rysp8tCFl7m0k/wqufz1UI5m0bEeU7DR2AYVmcu+VKDazDdOjTiVAKhAXIsbf/yHAySSJcy8c+7NbmNTPVeE3EixMfkQPow8Pz9iYHVWKuqJBWA6CIvrgXWMa5xxhg2cpiS7NjhDVUE9PDX9s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.zohomail.com with SMTPS id 1633283871700882.5057176832281; Sun, 3 Oct 2021 10:57:51 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id g193-20020a1c20ca000000b0030d55f1d984so5813611wmg.3 for ; Sun, 03 Oct 2021 10:57:51 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id z12sm12230540wrv.31.2021.10.03.10.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l/rdeP+spIdDQqIh+wJEBCFICiFkl7U81t6jAZeqrt0=; b=IVyerHTT0VCQqvddoVXjqHnagM4Pd0Se+ZDSmQ3DyD9994+zWYKzdacsrXpbUI5Thk r2I2jrNCcYQ4yv+otw/sZBnw+9h8VIYj6xvIIiLQBTX49wqJ9AOSQxvzRTsp9Gbx/W10 JnM80W6B1xE2d7CrBMKjI7BkANanx52Q9RV78qn/EXViOiRff37VrBe1LYbK3dK28W49 FJo6VYr35oDMR6jEDUxYBwXQB1rq23fZnmjJ6SwxfEFKd9RFpuAH5rJTxEEBzvpAKz5L 9qihwGrBmQUZw9VDkJwJNBSaHDbUGB9eD/cWuD0gK727wW9I7l2Ibs4aMWCHiu1GHC88 L97A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=l/rdeP+spIdDQqIh+wJEBCFICiFkl7U81t6jAZeqrt0=; b=dYmVf8I30ipmi2FPIB7XFbpk9NwLaflRylgJf093EwRtP5UMXxyeIji/XctB6E6jtf Xic4Md3BRl2TyCwzgl+7K0qh4NEYjqmb40SKVV6jil3aNE1wsjd6sEpYabSh4MuIpax8 6kcKIW23RD+n8UIZn8Rwl0Tx0TDdcDYW07F/GR2E/AYYTJmAVLFA2d6Y920YPxlsbFN2 bPVkzGDnBTLFXwDk1WFui0bQeHM6VWsf7xneUe3jhZNrrrECGXLSgodLkuAwVV2kWEXa 1BK3EN1HfwWKyL9eKOaNOA9A0qe72iUIQRe7e6qZz1J6GoPmjkEVJMb1dqUJYuUC39uK J4AA== X-Gm-Message-State: AOAM530by2JpfV1g+shpaT0KxA6qwpCWoCRpMPSNZ1xQFQkWM+AhYa44 RvMHuCc1hd885xTuI2hxQwM= X-Google-Smtp-Source: ABdhPJwobKwnGAaDESJAVMFn9/4BTR2DuQBOsm48oMFxGb3fG0/WN2bolX2PfusiIJ0zienHkw/c9Q== X-Received: by 2002:a7b:c307:: with SMTP id k7mr12706920wmj.170.1633283869861; Sun, 03 Oct 2021 10:57:49 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 1/8] target/mips: Remove unused register from MSA 2R/2RF instruction format Date: Sun, 3 Oct 2021 19:57:36 +0200 Message-Id: <20211003175743.3738710-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283872616100001 Commits cbe50b9a8e7 ("target-mips: add MSA VEC/2R format instructions") and 3bdeb68866e ("target-mips: add MSA 2RF format instructions") added the MSA 2R/2RF instructions. However these instructions don't use any target vector register, so remove the unused TCG temporaries. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Reworded, removing the Fixes: tag. --- target/mips/tcg/msa_translate.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 8170a8df26b..ee6424126f7 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1942,13 +1942,11 @@ static void gen_msa_2r(DisasContext *ctx) { #define MASK_MSA_2R(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ (op & (0x7 << 18))) - uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; uint8_t df =3D (ctx->opcode >> 16) & 0x3; TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twt =3D tcg_const_i32(wt); TCGv_i32 tdf =3D tcg_const_i32(df); =20 switch (MASK_MSA_2R(ctx->opcode)) { @@ -2018,7 +2016,6 @@ static void gen_msa_2r(DisasContext *ctx) =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); tcg_temp_free_i32(tdf); } =20 @@ -2026,13 +2023,11 @@ static void gen_msa_2rf(DisasContext *ctx) { #define MASK_MSA_2RF(op) (MASK_MSA_MINOR(op) | (op & (0x1f << 21)) | \ (op & (0xf << 17))) - uint8_t wt =3D (ctx->opcode >> 16) & 0x1f; uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; uint8_t df =3D (ctx->opcode >> 16) & 0x1; TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 twt =3D tcg_const_i32(wt); /* adjust df value for floating-point instruction */ TCGv_i32 tdf =3D tcg_const_i32(df + 2); =20 @@ -2089,7 +2084,6 @@ static void gen_msa_2rf(DisasContext *ctx) =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(twt); tcg_temp_free_i32(tdf); } =20 --=20 2.31.1 From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283876; cv=none; d=zohomail.com; s=zohoarc; b=N7PsOvEQgD9SHXNvrWxfs6+3cz/Gep5Od33eUh0IQ0LBeLAz0+iPg1JwLw1WrEVop7wDMQF0zE6cwWivpuM3e4wdXieZlPNiuuy0DNa1dwUfmm38sFE0gXENHj4/NfVLYw24RcrrrIt42Lr/4qRon/K+kn4vp+MDMXcxokCA6qU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283876; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z+JF3MQH1rPB321dugVt3oY5emnBWy8JVQSDmjDElJM=; b=lV7WX3vycdFDuOgKMkTYtEVf6X9vmF1wqR/B7Y9ApE9hqCGXBjWbFcbAi20Mo3JSfacHJlRKjMP4EbODw0x1AaYCVlyeCVDAMwcr0fDa3MO1GBiH37p/QvrFIAf4nUriI99/UgYmEISHLWOsKxZH5JoBfK4wkJKZGFyzrfvAwSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1633283876140500.9290910787048; Sun, 3 Oct 2021 10:57:56 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id s21so26038798wra.7 for ; Sun, 03 Oct 2021 10:57:55 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id a17sm2473793wmj.48.2021.10.03.10.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z+JF3MQH1rPB321dugVt3oY5emnBWy8JVQSDmjDElJM=; b=gTN5zezdAI7zDYzDDp0bgpvnbz444LUBIKgTrp+evuNkz4THywspCnymhDPPp6ZGJV tc3+V4bU3nonQVxaqTc4DptUpFr5nz4b4RYHMz0PBjGslqY0HUaNDhb+OPfWzpZ6Ah4s pZojM4DHnTZdfX/1UlNKe8XwZudn0KZw/emWV2dzZXU+yujqGlNt4v5tQM58OJ1/Oisu t58py7SjpVyd2FKJSLCNMyZ1XiGuRiNqMCl4E9nKTGOvpCgtJHPCLuxImuA1FbGMpaeX Fdh50VG6nAXhBdfyAeUjS6H2b1/N4dZ/2+QKRoLbBfJi/i2mzT6lWggmtUDRa+b1zMv2 GbDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z+JF3MQH1rPB321dugVt3oY5emnBWy8JVQSDmjDElJM=; b=0gpBTjscFcepfydiNuHVRCcrr6SVPP+e0GX8dzIJNT/9xJ1A4EVTfQvB1H9tvRc4sP 5WycHrLG4/xibC3pl3/UOlUDmRz5WNPMwtE6rewwt0d772J5fMSSHcJbowXRHjN7dQdo Qumfpw2Bc27LbuEjC3I32E2fvCdLVPvO4hTi4iheikOOlyM/1ry51o9qW+/4pDNiWIZO UuJ+UjCW00AjeTgbzpXnUDoWg5Le2j5hp4/Fwyi29+katjpj4au0jJoPW9rVBGYGmJwk 6m8gJFU9iVbcCB+d/tdP2nustuAF22d+sJzNStmZfgDiWpSX3O6rVedO257Z4KO8x9Si n59w== X-Gm-Message-State: AOAM530eEznBw6bpehcyk0gfTddgIML1YqLBw8yfTomcsLGCemgTscje JEb/M4mn+y7+0icEY96/NjM= X-Google-Smtp-Source: ABdhPJxO63WBk+01WFgmdd2dJgUsM4toHKC6jF9Ywk6l0Pl7FwPm2TSbUvkbN1O2tRglg3CFuK0Eww== X-Received: by 2002:adf:a51e:: with SMTP id i30mr8985653wrb.206.1633283874316; Sun, 03 Oct 2021 10:57:54 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 2/8] target/mips: Use tcg_constant_i32() in gen_msa_elm_df() Date: Sun, 3 Oct 2021 19:57:37 +0200 Message-Id: <20211003175743.3738710-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283876792100001 Data Format is a 2-bit constant value. Avoid using a TCG temporary by moving it to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index ee6424126f7..20036ae4968 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1650,7 +1650,7 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_= t df, uint32_t n) TCGv_i32 tws =3D tcg_const_i32(ws); TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tn =3D tcg_const_i32(n); - TCGv_i32 tdf =3D tcg_const_i32(df); + TCGv_i32 tdf =3D tcg_constant_i32(df); =20 switch (MASK_MSA_ELM(ctx->opcode)) { case OPC_SLDI_df: @@ -1748,7 +1748,6 @@ static void gen_msa_elm_df(DisasContext *ctx, uint32_= t df, uint32_t n) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(tn); - tcg_temp_free_i32(tdf); } =20 static void gen_msa_elm(DisasContext *ctx) --=20 2.31.1 From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283880; cv=none; d=zohomail.com; s=zohoarc; b=k/h/KV5PWVAp6tbm99+kFuPYztdgx+lZEchd8Qq+aQqqaEd3SOgLjJyP3+Do2OSJ9LHMcDvKbuw9svMdHqXWJkiIs0cquqv6NvM3B/94xmp7drIbMP7D0ZEqp9Aby3kTcPgT2rpeYBHV+SnrkFfg9vjeytPJW19Kp4E6G9SbDgk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283880; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XxuEIy1tj7Fs3MbSgOfbbhEpKEgia9N0pym7Jb9gPes=; b=Q4WQFY0voWFavTvXD+/RmqJ1DpW69Yr2vRk1F0eaGIU4+JWDqyZsekgCpzP8doptq6td0byhtzLlWRGtKtUzeD+H3dAoyTmJhgy77k6sYuQZb5zVJhFCnct393v6U6C+0jNrd8xBU1aM88MQToMKQcwklF2vZrP1/KG8EzeTXFQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1633283880680227.26663563959335; Sun, 3 Oct 2021 10:58:00 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id z2so11534081wmc.3 for ; Sun, 03 Oct 2021 10:58:00 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id i27sm14364760wmb.40.2021.10.03.10.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XxuEIy1tj7Fs3MbSgOfbbhEpKEgia9N0pym7Jb9gPes=; b=I9wcFshD0ucYa2NhQzSylmOLO5zpFA6uYnC/roHPmREspjyv5rEzoGORGOmmB+ZcRX UFpit91wLeIcB8fFWoApSK8y18uCIoRtaeyhdivy0MF207mTuueq69syYB5XiAjYwUG0 UoBg57YpJR7FfvK71YNhQ8dTQlL5S4HOjIQSnWwqISkq8ldRg9BlT4VIrSgFqUP/u4cV pSLDSYijPPN4rdHNEA45dBr2D5nkiMKt8kvl2SLuhjs+t72KdAJcBvmmf1oQ7gh2KlLO QivTLYVkOhwt8RQ2NoxWCyaNXqE99wr4c+mJ1vkDaSOC5DgEG6jNKHeNSZv9hFPFq5Vt /wvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XxuEIy1tj7Fs3MbSgOfbbhEpKEgia9N0pym7Jb9gPes=; b=FFFPMgSHzWLRc6dxuP0Cb2ZI4T2Mgmb/ndRTjqk9KRW99DmVvtD1htgN/+YeJ99h6A Hw9yOEk/CgoaHRZPc0gQXcYKMalTWXHbuFdrpZ0oucS8H1aLJvdWNGqp+zrlQTUCcEr7 jPsJdOJEXBu3WX8JSokUe9Sht4BC+PwDicx2ar2FAd1WrIWoVFszCEr5NOhTJFH/eZcT FK7CUykaW72o8kSb1479mr2omDua+rpEwt3M8KyOPFhijJJnDsCnOJMGmB3UeMN3+jml P380BivSyvmEn+CZNqpGRclR7jy7Zke6fY+dd0s9SCH8naUquPnXq/7YmsGThk/BdYED UuxQ== X-Gm-Message-State: AOAM5324IdINQO+NII6NIGw3AU0YpEiolrK5FwnErW/2FqCRfIWU3xKc 2FArTOdAHC0XNP9F2Z3kbWJXcWNkosY= X-Google-Smtp-Source: ABdhPJxzQPm7/EkbskeBO4xIHgdQBj8QcWThbKZDRYLSKkw+47WVVi2FWbwPkPo1nSIq8I9H89CqvA== X-Received: by 2002:a05:600c:218:: with SMTP id 24mr2675927wmi.124.1633283878905; Sun, 03 Oct 2021 10:57:58 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 3/8] target/mips: Use tcg_constant_i32() in gen_msa_2rf() Date: Sun, 3 Oct 2021 19:57:38 +0200 Message-Id: <20211003175743.3738710-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283881190100001 Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 20036ae4968..5e8f80f2f23 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -2028,7 +2028,7 @@ static void gen_msa_2rf(DisasContext *ctx) TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); /* adjust df value for floating-point instruction */ - TCGv_i32 tdf =3D tcg_const_i32(df + 2); + TCGv_i32 tdf =3D tcg_constant_i32(df + 2); =20 switch (MASK_MSA_2RF(ctx->opcode)) { case OPC_FCLASS_df: @@ -2083,7 +2083,6 @@ static void gen_msa_2rf(DisasContext *ctx) =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(tdf); } =20 static void gen_msa_vec_v(DisasContext *ctx) --=20 2.31.1 From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283885; cv=none; d=zohomail.com; s=zohoarc; b=GvYR1hnMQzWbl7VTwwdpQsyVnMRVCQbRFe9vwfY3Pb7qMh4RvxoBb2Zn5KLxOB4/ItlMbQDd3TJM1uQHcR8iMn3nVS9Ws4MBkpkGQ0xoV0OH5h/Q5itGciHDVARtpLGGlod5xOBqTgkWK346V52f4x49IuYkDpCG60TtjVzl6iA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283885; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zN28LoK0n7WogBiC27sRyJmL1zm0wkkrymJdJPui0K8=; b=g2uSG2fFTvV02ZHlOq7oAQ18swQGrw4p8/dpkdrbyybRSOA7DqTiLBztBJb0nv41Med4kp0okCz+5HVnqtdsjqqaiJNIWsQaCwhQ0Aonp+UteVlqR7ZGWCmxi1HZe+Z+E7jeyAANyZg45OPCQjnOoh1GtdDPurKw1UADWUahbdE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1633283885374777.3681581646731; Sun, 3 Oct 2021 10:58:05 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id v17so26080826wrv.9 for ; Sun, 03 Oct 2021 10:58:04 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id m21sm13178388wmq.37.2021.10.03.10.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zN28LoK0n7WogBiC27sRyJmL1zm0wkkrymJdJPui0K8=; b=lCMszzerOt0W6S+GW2gZq3LQATrzK6Di1V5xx6XtZPvTrZugnQWJcDNG0oVBkCrnlo d+fMYGdsK71KUovubzmAwI1ff5m5nmAB/oMZ1VzvGrKmcE2RINZEoDQ3hRoPbypwSoVI 8RK45riqdxFwtL9rfN+qh1BT5gXPRS+S3HLIzFdtPiEaGmz0XpDoaw3ke0BS0F+qNc66 huGVDm5vfjY/FU1ixrWNnGGSTd88+wxyeJCwtkV54W3B/8QN2KBAvXn6GiYLwtwXrNOt Mc2SBpE3YYIhuA2GIHKfAzOKEKoe+6JOhKKn86IfBrp29v7lz1MbgNqSoxrnRh/n6exO GWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zN28LoK0n7WogBiC27sRyJmL1zm0wkkrymJdJPui0K8=; b=uSKdnwD4PI9LbzOJSJKpyU1Nz6cZTEAyW/PT1e7HnYliDVIZt/2jSMeoRUmukeDfTX XFlvZmfwdruBsuajAdVVXqdi9SAu1VkyiyRHpV98XcFoSfU2GGady0Qve+ptY3dLDG8l vrH1wkLpdVErHgUQn439Fzha2Woy8QMTX2ADbmqe65mqxcCAGA0YQGR1PPVvYVJSqSMP 1ebFl7A9IAGRIMmRjl4MR10vkG3bdqv+PN3FYOfvOfymZt7NnlcbAJS50yzXFrVIlImQ iEMlQ/9jUq09lHoDOH8bChMqjfzzSkjucYBkVPxSvVx0M5fycyfpijB9XTnlZImiMzSy gs3g== X-Gm-Message-State: AOAM532JIam2HhtpzYudOnnEfE54+1y9qKve4YLRjJODM8GvxFAxFG0A SiV6gWWpk1rgJAJprkL1FrI= X-Google-Smtp-Source: ABdhPJxeLyETKmygx3tyus9BOqZyK6kgYmlTDp38a3YFsAySC+L2AIGjyWg67CzaKfG+ex8fBxgrvg== X-Received: by 2002:a5d:4b11:: with SMTP id v17mr9700086wrq.313.1633283883566; Sun, 03 Oct 2021 10:58:03 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 4/8] target/mips: Use tcg_constant_i32() in gen_msa_2r() Date: Sun, 3 Oct 2021 19:57:39 +0200 Message-Id: <20211003175743.3738710-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283887339100001 Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 5e8f80f2f23..bbe9146513a 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1946,7 +1946,6 @@ static void gen_msa_2r(DisasContext *ctx) uint8_t df =3D (ctx->opcode >> 16) & 0x3; TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); - TCGv_i32 tdf =3D tcg_const_i32(df); =20 switch (MASK_MSA_2R(ctx->opcode)) { case OPC_FILL_df: @@ -1957,7 +1956,8 @@ static void gen_msa_2r(DisasContext *ctx) break; } #endif - gen_helper_msa_fill_df(cpu_env, tdf, twd, tws); /* trs */ + gen_helper_msa_fill_df(cpu_env, tcg_constant_i32(df), + twd, tws); /* trs */ break; case OPC_NLOC_df: switch (df) { @@ -2015,7 +2015,6 @@ static void gen_msa_2r(DisasContext *ctx) =20 tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(tdf); } =20 static void gen_msa_2rf(DisasContext *ctx) --=20 2.31.1 From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283890; cv=none; d=zohomail.com; s=zohoarc; b=U5t+Z+Jok5dIlgpIqpoGZqdRhDVh8JcjOPMrOfLKGlCyDUob3Uo23R/8ITYm6y+8x3DGIARVK03X5Vq/6EnyYwdpHsCVQRLBW1REGaQHADmwKLG5+ShaWxSFdtxIKUXORmJe40RdoNenyDbuh6zHld1wsF4zof12LWz6F9zzUjs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=PVKuBSfqfZIunK1IS9SkSO10nae1yDOTpq6qk/aJm03aJa60zOqdlYSn9S+WGZ+5ljRU21YnQ4ZQ/qGHGxw4e36eMqwZQOcqVYtqbyDj6k21I2xKppl4bu0SCTwh2Ep/enGAi1v2dRKuY8P4poiskV3s0BEuRZg8igB7HVYra2U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 163328389017184.29553369283519; Sun, 3 Oct 2021 10:58:10 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id v17so26081123wrv.9 for ; Sun, 03 Oct 2021 10:58:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id k18sm11933999wrh.68.2021.10.03.10.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=SO06pSfq2CCDJxqQQ5sCvbpP5HSge2Hl36omH3M5jizdjqg/lkmu5dRqvP4G88TpYi sV3TVQBtJPp/PjoYH84URx0xRnPAsbbcXNufDpNPpc/IgZXn/I1j2sbKEPk++BG0Gl2N Slpe5MkFHxrNOnX5Apok/tqDyC6Lyfq8GYbd6dL6vpkpEFNxT3isv9WmzSRUZX5j71lg l+IGa3cB814m4DNoSTKgJ2cR+ZXniCNnYXgzFSbpB8U4bKeE4PIzX4dF0A0gMXq2EdfS 7VU4EsjwmrUQkUs1rN+W7ZNt1CEOWBZ+9PuygdD/utaGhcRCyRzQYxvWY2/AELIaQ0Zi bDmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2n9LSU1b2DlEwFolRpa1OCTd/teoFX3/1wugs2VhoEo=; b=NRNlacvZYgG+hg0lNrJcIRYiVS1awX1hPHM5ENVvJUMm4wwih5xt88QwLKHRQeMirP bIjVIWTKh6rIc+GVb9jnu76J6sd2Y2A9d1rTR41DPKp9yH3PwJqndYfS/kUSAZUAgHUV A5iOXPwCNKoPKrIX3LCYBaPHrfuw2J0qFPTbqUfirt8upnLd0MjU84ZN2TKCj5Xhl0ca W/YxItmXd/ca3nteNXv9DNnb8b+ds0F9yXeUivsUiznsTgpr4mMaHLNaqCEMp4AxyRPr vfO5umB1JUuLgkSee4v7c5MLSDGR9UQQ2cXcZu1m0kII2bbCz7Wz3JHYo/lse3Wc17CZ Vf1g== X-Gm-Message-State: AOAM530ZVOfD6d8+0YDSMKbwFNlxRIdxnwScLnbqjR1hY4tDLxA/p77/ kw/41c62rz5ecYAiNZ9KYep24AtHulk= X-Google-Smtp-Source: ABdhPJxw+wMy5P1ZQfwNeBbQoeaFyc7lv9XiHtXRAEhGQoGlYoE1/+D9087VqBkRwa+Ma+7UJ9kz8w== X-Received: by 2002:a5d:6d8e:: with SMTP id l14mr9803986wrs.196.1633283888347; Sun, 03 Oct 2021 10:58:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 5/8] target/mips: Use tcg_constant_i32() in gen_msa_3rf() Date: Sun, 3 Oct 2021 19:57:40 +0200 Message-Id: <20211003175743.3738710-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283891454100001 Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index bbe9146513a..e107cad57ee 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -1790,10 +1790,22 @@ static void gen_msa_3rf(DisasContext *ctx) TCGv_i32 twd =3D tcg_const_i32(wd); TCGv_i32 tws =3D tcg_const_i32(ws); TCGv_i32 twt =3D tcg_const_i32(wt); - TCGv_i32 tdf =3D tcg_temp_new_i32(); + TCGv_i32 tdf; =20 /* adjust df value for floating-point instruction */ - tcg_gen_movi_i32(tdf, df + 2); + switch (MASK_MSA_3RF(ctx->opcode)) { + case OPC_MUL_Q_df: + case OPC_MADD_Q_df: + case OPC_MSUB_Q_df: + case OPC_MULR_Q_df: + case OPC_MADDR_Q_df: + case OPC_MSUBR_Q_df: + tdf =3D tcg_constant_i32(df + 1); + break; + default: + tdf =3D tcg_constant_i32(df + 2); + break; + } =20 switch (MASK_MSA_3RF(ctx->opcode)) { case OPC_FCAF_df: @@ -1836,7 +1848,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmadd_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MUL_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mul_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULT_df: @@ -1846,14 +1857,12 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmsub_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADD_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_madd_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCLE_df: gen_helper_msa_fcle_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUB_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msub_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FCULE_df: @@ -1896,7 +1905,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MULR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_mulr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULT_df: @@ -1906,7 +1914,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmin_a_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MADDR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_maddr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSLE_df: @@ -1916,7 +1923,6 @@ static void gen_msa_3rf(DisasContext *ctx) gen_helper_msa_fmax_df(cpu_env, tdf, twd, tws, twt); break; case OPC_MSUBR_Q_df: - tcg_gen_movi_i32(tdf, df + 1); gen_helper_msa_msubr_q_df(cpu_env, tdf, twd, tws, twt); break; case OPC_FSULE_df: @@ -1934,7 +1940,6 @@ static void gen_msa_3rf(DisasContext *ctx) tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); tcg_temp_free_i32(twt); - tcg_temp_free_i32(tdf); } =20 static void gen_msa_2r(DisasContext *ctx) --=20 2.31.1 From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283894; cv=none; d=zohomail.com; s=zohoarc; b=MSXM81K4i10yRyz82eCUqC+4chKQaFvbP3ahzv3SQruyrFHN1204WpqNv/6XeBHipeYk4UFR/l7knOZVYNozFq8ESCCaq2OwZwrUvJ/6sMChjh1VDRftB4TmlFL8H02cwxKjxG8W/bH4XMRrRZeeFKvYzGpZx6+hD+6c7eP3RIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283894; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=D0CPzyO8gzNn5EXtO6Agp6kUYxs4C9PP2ZtLig34eEJCwC6HaF6K0r21RFoWzrzQg0zbLsWkcTNLKTvdnuwvC3+At+8iQWA3LMI8FWg3InjG/iHiCyWhGwwV79Y7RqbSVQBllcboVoFblkv6wxr2heoVT5nZap7V3Kf4+demVek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1633283894863393.04409455517043; Sun, 3 Oct 2021 10:58:14 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id j10-20020a1c230a000000b0030d523b6693so6534606wmj.2 for ; Sun, 03 Oct 2021 10:58:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id p6sm7508691wrj.95.2021.10.03.10.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=heyTkqrEddrxX4nRPI+sZdGCq825lzySUhCayps+4/7gOV95EorAgm3BX44r1ZEbgJ b5YSZtnf6eU6ua0Afil7vRJXd9aa2MLAyI1Q4lKOYq9+nMlArMFX+kifBsV7aqMgBshY mMW/5qknzuXquUFCbtrsrefjiD+gyK8Bv/BjYVNWWo6Xd13fpnX6u4HhGFBEMbEhbeF5 2WqMAdPvOFCRbsV3aCcLE4heBwsm1+UwZjVcGlwmxB7Y+a9a6TobE1v+MhZ5j7Vl3Zlb jYqmBUQyIIaZcfi7TZ13OQNDSWTQ2AdQkEudj0kOJTgwJF6gLzMUv7FV7GvbHOdW5Ypm OtOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yhXr0CImE+7NvBwyuzdOAZs7t1J2dHvRPqJwA4cIlkQ=; b=MV7Acv2cmzVwMTY7pGy5XQytUmwftVCATnlX+8daGLpXHhrWhH5pzU6HXTc0F3Bs37 /+o2TSsYeWHNpa7PsquigRB3JdoI/NAFlVOG6FOFKHWGk8fHDjQMXAMh8vewp1K/Kx8V hGg4DtjhT7e8pl4OtTpdY6M4WaJm3uENDVOt8KjunlLBnFFg2PojUKygJRkCNLQoa7Tz vLER8imR+lxtQn/c4RYKMCFzZtd0Eos9O+ijCcmF6xej9F3VNh4GVmRVSwJFn3oEeyVi fb3g0VdwY3z38tdp2E8OmBLg7pmlc0hT0kZBZmx6lmR6tCGYb8Y+hNet1nKSgfBWaG/D MtlQ== X-Gm-Message-State: AOAM531BcDsHZYm4ZRagoW0tO99XbvyYuxz00SBkRQNCySFDt45/0AGo cfQzX6ukJSmdjnPF/TTgfMc= X-Google-Smtp-Source: ABdhPJxvwuCumsr8NNeeMw8ghCCwqo//WGAtcbT4Ag5BtmhFF217UgEdiv31yWOiYejoN+BwOKLF2w== X-Received: by 2002:a05:600c:3646:: with SMTP id y6mr14745336wmq.61.1633283893117; Sun, 03 Oct 2021 10:58:13 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 6/8] target/mips: Use explicit extract32() calls in gen_msa_i5() Date: Sun, 3 Oct 2021 19:57:41 +0200 Message-Id: <20211003175743.3738710-7-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283895733100001 We already use sextract32(), use extract32() for completeness instead of open-coding it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index e107cad57ee..3ef912da6b8 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -473,15 +473,12 @@ static void gen_msa_i8(DisasContext *ctx) static void gen_msa_i5(DisasContext *ctx) { #define MASK_MSA_I5(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - uint8_t df =3D (ctx->opcode >> 21) & 0x3; int8_t s5 =3D (int8_t) sextract32(ctx->opcode, 16, 5); - uint8_t u5 =3D (ctx->opcode >> 16) & 0x1f; - uint8_t ws =3D (ctx->opcode >> 11) & 0x1f; - uint8_t wd =3D (ctx->opcode >> 6) & 0x1f; + uint8_t u5 =3D extract32(ctx->opcode, 16, 5); =20 - TCGv_i32 tdf =3D tcg_const_i32(df); - TCGv_i32 twd =3D tcg_const_i32(wd); - TCGv_i32 tws =3D tcg_const_i32(ws); + TCGv_i32 tdf =3D tcg_const_i32(extract32(ctx->opcode, 21, 2)); + TCGv_i32 twd =3D tcg_const_i32(extract32(ctx->opcode, 11, 5)); + TCGv_i32 tws =3D tcg_const_i32(extract32(ctx->opcode, 6, 5)); TCGv_i32 timm =3D tcg_temp_new_i32(); tcg_gen_movi_i32(timm, u5); =20 --=20 2.31.1 From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283899; cv=none; d=zohomail.com; s=zohoarc; b=gLfG0QBB+o6Xkq8qOF/q9fY7VIRoG2aVPJZUR3hf+FOCR6cYSJfL33gxn0aK2zxYM2CKp8BF8016U6QTIvNklgFutyzfYj/aVT/CU6xDs/p9Ys7ksjP8Rk72HdiOaR9ihF1XdE/yv/6v6KAtprotL2rzxBv5t5dC3GaNVzTww0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283899; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6XihHO8hR/2w0fkY9TAy59BcD7FH2rXSgl3e1w0F2cc=; b=mlrvvjMuJW4yFTU/zHyqovFOHGJsWU+FDe1nKfT7LiF1EeCx5Nn3i6hGL9cnTnm7TPyxITELmaim09S5PpL1ntSBUsoIiJk8VxDIYO2q9r6y8/lK8/YULLah0PK6sqME8buERMxSZ+Ng7ETWVIrLNNTzepV3zdH+dC1+JyEIPz8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1633283899550755.3245950877147; Sun, 3 Oct 2021 10:58:19 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id m22so20680098wrb.0 for ; Sun, 03 Oct 2021 10:58:18 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id d16sm13728474wmb.2.2021.10.03.10.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6XihHO8hR/2w0fkY9TAy59BcD7FH2rXSgl3e1w0F2cc=; b=pPcfGcI0CMfJK4Nio3gEDH/ajJlkGFl1mKbZRf58tfPzWJZUOvxThTfu8AMnVdUXx+ y9f7yLyVxx9R8Dtb42wk6DE7LVN668hzA4dOoYy4ych+fC8JVgKUvwdouos13maCUeG3 y4jC2/yoyy49API3+DP/J/ryvilLiTWpRW0kqi5S3zOkCmY3iz6IJaPVXcerADBrsDhu S+Fn89pBoqZJ/ezH8yCnE3Or5gVcbNi4cCc2FRkMQZ0PbbaMYHp+XjzXMsGnrrp8sV0d /wPFJzk5PUWCprice0b3Cy8SU8dcZDUs6wPzcSxJTH6Giufpd5NgQaVOFgsnmT7+h58s k2zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=6XihHO8hR/2w0fkY9TAy59BcD7FH2rXSgl3e1w0F2cc=; b=7LsPg+uGHZBgddBXMTszbet//MNk5u0+nIDvDdlJiQSm8+Gn9nkb+hyz0oaQOnSoGB N+j/rOH1M3H0Z9xLLJBXaJJdXeHd9O3FAiz8kc1YjZwKbCnok1d1nSAk4GnGRzjKA40y oOMIqIX1coYxuMCGTNbIfIoJ/W7FTohvYrjk84oZmcqb8jP2Fgsjf3yQ22UtEw4+39gJ YoPOxUPw3fP1yxlSjJh43vyFDkGw2iLRCTwGTcRNj5M9lFsD6oOUYO0GUMTDfBYs/fK0 NKI6GCLFaEz2d321LlO6xtOR0Xp2yFj1qU4y1grMcTjPZvm7xItX3Stc4fuO4ZKaqDGy DMlA== X-Gm-Message-State: AOAM530DnO7NbG6YWwB4tpdxZ6bUZkubHqZAjyVLP4aygAMETdvCe2xv iM0RU3vQ8lNKcZPv5vfEnAs= X-Google-Smtp-Source: ABdhPJzgeuLoh7FsFtCvwTOsYvs5kfncYBjNQWhfTmPdGHzhXyviQFsXClgDCyALV4XepZm1Jbm8Mg== X-Received: by 2002:adf:a505:: with SMTP id i5mr8134053wrb.38.1633283897737; Sun, 03 Oct 2021 10:58:17 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 7/8] target/mips: Use tcg_constant_i32() in gen_msa_i5() Date: Sun, 3 Oct 2021 19:57:42 +0200 Message-Id: <20211003175743.3738710-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283899806100001 Avoid using a TCG temporary by moving Data Format to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/msa_translate.c | 40 ++++++++++++++++++++------------- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 3ef912da6b8..3ede2f643c0 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -473,14 +473,32 @@ static void gen_msa_i8(DisasContext *ctx) static void gen_msa_i5(DisasContext *ctx) { #define MASK_MSA_I5(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) - int8_t s5 =3D (int8_t) sextract32(ctx->opcode, 16, 5); - uint8_t u5 =3D extract32(ctx->opcode, 16, 5); - TCGv_i32 tdf =3D tcg_const_i32(extract32(ctx->opcode, 21, 2)); TCGv_i32 twd =3D tcg_const_i32(extract32(ctx->opcode, 11, 5)); TCGv_i32 tws =3D tcg_const_i32(extract32(ctx->opcode, 6, 5)); - TCGv_i32 timm =3D tcg_temp_new_i32(); - tcg_gen_movi_i32(timm, u5); + TCGv_i32 timm; + + switch (MASK_MSA_I5(ctx->opcode)) { + case OPC_ADDVI_df: + case OPC_MAXI_U_df: + case OPC_MINI_U_df: + case OPC_CLTI_U_df: + case OPC_CLEI_U_df: + timm =3D tcg_constant_i32(extract32(ctx->opcode, 16, 5)); + break; + case OPC_MAXI_S_df: + case OPC_MINI_S_df: + case OPC_CEQI_df: + case OPC_CLTI_S_df: + case OPC_CLEI_S_df: + timm =3D tcg_constant_i32(sextract32(ctx->opcode, 16, 5)); + break; + case OPC_LDI_df: + timm =3D tcg_constant_i32(sextract32(ctx->opcode, 11, 10)); + break; + default: + break; + } =20 switch (MASK_MSA_I5(ctx->opcode)) { case OPC_ADDVI_df: @@ -490,43 +508,34 @@ static void gen_msa_i5(DisasContext *ctx) gen_helper_msa_subvi_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MAXI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_maxi_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MAXI_U_df: gen_helper_msa_maxi_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MINI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_mini_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_MINI_U_df: gen_helper_msa_mini_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CEQI_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_ceqi_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLTI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_clti_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLTI_U_df: gen_helper_msa_clti_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLEI_S_df: - tcg_gen_movi_i32(timm, s5); gen_helper_msa_clei_s_df(cpu_env, tdf, twd, tws, timm); break; case OPC_CLEI_U_df: gen_helper_msa_clei_u_df(cpu_env, tdf, twd, tws, timm); break; case OPC_LDI_df: - { - int32_t s10 =3D sextract32(ctx->opcode, 11, 10); - tcg_gen_movi_i32(timm, s10); - gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); - } + gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); break; default: MIPS_INVAL("MSA instruction"); @@ -537,7 +546,6 @@ static void gen_msa_i5(DisasContext *ctx) tcg_temp_free_i32(tdf); tcg_temp_free_i32(twd); tcg_temp_free_i32(tws); - tcg_temp_free_i32(timm); } =20 static void gen_msa_bit(DisasContext *ctx) --=20 2.31.1 From nobody Mon Feb 9 09:46:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633283904; cv=none; d=zohomail.com; s=zohoarc; b=P+8JONx501j6it6aVHqV6RCi8HNB/+mL7BQu+K2rs8zL5fQD9fECQREN/3bHEtOCHH3hOjIftjP/JBciro+k1ZeYJc+y5Kc1Y5gi7fX0bTuBslW8HTBn2lPRthwOsAbezSOxdKi9nVxU9R+sbr7mquA/tZzrrGfDhm4Y9NmiKJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633283904; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aQLZEwzsOLFau3mXxxxHhtsLM0I/M/Yo3h72hp1JP8M=; b=W1alZdLwM0HslREwnIfCc4eOYuSnL5bc+DVHK19gOu//yqDAUxYRN4x+YwVzibDJyS5tsrxTHLcj5thxvPYiejMdPky000tmQgYcclZz9T7DyZD9aWogZzB/FZPIcy12XTb5ikFhqY2fongiTujOTOrv3Lo6D6bOHttcglyTcHA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 1633283904124223.13348422350805; Sun, 3 Oct 2021 10:58:24 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id g198-20020a1c20cf000000b0030d60cd7fd6so2731506wmg.0 for ; Sun, 03 Oct 2021 10:58:23 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id k22sm12270084wrd.59.2021.10.03.10.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 10:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aQLZEwzsOLFau3mXxxxHhtsLM0I/M/Yo3h72hp1JP8M=; b=UU0+JnFdSQjw8kvnUGaCnO6XR5oHf5mwkljQMjLrE3t3J4x0qHeX5LVour76s9qSBe NKTZQK5nkji3xhf/JP8VvgjxUzYac2WkUw2KNNympHy9nmP2oCNB/dmhrMAcXRsAQ4By iM8IZmhVlHmqf/FMMNKw9qRbi3yB22JownyjYax+cg7ZInmfh3NCZZ4msuww3EoRKXbr cf+xIEtnPUhG3YZWR83VGgpMLwV2/jVPV2/pu2KCXdrBWBp9cLxNczdJ3j/TZ3HKw6Ek tDsaouaH/r2Js/eEhENFajSvgoFN0s8HIuGk27z4ZNcRYCN550xT7ZPd0yui++2dfSzq 2cug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=aQLZEwzsOLFau3mXxxxHhtsLM0I/M/Yo3h72hp1JP8M=; b=mskQFlUhc5K47x0xbfJeEikvJEvuuPEDg4a5CdoAqU1ouwBDwMlCOnNv6j0DFev/2+ 1Xbg8tgH4IuE5N4IOBSUEuvUMR98V9P3zNrqRXvYwyRZQ03MW8Vo3VoPnlI2/QUdKjL1 xYRIqX938zetldmmui/UgHv6N2pROT0c4Q2FMkfkA7on4bNSzYxI1QlhFkIerdMU0bNO 5VHQ5wWgwyNbMue8ctj1DxjSmO0Q9T/JE2QboCuEfrrubHZjHALj9iYBYjFOxOWuAwyN i+GlPfmHG+eQWPgZD6dLdGMfbdwH/Bctf40UqrcGPunt3bSSDtmp0PrabM1nHDh746c7 M5ig== X-Gm-Message-State: AOAM532KdY6CXNPLAmcK7jyoQsPqYz1OPvv6xyX07tdlzUuuUBITDyIW qpsU/5dWS5gai5lcZhhj4aA= X-Google-Smtp-Source: ABdhPJy2WQreFL1akAGlWFOtSFk/0pGIAqXpCZ4FHAbPuXz5luoVea4YZQHCqNUZs8zLlz9g3ES5CQ== X-Received: by 2002:a1c:2c3:: with SMTP id 186mr2477980wmc.183.1633283902349; Sun, 03 Oct 2021 10:58:22 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Richard Henderson , Aleksandar Rikalo Subject: [PATCH 8/8] target/mips: Use tcg_constant_tl() in gen_compute_compact_branch() Date: Sun, 3 Oct 2021 19:57:43 +0200 Message-Id: <20211003175743.3738710-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003175743.3738710-1-f4bug@amsat.org> References: <20211003175743.3738710-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633283906006100001 The offset is constant and read-only: move it to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 148afec9dc0..d4e0fbd35be 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -11866,13 +11866,11 @@ static void gen_compute_compact_branch(DisasConte= xt *ctx, uint32_t opc, } else { /* OPC_JIC, OPC_JIALC */ TCGv tbase =3D tcg_temp_new(); - TCGv toffset =3D tcg_temp_new(); + TCGv toffset =3D tcg_constant_tl(offset); =20 gen_load_gpr(tbase, rt); - tcg_gen_movi_tl(toffset, offset); gen_op_addr_add(ctx, btarget, tbase, toffset); tcg_temp_free(tbase); - tcg_temp_free(toffset); } break; default: --=20 2.31.1