From nobody Tue Feb 10 11:55:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633271950; cv=none; d=zohomail.com; s=zohoarc; b=Mb7/TyBaRhPn+4kwVssK0AyYMGlMbxLNl7uln7po6P4Xv80X0Dq471tS3ilWVfF7To2BCDx6rq3bkSx0A5gyns41zEAY1BD4UCUuWGYUPgVFSIrnHiTBi4efyx0kRFDhK7olXKxB+aUiIxQdsXU3IQx14Fx18J47E0wqcMR77ds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633271950; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VkTxOuPntTexHAld4+mJv1hOaBW5vbrtx3WxK0zn1+8=; b=mnqn4oWKq4IF/fqr+1pwm/2AHuZZjzUn2E4UaUwitJl9RT6uEW48w9cS/j5gP5gDnF6FBjPtDZAuJe/eGC44To6oQWiUa6FcMfUdPx1l40ONFMKxAYh76LfZdZeAMTIxzn8amNAYuIJthf8bQLGphm+BKdVowt2Gx1QgZ1sOiNU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1633271950032648.5793447166199; Sun, 3 Oct 2021 07:39:10 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id v127so11226921wme.5 for ; Sun, 03 Oct 2021 07:39:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id o7sm13702769wro.45.2021.10.03.07.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 07:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VkTxOuPntTexHAld4+mJv1hOaBW5vbrtx3WxK0zn1+8=; b=bKslWLm5yK61qTCsTGqA+YoeekKU8eZYFj3Z5ieA3WHHre7PiQAvGRjFPTucPr0FkW peGNtMCugGUrFXzXNZx3BJ7nGtyTxVwKrYyDoIRwKxfP62L1ozM6HBPB1x7p3e0y/j7S 9RFnh/qzoUp3ngvCai/yPr7K/TQNplmI1SbSJGfwuFgmfU1bpw0AEK9LzmAsGxrD0dg/ ZMAwB490rcGKKnuA3C6P64zr7oVMyDxEUzQIGqTJLH5ysmb8VWBln2yTPnzDRLpF5QZc K0ERLY5ucg5FVsLuQgePFHlzuXkNig49b35kRfLw2ACgYhIXWHVi0JrMYhkBVcuGRi5r 77/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VkTxOuPntTexHAld4+mJv1hOaBW5vbrtx3WxK0zn1+8=; b=LuD7LH7N+yXgQYijnmtYjwxHTTz8b1F1Ass8Hz0xo2Nibu3g5X+vp0ZUxR6t1Kahs4 LrrmrizZhO5Vwvrea6t96jgfyTf4mcqBQrIztxW9+nB7+66ajILX27qUTVaV66D0/Yiq DKfVDWbod28mBvzlfpuc+gaqMcsSOvQlAe7JXyFWu0j03WMMieaqtfXcAVyR4hKDiEMz 0eEHS3N3Z8xgH+zMhIzz29nl8JWdt9dUMR1QjXxqdgCnip9Les6xr6a9vvTHliDPAuQw g0JHO0P/tUj+DSFw6udKZ6z01DMOa3PxVzAfguUwaYibTCF+JwtCS6D20RZaZt4BWwIP ZdWg== X-Gm-Message-State: AOAM533/3puceLEuHLVSMbnRTTpZmg+0hVuzmHWFSqB8Nforhew0PDlO rebXXAPf1iCnvxJkPOaykPnME4YcLDA= X-Google-Smtp-Source: ABdhPJyUrV+EEEgnBNqRzJOyiR7EI5tXQbYrFkzVHMuCPqxZ3ncHgSSuZGcCAyug5Snwxx93jfzVgA== X-Received: by 2002:a1c:2904:: with SMTP id p4mr13895934wmp.49.1633271948153; Sun, 03 Oct 2021 07:39:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] target/arm: Use tcg_constant_i32() in op_smlad() Date: Sun, 3 Oct 2021 16:38:59 +0200 Message-Id: <20211003143901.3681356-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003143901.3681356-1-f4bug@amsat.org> References: <20211003143901.3681356-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633271951062100001 Avoid using a TCG temporary for a read-only constant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index f7086c66a59..b41e0f50dfe 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7873,10 +7873,9 @@ static bool op_smlad(DisasContext *s, arg_rrrr *a, b= ool m_swap, bool sub) t3 =3D tcg_temp_new_i32(); tcg_gen_sari_i32(t3, t1, 31); qf =3D load_cpu_field(QF); - one =3D tcg_const_i32(1); + one =3D tcg_constant_i32(1); tcg_gen_movcond_i32(TCG_COND_NE, qf, t2, t3, one, qf); store_cpu_field(qf, QF); - tcg_temp_free_i32(one); tcg_temp_free_i32(t3); tcg_temp_free_i32(t2); } --=20 2.31.1