From nobody Mon Feb 9 05:55:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633271365; cv=none; d=zohomail.com; s=zohoarc; b=k1nTwOAGN3116k1FT6WfFl/iJPuA6zAIeJFCB+QiES6oX2zP6wC21a5NiRI8WcE6XJyiz++fagutdiP6k+6oTuvaHy1OcWX4nee18sujVlxmNA2Z3PsUXJOKvkhx0teMoIc53ebUpUWdNvB3K3Ad3DVIi41nJFHWZk1cKVXYyUc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633271365; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=tf1HffZsun/ljYlvTFfDvOCkmO375AxDos8nRbn/Wkw=; b=NRxsNWp2m8vOTWxUq5ph5WX3VPguuBtHPQrIAZf3Ka0IkJb+ba5BX+Hpn/CkwAClLpnCv7K0gP/YsvpAs0IH2kAa8vnUJoPbt53+jM3BXtUjS7pRNK6+M9zTypURskZOqla0cYaIplDDl+u3x9ElR5JNc+Wy8A7FHO5jjW33o1w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1633271365905497.16553825808535; Sun, 3 Oct 2021 07:29:25 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id u18so25343247wrg.5 for ; Sun, 03 Oct 2021 07:29:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id p10sm11822158wmq.40.2021.10.03.07.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 07:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tf1HffZsun/ljYlvTFfDvOCkmO375AxDos8nRbn/Wkw=; b=UzRa+rl6AdAswQDUVGFxUsrsIF5u77R6GzN/DHcUeos/vByLv1nHbYsBhvSl0ycdiY pJg4XxNqxsn2MDmfYJ0CFb4ITxMthPFXaLoDD2gRHRhfQNddiZcZ5quOX9JmAPaHiCJ+ WgDdA6NkGajJgfTvlWXfARauIQFCAQsoDCmV9AdxxYXvuz+vYKOpYlQLfDXgaJZIk5c4 +gXq69de+HPhVVUry2UhsWJcKkjskJe6JlFWAYDm1A1m7s1lrUWWEb6DLos5qfiga6nc XkO4duNuU4rJnqWlKKpJKYfh+sb6xFeflS+giojosjDQ7n0awedLkWroZgWc0nM0kiqZ 0p+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=tf1HffZsun/ljYlvTFfDvOCkmO375AxDos8nRbn/Wkw=; b=CmrWodxlQwruXI6bZqbmsTiINiqlNRQprDQKL9lGMfHbbpRw8zeTpGM6mWiVsW0qbc Tekg1T7S59vrP9vwpaPm1y7wZaJ3dvfacAsBEljey6JXoJ9ie/cK3YzkIpLraqqzUk9p oJtgyYN4EmBvxxdbO6/3BDKoVcCEHrY9I/f6KII8sO0OImTUe3sxCiuHDWWxo43H3NKW a9QlBkYpMV50+wwPno1zy7YQwkiAp0NwcvrT6NOSJ5qbwUL86FLjrFrVSjyYPlgNy8nd vQ+x63eSpRlz99ZsitiTncz9vBkf7LiF5lFMQvIgrjbhHSaqM46jRL6S3tuOFss22aMM NFsg== X-Gm-Message-State: AOAM532heFQmpGjT6U6/NgkaEpJNpzfhmVnI+qBbXDm17rsDV1FWcZs9 vk5FmZ3cCapqE3tALLGotUs= X-Google-Smtp-Source: ABdhPJxnk7uj5uq7NK+ids9rTyUqEv4Jz/1KqyEVv9lScFbBXME2T/IdaExIa0nJOciJY3ic0CKdgA== X-Received: by 2002:adf:dd01:: with SMTP id a1mr8716524wrm.132.1633271364130; Sun, 03 Oct 2021 07:29:24 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Cornelia Huck , David Hildenbrand , qemu-s390x@nongnu.org, Richard Henderson , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] target/s390x: Optimize save_link_info() using extract() TCG opcode Date: Sun, 3 Oct 2021 16:29:22 +0200 Message-Id: <20211003142922.3678039-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633271367925100001 When running the scripts/coccinelle/tcg_gen_extract.cocci Coccinelle semantic patch on target/s390x/, we get: [DBG] candidate at target/s390x/tcg/translate.c:1560 Manually inspect and replace combinations of (shri, andi) opcodes by the extract opcode. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/s390x/tcg/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index f284870cd2f..bfd805920c6 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -1557,8 +1557,7 @@ static void save_link_info(DisasContext *s, DisasOps = *o) tcg_gen_andi_i64(o->out, o->out, 0xffffffff00000000ull); tcg_gen_ori_i64(o->out, o->out, ((s->ilen / 2) << 30) | s->pc_tmp); t =3D tcg_temp_new_i64(); - tcg_gen_shri_i64(t, psw_mask, 16); - tcg_gen_andi_i64(t, t, 0x0f000000); + tcg_gen_extract_i64(t, psw_mask, 40, 4); tcg_gen_or_i64(o->out, o->out, t); tcg_gen_extu_i32_i64(t, cc_op); tcg_gen_shli_i64(t, t, 28); --=20 2.31.1