From nobody Mon Feb 9 05:37:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633271071; cv=none; d=zohomail.com; s=zohoarc; b=ONR9qsu0ObMTd5Apn6mvT0AwHTx61PoHiY4DTMtsBHt/ELnWNF4zM2UL4yf2+P7f5scVvExUWtnlHMdfNe0mSNTtsPmUiM256n+U/pXYDiEh+UX86pgR/RCpsvWj9iJr+bwU8XaDmmtPGyx9TGMZecbLOQvLHN6Og1vbuCoB0s4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633271071; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=lpJOcUfX3QlDekAfq0GErVJB9iwYa3lMEMw+O6tafBY=; b=YM22j2qBCqF5zavP+lncMfMc8wFEUOqrbqKvozeTbHw/uP4zK5kcUNS02+mcnLf1UOf0dQpy3wyBZ6XJR1q7DnAgH/1XYIrgls9+te9hF4tK/V9WuZTGkBUb6NPi7e0yUL+eFtrZh6a5yoM6Yq0nieuGvapPfsGXNRDQnABH9ZI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1633271071717952.7718955227613; Sun, 3 Oct 2021 07:24:31 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id o4-20020a05600c510400b0030d55d6449fso4062509wms.5 for ; Sun, 03 Oct 2021 07:24:31 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id l124sm13845926wml.8.2021.10.03.07.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 07:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lpJOcUfX3QlDekAfq0GErVJB9iwYa3lMEMw+O6tafBY=; b=J/Zm4zBQwyoaLu1qnU15ykisco4YdtElGt5o0VBU/pymyGYeF3EDkvmByFgJ2GaUhw o4h/ROvvlHUgeBXOvgwqQsrVW/wT6JdeW1BP4AoCVQ/vWoerfglyF6sPl7fJDj6BDcZt KCcwZtyg2y9J1V2UzHq8ZUKebpN2iX5iQzLyA+lVtZgjAAY+jcdjtOWHDIBBX3CWzhFI rIPi7zadJT5mwRPLS97TY6lM2dNtg6hcmtodozYDLAlCIz36mWRjw5gjdu57DxuMPJWE YpdSiLbTx9wPRidRBMCBayAx3pY0BrC96jI/mWKa1mBqgs3rsIdO5KxyjIDkh2A0t/lk f/OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=lpJOcUfX3QlDekAfq0GErVJB9iwYa3lMEMw+O6tafBY=; b=XxYPvf8n+Eh39YKMVwI/ot8nCsElsENKTTaRQSaeq5nuuka8+QIQTgXTqs6qJfgCsa Eg3VnzJzBIxjWKf9syZpBAR43nNmXO6LGBYv2J3KWj7sxllUfrRlu+3VX/8m2g/M7JUI megArkj5ewEQZfg1xKWoEVM6jb1mNjufm/fmAcOfnoSbEd9NNPxha2pHvkOXF/UypQkm +ad7VeoVx1sHKl/6gh3JtyGTZB2vU6plaLd4Wt6v+mi2+U+8RSKZYCrLpCJAB9ErY9yD DWDvVyyOq+bMX4brDRcgVQeETVpD/+48qbAJ/Otvcb9r9p1cT95xJ2a16kx/8RzWCFKE NqoA== X-Gm-Message-State: AOAM530Fjace5gkiyw9qCFxYZeOviCLe6qJD70Bukk3LBE/bPEEm0oYo 2rvXjtlFGzmWxGRuDPCyJgU= X-Google-Smtp-Source: ABdhPJyqHicNb6oWLeDKGgpnNkv2pqWJeal6vKJy2ZYi2+d/9HOQ2VZfaaWTqhq+WoHC3ORKa8EKNA== X-Received: by 2002:a7b:c74d:: with SMTP id w13mr14208229wmk.11.1633271069787; Sun, 03 Oct 2021 07:24:29 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] target/m68k: Optimize shift_mem() using extract() TCG opcode Date: Sun, 3 Oct 2021 16:24:28 +0200 Message-Id: <20211003142428.3676092-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633271073063100001 When running the scripts/coccinelle/tcg_gen_extract.cocci Coccinelle semantic patch on target/m68k/, we get: [DBG] candidate at target/m68k/translate.c:3668 Manually inspect and replace combinations of (shri, andi) and (movi, andi) opcodes by the extract opcode. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/m68k/translate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 50a55f949cd..a38cf414077 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -3665,7 +3665,7 @@ DISAS_INSN(shift_mem) SRC_EA(env, src, OS_WORD, !logical, &addr); tcg_gen_movi_i32(QREG_CC_V, 0); if (left) { - tcg_gen_shri_i32(QREG_CC_C, src, 15); + tcg_gen_extract_i32(QREG_CC_C, src, 15, 1); tcg_gen_shli_i32(QREG_CC_N, src, 1); =20 /* @@ -3678,7 +3678,7 @@ DISAS_INSN(shift_mem) tcg_gen_xor_i32(QREG_CC_V, QREG_CC_N, src); } } else { - tcg_gen_mov_i32(QREG_CC_C, src); + tcg_gen_extract_i32(QREG_CC_C, src, 0, 1); if (logical) { tcg_gen_shri_i32(QREG_CC_N, src, 1); } else { @@ -3687,7 +3687,6 @@ DISAS_INSN(shift_mem) } =20 gen_ext(QREG_CC_N, QREG_CC_N, OS_WORD, 1); - tcg_gen_andi_i32(QREG_CC_C, QREG_CC_C, 1); tcg_gen_mov_i32(QREG_CC_Z, QREG_CC_N); tcg_gen_mov_i32(QREG_CC_X, QREG_CC_C); =20 --=20 2.31.1