From nobody Mon Feb 9 14:00:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633270906; cv=none; d=zohomail.com; s=zohoarc; b=LGWxNWFfXmPqIHR7h6bflWGIqm6EvHdEssDLUGuT2uy+R/bgL28b3k1iojAEi5Dg5RDSP9i5zyJ9JhYtdrGbzW56Soidc5Xxglyz0IgVhHHxpIawKGHgiGiDihni51fRkCdHfANIbe4HmPRsuIuXUOuhUqFG9SMvY3GjgWBIVPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633270906; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=FGFt3Emm2J4ZJHwqmsZyM0FIoxBakX/wgin/HsQFwEk=; b=IU5/vRd8zki2Bj9KoUjYPDAn7BdfaLf9l+/FeWDMFDKYtF0eVFUgrhcm6PYrdZQL8xbQpgnpZUowYsBa9PuVSaNgsG8tWUar65xIja3zU/q4Mazc5me/Xkvy4bT6yi9agiYqhVndWK98ytEtTqWFPDwWXF0zgnxPFjNHVllH6oI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.zohomail.com with SMTPS id 1633270906493920.5263197565159; Sun, 3 Oct 2021 07:21:46 -0700 (PDT) Received: by mail-wm1-f54.google.com with SMTP id j27so11247624wms.0 for ; Sun, 03 Oct 2021 07:21:45 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id q18sm13700051wmc.7.2021.10.03.07.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 07:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FGFt3Emm2J4ZJHwqmsZyM0FIoxBakX/wgin/HsQFwEk=; b=pzG5bIg5ppHAPdlsW1KGtcoMejjY7BgreT5ELGtYfluW3mNzcnmtQEZF39iMGQAgnj hEx/LZFVU6xUtR46vAv9XUtWNTZeW3XnSHu/MgChz1kxwTdSOdzxPsaptpCx4YMgXS3q NWdSp4kXB6LjM7hREY82+d9cFeZqj03mUZfPLj3Ul2z2de3Qrg/YCEC0Xol7K+CwL05P CVQNzfNqL+CoOnFdGYWVF2A0ZkFEIf8a08fOPkrbGrqWlMJnF/JHofxYVW4kw9lwMPX4 M+BHoAez0oxSVLyjvsfCYSy7kobSqohZbzXWIKuawE3L6RjPdayayGmSlWV2F09QDnvS pipw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=FGFt3Emm2J4ZJHwqmsZyM0FIoxBakX/wgin/HsQFwEk=; b=wsL7zZ2hZBsZC1GqSOMmA62k+hP+0LETL0TXUx3QMX50Ryxdb6lK462145qR7zMjxM nQlRkauTH3VI87vm/+LughppeVJXuf1RqSULoXMUU93OFahFVInQk+ekMoSiXK/88EjM mTrWcwOmElbt9bW9UNXR7Z+4YLTlVDpl3MLXXIPrMREmCRHVkkTX8HuPc52Hbndmu+oU XZxl9lrVvB/4eulXzD+cMNBR1JtXYcpruGv4uY5Pm9r2+jGN2lQNvDNfSZiSvW8MFc04 JMIn0ED2TqylhALpoZHOrMRX5SvnWZ3ujg4mFEGPETLSeQm+P5EQonFuqXygwOd8S4kP 0+4A== X-Gm-Message-State: AOAM531rVstbyHniZxQpX1GsfFn20q7cbu4qCazFYGl/SWqnP1SorcLY 1Ho/SnoP3ZDyHHpZZsIv7Yg= X-Google-Smtp-Source: ABdhPJyb9xZ6onO7IiktWSeuJsj8/Z4mO92kaOiSjzietBvoAsFChGb1Iie7O+7zdVThMaxloe1cRg== X-Received: by 2002:a1c:7304:: with SMTP id d4mr14132642wmb.125.1633270904674; Sun, 03 Oct 2021 07:21:44 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Michael Rolnik , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] target/avr: Optimize various functions using extract opcode Date: Sun, 3 Oct 2021 16:21:42 +0200 Message-Id: <20211003142142.3674844-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633270907269100001 When running the scripts/coccinelle/tcg_gen_extract.cocci Coccinelle semantic patch on target/avr/, we get: [DBG] candidate at target/avr/translate.c:228 [DBG] candidate at target/avr/translate.c:266 [DBG] candidate at target/avr/translate.c:885 [DBG] candidate at target/avr/translate.c:924 [DBG] candidate at target/avr/translate.c:962 Manually inspect and replace combinations of (shri, andi) opcodes by the extract opcode. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/avr/translate.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/target/avr/translate.c b/target/avr/translate.c index 438e7b13c18..246cbfba1cd 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -225,8 +225,7 @@ static void gen_add_CHf(TCGv R, TCGv Rd, TCGv Rr) tcg_gen_or_tl(t1, t1, t3); =20 tcg_gen_shri_tl(cpu_Cf, t1, 7); /* Cf =3D t1(7) */ - tcg_gen_shri_tl(cpu_Hf, t1, 3); /* Hf =3D t1(3) */ - tcg_gen_andi_tl(cpu_Hf, cpu_Hf, 1); + tcg_gen_extract_tl(cpu_Hf, t1, 3, 1); /* Hf =3D t1(3) */ =20 tcg_temp_free_i32(t3); tcg_temp_free_i32(t2); @@ -263,8 +262,7 @@ static void gen_sub_CHf(TCGv R, TCGv Rd, TCGv Rr) tcg_gen_or_tl(t2, t2, t3); /* t2 =3D ~Rd & Rr | ~Rd & R | R & Rr */ =20 tcg_gen_shri_tl(cpu_Cf, t2, 7); /* Cf =3D t2(7) */ - tcg_gen_shri_tl(cpu_Hf, t2, 3); /* Hf =3D t2(3) */ - tcg_gen_andi_tl(cpu_Hf, cpu_Hf, 1); + tcg_gen_extract_tl(cpu_Hf, t2, 3, 1); /* Hf =3D t2(3) */ =20 tcg_temp_free_i32(t3); tcg_temp_free_i32(t2); @@ -882,9 +880,7 @@ static bool trans_FMUL(DisasContext *ctx, arg_FMUL *a) /* update output registers */ tcg_gen_shli_tl(R, R, 1); tcg_gen_andi_tl(R0, R, 0xff); - tcg_gen_shri_tl(R1, R, 8); - tcg_gen_andi_tl(R1, R1, 0xff); - + tcg_gen_extract_tl(R1, R, 8, 8); =20 tcg_temp_free_i32(R); =20 @@ -921,8 +917,7 @@ static bool trans_FMULS(DisasContext *ctx, arg_FMULS *a) /* update output registers */ tcg_gen_shli_tl(R, R, 1); tcg_gen_andi_tl(R0, R, 0xff); - tcg_gen_shri_tl(R1, R, 8); - tcg_gen_andi_tl(R1, R1, 0xff); + tcg_gen_extract_tl(R1, R, 8, 8); =20 tcg_temp_free_i32(t1); tcg_temp_free_i32(t0); @@ -959,8 +954,7 @@ static bool trans_FMULSU(DisasContext *ctx, arg_FMULSU = *a) /* update output registers */ tcg_gen_shli_tl(R, R, 1); tcg_gen_andi_tl(R0, R, 0xff); - tcg_gen_shri_tl(R1, R, 8); - tcg_gen_andi_tl(R1, R1, 0xff); + tcg_gen_extract_tl(R1, R, 8, 8); =20 tcg_temp_free_i32(t0); tcg_temp_free_i32(R); --=20 2.31.1