From nobody Tue Feb 10 14:32:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633270645; cv=none; d=zohomail.com; s=zohoarc; b=FgJ0mKCWrsD8yC+WpVfQdMpSb57zQLR/YTAC/OawM97idtYHFe6HjyYCtXFPC8geF0Ijs0p1GSHFYoDlNrFS9vbV01tfQB3ympNv4NHpXeXrL/1lIlBFuNnq65bzuOchdYSJfKKnFBhEn2gwqh5ImPgnJZMrdIbwsNXydW9mjkY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633270645; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+qKGw4q6/hJhz4VZmO0Noz/zkq42BzizY+4WFw06qiA=; b=Y8swqhkmYWi1uqIeNVL7AyZgkhBNFHTaU/BV7LT8n3tmBPP/vNkCJyikoPmJYQt2HuiNKtqHxXoaaXWGBlOM4RmjSJ42JLr+b8ik3W5nv+L+MNwJ7wYP2SgE+4h4uR2OGqpmF8bsnbGcoNf2ueN27md97SnRip3VAWBdduRYfG0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1633270645682300.0261335606399; Sun, 3 Oct 2021 07:17:25 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id t2so1751604wrb.8 for ; Sun, 03 Oct 2021 07:17:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id l124sm13829201wml.8.2021.10.03.07.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 07:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qKGw4q6/hJhz4VZmO0Noz/zkq42BzizY+4WFw06qiA=; b=Y33+THpA6JrmfQ5eu+QZQRJY2p/ixm2lu/bd+/54YkcBgFaULbvAhPlircLY+J8N2R Orfzo3tzizt8kiHECHCnnGKH73rd4T14lqRIzls31uptG09lDP4qlnrz0CfVjXNWchfp p3Jxxx2mFaXDboZqe5X3onQWiwkPIFY/2Xbt7QJKlC3hPF6QWr8Dz246cYfdhc5bw7Cx VO7BK4xHNl/uB/1w0i9mBMZ1sAa2fzMRCXDy+Py9TJYNyH4WoFKpqOo63gHN7qAfZiKU VG8T7a7wxmuxfyJbTLoyvtsXn/c0ShaVrYHl/8NKY+hHzcuzbHDPY8LHmIwvyF/tpYP3 0m6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+qKGw4q6/hJhz4VZmO0Noz/zkq42BzizY+4WFw06qiA=; b=VsMCl9SBewj3qojBnh7dvhy83MC6frEFJvLl97IKKMILoyY/Eqlp9E06jjZoDP9gjT LIYx0AZ8+vpA+nlBNuQzlRv/BbSgLPuK98LGk1NQo0U+YeaWv4X3P0KjG7ML4LUgFgXi 0KvxHntOjyd+0wSC4A2bHO6kucHGGU6qb2XTM2N+n3I9yymEsCQGEQ9wU2z+HhubhyFY QnzSQJTaM/UEFa7VD/1Ptyub4jTRxFXRTU6PU/fiIessbYoHkhrvL06scaqjyz7Myca+ XO2w50a7z53wa++ppWftUC5KrKR80DKi2Rqo22sJOe3QfFK63Z8IUPjYvqrumQm53Ttm EEtw== X-Gm-Message-State: AOAM533aBAKYjkPw4/p8Z4plbKtYBhqWsOaIZzpTTLct2kjV3md/pFb0 8B1o9GzLEuV2Fu2QQ9+W714= X-Google-Smtp-Source: ABdhPJyp7ENxVy4qWySDHl52JIz00BrBybLiuT2UcJ+h/F0ID8tryke3WJIf6MzQN55muBrx30zaKQ== X-Received: by 2002:adf:a4ca:: with SMTP id h10mr8921011wrb.28.1633270643809; Sun, 03 Oct 2021 07:17:23 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: David Gibson , Greg Kurz , qemu-ppc@nongnu.org, Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/2] target/ppc: Use tcg_constant_i64() in gen_brh() Date: Sun, 3 Oct 2021 16:17:11 +0200 Message-Id: <20211003141711.3673181-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003141711.3673181-1-f4bug@amsat.org> References: <20211003141711.3673181-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633270647555100001 The mask of the Byte-Reverse Halfword opcode is a read-only constant. We can avoid using a TCG temporary by moving the mask to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/ppc/translate.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 193d8e89152..30a60d60973 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7575,18 +7575,16 @@ static void gen_brw(DisasContext *ctx) /* brh */ static void gen_brh(DisasContext *ctx) { - TCGv_i64 t0 =3D tcg_temp_new_i64(); + TCGv_i64 mask =3D tcg_constant_i64(0x00ff00ff00ff00ffull); TCGv_i64 t1 =3D tcg_temp_new_i64(); TCGv_i64 t2 =3D tcg_temp_new_i64(); =20 - tcg_gen_movi_i64(t0, 0x00ff00ff00ff00ffull); tcg_gen_shri_i64(t1, cpu_gpr[rS(ctx->opcode)], 8); - tcg_gen_and_i64(t2, t1, t0); - tcg_gen_and_i64(t1, cpu_gpr[rS(ctx->opcode)], t0); + tcg_gen_and_i64(t2, t1, mask); + tcg_gen_and_i64(t1, cpu_gpr[rS(ctx->opcode)], mask); tcg_gen_shli_i64(t1, t1, 8); tcg_gen_or_i64(cpu_gpr[rA(ctx->opcode)], t1, t2); =20 - tcg_temp_free_i64(t0); tcg_temp_free_i64(t1); tcg_temp_free_i64(t2); } --=20 2.31.1