From nobody Mon Feb 9 13:06:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) client-ip=209.85.128.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633222078; cv=none; d=zohomail.com; s=zohoarc; b=mU0PPq2bQc1HugnlxwUR4gbpV87r0l91ZjUoQKk1V2LJIp3NO7xuxjNwKlHbu5SKKr5EHd1WopG5UQkp+Jx1vcVmNI/P/5tg3KWqKSK76zVJlCf/bDVPSU1Sr2t1QHTfzU3+8J3DthGpZZct/bdz74kqMcBZclfha1NI8CAEUqU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633222078; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bo8NwHPIZJi76xNaPQPetSv6WEjzS6D8SX6zEURGAP0=; b=ggj/q8NIiy7C3NDIKmEzG0cRYfGGqz2hTMrdpjeX5zXAh2vdnoHXGhktYoBWqD1P7R55jmjCbMvqBTL5ZULe4CIL6wAYj60M1HhnVpa9lyDs/kdbIpvdhyH1aNPES56E7hoWCDNwAhkZT+dBsgy0c5Ao75vr5L3gC6X21OXaGBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.zohomail.com with SMTPS id 1633222078612371.989326448028; Sat, 2 Oct 2021 17:47:58 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id j27so10161430wms.0 for ; Sat, 02 Oct 2021 17:47:58 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id g78sm9101686wme.14.2021.10.02.17.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Oct 2021 17:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bo8NwHPIZJi76xNaPQPetSv6WEjzS6D8SX6zEURGAP0=; b=E8BxfYJSg/sFYsfi+SqSDmfGlKcf0ghBF20ztCcR3TrgfSTMXzPcy992MBnSmVIjQF PMSbOF+dn84rMtlYM4DXZKCFcwNZpeuY9gxz+IAH/nkavwxu7sVT8Hy8BGq3Xx1f2XQF 3bc7NKD13c8Pxp+2HZFzpAy9GayvttuRxMZcy4bWRr+65GbjokogPgi2TXfsQy/rXXny EZGtWZ7DmnFR4CyNndBUDhFnKZ4bvaXl0o0BDI2eziwZJzSJ5eEkubmA9gi1agzkYR4/ iztwNjdaTjP2boxYgjHnmiKEvFdYEx+6pWbcMwXOBto0tYkxv4CC7XqcUcMK2swhgu3g Pq4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=bo8NwHPIZJi76xNaPQPetSv6WEjzS6D8SX6zEURGAP0=; b=BBm3xRXcO2wN16jAvYjNqWppSuCR29Wr+wv50YBc+H2uj5p3+09s6r6uWxPpJcfisu gYbkSvUAx6HQwJi2iSN1w1GLwptOe04Eynyzb0eFdTTy3cKQSEYV0xYCCwi3JuVJSihi KeQV5zjiLEGmAM/uTdpzfq6iH/B4qhI/2jD/TWkg3ssWLp1y0rEWK4c3hzllUGe0EgJ+ HmuplHU1tqr3TuZji5aXFyEJCkr4BMSVCGppYGBa2rxsf6trqJXVNkDSPKD/b0U6yJrV WkuBPkoBP/Ff5T2i7fbynSrp1h+HFzcWufuRdwp4CPX3EojT3PWfb91pTNNjqkvQ571I inoQ== X-Gm-Message-State: AOAM530VsHqQHqBKr9qwWXzIpgyvVlpdUxzqcFK6Pbv7PUdemtRJwxc0 Hrz0xmTTI6ayUL18qK5iXaw= X-Google-Smtp-Source: ABdhPJw2OSdljxFzYr9fwciGkDrQZvmtoABBQWkHhR0V8mBm8QIVpa4VQiUn7L4XOFP8z8c1sq3Biw== X-Received: by 2002:a1c:7508:: with SMTP id o8mr11485169wmc.104.1633222076854; Sat, 02 Oct 2021 17:47:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Taylor Simpson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/2] target/hexagon: Remove unused TCG temporary from predicated loads Date: Sun, 3 Oct 2021 02:47:49 +0200 Message-Id: <20211003004750.3608983-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003004750.3608983-1-f4bug@amsat.org> References: <20211003004750.3608983-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633222080673100001 The gen_pred_cancel() function, introduced in commit a646e99cb90 (Hexagon macros) doesn't use the 'one' TCG temporary; remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/macros.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 094b8dabb5a..ae6663c09fe 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -190,7 +190,6 @@ static inline void gen_pred_cancel(TCGv pred, int slot_= num) TCGv slot_mask =3D tcg_const_tl(1 << slot_num); TCGv tmp =3D tcg_temp_new(); TCGv zero =3D tcg_const_tl(0); - TCGv one =3D tcg_const_tl(1); tcg_gen_or_tl(slot_mask, hex_slot_cancelled, slot_mask); tcg_gen_andi_tl(tmp, pred, 1); tcg_gen_movcond_tl(TCG_COND_EQ, hex_slot_cancelled, tmp, zero, @@ -198,7 +197,6 @@ static inline void gen_pred_cancel(TCGv pred, int slot_= num) tcg_temp_free(slot_mask); tcg_temp_free(tmp); tcg_temp_free(zero); - tcg_temp_free(one); } #define PRED_LOAD_CANCEL(PRED, EA) \ gen_pred_cancel(PRED, insn->is_endloop ? 4 : insn->slot) --=20 2.31.1 From nobody Mon Feb 9 13:06:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633222083; cv=none; d=zohomail.com; s=zohoarc; b=Tt8CcNecAfojwxJV2XkmpGvQE3h5MABFGuZJU5XMrQhR5VfqstmmXXccouqmNdzkv/RGtxqunQLl1RbGCr1M54devuD3cv01n+/kxtkgdxPPwza3bhBWTQBmTQ24m8bxHK7Av35R2lDCiLmOGeJmSNxuKyjlLBBnNbcVKWaVNr4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633222083; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5VI85G4294es99iD21jmCA+4Em454SmAFRcuqCppvkI=; b=XFeHqSLVfS0UA0WU2mhoZVmNHcUOT441MLfj6Kq8kF46K11o5V7P1zbJOqvIatlitWD8Vw5nmLMQn0MZpdYNONmj0MemETknUN00nnZCebQo2wiIOAvQE/EWPLruyGP1o0ZDgd+KpPe621mjMZ8kUh2CvFlTLJtZQxfG3WpH3Jo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1633222083319802.4711530018109; Sat, 2 Oct 2021 17:48:03 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id m14-20020a05600c3b0e00b0030d4dffd04fso4340930wms.3 for ; Sat, 02 Oct 2021 17:48:02 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id g1sm12779856wmk.2.2021.10.02.17.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Oct 2021 17:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5VI85G4294es99iD21jmCA+4Em454SmAFRcuqCppvkI=; b=YXjMkyD/RxN1rWeQUjTvTqv3RNb46GZg7Lm62yv1m/xPgIBLYO+MwgQNVHTcSl9Shh IaTOp2uBB1THMNpvPfb0JKurUdZwqa1HO9UB5EI6fZM/NO7LeSOJi25Tj7or4MqSNH5q WmjysWh9ua3zVgfy9BEF6Nu+ETzwuDGdm9biSDZUt/PHUcR3u8BEpczPYR5+xA4or81O F4QltE7ChHy0MfVSRSEoYnch/Derecu0lgMIM2lU3SpsgpKW5qpfg60NiyS/OvIjugVw OT736Ce47+2dWFxDPQRdPkK6/aIs6FE7yAbEpduwB1GSPVw3ecqo/qZ9I8monHY3b4aW 3n9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5VI85G4294es99iD21jmCA+4Em454SmAFRcuqCppvkI=; b=GIVG4ChjY4PFQRl3UqxsTsceJzte9L2TW2WflUKrVl1ASzYKERNmq/I8mqQ6T3o02Y Xp9veHQI3AHcxt/oPsZU7x0V5QaZdmpE4o34ehbSz68UTEu4cvVTy+0uS42yy869FLcB Y1bf1KMx6iCkYmbvQ9Ym6qdiIjBDWxwJ6c7LMah/7Ku1yg+aasNaihOO35LyzVTpVn08 cL6Mjxq6m+YUhXfjmDApqXpoZVyjhSUu96hk7iYp1o1rGv8qSizM3hxP3XC11UFXNLfO S3e68WqrcHkbYNcDGfFNmRTgQ665d3cPUAYVLTXzJd6dUMA1D8PcO0Dfb8ghyB+rNzTs 0U8w== X-Gm-Message-State: AOAM532K/2baqpU2XjXFor+Dg09vcIwdZF4JYdZv4OGfCbU47Tb4kA1k w7n87FRInXsTLKqTBLf9Wec= X-Google-Smtp-Source: ABdhPJx7C45fxc9UnPOZqXNMsNyUrIJ1mRW0IF+WrqfnMoOTImHiMkSCY5LTcsU4bmzj7RJjzHVPbA== X-Received: by 2002:a7b:cbc4:: with SMTP id n4mr11455546wmi.37.1633222081457; Sat, 02 Oct 2021 17:48:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Taylor Simpson , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/2] target/hexagon: Use tcg_constant_* Date: Sun, 3 Oct 2021 02:47:50 +0200 Message-Id: <20211003004750.3608983-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211003004750.3608983-1-f4bug@amsat.org> References: <20211003004750.3608983-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633222084707100001 Replace uses of tcg_const_* with the allocate and free close together. Inspired-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/gen_tcg.h | 6 ++--- target/hexagon/macros.h | 3 +-- target/hexagon/genptr.c | 39 +++++++++++---------------------- target/hexagon/translate.c | 26 +++++++--------------- target/hexagon/gen_tcg_funcs.py | 4 +--- 5 files changed, 25 insertions(+), 53 deletions(-) diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h index ee94c903dba..03615641042 100644 --- a/target/hexagon/gen_tcg.h +++ b/target/hexagon/gen_tcg.h @@ -684,9 +684,8 @@ gen_helper_sfmin(RdV, cpu_env, RsV, RtV) #define fGEN_TCG_F2_sfclass(SHORTCODE) \ do { \ - TCGv imm =3D tcg_const_tl(uiV); \ + TCGv imm =3D tcg_constant_tl(uiV); \ gen_helper_sfclass(PdV, cpu_env, RsV, imm); \ - tcg_temp_free(imm); \ } while (0) #define fGEN_TCG_F2_sffixupn(SHORTCODE) \ gen_helper_sffixupn(RdV, cpu_env, RsV, RtV) @@ -712,9 +711,8 @@ gen_helper_dfcmpuo(PdV, cpu_env, RssV, RttV) #define fGEN_TCG_F2_dfclass(SHORTCODE) \ do { \ - TCGv imm =3D tcg_const_tl(uiV); \ + TCGv imm =3D tcg_constant_tl(uiV); \ gen_helper_dfclass(PdV, cpu_env, RssV, imm); \ - tcg_temp_free(imm); \ } while (0) #define fGEN_TCG_F2_sfmpy(SHORTCODE) \ gen_helper_sfmpy(RdV, cpu_env, RsV, RtV) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index ae6663c09fe..44e9b857b56 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -189,14 +189,13 @@ static inline void gen_pred_cancel(TCGv pred, int slo= t_num) { TCGv slot_mask =3D tcg_const_tl(1 << slot_num); TCGv tmp =3D tcg_temp_new(); - TCGv zero =3D tcg_const_tl(0); + TCGv zero =3D tcg_constant_tl(0); tcg_gen_or_tl(slot_mask, hex_slot_cancelled, slot_mask); tcg_gen_andi_tl(tmp, pred, 1); tcg_gen_movcond_tl(TCG_COND_EQ, hex_slot_cancelled, tmp, zero, slot_mask, hex_slot_cancelled); tcg_temp_free(slot_mask); tcg_temp_free(tmp); - tcg_temp_free(zero); } #define PRED_LOAD_CANCEL(PRED, EA) \ gen_pred_cancel(PRED, insn->is_endloop ? 4 : insn->slot) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 73332996156..4a21fa590ff 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -29,7 +29,7 @@ =20 static inline void gen_log_predicated_reg_write(int rnum, TCGv val, int sl= ot) { - TCGv zero =3D tcg_const_tl(0); + TCGv zero =3D tcg_constant_tl(0); TCGv slot_mask =3D tcg_temp_new(); =20 tcg_gen_andi_tl(slot_mask, hex_slot_cancelled, 1 << slot); @@ -47,7 +47,6 @@ static inline void gen_log_predicated_reg_write(int rnum,= TCGv val, int slot) tcg_gen_or_tl(hex_reg_written[rnum], hex_reg_written[rnum], slot_m= ask); } =20 - tcg_temp_free(zero); tcg_temp_free(slot_mask); } =20 @@ -63,7 +62,7 @@ static inline void gen_log_reg_write(int rnum, TCGv val) static void gen_log_predicated_reg_write_pair(int rnum, TCGv_i64 val, int = slot) { TCGv val32 =3D tcg_temp_new(); - TCGv zero =3D tcg_const_tl(0); + TCGv zero =3D tcg_constant_tl(0); TCGv slot_mask =3D tcg_temp_new(); =20 tcg_gen_andi_tl(slot_mask, hex_slot_cancelled, 1 << slot); @@ -92,7 +91,6 @@ static void gen_log_predicated_reg_write_pair(int rnum, T= CGv_i64 val, int slot) } =20 tcg_temp_free(val32); - tcg_temp_free(zero); tcg_temp_free(slot_mask); } =20 @@ -181,9 +179,8 @@ static inline void gen_read_ctrl_reg_pair(DisasContext = *ctx, const int reg_num, tcg_gen_concat_i32_i64(dest, p3_0, hex_gpr[reg_num + 1]); tcg_temp_free(p3_0); } else if (reg_num =3D=3D HEX_REG_PC - 1) { - TCGv pc =3D tcg_const_tl(ctx->base.pc_next); + TCGv pc =3D tcg_constant_tl(ctx->base.pc_next); tcg_gen_concat_i32_i64(dest, hex_gpr[reg_num], pc); - tcg_temp_free(pc); } else if (reg_num =3D=3D HEX_REG_QEMU_PKT_CNT) { TCGv pkt_cnt =3D tcg_temp_new(); TCGv insn_cnt =3D tcg_temp_new(); @@ -331,15 +328,13 @@ static inline void gen_store_conditional4(DisasContex= t *ctx, =20 tcg_gen_brcond_tl(TCG_COND_NE, vaddr, hex_llsc_addr, fail); =20 - one =3D tcg_const_tl(0xff); - zero =3D tcg_const_tl(0); + one =3D tcg_constant_tl(0xff); + zero =3D tcg_constant_tl(0); tmp =3D tcg_temp_new(); tcg_gen_atomic_cmpxchg_tl(tmp, hex_llsc_addr, hex_llsc_val, src, ctx->mem_idx, MO_32); tcg_gen_movcond_tl(TCG_COND_EQ, pred, tmp, hex_llsc_val, one, zero); - tcg_temp_free(one); - tcg_temp_free(zero); tcg_temp_free(tmp); tcg_gen_br(done); =20 @@ -359,16 +354,14 @@ static inline void gen_store_conditional8(DisasContex= t *ctx, =20 tcg_gen_brcond_tl(TCG_COND_NE, vaddr, hex_llsc_addr, fail); =20 - one =3D tcg_const_i64(0xff); - zero =3D tcg_const_i64(0); + one =3D tcg_constant_i64(0xff); + zero =3D tcg_constant_i64(0); tmp =3D tcg_temp_new_i64(); tcg_gen_atomic_cmpxchg_i64(tmp, hex_llsc_addr, hex_llsc_val_i64, src, ctx->mem_idx, MO_64); tcg_gen_movcond_i64(TCG_COND_EQ, tmp, tmp, hex_llsc_val_i64, one, zero); tcg_gen_extrl_i64_i32(pred, tmp); - tcg_temp_free_i64(one); - tcg_temp_free_i64(zero); tcg_temp_free_i64(tmp); tcg_gen_br(done); =20 @@ -396,9 +389,8 @@ static inline void gen_store1(TCGv_env cpu_env, TCGv va= ddr, TCGv src, static inline void gen_store1i(TCGv_env cpu_env, TCGv vaddr, int32_t src, DisasContext *ctx, int slot) { - TCGv tmp =3D tcg_const_tl(src); + TCGv tmp =3D tcg_constant_tl(src); gen_store1(cpu_env, vaddr, tmp, ctx, slot); - tcg_temp_free(tmp); } =20 static inline void gen_store2(TCGv_env cpu_env, TCGv vaddr, TCGv src, @@ -411,9 +403,8 @@ static inline void gen_store2(TCGv_env cpu_env, TCGv va= ddr, TCGv src, static inline void gen_store2i(TCGv_env cpu_env, TCGv vaddr, int32_t src, DisasContext *ctx, int slot) { - TCGv tmp =3D tcg_const_tl(src); + TCGv tmp =3D tcg_constant_tl(src); gen_store2(cpu_env, vaddr, tmp, ctx, slot); - tcg_temp_free(tmp); } =20 static inline void gen_store4(TCGv_env cpu_env, TCGv vaddr, TCGv src, @@ -426,9 +417,8 @@ static inline void gen_store4(TCGv_env cpu_env, TCGv va= ddr, TCGv src, static inline void gen_store4i(TCGv_env cpu_env, TCGv vaddr, int32_t src, DisasContext *ctx, int slot) { - TCGv tmp =3D tcg_const_tl(src); + TCGv tmp =3D tcg_constant_tl(src); gen_store4(cpu_env, vaddr, tmp, ctx, slot); - tcg_temp_free(tmp); } =20 static inline void gen_store8(TCGv_env cpu_env, TCGv vaddr, TCGv_i64 src, @@ -443,18 +433,15 @@ static inline void gen_store8(TCGv_env cpu_env, TCGv = vaddr, TCGv_i64 src, static inline void gen_store8i(TCGv_env cpu_env, TCGv vaddr, int64_t src, DisasContext *ctx, int slot) { - TCGv_i64 tmp =3D tcg_const_i64(src); + TCGv_i64 tmp =3D tcg_constant_i64(src); gen_store8(cpu_env, vaddr, tmp, ctx, slot); - tcg_temp_free_i64(tmp); } =20 static TCGv gen_8bitsof(TCGv result, TCGv value) { - TCGv zero =3D tcg_const_tl(0); - TCGv ones =3D tcg_const_tl(0xff); + TCGv zero =3D tcg_constant_tl(0); + TCGv ones =3D tcg_constant_tl(0xff); tcg_gen_movcond_tl(TCG_COND_NE, result, value, zero, ones, zero); - tcg_temp_free(zero); - tcg_temp_free(ones); =20 return result; } diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 6fb4e6853c1..8959683d0eb 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -54,9 +54,7 @@ static const char * const hexagon_prednames[] =3D { =20 static void gen_exception_raw(int excp) { - TCGv_i32 helper_tmp =3D tcg_const_i32(excp); - gen_helper_raise_exception(cpu_env, helper_tmp); - tcg_temp_free_i32(helper_tmp); + gen_helper_raise_exception(cpu_env, tcg_constant_i32(excp)); } =20 static void gen_exec_counters(DisasContext *ctx) @@ -288,7 +286,7 @@ static void gen_pred_writes(DisasContext *ctx, Packet *= pkt) * write of the predicates. */ if (pkt->pkt_has_endloop) { - TCGv zero =3D tcg_const_tl(0); + TCGv zero =3D tcg_constant_tl(0); TCGv pred_written =3D tcg_temp_new(); for (i =3D 0; i < ctx->preg_log_idx; i++) { int pred_num =3D ctx->preg_log[i]; @@ -299,7 +297,6 @@ static void gen_pred_writes(DisasContext *ctx, Packet *= pkt) hex_new_pred_value[pred_num], hex_pred[pred_num]); } - tcg_temp_free(zero); tcg_temp_free(pred_written); } else { for (i =3D 0; i < ctx->preg_log_idx; i++) { @@ -317,11 +314,9 @@ static void gen_pred_writes(DisasContext *ctx, Packet = *pkt) static void gen_check_store_width(DisasContext *ctx, int slot_num) { if (HEX_DEBUG) { - TCGv slot =3D tcg_const_tl(slot_num); - TCGv check =3D tcg_const_tl(ctx->store_width[slot_num]); + TCGv slot =3D tcg_constant_tl(slot_num); + TCGv check =3D tcg_constant_tl(ctx->store_width[slot_num]); gen_helper_debug_check_store_width(cpu_env, slot, check); - tcg_temp_free(slot); - tcg_temp_free(check); } } =20 @@ -403,9 +398,8 @@ void process_store(DisasContext *ctx, Packet *pkt, int = slot_num) * TCG generation time, we'll use a helper to * avoid branching based on the width at runtime. */ - TCGv slot =3D tcg_const_tl(slot_num); + TCGv slot =3D tcg_constant_tl(slot_num); gen_helper_commit_store(cpu_env, slot); - tcg_temp_free(slot); } } tcg_temp_free(address); @@ -436,7 +430,7 @@ static void process_dczeroa(DisasContext *ctx, Packet *= pkt) if (pkt->pkt_has_dczeroa) { /* Store 32 bytes of zero starting at (addr & ~0x1f) */ TCGv addr =3D tcg_temp_new(); - TCGv_i64 zero =3D tcg_const_i64(0); + TCGv_i64 zero =3D tcg_constant_i64(0); =20 tcg_gen_andi_tl(addr, hex_dczero_addr, ~0x1f); tcg_gen_qemu_st64(zero, addr, ctx->mem_idx); @@ -448,7 +442,6 @@ static void process_dczeroa(DisasContext *ctx, Packet *= pkt) tcg_gen_qemu_st64(zero, addr, ctx->mem_idx); =20 tcg_temp_free(addr); - tcg_temp_free_i64(zero); } } =20 @@ -478,15 +471,12 @@ static void gen_commit_packet(DisasContext *ctx, Pack= et *pkt) update_exec_counters(ctx, pkt); if (HEX_DEBUG) { TCGv has_st0 =3D - tcg_const_tl(pkt->pkt_has_store_s0 && !pkt->pkt_has_dczeroa); + tcg_constant_tl(pkt->pkt_has_store_s0 && !pkt->pkt_has_dczeroa= ); TCGv has_st1 =3D - tcg_const_tl(pkt->pkt_has_store_s1 && !pkt->pkt_has_dczeroa); + tcg_constant_tl(pkt->pkt_has_store_s1 && !pkt->pkt_has_dczeroa= ); =20 /* Handy place to set a breakpoint at the end of execution */ gen_helper_debug_commit_end(cpu_env, has_st0, has_st1); - - tcg_temp_free(has_st0); - tcg_temp_free(has_st1); } =20 if (pkt->pkt_has_cof) { diff --git a/target/hexagon/gen_tcg_funcs.py b/target/hexagon/gen_tcg_funcs= .py index 7ceb25b5f68..ca8a801baa0 100755 --- a/target/hexagon/gen_tcg_funcs.py +++ b/target/hexagon/gen_tcg_funcs.py @@ -403,7 +403,7 @@ def gen_tcg_func(f, tag, regs, imms): if hex_common.need_part1(tag): f.write(" TCGv part1 =3D tcg_const_tl(insn->part1);\n") if hex_common.need_slot(tag): - f.write(" TCGv slot =3D tcg_const_tl(insn->slot);\n") + f.write(" TCGv slot =3D tcg_constant_tl(insn->slot);\n") f.write(" gen_helper_%s(" % (tag)) i=3D0 ## If there is a scalar result, it is the return type @@ -424,8 +424,6 @@ def gen_tcg_func(f, tag, regs, imms): if hex_common.need_slot(tag): f.write(", slot") if hex_common.need_part1(tag): f.write(", part1" ) f.write(");\n") - if hex_common.need_slot(tag): - f.write(" tcg_temp_free(slot);\n") if hex_common.need_part1(tag): f.write(" tcg_temp_free(part1);\n") for immlett,bits,immshift in imms: --=20 2.31.1