From nobody Tue Feb 10 11:32:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1633217463; cv=none; d=zohomail.com; s=zohoarc; b=V/UG4XHNMaLNjmVnmU028/x6CGaSKLmuVTGGtCjKmoF3IRsdoPbBet/orrQ0GHfZLN/5hfgM8ekWwgvE/Oq2SLxO1vgN29jk7c08ZM17PMWLYPCnkBpwdEurLP51lTormKNMa7h4QTrIEBLPWNdaxmQPRKVR9CnqMczQ6kXdjOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633217463; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x2u29mcCg9qLO7Eb+7HUeeSmQjTzAIKPzQVYsojV4k4=; b=Xra8MB146os+PyYaYTDFdu0jKUPWRukd0B9z+4y4gLZuUhqlSfb33PJhjjhfb6us/VwiBKx/fXrhIRA1lcAyvkFyZXm+zC2leF6gg4n2Y4mrTRyS76q5RC2puV6Ih3+ofBJ6c74mby6PlO8PiNvx1h1ut9XSKVSQkriI3qeO0bw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1633217463602427.41217360565827; Sat, 2 Oct 2021 16:31:03 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id r7so6599362wrc.10 for ; Sat, 02 Oct 2021 16:31:03 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id t12sm6837273wrw.12.2021.10.02.16.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Oct 2021 16:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x2u29mcCg9qLO7Eb+7HUeeSmQjTzAIKPzQVYsojV4k4=; b=AqJddUPZPnD+gi6tXg5QtJ2V0UYVhgkKx5mxGElkXGyzUUYRnJhYCV0STE9Z+pZ/yp EFv3MN1XmmNgcpwDFCskWkZm+U9cefLo0QWGd3k/U9ngC0228Mh1UfdjZ7VowVbvkHoE n0YFklr3F5e65vwSwo8kgOzLhLbe/9JGEbdYxmLfc2uflKCs/Te62MceQqr6j0WKCQZO 2MadlweHzoJ4D/x3aVyRHkTblckQtjSwexp8OUfAsQn8lgzbH86D8Nq05cTdt+SB3mm4 R+RYFC/m+VuqaIcphHry85bvoannXaOUP3I6txLe4S2jUu58pjdPDs0JSUmIy5H7wlnB swuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=x2u29mcCg9qLO7Eb+7HUeeSmQjTzAIKPzQVYsojV4k4=; b=676DGOFHudnmYAO5JaNvDrE4tjtkZWGK4UNXgv2OK74MHMKbzXJ7P3sa+tW/8+bucn 8qdGGxcTtCqZAF9797yCbJxxPPMu1bh3uaed7i7vc9n0XL+tV8rrRilQdLxGPskqePgV VRCXd7lqjnOby0FCJzSlO2PAxtTB2aB7bQhcBF5Fk2hNGp/Y1SfBz9uUBRqUNLgu7ok4 fNtcBEVZ1uNCkDVqQvU6REd46GwWCk5XnPljf0ANFRmdZMCKs7j7SEr4YUOCt9iR868o zNNV8oHFaHxqCLyYid9crnIBzHaaZmA+bk8Ie7CE2B9z6tSOp68459q4E11kTslC2S2N yL7g== X-Gm-Message-State: AOAM533aVT62xZ0I2btf/Gi/4z3zMsuDVTehKuqqEFzLrEzfMluf8MvG +u0B7tDa+kGJ3dM0kt17DE0= X-Google-Smtp-Source: ABdhPJw2/PoZf/vkWT6KXRvqydARe8tx6Ziija4hWn//v6nE4Hffp6S3TaeDvZlIUk6MneSSVPv2ow== X-Received: by 2002:adf:e788:: with SMTP id n8mr5383231wrm.431.1633217461859; Sat, 02 Oct 2021 16:31:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chris Wulff , Marek Vasut , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] target/nios2: Replace load_zero() by zero constant in DisasContext Date: Sun, 3 Oct 2021 01:30:52 +0200 Message-Id: <20211002233054.3575646-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211002233054.3575646-1-f4bug@amsat.org> References: <20211002233054.3575646-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1633217465368100001 Instead of using a temporary for $zero, keep a reference to the constant pool. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/nios2/translate.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/target/nios2/translate.c b/target/nios2/translate.c index 08d7ac53983..c398c5320fb 100644 --- a/target/nios2/translate.c +++ b/target/nios2/translate.c @@ -122,20 +122,12 @@ static uint8_t get_opxcode(uint32_t code) return instr.opx; } =20 -static TCGv load_zero(DisasContext *dc) -{ - if (!dc->zero) { - dc->zero =3D tcg_const_i32(0); - } - return dc->zero; -} - static TCGv load_gpr(DisasContext *dc, uint8_t reg) { if (likely(reg !=3D R_ZERO)) { return cpu_R[reg]; } else { - return load_zero(dc); + return dc->zero; } } =20 @@ -752,6 +744,7 @@ static void nios2_tr_init_disas_context(DisasContextBas= e *dcbase, CPUState *cs) int page_insns; =20 dc->mem_idx =3D cpu_mmu_index(env, false); + dc->zero =3D tcg_constant_i32(0); =20 /* Bound the number of insns to execute to those left on the page. */ page_insns =3D -(dc->base.pc_first | TARGET_PAGE_MASK) / 4; @@ -797,14 +790,8 @@ static void nios2_tr_translate_insn(DisasContextBase *= dcbase, CPUState *cs) return; } =20 - dc->zero =3D NULL; - instr =3D &i_type_instructions[op]; instr->handler(dc, code, instr->flags); - - if (dc->zero) { - tcg_temp_free(dc->zero); - } } =20 static void nios2_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) --=20 2.31.1