From nobody Mon Feb 9 18:20:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633168892; cv=none; d=zohomail.com; s=zohoarc; b=enTy6NlqPPWcFubeE/oiePx4i4F6C6Vidjvuu9jn2JCgsUcf0QP2+JBrwCmyD/tlSpALWUbxRhs+dnO6u1JQI1Gvm7GY0c7n5cFEE84JF/tUJvHPc43G/D0EDVVX9xufZDt+F4NxjT/+Rct5qQyVajgKcxahmAqpiybFeQGCToM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633168892; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aF6oJ+cMuBEvm2wLYFiGdSjkyr9ogvEyg+a4WCN7LGg=; b=GOB0ORL4+0QVInbcU3g2tnrFp7NStSCvXPlpC4quzsdmNS5RGMO26EOUtE7dtlFv4y32Fl1qtLrkqy/NrybEc9l56uzQ1UQlVqo2NV8DdSdB2CC8olXCmfGsaLOEFbfZng1Pb3fwDA3L5MTTucIcmu5iQ5kf+Bznkhrd8JYWhCg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1633168892490659.0598027678108; Sat, 2 Oct 2021 03:01:32 -0700 (PDT) Received: from localhost ([::1]:42628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWbpj-00019Y-66 for importer@patchew.org; Sat, 02 Oct 2021 06:01:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWblR-00016F-5z for qemu-devel@nongnu.org; Sat, 02 Oct 2021 05:57:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWblN-0004K5-20 for qemu-devel@nongnu.org; Sat, 02 Oct 2021 05:57:04 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-NjZZQVi7OjecNiEnpOdA1Q-1; Sat, 02 Oct 2021 05:56:58 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 05BB61808312; Sat, 2 Oct 2021 09:56:57 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCCA110016F4; Sat, 2 Oct 2021 09:56:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 796B31138526; Sat, 2 Oct 2021 11:56:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633168619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aF6oJ+cMuBEvm2wLYFiGdSjkyr9ogvEyg+a4WCN7LGg=; b=E7c5ncZA3yoTNFkgccDKY+fszMDwJWIzMdev1BcKQ+J0+85tZ6PE5AqV8gA8Lq4qXiKmxU RugHOcX+RsmGQkYbym2SCm6jKvylLI5izBtkBiMursuWXNCZJVSsOtZ4ufe19cWiJAuzMD dCK+2ao7fIWOiIhyqhZBxtiJ5sv00L4= X-MC-Unique: NjZZQVi7OjecNiEnpOdA1Q-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 04/13] qapi: Add spaces after symbol declaration for consistency Date: Sat, 2 Oct 2021 11:56:46 +0200 Message-Id: <20211002095655.1944970-5-armbru@redhat.com> In-Reply-To: <20211002095655.1944970-1-armbru@redhat.com> References: <20211002095655.1944970-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633169795382100001 Content-Type: text/plain; charset="utf-8" From: John Snow Several QGA definitions omit a blank line after the symbol declaration. This works OK currently, but it's the only place where we do this. Adjust it for consistency. Future commits may wind up enforcing this formatting. Signed-off-by: John Snow Message-Id: <20210930205716.1148693-5-jsnow@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- qapi/block-core.json | 1 + qga/qapi-schema.json | 3 +++ tests/qapi-schema/doc-good.json | 8 ++++++++ 3 files changed, 12 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index 623a4f4a3f..6d3217abb6 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -3132,6 +3132,7 @@ =20 ## # @BlockdevQcow2EncryptionFormat: +# # @aes: AES-CBC with plain64 initialization vectors # # Since: 2.10 diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index c60f5e669d..94e4aacdcc 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -1140,6 +1140,7 @@ =20 ## # @GuestExec: +# # @pid: pid of child process in guest OS # # Since: 2.5 @@ -1171,6 +1172,7 @@ =20 ## # @GuestHostName: +# # @host-name: Fully qualified domain name of the guest OS # # Since: 2.10 @@ -1197,6 +1199,7 @@ =20 ## # @GuestUser: +# # @user: Username # @domain: Logon domain (windows only) # @login-time: Time of login of this user on the computer. If multiple diff --git a/tests/qapi-schema/doc-good.json b/tests/qapi-schema/doc-good.j= son index a20acffd8b..86dc25d2bd 100644 --- a/tests/qapi-schema/doc-good.json +++ b/tests/qapi-schema/doc-good.json @@ -53,6 +53,7 @@ =20 ## # @Enum: +# # @one: The _one_ {and only} # # Features: @@ -67,6 +68,7 @@ =20 ## # @Base: +# # @base1: # the first member ## @@ -75,6 +77,7 @@ =20 ## # @Variant1: +# # A paragraph # # Another paragraph (but no @var: line) @@ -91,11 +94,13 @@ =20 ## # @Variant2: +# ## { 'struct': 'Variant2', 'data': {} } =20 ## # @Object: +# # Features: # @union-feat1: a feature ## @@ -109,6 +114,7 @@ =20 ## # @Alternate: +# # @i: an integer # @b is undocumented # @@ -126,6 +132,7 @@ =20 ## # @cmd: +# # @arg1: the first argument # # @arg2: the second @@ -175,6 +182,7 @@ =20 ## # @EVT_BOXED: +# # Features: # @feat3: a feature ## --=20 2.31.1