From nobody Sun Dec 14 06:15:45 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1632771723474466.5978839381262; Mon, 27 Sep 2021 12:42:03 -0700 (PDT) Received: from localhost ([::1]:42528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUwVm-0002Jg-C0 for importer@patchew.org; Mon, 27 Sep 2021 15:42:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUwHt-0003Sd-JX for qemu-devel@nongnu.org; Mon, 27 Sep 2021 15:27:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUwHr-0007P9-St for qemu-devel@nongnu.org; Mon, 27 Sep 2021 15:27:41 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-tp7kp0mtPWuBiHh0KB9mow-1; Mon, 27 Sep 2021 15:27:37 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3C5E1006AA3; Mon, 27 Sep 2021 19:27:36 +0000 (UTC) Received: from scv.redhat.com (unknown [10.22.9.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 715F060871; Mon, 27 Sep 2021 19:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632770859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5bXw48pGXenFR8Znjwp1tOJ/BfFdT4xpOZbVwehQB38=; b=Kj31D7iEAuAnrqEyw+rmPWEnQjx8zmc5b9eFj7ecDDel9ANIlbOLLbXmummLEir8C6oaj2 xmbBcUxN1aXNoBq6u2Nigbcj4KwLwwHFfBkLoAZp+Bd2zpVakypXYdPpeB43tVUo9YZ6i9 uZM1VNBhqGsdqmi8CwiuXgv6zi2WqMU= X-MC-Unique: tp7kp0mtPWuBiHh0KB9mow-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PULL 10/32] python/aqmp: add configurable read buffer limit Date: Mon, 27 Sep 2021 15:24:51 -0400 Message-Id: <20210927192513.744199-11-jsnow@redhat.com> In-Reply-To: <20210927192513.744199-1-jsnow@redhat.com> References: <20210927192513.744199-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Daniel Berrange , Eduardo Habkost , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Markus Armbruster , Wainer dos Santos Moschetta , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Willian Rampazzo , G S Niteesh Babu , Cleber Rosa , John Snow , Eric Blake Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1632771725669100001 Content-Type: text/plain; charset="utf-8" QMP can transmit some pretty big messages, and the default limit of 64KB isn't sufficient. Make sure that we can configure it. Reported-by: G S Niteesh Babu Signed-off-by: John Snow Reviewed-by: Eric Blake Message-id: 20210915162955.333025-11-jsnow@redhat.com Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/python/qemu/aqmp/protocol.py b/python/qemu/aqmp/protocol.py index 62c26ede5a4..2ef19e96932 100644 --- a/python/qemu/aqmp/protocol.py +++ b/python/qemu/aqmp/protocol.py @@ -189,6 +189,9 @@ class AsyncProtocol(Generic[T]): #: Logger object for debugging messages from this connection. logger =3D logging.getLogger(__name__) =20 + # Maximum allowable size of read buffer + _limit =3D (64 * 1024) + # ------------------------- # Section: Public interface # ------------------------- @@ -452,6 +455,7 @@ async def _client_connected_cb(reader: asyncio.StreamRe= ader, port=3Daddress[1], ssl=3Dssl, backlog=3D1, + limit=3Dself._limit, ) else: coro =3D asyncio.start_unix_server( @@ -459,6 +463,7 @@ async def _client_connected_cb(reader: asyncio.StreamRe= ader, path=3Daddress, ssl=3Dssl, backlog=3D1, + limit=3Dself._limit, ) =20 server =3D await coro # Starts listening @@ -482,9 +487,18 @@ async def _do_connect(self, address: Union[str, Tuple[= str, int]], self.logger.debug("Connecting to %s ...", address) =20 if isinstance(address, tuple): - connect =3D asyncio.open_connection(address[0], address[1], ss= l=3Dssl) + connect =3D asyncio.open_connection( + address[0], + address[1], + ssl=3Dssl, + limit=3Dself._limit, + ) else: - connect =3D asyncio.open_unix_connection(path=3Daddress, ssl= =3Dssl) + connect =3D asyncio.open_unix_connection( + path=3Daddress, + ssl=3Dssl, + limit=3Dself._limit, + ) self._reader, self._writer =3D await connect =20 self.logger.debug("Connected.") --=20 2.31.1