From nobody Tue Feb 10 14:32:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632695273; cv=none; d=zohomail.com; s=zohoarc; b=JC9O9dUblemuvocvHV12Srstz1sGJdkgnzyO8z8Pr4/YYRt6dwXB2RWNXh6U6nXPm1cAW1dBlobr/q2+sW0jeDi5wquWeikb2UL37vgwuSCIvYWV4J+u0ftv0lpfCw/f87xygDqRjWO0Duj0wZNZYHdPsY0kEkC8AyBq/sI43zU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632695273; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vUe+1tkOVnIH977cfWQkm6Ao8Hfy7tcpnU7MaXPzIOo=; b=f6mdNhRUzyjjkOtF8wYFM9KmjGIpw6TegcchoZuyPKWt9618pdb9hnRvKbzD+0HH1htQV4r4GSyF5Dq2l6ujZhlk/LLFg8KbAkjiTBRKSx7m/UIINOGIlnZQ9RCWEyvDjIqcQueneTnVg+J/jz/gdeJmbY7TbelPgrF8hrqEZTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1632695273245162.2277355620713; Sun, 26 Sep 2021 15:27:53 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id i23so46570626wrb.2 for ; Sun, 26 Sep 2021 15:27:52 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id o3sm15552836wra.52.2021.09.26.15.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 15:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vUe+1tkOVnIH977cfWQkm6Ao8Hfy7tcpnU7MaXPzIOo=; b=osZOzyl570nMTzc8yw2awwxE1MsWORyofZqC0UxcPWtKnIgde5fIzu34dWWxCNJwvE Rms1Ye+bCnucVMv3AhpxbmoX5QiBgzEBruq4TqHiOoA/0FcbKyAVRlRc3RDO0bsZOXKq yfrsF/W4PUHj9YSH8+sI13YxLZ6VHpYml0riV/jNTGo5n/+szgrBEJSfQN7vVoRfRkmt hd+X6iAti6UhsgU3zNzCFi9AzQFVmV7LUtOgiPKv+KBjPspkLV9yKxgJeWfh6Sc456dn f9AQGWsmLTvAzPcTso4tQxfNJHrmkXjyJWnBwcmTSvxtQPAk9ozWSfWlzj7pANKdXc1R u9Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vUe+1tkOVnIH977cfWQkm6Ao8Hfy7tcpnU7MaXPzIOo=; b=QKyPFb99lADiyo+Wq15c3hIlPxnxVudeYdbAFT/FcRjBxFGKEMtH0ORi1k4botzwqd ja/2Q2sbIn1aVPJUSbi83BzT2lEerkW4dZWdz3TIZ0M+AyQh4fa8ZCXXmOeUq5OagMFb Kv9cC/BDLuacOtTG+fFBixe17fcAeKjSPRbrtWBUtlExCFzyrAC352ynE5txJkXZx6UQ 1tpVwryZMgrhIoXUYp97uLZKZvdo9qQe9FV/bxhjBXNq4Jssi35bqlpOvvflNk2Z0kjT vCZKmR2N5iT+nDIIKje1xr50sbYD1OKRJJCoRxKMpC+dwXqnTR3C4h09iflIyrIp9RCO Vufw== X-Gm-Message-State: AOAM5319xOWSUlS9qEBV4WNu4wIYkHpuDAv0klhfZO3tRBYkv0pZO7Lv LYWtG623AvrQgVmoXQqwrF0= X-Google-Smtp-Source: ABdhPJy2nDIc0bOSLZ9gSs8fB14NnUc66qIdOVI14E0smbIfjaQodDfkxrlvklf1xotUCP2kx6TGOg== X-Received: by 2002:adf:e649:: with SMTP id b9mr24756235wrn.309.1632695271540; Sun, 26 Sep 2021 15:27:51 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v8 07/40] accel/whpx: Implement AccelOpsClass::has_work() Date: Mon, 27 Sep 2021 00:26:43 +0200 Message-Id: <20210926222716.1732932-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210926222716.1732932-1-f4bug@amsat.org> References: <20210926222716.1732932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632695275026100001 Implement WHPX has_work() handler in AccelOpsClass and remove it from cpu_thread_is_idle() since cpu_has_work() is already called. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/cpus.c | 4 +--- target/i386/whpx/whpx-accel-ops.c | 6 ++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index c9f54a09989..5ffa02f9cef 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -41,7 +41,6 @@ #include "sysemu/replay.h" #include "sysemu/runstate.h" #include "sysemu/cpu-timers.h" -#include "sysemu/whpx.h" #include "hw/boards.h" #include "hw/hw.h" #include "trace.h" @@ -89,8 +88,7 @@ bool cpu_thread_is_idle(CPUState *cpu) if (cpu_is_stopped(cpu)) { return true; } - if (!cpu->halted || cpu_has_work(cpu) || - whpx_apic_in_platform()) { + if (!cpu->halted || cpu_has_work(cpu)) { return false; } return true; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-acce= l-ops.c index 6bc47c53098..1f9c6d52c27 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -83,6 +83,11 @@ static void whpx_kick_vcpu_thread(CPUState *cpu) } } =20 +static bool whpx_cpu_has_work(CPUState *cpu) +{ + return whpx_apic_in_platform(); +} + static void whpx_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); @@ -94,6 +99,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, vo= id *data) ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; ops->synchronize_state =3D whpx_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D whpx_cpu_synchronize_pre_loadvm; + ops->has_work =3D whpx_cpu_has_work; } =20 static const TypeInfo whpx_accel_ops_type =3D { --=20 2.31.1