From nobody Tue Feb 10 12:43:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632695245; cv=none; d=zohomail.com; s=zohoarc; b=lWZU6qs2vZ1EfPsIFhFZsJPC1i4GKBMCOBcYKckHI2XX8JsLjORoNxSb+q21aHOOg/f+YnFM40cFWlpOKpTOhEbRyk8hK+rcRXw+Ttwgmu+OQ/GKFJsowqN90hSz3k/jZk8VXnDgZ99/xc80HFerSP45z9Rql+b7rmuefd5HnwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632695245; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2W0DjczmO00zs6me7cCuH7cvWlENeBJiJjnuJqxx7ic=; b=jrIcns0RQukFAVsvs91w6Omm8VvBmx+FFKZCh3bd2d+esmjt0Kc0r1NmxZ2N8QS9j04XZPld4tByD9MTgtYOJS+VyWTua52AtbILQgJOsGTdRZkP8VwbeD9uR3/rQjN8IItuBiCXnra0ihZ44Cg04Pr0iuapmbywK23Tqrrubrw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1632695245452114.1136230497674; Sun, 26 Sep 2021 15:27:25 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id t8so46607776wri.1 for ; Sun, 26 Sep 2021 15:27:24 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id a25sm18738909wmj.34.2021.09.26.15.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 15:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2W0DjczmO00zs6me7cCuH7cvWlENeBJiJjnuJqxx7ic=; b=f2GnhHn0L/+gczIPwFeeDG/VOHGy5shwhm/t5bY+DsDjAvSW8ChtmWkwu09Cgz5iPY tuQ+ZfVRrO40T7ShLZMAsQB051MIrJPQXRsCSa3TdDsY0gWJ6YGPsucLcPF0UV7FOtOb jI9ZzH7Ed3KTRc3+Kt9YNmxlsOlisV977dMIioo3q1kGb/kkXrq8vX0t/VuqBP4NG44a K04Y2MloOxXxo1hly9FL/1M20pupCHRWYNBiJusc7vWr/QThxhz2BeqDIoYhTKSuoYDb cpK0JaDQ2Bqh2ni2qwTtpSzFmBgZK6fzlUhuX3LBj6sdtWkbDId8NwF06IgMrKMxdpvZ rdEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2W0DjczmO00zs6me7cCuH7cvWlENeBJiJjnuJqxx7ic=; b=3EBS+610wEzN6r9SjB1+RgzOUGFLZVJB1h3VtOv8/Qo81B7XX/9BdZa8ZrRLCEl06q JrI/TbgS+8hZ/YcJtUl3rqGc2NJz+XOOaRAbjfdCHnl5AYbpgWdKo6KkyJrpILgg6uS8 OgB22en2dn1qsm+r79fM+WmziwMwUJOhwvwzjc8c0fYnUpoLIgj5nW2ltMkqNVxBgTzU wBOog0f0k/sCg97oyxoy2JFbmLrPvIzmITLu3kvHl5XygBKnSBCVGEYeSBbChPo0RIgN ylLi7TKTe9PURpZx4oDQyfTGJZ51HIl9naL3EHKT+ps63JrgzpsS7kF4eUqinJDcbzmM aqhg== X-Gm-Message-State: AOAM532wzK0QFINrNEWMyOtOFRYNsD5TvGaQ+5ZvMRuWknzCOpbhdl5p NPgGVfvaga7D6HGLpoJsgxz0KmHRGMA= X-Google-Smtp-Source: ABdhPJwRJu/LGw8uWoWxq2vn5EWhb+hv8SBOYDggT1CHJPZNXu/cX9+Vg1G8Io6/GtsPy9ZyMSlCqw== X-Received: by 2002:a05:6000:1844:: with SMTP id c4mr23535886wri.355.1632695243746; Sun, 26 Sep 2021 15:27:23 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v8 01/40] accel: Simplify qemu_init_vcpu() Date: Mon, 27 Sep 2021 00:26:37 +0200 Message-Id: <20210926222716.1732932-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210926222716.1732932-1-f4bug@amsat.org> References: <20210926222716.1732932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632695245989100001 cpus_register_accel() already checks for ops->create_vcpu_thread being non-NULL, so it is pointless to re-check for it in qemu_init_vcpu(). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/cpus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 071085f840b..646326b24fd 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -604,7 +604,10 @@ void cpu_remove_sync(CPUState *cpu) void cpus_register_accel(const AccelOpsClass *ops) { assert(ops !=3D NULL); - assert(ops->create_vcpu_thread !=3D NULL); /* mandatory */ + + /* Mandatory non-NULL handlers */ + assert(ops->create_vcpu_thread !=3D NULL); + cpus_accel =3D ops; } =20 @@ -626,7 +629,7 @@ void qemu_init_vcpu(CPUState *cpu) } =20 /* accelerators all implement the AccelOpsClass */ - g_assert(cpus_accel !=3D NULL && cpus_accel->create_vcpu_thread !=3D N= ULL); + g_assert(cpus_accel !=3D NULL); cpus_accel->create_vcpu_thread(cpu); =20 while (!cpu->created) { --=20 2.31.1